openproject

Commit Graph

Author	SHA1	Message	Date
ulferts	d800fb25c8	don't submit an unchanged wp resource (#4575 ) Checks the wp's dirty flag before actually submitting the wp. Thereby, updateWorkPackage becomes a noop if a wp has no changes.	8 years ago
Alex Dik	7e8c9beea4	Add success state redirect after new WP is saved	8 years ago
Jens Ulferts	4b06a41ba3	provide api independent error message for date format errors	8 years ago
Jens Ulferts	4a1274d6a3	extract wp notifications into separate service	8 years ago
Oliver Günther	74b52eaab8	[23300] Fix date fields not being updated (#4556 ) * Fix date fields not being updated For Milestone rows, start and due date are both mapped to `date` and thus collide with the wpEditForm#callbacks helper that propagate changes from the `wpCacheService` down to edit and display fields. This fails to update the last field since they registers callbacks based on their attribute name. This commit instead suggests to use the wpCacheService directly, since the scopedObservable will handle deregistration correctly on its own. * Remove no-longer-required wpEditForm	9 years ago
ulferts	1d99206232	Fix/accessible error messages (#4529 ) * add error messages to each field * move role=alert up so that success messages are also covered * remove focus code from notification-box directive The box does not need to be focused as it has the role=alert which will lead to it being read out. * remove specific focusing behaviour for accessibility mode The mode was introduced to present error messages to user requiring assistive technology e.g. screen readers. By setting role=alert on the error fields and additionally labeling the fields with the errors, this should no longer be necessary	9 years ago
Oliver Günther	909bc08266	Fix cuke selector	9 years ago
Oliver Günther	ca65f078c3	Fix leftover values from wp resource still showing up The display-attr causes old values in the resource to still show up, despite no associated schema being available. I don't think it hurts to have old values in the resource, as long as we can ensure that it's the schema that decides what is showing.	9 years ago
Oliver Günther	6549869000	Fix focussing on erroneous fields	9 years ago
Oliver Günther	5da8c31f40	Fix switching types in Edit all mode	9 years ago
Oliver Günther	760fc47c7f	Fix focus on first element on create	9 years ago
Oliver Günther	67e4551387	Mark WorkPackageResource as dirty when values were changed This allows us to check the cache services for changes in the work package and not refresh it from the cache. Currently, this is only relevant for edit all mode, however it may be the entry point for a API merging / refreshing service.	9 years ago
Oliver Günther	426876a264	Fix enabling fields by default when switching	9 years ago
Oliver Günther	d34799a89a	Edit all on fullscreen view	9 years ago
Oliver Günther	805b754971	Add wpEditModeState service to register form	9 years ago
Oliver Günther	c7d9be477d	Expand fields correctly	9 years ago
Oliver Günther	650b5f4159	Implement edit-all through wpEditForm	9 years ago
Oliver Günther	a5823dc755	Fix error state of fields newly introduced by type switch	9 years ago
Alex Dik	6711fbb2ec	Replace $timeout with $scope.$evalAsync	9 years ago
Oliver Günther	34393d07ac	Use separate error handling for table	9 years ago
Oliver Günther	22be2d04e2	Test for ErrorResource before accessing notification helper	9 years ago
Oliver Günther	31aba317f5	Enable error notification for internal errors	9 years ago
ulferts	e7ff5eb374	Fix/invalid date entry (#4398 ) Allows to correct errors made when data of an invalid format is inserted to one of the WP inline edit fields, e.g. when 'aaaaa' is inserted for 'start date'. Before the fix, the promise calling 'POST work_packages/:id/form' was assigned to the work package resource. But in case of an error, the result of the promise is an error and not a form. As we do rely on the links present in the form, we need to ensure that we always have a form where we expect it. The PR also fixes a couple of errors in the js console when invalid information is added which are caused by the API not specifying the invalid column. While the PR increases the robustness of the front end, it does not improve the API.	9 years ago
Oliver Günther	141cbfa4e4	[22624] Display 'Open this work package in full screen' correctly (#4363 ) * Display 'Open this work package in full screen' correctly Currently, the 'Click here to open this work package in fullscreen view.' is not implemented correctly: 1. It is not only shown for update and create, but also delete in the table 2. It is not shown for inline create / edit 3. It is shown in full screen This reimplements the functionality without requring deep knowledge in NotificationsService. * Move NotificationsService * Move notification box directive * Move DetailsTabOverviewController	9 years ago
Oliver Günther	02cf2b0efe	[22851] Table Inline Create (#4290 ) * Move the WP create button to the WP buttons directory * Move the keepTab service to the wp-panels directory * Move angular module definitions into separate file * Move the WP create button into a separate file * Use TS in WP create button directive * Refactor the WP create button controller * Move the has-context-menu directive to the components directory * Refactor has-context-menu item focus * Create new button directive and place in table * Export and use wpButton module * Add title to form properties * Add -new modifier to new work package rows * Add WP inline create directive * Reduce error widths to cell span * Save or update work package conditionally * Mark work package as new * Implement the WP inline create button * Style button correctly * Decide when to activate the field for new WPs * Remove padding on -new row * Avoid animation on added -new rows * Avoid writing title when passed from new workPackage * Remove jqMigrate warning * Avoid animations for newly added rows * Add cancel button to inline create row * Track new work packages by custom id If we don't track new work packages, ng-animate will freak out due to the track by expression. We thus track work packages by setting a custom id set from the current date. * Disable focus on errors outside accessibility mode * Add inline create cancel context menu * Conditionally set focus on fields Set focus on the first active field	9 years ago
Oliver Günther	8b2a068ede	Fix schema loading	9 years ago
Oliver Günther	f6ab6de17b	Very crudely reload table	9 years ago
Oliver Günther	51b467ee15	Reset error state when submission successful	9 years ago
Oliver Günther	ec3f48e6a6	Add class states to outer td element Mark the td element with `-editable` when the wp-edit field is editable.	9 years ago
Oliver Günther	a56b38d658	Properly handle no-longer erroneous fields	9 years ago
Oliver Günther	c872a32124	Add separate ErrorResource	9 years ago
Oliver Günther	cc315c2194	Add very basic error styling	9 years ago
Oliver Günther	560da7b09b	Add column for attributes when in error	9 years ago
Oliver Günther	4f14459a61	Reset error state when submission successful	9 years ago
Oliver Günther	6c6bd49aa3	Add class states to outer td element Mark the td element with `-editable` when the wp-edit field is editable.	9 years ago
Oliver Günther	8dbafd3fb5	Properly handle no-longer erroneous fields	9 years ago
Oliver Günther	08761bcd75	Add separate ErrorResource	9 years ago
Oliver Günther	3043fcae79	Add very basic error styling	9 years ago
Oliver Günther	41e6a97fab	Add column for attributes when in error	9 years ago
Oliver Günther	90e312e4d7	Control single promise in wp-resource#save	9 years ago
Oliver Günther	7e732b25ed	Use errors from API	9 years ago
Alex Dik	cd5dac3769	Show generic error message on WP update failure	9 years ago
Alex Dik	08efd59277	Set loaded schema resources as properties of the work package	9 years ago
Alex Dik	4a9702f614	Move the wp-edit-field files in their own directory	9 years ago
Alex Dik	fcc2cd39a6	Implement first version of the WP edit module Disable links in the WP td directive as to prevent opening the details view. Also disable the table single-click handler to prevent confusion. This actually might be introduced back again, but can stay disabled for development.	9 years ago
Alex Dik	69a0b95eb1	Isolate activity panel scope	9 years ago
Alex Dik	26acc8d1dd	Add alternative activity panel template for overview panel	9 years ago
Alex Dik	1198c2bfd1	Extract code to ActivityPanelController Copy pasta buster	9 years ago
Alex Dik	aded24d3e1	Implement activity panel directive	9 years ago
Alex Dik	6a4ee0d34a	Replace EdiableFieldsState.errors with errors service	9 years ago

39 Commits (d800fb25c8c09232c9cc1fe76e4a6cff5cbe71f4)