56 Commits (d83dde0284fdaf7829b7d1862f171433a83dffe5)

Author	SHA1	Message	Date
Alex Coles	ce93701029	Fix syntax (w/Rubocop) in specs ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	57618b25ec	Replace dynamic finder usages with #find_by, etc. ... This patch replaces all dynamic finders, for the sake of consistency, although only some methods are deprecated. See: https://github.com/rails/activerecord-deprecated_finders#active-record-deprecated-finders * Revert some `User#find_by_login` usages in cuke steps accidentally removed in 74228b59. User Story # 20325 Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	ebbc9e3d7d	Prefer #not_to over #to_not in specs ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	e0191e759c	Update year in copyright header to 2015 ... [ci skip]	10 years ago
Alex Coles	1bb21b23c7	Remove option passed to render_template matcher ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	f95c9d15f3	Prefer #map over #collect in specs ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	5afc11f19e	Fix syntax (w/Rubocop) in specs ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	03978767be	Use 1.9+ Hash syntax in specs ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	0b941955ce	Fully qualify ::Type class constant ... This fixes a naming collision with AR internals: undefined method `find' for ActiveRecord::AttributeMethods::Serialization::Type:Class Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Michael Frister	8d08e71ed5	API v2: Change boolean value to use true/false ... While this is not the OpenProject API, we use true/false for other APIs and for other parameters in the application, like `layout=false`. true/false also seems more intuitive.	10 years ago
Michael Frister	959c4ba405	API v2 PE index: Allow disabling parent rewiring ... Allow disabling rewiring - this exposes parent IDs of work packages invisible to the user. When requesting single work packages via IDs, the rewiring fails as it assumes that all visible work packages are loaded, which they might not be. For a work package with a parent visible to the user, but not included in the requested IDs, the parent_id would thus be nil. Disabling rewiring allows fetching work packages with their parent_ids even when the parents are not included in the list of requested work packages. There's also a case when rewiring is not used at all: When not providing a project id and requesting via /api/v2/planning_elements.json?ids=[...]. In this case parent_ids were and are always shown. This is pretty inconsistent, but that's the way API v2 is. Btw, planning_elements.json returns 404 when not giving an ids parameter. Apparently, the way custom fields are returned is also different between the general planning elements endpoint and the project-specific one. I didn't look into this, though.	10 years ago
Hagen Schink	f6353003d9	Add specs	10 years ago
Hagen Schink	63ace93877	Add specs	10 years ago
Alex Coles	e137ed8135	Convert specs to RSpec 2.99.0 syntax with Transpec ... This conversion is done by Transpec 2.3.1 with the following command: transpec * 72 conversions from: describe 'some controller' { } to: describe 'some controller', :type => :controller { } * 57 conversions from: describe 'some model' { } to: describe 'some model', :type => :model { } * 49 conversions from: describe 'some view' { } to: describe 'some view', :type => :view { } * 34 conversions from: obj.should to: expect(obj).to * 27 conversions from: describe 'some routing' { } to: describe 'some routing', :type => :routing { } * 8 conversions from: describe 'some feature' { } to: describe 'some feature', :type => :feature { } * 7 conversions from: describe 'some helper' { } to: describe 'some helper', :type => :helper { } * 5 conversions from: be_true to: be_truthy * 5 conversions from: describe 'some request' { } to: describe 'some request', :type => :request { } * 2 conversions from: obj.should_receive(:message) to: expect(obj).to receive(:message) * 2 conversions from: obj.stub(:message) to: allow(obj).to receive(:message) * 1 conversion from: before { example } to: before { |example| example } * 1 conversion from: describe 'some mailer' { } to: describe 'some mailer', :type => :mailer { } For more details: https://github.com/yujinakayama/transpec#supported-conversions	11 years ago
Jens Ulferts	e13fa469b8	release/3.0: fixes fickle spec	11 years ago
Jens Ulferts	e6bfe613b2	fixes fickle spec	11 years ago
Ion Biziiac	d637354013	Add specs for Fix: APIv2 does not rewire parents correctly	11 years ago
Jens Ulferts	90e1a9863e	reduces memory and increases performance of api planning_element#index ... OpenStruct requires significant more memory and is slower than simple structs	11 years ago
Alex Coles	7645789b5c	Style fix: Replace do…end with {} in expect blocks ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	11 years ago
Alex Coles	0bdbdcac35	Convert specs to RSpec 2.14.8 syntax with Transpec ... This conversion is done by Transpec 1.10.4 with the following command: transpec * 1414 conversions from: obj.should to: expect(obj).to * 646 conversions from: == expected to: eq(expected) * 376 conversions from: obj.stub(:message) to: allow(obj).to receive(:message) * 107 conversions from: obj.should_not to: expect(obj).not_to * 70 conversions from: obj.should_receive(:message) to: expect(obj).to receive(:message) * 45 conversions from: =~ [1, 2] to: match_array([1, 2]) * 27 conversions from: lambda { }.should to: expect { }.to * 13 conversions from: Klass.any_instance.stub(:message) to: allow_any_instance_of(Klass).to receive(:message) * 8 conversions from: === expected to: be === expected * 7 conversions from: expect { }.not_to raise_error(SpecificErrorClass) to: expect { }.not_to raise_error * 6 conversions from: =~ /pattern/ to: match(/pattern/) * 2 conversions from: obj.should_not_receive(:message) to: expect(obj).not_to receive(:message) * 1 conversion from: < expected to: be < expected * 1 conversion from: obj.stub!(:message) to: allow(obj).to receive(:message) * 1 conversion from: stub('something') to: double('something')	11 years ago
Johannes Wollert	8b096975fe	updates copyright headers ... updates more copyright more copyright headers	11 years ago
Martin Czuchra	4979834351	Fixes specs. ... Adds empty custom values array to the generated structs, as those are now appended on the server, even when there are no custom fields. This also fixes minor whitespace issues.	11 years ago
Hagen Schink	f3309b6e8b	Adds notes spec	11 years ago
Hagen Schink	bdbb101516	Adds missing error handling spec	11 years ago
Hagen Schink	535e7a42e5	Adds specs	11 years ago
Hagen Schink	43fea0f5a6	Refactores and extends API v2 WP status specs	11 years ago
Markus Kahl	5ff6766d08	added regression test for bug #3229, i.e. for setting a planning element's status	11 years ago
Michael Frister	4a2606d9d4	Fix expected URL in PlanningElementsController spec	11 years ago
Markus Kahl	162af23644	split up create and show tests	11 years ago
Markus Kahl	24a818f72c	don't keep standard type around	11 years ago
Markus Kahl	9b0611c953	test planning element custom field create/update	11 years ago
Nils Kenneweg	fcbb74b60a	fix loading of multiple vertical pes. ... also updates tests.	11 years ago
Martin Czuchra	1b62fd8184	Fixes expectations for planning element controller spec.	11 years ago
Nils Kenneweg	0afa79401a	refactor gets into before.	11 years ago
Nils Kenneweg	99b99b0f0f	revert wrong change.	11 years ago
Nils Kenneweg	7e11d0c764	validate access. specs.	11 years ago
Hagen Schink	2f5e9ad3d6	Renames IssueStatus to Status	11 years ago
Hagen Schink	4899367d8c	Removes :delete_work_packages	11 years ago
Hagen Schink	dc00910385	Removes :edit_planning_elements	11 years ago
Hagen Schink	ab7dd219db	Removes :view_planning_elements	11 years ago
Philipp Tessenow	a1e67dd460	new copyright header #1903	11 years ago
Stefan Frank	54a4bbaf7d	permitted params still needs a special set of permitted params for the api.	11 years ago
Stefan Frank	bf7054fa47	re-merged the changes from the unit-tests-branch&fixed the tests.	11 years ago
Hagen Schink	582ee8b9fb	Adds priority and status to PE specs	11 years ago
Martin Czuchra	e15f55e102	Fixes redirect expectation in PE controller spec. ... PE always returned 204 no content when updating via the API. Sending the right format broke the expectation for a redirect.	12 years ago
Martin Czuchra	6ec9416e2a	Removes timelines prefix in api/v2 controllers. ... Some view expectation still features a timelines prefix. This is now fixed.	12 years ago
Martin Czuchra	4420895da1	Fixes most of the controller specs. ... This includes moving API tests out to api/v2, as well as fixing some view expectations. In addition, the redirect path of destroys was altered.	12 years ago
Martin Czuchra	475a22204e	Fixes controller names in specs.	12 years ago
Martin Czuchra	46ffcfc195	Refactors current timelines API into api/v2.	12 years ago
Martin Czuchra	7963fe3521	Updates copyright notice in timelines sources.	12 years ago