32 Commits (d83dde0284fdaf7829b7d1862f171433a83dffe5)

Author	SHA1	Message	Date
Jan Sandbrink	6e9ed008fb	Enforce passing of current_user into representers ... Thereby permission checks will no longer silently fail if no user was passed. This uncovered a lot of places where we actually expected a user to be passed, when it wasn't. This was especially true for collections. The basic idea is, that virtually all representers could change their behaviour based on the current user. Representers where this is not the case (e.g. Digest), can still explicitly opt-out.	9 years ago
Jan Sandbrink	4c232e786b	split specs for unpaginated and paginated collections	9 years ago
Jan Sandbrink	b332ef06aa	make collection representer explicitly unpaginated	9 years ago
Alex Coles	ce93701029	Fix syntax (w/Rubocop) in specs ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Jan Sandbrink	6406b640b7	remove redundant spec ... one could argue that I learned from @0xF013 to delete inconvenient specs ;-) But in this case the spec is really made redundant by the two specs below [ci skip]	9 years ago
Jan Sandbrink	db5d633850	update factories to new default preference ... also use boolean type instead of DB values	9 years ago
Jan Sandbrink	a3ff9d57ed	fix user representer for representing groups [sic]	10 years ago
Jan Sandbrink	957b060851	hide a users mail address if he wishes to	10 years ago
Jan Sandbrink	9feb0700ac	rename mail to email, update docs, style code	10 years ago
Alex Coles	ebbc9e3d7d	Prefer #not_to over #to_not in specs ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	944b89d83e	Convert specs to RSpec 3.2.0 syntax with Transpec ... This conversion is done by Transpec 3.0.7 with the following command: transpec -f * 34 conversions from: it { should ... } to: it { is_expected.to ... } * 14 conversions from: obj.stub_chain(:message1, :message2) to: allow(obj).to receive_message_chain(:message1, :message2) * 7 conversions from: obj.stub(:message) to: allow(obj).to receive(:message) * 4 conversions from: be_true to: be_truthy * 3 conversions from: obj.should_receive(:message) to: expect(obj).to receive(:message) * 2 conversions from: failure_message_for_should { } to: failure_message { } * 2 conversions from: failure_message_for_should_not { } to: failure_message_when_negated { } * 1 conversion from: Klass.any_instance.stub(:message => value) to: allow_any_instance_of(Klass).to receive_messages(:message => value) * 1 conversion from: be_false to: be_falsey * 1 conversion from: obj.should_not_receive(:message) to: expect(obj).not_to receive(:message) * 1 conversion from: stub('something') to: double('something') * 1 addition of: RSpec.configure { |c| c.infer_spec_type_from_file_location! } For more details: https://github.com/yujinakayama/transpec#supported-conversions	10 years ago
Jan Sandbrink	03bfa42394	use shared examples in more tests	10 years ago
Jan Sandbrink	14ded43bda	fix tests, use mocking	10 years ago
Jens Ulferts	da588b812c	harmonize api decorators	10 years ago
Jan Sandbrink	c28a581ec4	test for missing delete link	10 years ago
Jan Sandbrink	d1e3f23467	obey style rules	10 years ago
Jan Sandbrink	c11bd5b8d5	actually include delete link ... how hard can ruby be anyway... I will for certain regret that commit soon ^^	10 years ago
Oliver Günther	9e6da91798	Updated API for user (un-)locking ... - Adds an lockable?, activatable? to the Principal model, which is overridden by User as aliases to active? and locked?. - UserRepresenter refers to the above methods - Refactored /lock routes into a single method Specs: - Adds delete /users/:id/lock spec - Refactored FactoryGirl calls to avoid create where feasible	10 years ago
Oliver Günther	d683d2a932	houndci linting fixes	10 years ago
Oliver Günther	a112291396	apiv3: User (Un-)Locking functionality ... This commit implements the proposed user locking/unlocking functionality in https://github.com/opf/openproject/pull/2401. The APIv3 is extended with a resource ``/user/:id/lock`` with the following properties: * ``POST /lock``: Set the lock of user(:id), if its account status is 'active'. * ``DELETE /lock``: Remove an active lock of user(:id), if its account status is 'locked'. This commit also implements the following changes to ``UserRepresenter``: * Replaced the integer status field with the textual status name (i.e., 'active') * Added two entries to *_links* for admin users: ``lock``, ``unlock``.	10 years ago
Alex Coles	e0191e759c	Update year in copyright header to 2015 ... [ci skip]	10 years ago
Hagen Schink	6af688abf4	Adapt specs to path helper usage	10 years ago
Hagen Schink	a482205aec	Test that collections adhere to the specifiction	10 years ago
Hagen Schink	85aeb8d0f3	Remove dependency to reform models from specs	10 years ago
Alex Coles	5afc11f19e	Fix syntax (w/Rubocop) in specs ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Jens Ulferts	f758aabfb1	uses gravatar_image_tag gem as standard avatar lib	10 years ago
Alex Coles	879fcd49f6	Convert specs to RSpec 2.99.0 syntax with Transpec ... This conversion is done by Transpec 2.3.6 with the following command: transpec -f * 66 conversions from: it { should ... } to: it { is_expected.to ... } * 53 conversions from: obj.stub(:message) to: allow(obj).to receive(:message) * 20 conversions from: == expected to: eq(expected) * 19 conversions from: obj.should to: expect(obj).to * 7 conversions from: describe 'some request' { } to: describe 'some request', :type => :request { } * 7 conversions from: describe 'some routing' { } to: describe 'some routing', :type => :routing { } * 7 conversions from: its(:attr) { } to: describe '#attr' do subject { super().attr }; it { } end * 5 conversions from: obj.should_not to: expect(obj).not_to * 4 conversions from: describe 'some view' { } to: describe 'some view', :type => :view { } * 3 conversions from: be_true to: be_truthy * 2 conversions from: describe 'some model' { } to: describe 'some model', :type => :model { } * 2 conversions from: its([:key]) { } to: describe '[:key]' do subject { super()[:key] }; it { } end * 2 conversions from: obj.should_receive(:message) to: expect(obj).to receive(:message) * 1 conversion from: be_false to: be_falsey * 1 conversion from: describe 'some controller' { } to: describe 'some controller', :type => :controller { } * 1 conversion from: describe 'some feature' { } to: describe 'some feature', :type => :feature { } * 1 conversion from: it { should_not ... } to: it { is_expected.not_to ... } For more details: https://github.com/yujinakayama/transpec#supported-conversions	10 years ago
Richard	3f81dc9b07	only display links to users' comments if they are active.	10 years ago
Alex Coles	c82bd01a1e	Move Representer specs under spec/lib/api/v3 ... For unit-style specs the file structure should mirror that of application code. Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago