358 Commits (d83dde0284fdaf7829b7d1862f171433a83dffe5)

Author	SHA1	Message	Date
Jan Sandbrink	b374ebdd7f	store messages alongside error symbols ... - allows to skip translation part in ErrorBase - allows to have correct translations containing placeholder values	9 years ago
Jan Sandbrink	138d3dba29	fix some specs ... - error messages now contain punctuation - when :save returns false, there should be errors present - errors in form representers are now API errors	9 years ago
Jan Sandbrink	dcd2a3b03c	rework error instantiation ... - multiple errors are no longer a special case of specific errors - there is a separate error class to represent multiple API errors - convert ActiveRecord errors to API errors in a single place, ideally work with API errors from there on	9 years ago
Jan Sandbrink	c586a9cc8c	mock the model in model_contract_spec	9 years ago
Jan Sandbrink	13b9042293	treat all 422 errors the same for forms ... That means: Do render the form for all HTTP 422 errors, problems are highlighted within the form	9 years ago
Jan Sandbrink	8f110d8b93	adapt specs to new contract behaviour ... - also refine specs for done-ratio to check for non-fail when not changed - use shared examples for parent properties also in done ratio specs	9 years ago
Jan Sandbrink	ac9cffe741	remove tautology and add apropriate specs	9 years ago
Jan Sandbrink	e9059a97ee	style ... [ci skip]	9 years ago
Jan Sandbrink	ce0b906d91	dirty trick to allow using a Hash as mock ... also removes default value from initializer, which was never sane	9 years ago
Jan Sandbrink	0b7b4bf329	extract error merging into contract	9 years ago
Alex Coles	0436446257	Revert "DRY WorkPackageSchema#available_custom_fields spec" ... This reverts commit 8e47f600b0.	9 years ago
Alex Coles	8e47f600b0	DRY WorkPackageSchema#available_custom_fields spec ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	837265c257	Fix API v3 WorkPackageSchema for AR::Relation ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	ce93701029	Fix syntax (w/Rubocop) in specs ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	57618b25ec	Replace dynamic finder usages with #find_by, etc. ... This patch replaces all dynamic finders, for the sake of consistency, although only some methods are deprecated. See: https://github.com/rails/activerecord-deprecated_finders#active-record-deprecated-finders * Revert some `User#find_by_login` usages in cuke steps accidentally removed in 74228b59. User Story # 20325 Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Jan Sandbrink	baaf452cbd	style ... [ci skip]	9 years ago
Jan Sandbrink	e50e18dba1	fix spec ... the actual hashes provided by grape have string keys	9 years ago
Jan Sandbrink	4054c2ae22	add a removeWatcher link to work packages	9 years ago
Jan Sandbrink	6406b640b7	remove redundant spec ... one could argue that I learned from @0xF013 to delete inconvenient specs ;-) But in this case the spec is really made redundant by the two specs below [ci skip]	9 years ago
Jan Sandbrink	db5d633850	update factories to new default preference ... also use boolean type instead of DB values	9 years ago
Alexander Bach	88bd8756b4	Add test descriptions	10 years ago
Alexander Bach	ef88ca1339	Move out of place parenthesis back into position	10 years ago
Alexander Bach	8ae33c9d0f	Simplify test setup	10 years ago
Alexander Bach	a1ad5b92bf	Refactor test to use helper_class	10 years ago
Alexander Bach	21ee97b19f	Move test to proper location and benefit from it	10 years ago
Alexander Bach	e7f080efbb	Check link content as well	10 years ago
Alexander Bach	90ed907657	Ditch regex for more readable string	10 years ago
Alexander Bach	02cbe0165b	Improve test setup and checks	10 years ago
Alexander Bach	16f67e8fb3	Clarify spec purpose	10 years ago
Alexander Bach	f99b000ae8	Cleanup test	10 years ago
Alexander Bach	5d7a1d2cb4	Remove model_ prefix	10 years ago
Alexander Bach	ce81b7f4f2	Add specs for create form api	10 years ago
Alexander Bach	0e9e986f7f	Style fixes	10 years ago
Alexander Bach	c88cb306dd	Add all the specs	10 years ago
Alexander Bach	134dd61000	Fix spec once again	10 years ago
Alexander Bach	3ee80e98e8	Correct work_package_contract filename	10 years ago
Alexander Bach	ba3770d97e	Some style fixes	10 years ago
Alexander Bach	43229f73c7	Moved wp payload representer accordingly	10 years ago
Alexander Bach	2d074e8f47	Adapt form representer tests	10 years ago
Alexander Bach	edddde9fc3	Merge form folder into work_packages folder	10 years ago
Alexander Bach	410e483fef	Provide more flexible structure for work package contract validations	10 years ago
Alexander Bach	72f47e90fe	Add test descriptions	10 years ago
Jan Sandbrink	92187cd6f7	simplify conditions + specs ... if a user is not allowed to view a work package he should not get to see the WP representer. (even hypothetically: then watcher links would not be the prime problem) Therefore the conditions can be simplified as well as the corresponding specs	10 years ago
Alexander Bach	4b45ad6a19	Move out of place parenthesis back into position	10 years ago
Alexander Bach	397d1d0d9b	Simplify test setup	10 years ago
Alexander Bach	2bf44da03e	Refactor test to use helper_class	10 years ago
Alexander Bach	4d6c724b11	Move test to proper location and benefit from it	10 years ago
Alexander Bach	34c684d4d3	Check link content as well	10 years ago
Alexander Bach	67c20cd7e6	Ditch regex for more readable string	10 years ago
Alexander Bach	071e1ffe62	Improve test setup and checks	10 years ago