openproject

Commit Graph

Author	SHA1	Message	Date
Christophe Bliard	47a297daae	Fix argument alignment since `f08bea3467` (#10129 ) * Fix argument alignment since `f08bea3467` The FactoryBot.* prefix has been removed in `f08bea3467`. Since then rubocop complains about Layout/ArgumentAlignment. This commit fixes it. * do not fix alignments for modules/*/spec yet hoping to be under the limit of 65535 characters for reviewdog to report on rubocop errors	3 years ago
Oliver Günther	f08bea3467	Remove FactoryBot.* prefix where applicable	3 years ago
Oliver Günther	409900411e	Merge origin/release/12.0	3 years ago
ulferts	38fb6a4a3e	include dedicated error message for readonly work packages	3 years ago
Oliver Günther	ccfa29c728	Move license and copyright docs to root, fix names and references	3 years ago
Oliver Günther	cd2d736c18	Prevent self-assignment of work package parent The backend doesn't prevent parent self assignment of a work package. I triggered this by accident through an API call and this resulted in an endless loop.	3 years ago
ulferts	7ecf08e005	rework changed_by_system (#9043 ) Before, it was implemented by passing the changed attribut keys over to the contract to whitelist them. This lead to: * The contract interface becoming bloated * Having to rely on the knowledge of the developer not to falsely whitelist an attribute. The developer would also have to make sure to not perform a mass assignment after the attribute has been whitelisted The new approach it to integrate the behaviour into the model which is first altered in the service before it is scrutinized in the contract. The information about the changed attributes is now stored inside the model which removes the necessity to flag the whitelisted attribute separately. Additionally, the exact change is tracked. So if an attribute is set to one value inside a whitelisted block there is no risk in later on performing a mass assignment. This comes at the cost of extending the models which is weird also it is build into the default SetAttributesService so child classes do not have to worry. One might include the module into every AR model but currently we only need it for a very specific use case.	4 years ago
ulferts	1bdd2ab9ae	safe automatic fixes by rubocop (#8994 )	4 years ago
ulferts	5ea185ef66	Placeholder user project members (#8961 ) * remove intermediate placeholder scope Doing so, placeholder users will begin to show up in the system * remove scope without value * extract scope * use enum for status * allow placeholder users to become project members * display placeholder user member on members widget * remove now superfluous method The status name can simply be queried via #status now * replace possible_assignees/responsibles on project This also leads to placeholder users becoming eligible as assignees and responsibles. * fix aggregated scope on bulk edit * linting * remove IssueHelper	4 years ago
luz paz	3683042c9b	Fix typos in user facing and non-user facing code Found via `codespell v2.1.dev0`	4 years ago
ulferts	6140f4c7e9	update copyright to 2021 (#8925 ) Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded. Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013	4 years ago
ulferts	3b0f7367fd	move to proper module	4 years ago
ulferts	fdcc89f810	allow freely setting the dates of manually scheduled child work packages	4 years ago
ulferts	0b15db3c9a	rename fixed_version to version	5 years ago
Henriette Dinger	bd7f4e4814	Update copyright notice	5 years ago
ulferts	fd6d707fa8	adapt specs	5 years ago
ulferts	6c4e572f4e	consolidate allowed_* logic in the wp contract	5 years ago
ulferts	176019f96f	return errors on unsupported topic properties	5 years ago
ulferts	587e61c647	nil non provided parameters on put	5 years ago
ulferts	bc682f6b01	bail on inexistent related resource * status * type * assignee * priority	5 years ago
ulferts	cd3ffe0cc5	adapt specs to altered interface	5 years ago
ulferts	4eab6effe1	merge changed_by_system into contract options	5 years ago
ulferts	4e5b9afef5	rename project attributes	5 years ago
Markus Kahl	cb6d28136d	allow editing estimated time for parents, show derived separately	5 years ago
Oliver Günther	016bfc49cb	[30590] Fix switching into closed status with closed version assigned https://community.openproject.com/wp/30396 introduced a blocking of status editing when the version and version is closed. But this blocking also happens when trying to move a status INTO a closed state. https://community.openproject.com/wp/30590	5 years ago
ulferts	cc0145daf6	prevent useless edits to wp status In case the fixed version and the status of a work package are both closed, the status of a work package cannot be altered any more. Attempting it will result in an error. Before the fix, the possible status calculation would not factor in that situation and the status would be marked as writable regardless as well. Therefore, the frontend would display a list of statuses even though selecting one would do nothing at all. Now, the status property is marked as non writable in such a situation and the status list will only contain the current status. As we only fetch the form after a click on the edit field, we can only disable the field after that which is a bit weird.	5 years ago
ulferts	6e9e7a4de4	adapt specs	6 years ago
ulferts	e69d9e9dc0	rely on SetAttributesService to set wp author	6 years ago
ulferts	6c3c7003e2	provide necessary permissions in specs	6 years ago
ulferts	5b758c1419	differentiate between user and system set attributes	6 years ago
ulferts	a5defb73c5	add dedicated permission to regulate assigning a version	6 years ago
Jens Ulferts	9b99fd4b43	adapt specs	6 years ago
Oliver Günther	ad43a7ea95	Prepare for core integration	6 years ago
Oliver Günther	3ba6913960	Implement read-only work package attributes based on status	6 years ago
Oliver Günther	3807bc4f7f	[28446] Rename due date to finish date https://community.openproject.com/wp/28446	6 years ago
Oliver Günther	0d59680815	[28086] Add error when moving to milestone with children https://community.openproject.com/wp/28086	6 years ago
Jens Ulferts	17efd9c84b	fix adding notes to work packages in `395c665627` the to generous interpretation of the :add_work_package_notes, that allowed user having the permission to alter additional attributes was removed. But after the removal a user having the permission was no longer allowed to add notes at all.	6 years ago
Oliver Günther	059770f533	FactoryGirl => FactoryBot Removes the deprecation	7 years ago
Oliver Günther	ea8daa63af	FactoryGirl => FactoryBot (belongs to opf/openproject#6304 )	7 years ago
Oliver Günther	6ef4211e77	Bump copyright to 2018 (#6171 ) [ci skip]	7 years ago
Jens Ulferts	b97d79af2e	additional specs	7 years ago
ulferts	83e605e63c	allow setting parent that has relation via new siblings (#6114 ) [ci skip]	7 years ago
Oliver Günther	3facc5851d	[26829] Patch reform-rails to use activerecord i18n_scope (#6105 ) The validator passed to AM::Error does not use the `i18n_scope` we define on either Reform::Form or the model, but is delegated from the included AM::Translations module. This in turn causes I18n to lookup the scope `:activemodel`, failing the localization. https://github.com/trailblazer/reform-rails/issues/56 https://github.com/trailblazer/reform-rails/pull/35 [ci skip]	7 years ago
ulferts	6b9e7066fd	streamline relation in hierarchy error message (#6056 ) [ci skip]	7 years ago
Jens Ulferts	690e0ffc60	wp create/update/destroy via services	7 years ago
Jens Ulferts	9b4a09f677	adapt to changes in core	7 years ago
Jens Ulferts	6fdd122534	merge wp tree and relations into typed_dag Instead of having the tree/hierarchy information for work packages and the relations between the work packages separated into two tables all the information is now stored in the relations table. To support this, the typed_dag plugin is used. Notable changes: * relations_to and relations_from are swapped. relations_to has all relations that point to another work package (from_id = work_package.id) and relations_from contains all relations that lead to the work package from another one (to_id = work_package.id). This change is merely in the code. The db information is left untouched. * For follows/precedes to_id and from_id are swapped in the db. Because of that, "follows" is now the canonical name instead of "precedes". This is done so that hierarchy relations and follows relations point into the same direction which allows to easily detect cyclic relationships that would lead to infinit scheduling. * the columns `root_id`, `lft`, `rgt` do no longer exist in the wp table. * the column `relation_type` does no longer exist in the relations table. * For every type of relation a column (integer) does now exist in the relations table (e.g. hierarchy, block, follow) * Separate associations exist for every type of relation into two directions. E.g. Work packages following the current one can be accessed via `work_package.precedes`	7 years ago
ulferts	5301280dd0	adapt to altered representers api (#257 ) [ci skip]	7 years ago
ulferts	0c0b16508b	Fix/bump representable (#5465 ) * bump reform and roar -> bumps representer * adapt to changed validation interface * disable initializer patch for now * adapt to changed representable attr interface * can no longer have private methods inside a representer * private no longer possible for representer * bump reform * wip - restyle validation * remove commented out patch * apply injection as prescribed * reactivate reform error symbols patch * remove patch to Hash superfluous wit ruby 2.3 * remove outdated human_attribute_name patch * whitespace fixes * adapt filter name after removal of human_attribute_name patch * adapt filter specs to no longer rely on human_attribute_name patch * fix version filter name * remove reliance on no longer existing human_attribute_name patch * use correct key in journal formatter * remove private from representer * adapt to altered setter interface * reenable i18n for error messages in contracts * no private methods in representer * defined model for contracts * fix validaton * instantiate correct Object * define model for contract * circumvent now existing render method on reform * replace deprecated constant * patch correct reform class - not the module - via prepend * refactor too complex method * replace deprations * remove remnants of parentId * prevent error symbols from existing twice * adapt user representer to altered setter interface * adapt watcher representer to altered setter interface * remove now unnessary patch * adapt setter to altered interface * adapt spec * fix custom field setters * remove parentId from wp representer As the parent is a wp resource, clients should use the parent link instead * adapt spec to changed valid? interface * remove parentId from wp schema * replace references of parentId in frontend * remove TODO [ci skip]	8 years ago
ulferts	21571ac3a2	Fix/add child rescheduling (#5499 ) A work package that is to be added as a child needs to be rescheduled to not validate any constraints posed by relations the parent work package might have [ci skip]	8 years ago

50 Commits (d96d47d4fba9f9e57be316b5b59a5b82feca183f)