openproject

Commit Graph

Author	SHA1	Message	Date
Christophe Bliard	47a297daae	Fix argument alignment since `f08bea3467` (#10129 ) * Fix argument alignment since `f08bea3467` The FactoryBot.* prefix has been removed in `f08bea3467`. Since then rubocop complains about Layout/ArgumentAlignment. This commit fixes it. * do not fix alignments for modules/*/spec yet hoping to be under the limit of 65535 characters for reviewdog to report on rubocop errors	3 years ago
Behrokh Satarnejad	97233137b9	[40038] Make team planner only accessible with EE token (#10021 ) * check if the user has a correct ee token activated * add team planner token and set the engine and routes of upsale * Update team_planner_controller.rb * before running the test we should check that we have a token * check if there is an EE token, then start test * change common upsale template * improve the styles and add image to the template for each feature * change custom actions and 2fa upsale template * add image of team planner to its template and medal icon * make placeholder user, 2fa and team planner upsale templates identical * Make placeholder users upsale template the same as other upsale templates * check if there is an ee token, then start testing * check there is an enterprise token for team planner and start testing	3 years ago
Oliver Günther	f08bea3467	Remove FactoryBot.* prefix where applicable	3 years ago
Oliver Günther	ccfa29c728	Move license and copyright docs to root, fix names and references	3 years ago
Wieland Lindenthal	44d57d36c6	Fix #37136 : Restrict deletion of placeholder users (#9294 )	4 years ago
Oliver Günther	a023ccf372	[36517] Fix placeholder filter returning query object, not AR collection (#9071 ) We depend on the query for correct sorting by name. https://community.openproject.com/work_packages/36517	4 years ago
Wieland Lindenthal	ffa5ac84a8	Allow deletion of placeholder users when permission of :manage_placeholder_user give (#9018 ) * Refactoring: Rename permission :add_user and :add_placholder_user to :manage_user and :manage_placeholder_user * Add deletion to :manage_placeholder_user permission label * WIP: Check :manage_placeholder_user permission before deletion Specs still missing * In controller rely on authorize_global for deleting placeholder users * Add deletion_info for placeholder users * Extend specs * Set placeholder users to locked when deleting * Review feedback Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
Oliver Günther	bbeae32698	[35508] Add global permission to manage placeholder users (#9000 ) * Add global permission to manage (but not delete) placeholders https://community.openproject.com/work_packages/35508 * Restore breadcrumbs for non-show routes * Remove permissions to memberships for add_placeholder_user permission * Allow non-admins with global permission to access membership * Remove permissions to memberships for add_placeholder_user permission * Rename shared_examples for admin contract validations Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
Wieland Lindenthal	a18954b2c9	Placeholder user services and administration (#8944 ) * Adding placeholder user contracts * Adding create, update, and delete services for placeholder users * WIP: Adding Placeholder User contract specs [ci skip] * Extract contract validation into common helper * Add common validation in BaseContract + common example for admin checks * Introduce common ModelContract shared context for validations * WIP: PlaceholderUser controller, i18n, and routes [ci skip] * Placeholder users index page and query - moved all group related scopes from User to Principal to make them also available in PlaceholderUser. * end * Create PlaceholderUser * Feature spec for editing a placeholder user * Manage PlaceholderUser memberships The managment of memberships is pretty similar for User and PlaceholderUser. This commit extacts the similarities and uses them for both. * General partial and show view for PlaceholderUser * Delete obosolete partial * Allow RequireAdminGuard to be used as a module function * Fix I18n for confirmation text * Smaller code improvements * Fix: Syntax for accessing status enums was wrong. * Use UpdateService for updating a placeholder user * Add spec for PlaceholderUsersController * First code improvements after code review. - more improvements to come. * Further code improvements after review ... still more to come * Correct namespace of delete service * Fix: Make placeholder user contract validate * Remove :type attribute from base contract of User and PlaceholerUser ...and add it to the CreateContracts. Also add type validations. Further extract shared examples for placeholder user attribute validation * Refactor: Extract membership hook calls to helper * Fix redirect paths for membership controllers * Specs already present in shared exampels. * Fix duplicates routes for users and placeholder users * Fix user path * Add attribute name and lastname We don't need a writeable check as both are equally writable * Replace more references to tab_edit_user_path * Skip specs for PlaceholderUsers::DeletionService We will tackle that service in a separate PR. * Fix module usage of RequireAdminGuard * Fix group filter for placeholder users * Fix invalid reference to expect_valid * Fix: Fix tabbed edit path for placeholder users * Fix status filtering on users * Linting * Improve generalisation of individual principal filter cell - Check for presence of groups and statuses in order to toggle visibility of their UI element. - Remove groups from placeholder user controller and cell initialization and options * Fix selector on groups assign * Remove using_shared_fixtures Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago

9 Commits (d96d47d4fba9f9e57be316b5b59a5b82feca183f)