openproject

Commit Graph

Author	SHA1	Message	Date
Wieland Lindenthal	466eaff6ac	[#40187 ] Uploaded IFC Model can't be set as Standard Model (#9984 ) https://community.openproject.org/work_packages/40187	3 years ago
Wieland Lindenthal	28571eac26	Fix updating conversion_status in Update Service	3 years ago
Wieland Lindenthal	69fd660a10	Ensure that IfcModel's conversion status is reset on update Set the status to pending and delete potential error messages.	3 years ago
Wieland Lindenthal	ebab8bb49c	Save for each IFC model what state its conversion to XKT is in. (#9751 ) * Save for each IFC model what state its conversion to XKT is in. Display the status and, if present, the error message to the users * Set conversion_state on migration * Add converion error messages to the ifc models list. * Extend ifc conversion spec to cover conversion status and message * Extend view spec to cover conversion status * Satisfy rubocop * Improve readability of migration code:	3 years ago
Benjamin Bädorf	3aaac1c7ce	Rename most notification to toaster instances (#9765 ) * Rename most notification to toaster instances * Frontend builds * Fix spec build * Rename more notification elements to toaster * Rename toaster-box to op-toast * Fix op-toast-container * Rename toasters upload progress * Try fixing page.rb toaster check * Fix some specs, break some others * Correctly overwrite toast_type * Fix more specs * Fix one more notification to toaster rename * Fix linting errors, harmonize naming more * Remove byebug debugging statement * Remove byebug debugging statement * Rename notification in the backend, too * Rename more instances of notifications to toastService * Rename backend back to notification since bundle gems expect it there * expect_toaster -> expect_toast Co-authored-by: Henriette Darge <h.darge@openproject.com>	3 years ago
Oliver Günther	2fcfa3ed3f	Remove retry as diskfile is already accessible	3 years ago
Oliver Günther	8e67070af3	Reschedule conversion job when direct upload not yet finished	3 years ago
Wieland Lindenthal	7273bdfab5	Allow downloading IFC files (#9750 ) * Allow downloading IFC files * Download file instead of showing the content in a new tab * Simplify to use original file name * Simple approach: keep orinal file names for now Renaming the IFC files before downloading is possible but out of scope at the moment. * Satisfy rubocop Co-authored-by: Henriette Darge <h.darge@openproject.com>	3 years ago
Oliver Günther	33acdd765a	Fix import name	3 years ago
Oliver Günther	eb0feb52d2	Fix exporting with a tempfile	3 years ago
Eric Schubert	9122884110	[#39144 ] fixed PR issues - removed some linter issues - fixed expected data from request tests	3 years ago
Eric Schubert	f8923ad238	fixed bim navigation spec, again	3 years ago
Eric Schubert	3e5cd88c94	fixed feature spec selector	3 years ago
Eric Schubert	c8a35f97da	[39451] remove base64 snapshot data from bcf vp - https://community.openproject.org/work_packages/39451 - remove base64 data after converted to snapshot attachement and before storing into database - added migration to remove snapshot data from current data	3 years ago
Eric Schubert	0ab5b5a164	[#39184 ] Switching viewer dropdown fails to load (#9763 ) * [#39184] Switching viewer dropdown fails to load - https://community.openproject.org/work_packages/39184 - ifc viewer is now only initialized after view is initialized * Fix bim nav spec to check for xoekit init Co-authored-by: Wieland Lindenthal <w.lindenthal@forkmerge.com>	3 years ago
Eric Schubert	a3ac4f4112	[#38981 ] Integrate latest Xeokit version v2.3.6 (#9712 ) * [#38981] Integration of v2.3.1 of xeokit viewer - restyled toolbar - added properties panel - moved focus warning icon - restructured viewer container * [#38981] Switch style to not blue panel * Fix: Open properties tab on context menu click. * Update npm-schrinkwrap to use lockfileVErsion 1. * Fix: Make info buttons use correct observable for active state. * [#38981] Fixes on bcf viewer - hide info button if no model is loaded - reduce font size in properties panel * [#38981] fixed viewer styles on mobile * [#38981] fixed spec selector * Bump Xeokit Bim Viewer to 2.3.2 - Fixes infos in the properties tab * [#38981] aligned porperties tab values to OP tables * bump xeokit-bim-viewer to version 2.3.6 * [#38981] fixed table wrap layout Co-authored-by: Eric Schubert <e.schubert@openproject.com> Co-authored-by: Wieland Lindenthal <w.lindenthal@forkmerge.com>	3 years ago
Oliver Günther	b33d4e78ad	Ensure the importer executes under the given user (#9713 ) Since the attachment services now depend on a user for authorization, but the viewpoint snapshot is assigned explictily through snapshot.viewpoint=, there is no way to pass the current_user explicitly. Instead, log in the given user for the course of the import process	3 years ago
Oliver Günther	0b5da9b9e1	Give access to the issue project when trying to save a viewpoint (#9707 )	3 years ago
Oliver Günther	af5e2e8494	Add spec for regular uploads as well	3 years ago
Eric Schubert	b23a3638f7	[#38960 ] Viewpoint files must end with .bcfv - https://community.openproject.org/work_packages/38960 - changed file extension from xml to bcfv	3 years ago
Wieland Lindenthal	3a4687ff9f	[#38954 ] IFC upload not working since attachment whitelisting * Saving the IFC file (at least during local upload): Validation of permissions for creating attachments fail as the project on which to check for permissions is missing * During conversion saving XKT file fails as it not an uploaded file and thus method `original_filename` is not present https://community.openproject.org/work_packages/38954	3 years ago
Eric Schubert	78c4531d1c	[#38833 ] Fixed PR issues - fixed some rubocop issues - added parameter declaration to comments api - added readonly flag to readonly records	3 years ago
Oliver Günther	b3ab397c94	Fix expects in specs after whitelist bypass	3 years ago
Oliver Günther	2d3a246fa4	Add create contract spec	3 years ago
Oliver Günther	4d1efab3c6	Fix content of viewpoint image to get correct content type	3 years ago
Oliver Günther	9e1dc1d50e	Set snapshot through attachment service	3 years ago
Oliver Günther	8a881cb20c	Fix uploader being changed by system	3 years ago
Oliver Günther	582579729e	Replace ifc models attachment handling with services	3 years ago
Oliver Günther	6ff21c6b96	Fix export job for bim	3 years ago
Eric Schubert	d6b87a2210	[#38833 ] BCF API Comments Service - https://community.openproject.org/work_packages/38833 - added requests tests - added check for expected body length - added representer and api for bcf_comments - added create and set attributes service for bcf_comments - added migration for comment hierarchy - added create and update service for journals	3 years ago
Wieland Lindenthal	ecfa0349e7	Fix #33448 : Format WP column "BCF snapshot" as string (#9652 ) Render an "X" if there is at least one viewpoint for the associated BCF issue. https://community.openproject.org/wp/33448	3 years ago
Wieland Lindenthal	0193b3fcfa	[#38032 ] BCF module: Change default order to ID DESC. (#9651 ) - Adopt spec. CSS class for ID link in WP cards changed https://community.openproject.org/work_packages/38032	3 years ago
Wieland Lindenthal	468b5602d1	Stabilyze Revit Add-in navigation spec	3 years ago
Wieland Lindenthal	00f4181156	Fix: Revit Add-in - Correct successState for creating BCF issues (#9673 ) Currently after creating a BCF issue in Revit Add-in the redirect goes to the work package module's full view. Instead it should redirect to 'bim.partitioned.show'. This fix here has no corresponding bug work package on community.	3 years ago
Wieland Lindenthal	35124c876d	Add Refresh button for Revit Add-in from dev into 11.4 (#9670 ) Originally implemented in PR 9461. - A feature spec was added here on top. - The navigation spec for the revit add-in got more stable. https://community.openproject.org/wp/38028	3 years ago
Oliver Günther	ccfa29c728	Move license and copyright docs to root, fix names and references	3 years ago
ulferts	63ad2e8dd1	Generate IAN near real time (#9570 ) * destroy notifications upon journal destruction * breakup spec by journable * have a dedicated job for scheduling journal completed events * generate notifications in delayed job * route wiki journal events through notifications * combine mail sending for notifications into single job * robustness if a journal is deleted * linting * differentiate BaseJournal and AssociatedJournal BaseJournal holds the data of a journal that reflects the columns in the journaled model while AssociatedJournal reflects the columns of a model associated to the journaled model via a has_many/one association * route news journal events through notifications This does not yet include notifications for comments on news * include news comment in notification workflow * have the whole workflow in a single state machine job * include forum message in notification workflow * include document in notification workflow * less dependencies from acts as watchable * fix, test and document workflow job	3 years ago
Wieland Lindenthal	8332b660b4	Satisfy rubocop	3 years ago
Wieland Lindenthal	4935d3a3d4	Fix #33448 : Format WP column "BCF snapshot" as string Render an "X" if there is at least one viewpoint for the associated BCF issue. https://community.openproject.org/wp/33448	3 years ago
Wieland Lindenthal	0b32f19712	[#38032 ] BCF module: Change default order to ID DESC. (#9464 ) https://community.openproject.org/work_packages/38032	3 years ago
bsatarnejad	bb67999afe	resolve errors	3 years ago
Henriette Darge	0c437b44b6	Stabilize spec as the single test cases interfered with each other	3 years ago
luzpaz	2ae53bd252	Fix typos in user facing and non-user facing code (#9497 ) * Fix typos in user facing and non-user facing code Found via `codespell -q 3 -S ./config/locales -L ba,nd,parms,sur,varius` * Fix strings in specs	3 years ago
Behrokh Satarnejad	133c0136c1	Using BEM methodology to change the styles (#9401 ) * change some of stylesheets * change the style naming * resolve the error * improving the previous commit with Ben's comments * improve the styles of breadcrumb * change the stylesheet related to status button * refactoring css stylesheets of wp single card * fixing the errors of PR, correct selector * change some of stylesheets * change the style naming * resolve the error * improving the previous commit with Ben's comments * improve the styles of breadcrumb * change the stylesheet related to status button * refactoring css stylesheets of wp single card * fixing the errors of PR, correct selector * resolve the error on PR related to boards onboarding * wp relation and list view style changes * resolve the errors of previous commit * fix error in selecting wp relation * fix the errors of wp relations ruby tests * change the stylesheets of autocompleter and wp calendar * change the style of grid page * Some improvements to the BEM styling * Prefix draggable-autocomplete BEM block with op- * Fix spec selector * Fix spec selector Co-authored-by: Benjamin Bädorf <b.baedorf@openproject.com>	3 years ago
Oliver Günther	e9d7c374cc	[37868] Whitelist for attachment mime types and extensions on upload (#9431 ) * Add setting for whitelist * Make attachments API BaseServices compatible * Add prepare service and contract * Correctly pass the filename to the UploadedFile * Add presence check to filename * Fix expected validation message * We no longer raise a multipart error when metadata is empty * Fix filesize validation on prepared uploads * Add parser error if invalid metadata json * When attachment is not saved, use filename property * Return correct error message on JSON parser erroro * Fix specs * Use attachment upload representer * Fix direct uploads mocks with new service layer * Lint * Fix export job using attachment service * Fix IFC controller using attachment prepare service * Fix export job * RenameRename params_getter to params_source * Fix mail handler using attachment service * Fix usage of attachment create service in documents * Reuse shared examples for document attachment spec * Fix stubbed attachment service in export job spec * Use admin user in backup spec * Fix export job for bim * Fix attachment integration spec * Fix issues_controller spec * Make budget resource spec reuse common examples * Fix attachment parsing representer spec * Replace prepare part of attachment spec into separate service spec * Clear cache for login spec * Convert document create/update into services * Budget services * Allow options to be passed to property twin * Remove setting author on budget initialize * Replace meetings update with services * Replace ifc models attachment handling with services * Don't check uploader if changed by system * Fix uploader being changed by system * Replace wiki page attach_files with attachable services * Replace avatar saving * Replace snapshot attach_files * Skip double validation when container present * Set snapshot through attachment service * Remove attach_files * Validate content type in contract * Enforce writing the content type without accepting user input * Expect changed content_type * Fix content of viewpoint image to get correct content type * Fix tsv spec * Add create contract spec * Bypass whitelist in internal services when conflicting with user * Fix expects in specs after whitelist bypass * Render contract errors for wiki * Add before_hook to bodied to allow to pre-authorize permissions * Budget errors from contract * Document errors from contract	3 years ago
ulferts	2a015eeac3	Feature/journal aggregation on write (#9396 ) * aggregate journals on write - simple implementation * remove references to aggregated journals on read * rewrite existing journals to be aggregated * remove aggregated journal reference * only delete predecessor if it can be aggregated * fix aggregation condition * adapt specs * remove aggregated journal functionality from production code The code is still necessary in a migration for the time being * adapt specs * use polymorphic belongs_to for journal data The association can then be employed for eager loading * eager load for activity rendering	3 years ago
Wieland Lindenthal	23e6f67ce6	Fix: BCF XML export: Don't write comment author's mail unless it exists (#9367 )	3 years ago
Wieland Lindenthal	31c1bdc9f9	Feature #37401 : Bump XEOKIT to use XKT files version 8. Migrate all IFC models. (#9300 ) * bump xeokit to xkt version 8 * Bump @xeokit/xeokit-gltf-to-xkt to version 1.3.1 - Remove all logic for extracting and providing metadata JSON - Update seeder - Update seeded XKT demo hospital model files - Update conversion service to join GLTF and metadata into XKT file - Fix feature spec for viewpoints. * Remove specs for metadata attachment checking * Update modules/bim/db/migrate/20210521080035_update_xkt_to_version8.rb Co-authored-by: Markus Kahl <machisuji@gmail.com>	3 years ago
Wieland Lindenthal	892322a0a2	Stop create BCF feature spec from flickering (#9344 )	3 years ago
ulferts	0c2d87b4eb	choose wp type by position only (#9297 ) There was a misconception in the code related to the `is_default` field. The `is_default` field only governs whether a type is enabled by default in a new project or not.	4 years ago

1 2 3 4 5

225 Commits (dd4ebb5bf7c7c979b8e3c70ca2a0781a6fa58533)