7876 Commits (dd703bcb2d5e7148644023a701749f39950a79d0)

Author	SHA1	Message	Date
Oliver Günther	3bf0711716	Remove back button from notification center ... https://community.openproject.org/wp/42048	3 years ago
Christophe Bliard	7d0d812b35	remove deprecation warning when using nested hash in env var names	3 years ago
Christophe Bliard	73a8421c42	make nested hash env names work with env_alias for Setting	3 years ago
Christophe Bliard	2c67f992a5	stringify hash settings keys and support OPENPROJECT_2FA env var ... updated code to look up the string key instead of the symbol key introduce a 'with settings' rspec shared context	3 years ago
Christophe Bliard	8082cd9d08	log deprecation warning when using env var names to set nested hash setting	3 years ago
Christophe Bliard	e02df3f29d	handle env vars overriding hash setting with single underscore ... setting OPENPROJECT_REPOSITORY_CHECKOUT_DATA_GIT_MINIMUM__VERSION=42 will do the same as OPENPROJECT_REPOSITORY__CHECKOUT__DATA_GIT_MINIMUM__VERSION=42: it will do Setting.repository_checkout_data['git']['minimum_data'] = 1 Please use OPENPROJECT_REPOSITORY_CHECKOUT_DATA='{git: {minimum_version: 42}}' instead, it is more readable.	3 years ago
Christophe Bliard	9f498b2f8e	load settings from variations of env variables ... could load value from: - OPENPROJECT_SOME__KEY__NAME=value can now also load value from: - OPENPROJECT_SOME_KEY_NAME=value - SOME_KEY_NAME=value A deprecation message is logged if used without the OPENPROJECT_ prefix.	3 years ago
Oliver Günther	53b72e2c9e	[41923] Show loading during initial backend API request (#10558) ... * [41923] Show loading during initial backend API request There is still a slight delay between initial loading and the re-rendering, but that appears to be minimal. https://community.openproject.org/wp/41923 * Ensure we click on a non-disabled button	3 years ago
Oliver Günther	c6e0cdaea0	add changed autocomplete=off due to rails bump	3 years ago
ulferts	9b8e5d6216	keep roles inherited from different group on role adding	3 years ago
Christophe Bliard	e06fb3423d	fix test	3 years ago
Christophe Bliard	718ccf6775	make backup possible when create_backup is the sole user permission	3 years ago
Oliver Günther	057ac5ff36	[42023] Ensure formattable properties output a string as raw ... The API specification states that the raw text is always a string. However when passing `nil` as the represented text, it is output directly. https://www.openproject.org/docs/api/basic-objects/#formattable-text https://community.openproject.org/wp/42023	3 years ago
Dombi Attila	18b1aa1b3c	Fix work packages bulk editing budget attribute	3 years ago
Eric Schubert	81d526c2c5	[#41945] fixed rubocop issues	3 years ago
Frank Bergmann	d632ba6bb6	[#40867] Wrong progress value in parent task - Estimated hours ... https://community.openproject.org/work_packages/40867 This is a second commit/pull request related to this bug. It deals with the dependency of done_ratio on estimated_hours. We need to recalculate done_ration along the hierarchy with changes in estimated_hours.	3 years ago
Frank Bergmann	968fbfa6f3	Simplified spec	3 years ago
Benjamin Bädorf	7712220ffb	Remove byebug debugging statement	3 years ago
Benjamin Bädorf	cd4ab52ff4	Remove last references to old 'reference-link' class in wp-inline-create	3 years ago
Dombi Attila	e8c4b6a872	fixup! Migrate team planner permissions	3 years ago
Dombi Attila	904f9ab1a1	fixup! Migrate team planner permissions	3 years ago
Dombi Attila	d1fb1d08d4	fixup! Migrate team planner permissions	3 years ago
Dombi Attila	a1dd6a3779	Migrate team planner permissions	3 years ago
Benjamin Bädorf	153fbb03c7	Update add assignee selector in more specs	3 years ago
Benjamin Bädorf	cf3dda7b74	Fix inline create button selection in specs	3 years ago
Dombi Attila	567c9984bd	Increase rubocop RSpec/MultipleMemoizedHelpers cop to allow 20 helpers, fix other cops	3 years ago
bsatarnejad	fc8d168404	disabling the a robocop is not working	3 years ago
luz paz	9e22d420db	Fix typos ... Found via `codespell -q 3 -S ./config/locales,./modules/xls_export/config/locales,./modules/job_status/config/locales,./modules/two_factor_authentication/config/locales,./modules/backlogs/config/locales/crowdin,./**/config/locales -L ba,nd,parms,pullrequest,pullrequests,sur,varius`	3 years ago
Christophe Bliard	69b9db3b9a	prevent seeding settings whose default value is undefined	3 years ago
Christophe Bliard	c6ff4be74f	deserialize empty string setting value to nil when not string format ... the seeder blindly saves all settings to database, setting the value to empty string when no value is defined. When the setting is read back, it can be misinterpreted. For instance a boolean setting with a nil value will have the value '' once seeded, and it is truthy which is wrong. add a helper to restore settings after resetting them in tests	3 years ago
Christophe Bliard	c0bb7ca367	send stdout to log for demo_data_seeder_spec.rb	3 years ago
Christophe Bliard	094b4c427e	reenable spec for BasicData::SettingSeeder and make it pass	3 years ago
bsatarnejad	ee76bcfc6d	not needed to open the dropdown to insert text to insert	3 years ago
Dombi Attila	76ea07ec6c	Regression tests for clearing filter representer cache on product version change	3 years ago
Eric Schubert	4d73962065	[#40196] another test fixed	3 years ago
Eric Schubert	385ebe1902	[#40196] fixed representer spec	3 years ago
Oliver Günther	a854ad03ac	[41649] Allow embedded bootstrap within boostrapped components ... Embeddable components need to be bootstrapped even if they are within another bootstrapped component. As the application root component is also dynamically bootstrapped, otherwise no embeddable component would have been bootstrapped. https://community.openproject.org/wp/41649	3 years ago
Oliver Günther	26176fcbe7	[41716] Consolidate assignee string in IAN center and team planner ... https://community.openproject.org/wp/41716	3 years ago
Andreas Pfohl	d3111b1b33	[#41728] Wiki updated notification: "Updated by" is shown to always be the "author" ... https://community.openproject.org/work_packages/41728 - No longer overwrite Wiki page author with last editor - Use user from Wiki page journal as author for mail notification	3 years ago
ulferts	f1111922ed	use API::ParserStruct for all API parsing	3 years ago
ulferts	464bfaa33c	avoid left joining on roles to avoid multiple projects returned ... As the permission check used to be left joined directly to the list of projects, with a user having multiple roles, this lead to having a project returned multiple times. The permission check is not necessary at this point at all however since the query will already add a visible scope if necessary.	3 years ago
Oliver Günther	a54c208a41	[41903] Fix queries visible scope for private global queries	3 years ago
Christophe Bliard	083f0e6b27	clear Rails cache between tests to avoid Settings leaking state ... Settings are cached with a key having the timestamp of the latest updated setting. When no settings are saved, current time is used instead. For fast tests occurring in the same second, the settings state is kept as they share the same cache key. That leads to non-isolated tests and possibly failures. Clearing the Rails cache before each test avoids it.	3 years ago
Oliver Günther	f5ea098356	[41437] Use signalling on project edit field (#10432) ... * Add project-edit-field that uses op-autocompleter * Replace for_type param with regular filter * Fix unrelated spec now fixed in behavior due to the select helper change The spec did not apply the new type previously, so would not override the description. This caused the expects to remain valid, but was actually incorrect behavior. * Ensure we're not focussing the project field on inline create * fix flickering test because of ng-select/ng-select#1869 we can't use a string with spaces in ng-select input value while the list of items is empty. The spaces would be ignored and matching an entry would then fail. Instead wait for ng-dropdown-panel to appear which means items are present, the bug is inactive, and the spaces can be properly sent to the input. flickering test was spec/features/custom_fields/multi_user_custom_field_spec.rb:61 * fix tests broken in 65695f1 - Reintroduce sleep to make test pass. I'd like to get rid of it but can't understand why it's needed. - refine results_selector only if it is 'body'. * fix tests by not waiting for dropdown before typing for global search Co-authored-by: Benjamin Bädorf <b.baedorf@openproject.com> Co-authored-by: Christophe Bliard <c.bliard@openproject.com>	3 years ago
Dombi Attila	c94eb6cef3	[41071] Ensure project export includes optional column https://community.openproject.org/wp/41071	3 years ago
Eric Schubert	3e07975584	[#41480] respond with 401 on invalid bearer tokens ... - https://community.openproject.org/work_packages/41480 - amend strategy for doorkeeper to react on all bearer tokens - added ouath request spec for valid, invalid and revoked token	3 years ago
ulferts	36baf76bc1	lint settings_helper	3 years ago
ulferts	43f85a9bfc	no hidden field on disabled setting	3 years ago
ulferts	a2caedcdb7	allows selecting items to copy from a template project	3 years ago
Benjamin Bädorf	b7f732ddcc	Feature/41135 include all subprojects (#10413) ... * Add new query attribute include_subprojects * Set include_subprojects in factories * Replace create_query helper with default endpoint * Adapt spec to new query create service * Add spec for changed subproject behavior * Extend project filter with replaced values and add spec * Fix spec trying to save default query * Fix ordered_work_packages now that we're base service compatible * Basic frontend for include all subprojects * Fix disabled state, update button colors * Add new query attribute include_subprojects * Set include_subprojects in factories * Replace create_query helper with default endpoint * Adapt spec to new query create service * Add spec for changed subproject behavior * Extend project filter with replaced values and add spec * Add a ParserStruct overriding Enumerable#group_by * Fix ordered_work_packages now that we're base service compatible * Add tooltip * Add tooltips to include projects * Add is parameter to query props for query space * Fix specs, add i18n strings * Correctly parse and update the query with includeSubprojects * FIx most spec * Fix badge count for team planner spec, fix duplicated where def in project filter * Only load project list if opening drop modal * Expect that sub_sub_bug is also present * I18nify the strings * Fix typo * Fix specs * Fix linting errors * Fix specs * Fix linting errors * Fix linting errors * Fix failing specs Co-authored-by: Oliver Günther <mail@oliverguenther.de>	3 years ago