63315 Commits (dd703bcb2d5e7148644023a701749f39950a79d0)

 

All Branches   

Search

Author	SHA1	Message	Date
dependabot[bot]	0e66d45020	Bump test-prof from 1.0.7 to 1.0.8 ... Bumps [test-prof](https://github.com/test-prof/test-prof) from 1.0.7 to 1.0.8. - [Release notes](https://github.com/test-prof/test-prof/releases) - [Changelog](https://github.com/test-prof/test-prof/blob/master/CHANGELOG.md) - [Commits](https://github.com/test-prof/test-prof/compare/v1.0.7...v1.0.8) --- updated-dependencies: - dependency-name: test-prof dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>	3 years ago
Behrokh Satarnejad	cacd8a081a	check if the current project is not null then add it to the list of projects (#10440)	3 years ago
Oliver Günther	4c6e5b4907	Use browser based feature test for CRUD tests ... They have form authenticity now and will fail otherwise	3 years ago
Oliver Günther	66d21ef73b	Enable forgery protection in test as well ... Otherwise, we're never running into CSRF validations in test env	3 years ago
Oliver Günther	e116c5f3eb	[41719] Fix 2FA using form_authenticity_token without ruby 3 kwargs	3 years ago
OpenProject Actions CI	cbf91f69c4	update locales from crowdin [ci skip]	3 years ago
Benjamin Bädorf	0e69fd1ecf	Improve add assignee button in team planner (#10436) ... * Show either add assignee or dropzone in the teamplanner, but never both * Improve add assignee button styles	3 years ago
ulferts	3bf706b153	removes distinct as rails will handle it if necessary ... In case e.g. Projects are to be fetched via `Project.allowed_to?` rails will add the necessary distinct to the SQL statment on its own. But having the distinct forced in the query can lead to nonperformant subqueries and there, the distinct isn't necessary at all if the subquery is something like `where(project_id: Project.allowed(...))`. In such a case, whether the values are distinct will yield the same results. But the DB's query planner will take the distinct into account and the DB will have to work extra to remove the duplicates. In case of one query at least that extra work leads to an undesirable execution time of 8s compared to 60ms when avoiding the distinct. The executions plan with distinct is like this: ``` app=> EXPLAIN ANALYZE SELECT COUNT(*) FROM "notifications" WHERE "notifications"."read_ian" IS NOT NULL AND "notifications"."recipient_id" = 2147 AND "notifications"."resource_type" = 'WorkPackage' AND "notifications"."resource_id" IN (SELECT "work_packages"."id" FROM "work_packages" WHERE "work_packages"."project_id" IN (SELECT DISTINCT "projects"."id" FROM "projects" LEFT OUTER JOIN "members" ON "projects"."id" = "members"."project_id" AND "members"."user_id" = 2148 AND "projects"."active" = TRUE INNER JOIN "enabled_modules" ON "projects"."id" = "enabled_modules"."project_id" AND "enabled_modules"."name" IN ('work_package_tracking') AND "projects"."active" = TRUE INNER JOIN "role_permissions" ON "role_permissions"."permission" IN ('view_work_packages') INNER JOIN "roles" "permission_roles" ON "permission_roles"."id" = "role_permissions"."role_id" LEFT OUTER JOIN "member_roles" ON "members"."id" = "member_roles"."member_id" LEFT OUTER JOIN "roles" "assigned_roles" ON "assigned_roles"."id" = "permission_roles"."id" AND "projects"."active" = TRUE AND ("assigned_roles"."id" = "member_roles"."role_id" OR "projects"."public" = TRUE AND "assigned_roles"."builtin" = 1 AND "member_roles"."id" IS NULL) WHERE "assigned_roles"."id" IS NOT NULL)) AND (notifications.read_ian IN ('f')); QUERY PLAN -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- Finalize Aggregate (cost=5060.65..5060.66 rows=1 width=8) (actual time=8060.041..8060.656 rows=1 loops=1) -> Gather (cost=5060.54..5060.65 rows=1 width=8) (actual time=8060.027..8060.652 rows=2 loops=1) Workers Planned: 1 Workers Launched: 1 -> Partial Aggregate (cost=4060.54..4060.55 rows=1 width=8) (actual time=8056.347..8056.357 rows=1 loops=2) -> Nested Loop Semi Join (cost=550.02..4059.44 rows=440 width=0) (actual time=83.255..8056.276 rows=62 loops=2) -> Parallel Bitmap Heap Scan on notifications (cost=103.77..1757.13 rows=1648 width=8) (actual time=0.461..7.019 rows=1826 loops=2) Recheck Cond: (recipient_id = 2147) Filter: ((read_ian IS NOT NULL) AND (NOT read_ian) AND ((resource_type)::text = 'WorkPackage'::text)) Heap Blocks: exact=523 -> Bitmap Index Scan on index_notifications_on_recipient_id (cost=0.00..103.07 rows=3554 width=0) (actual time=0.684..0.684 rows=3686 loops=1) Index Cond: (recipient_id = 2147) -> Hash Join (cost=446.24..447.36 rows=1 width=4) (actual time=4.398..4.398 rows=0 loops=3652) Hash Cond: (projects.id = work_packages.project_id) -> Unique (cost=441.49..441.78 rows=59 width=4) (actual time=4.357..4.373 rows=62 loops=3652) -> Sort (cost=441.49..441.64 rows=59 width=4) (actual time=4.357..4.362 rows=63 loops=3652) Sort Key: projects.id Sort Method: quicksort Memory: 28kB Worker 0: Sort Method: quicksort Memory: 28kB -> Merge Join (cost=159.35..439.75 rows=59 width=4) (actual time=0.499..4.343 rows=64 loops=3652) Merge Cond: (role_permissions.role_id = permission_roles.id) -> Nested Loop (cost=159.12..559.28 rows=89 width=12) (actual time=0.493..4.320 rows=64 loops=3652) Join Filter: ((assigned_roles.id = member_roles.role_id) OR (projects.public AND (assigned_roles.builtin = 1) AND (member_roles.id IS NULL))) Rows Removed by Join Filter: 21166 -> Merge Join (cost=82.31..84.06 rows=79 width=12) (actual time=0.419..0.491 rows=110 loops=3652) Merge Cond: (role_permissions.role_id = assigned_roles.id) -> Sort (cost=74.32..74.62 rows=120 width=4) (actual time=0.369..0.380 rows=120 loops=3652) Sort Key: role_permissions.role_id Sort Method: quicksort Memory: 30kB Worker 0: Sort Method: quicksort Memory: 30kB -> Seq Scan on role_permissions (cost=0.00..70.18 rows=120 width=4) (actual time=0.006..0.345 rows=121 loops=3652) Filter: ((permission)::text = 'view_work_packages'::text) Rows Removed by Filter: 3104 -> Sort (cost=7.98..8.27 rows=113 width=8) (actual time=0.048..0.057 rows=116 loops=3652) Sort Key: assigned_roles.id Sort Method: quicksort Memory: 30kB Worker 0: Sort Method: quicksort Memory: 30kB -> Seq Scan on roles assigned_roles (cost=0.00..4.13 rows=113 width=8) (actual time=0.004..0.027 rows=116 loops=3652) Filter: (id IS NOT NULL) -> Materialize (cost=76.81..299.96 rows=127 width=13) (actual time=0.000..0.013 rows=193 loops=401720) -> Hash Right Join (cost=76.81..299.32 rows=127 width=13) (actual time=0.622..0.946 rows=193 loops=2) Hash Cond: (members.project_id = projects.id) Join Filter: projects.active -> Nested Loop Left Join (cost=4.73..227.08 rows=25 width=12) (actual time=0.045..0.314 rows=68 loops=2) -> Bitmap Heap Scan on members (cost=4.44..69.05 rows=19 width=8) (actual time=0.028..0.060 rows=67 loops=2) Recheck Cond: (user_id = 2148) Heap Blocks: exact=12 -> Bitmap Index Scan on index_members_on_user_id_and_project_id (cost=0.00..4.43 rows=19 width=0) (actual time=0.019..0.020 rows=67 loops=2) Index Cond: (user_id = 2148) -> Index Scan using index_member_roles_on_member_id on member_roles (cost=0.29..8.31 rows=1 width=12) (actual time=0.003..0.003 rows=1 loops=134) Index Cond: (member_id = members.id) -> Hash (cost=70.89..70.89 rows=96 width=6) (actual time=0.558..0.562 rows=192 loops=2) Buckets: 1024 Batches: 1 Memory Usage: 16kB -> Hash Join (cost=53.25..70.89 rows=96 width=6) (actual time=0.296..0.510 rows=192 loops=2) Hash Cond: (enabled_modules.project_id = projects.id) -> Bitmap Heap Scan on enabled_modules (cost=15.16..31.81 rows=372 width=4) (actual time=0.064..0.184 rows=382 loops=2) Recheck Cond: ((name)::text = 'work_package_tracking'::text) Heap Blocks: exact=12 -> Bitmap Index Scan on index_enabled_modules_on_name (cost=0.00..15.07 rows=372 width=0) (actual time=0.054..0.055 rows=383 loops=2) Index Cond: ((name)::text = 'work_package_tracking'::text) -> Hash (cost=36.85..36.85 rows=99 width=6) (actual time=0.216..0.216 rows=195 loops=2) Buckets: 1024 Batches: 1 Memory Usage: 16kB -> Seq Scan on projects (cost=0.00..36.85 rows=99 width=6) (actual time=0.007..0.165 rows=195 loops=2) Filter: (active AND active) Rows Removed by Filter: 190 -> Index Only Scan using roles_pkey on roles permission_roles (cost=0.14..9.84 rows=113 width=4) (actual time=0.005..0.010 rows=33 loops=3652) Heap Fetches: 10956 -> Hash (cost=4.74..4.74 rows=1 width=8) (actual time=0.012..0.012 rows=1 loops=3652) Buckets: 1024 Batches: 1 Memory Usage: 9kB -> Index Scan using work_packages_pkey on work_packages (cost=0.42..4.74 rows=1 width=8) (actual time=0.009..0.010 rows=1 loops=3652) Index Cond: (id = notifications.resource_id) Planning Time: 2.242 ms Execution Time: 8060.808 ms ``` and without it: ``` EXPLAIN ANALYZE SELECT COUNT(*) FROM "notifications" WHERE "notifications"."read_ian" IS NOT NULL AND "notifications"."recipient_id" = 2147 AND "notifications"."resource_type" = 'WorkPackage' AND "notifications"."resource_id" IN (SELECT "work_packages"."id" FROM "work_packages" WHERE "work_packages"."project_id" IN (SELECT "projects"."id" FROM "projects" LEFT OUTER JOIN "members" ON "projects"."id" = "members"."project_id" AND "members"."user_id" = 2148 AND "projects"."active" = TRUE INNER JOIN "enabled_modules" ON "projects"."id" = "enabled_modules"."project_id" AND "enabled_modules"."name" IN ('work_package_tracking') AND "projects"."active" = TRUE INNER JOIN "role_permissions" ON "role_permissions"."permission" IN ('view_work_packages') INNER JOIN "roles" "permission_roles" ON "permission_roles"."id" = "role_permissions"."role_id" LEFT OUTER JOIN "member_roles" ON "members"."id" = "member_roles"."member_id" LEFT OUTER JOIN "roles" "assigned_roles" ON "assigned_roles"."id" = "permission_roles"."id" AND "projects"."active" = TRUE AND ("assigned_roles"."id" = "member_roles"."role_id" OR "projects"."public" = TRUE AND "assigned_roles"."builtin" = 1 AND "member_roles"."id" IS NULL) WHERE "assigned_roles"."id" IS NOT NULL)) AND (notifications.read_ian IN ('f')); QUERY PLAN -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- Finalize Aggregate (cost=13644.10..13644.11 rows=1 width=8) (actual time=60.167..61.846 rows=1 loops=1) -> Gather (cost=13643.99..13644.10 rows=1 width=8) (actual time=60.154..61.839 rows=2 loops=1) Workers Planned: 1 Workers Launched: 1 -> Partial Aggregate (cost=12643.99..12644.00 rows=1 width=8) (actual time=56.361..56.376 rows=1 loops=2) -> Parallel Hash Semi Join (cost=10982.86..12643.36 rows=252 width=0) (actual time=53.275..56.364 rows=62 loops=2) Hash Cond: (notifications.resource_id = work_packages.id) -> Parallel Bitmap Heap Scan on notifications (cost=103.77..1757.13 rows=1648 width=8) (actual time=0.471..3.217 rows=1826 loops=2) Recheck Cond: (recipient_id = 2147) Filter: ((read_ian IS NOT NULL) AND (NOT read_ian) AND ((resource_type)::text = 'WorkPackage'::text)) Heap Blocks: exact=196 -> Bitmap Index Scan on index_notifications_on_recipient_id (cost=0.00..103.07 rows=3554 width=0) (actual time=0.712..0.712 rows=3686 loops=1) Index Cond: (recipient_id = 2147) -> Parallel Hash (cost=10782.56..10782.56 rows=7722 width=4) (actual time=50.813..50.826 rows=2328 loops=2) Buckets: 32768 Batches: 1 Memory Usage: 480kB -> Hash Semi Join (cost=440.49..10782.56 rows=7722 width=4) (actual time=9.231..49.907 rows=2328 loops=2) Hash Cond: (work_packages.project_id = projects.id) -> Parallel Seq Scan on work_packages (cost=0.00..10123.89 rows=50389 width=8) (actual time=0.006..16.405 rows=60496 loops=2) -> Hash (cost=439.75..439.75 rows=59 width=8) (actual time=9.196..9.208 rows=64 loops=2) Buckets: 1024 Batches: 1 Memory Usage: 11kB -> Merge Join (cost=159.35..439.75 rows=59 width=8) (actual time=2.212..9.188 rows=64 loops=2) Merge Cond: (role_permissions.role_id = permission_roles.id) -> Nested Loop (cost=159.12..559.28 rows=89 width=16) (actual time=2.185..9.141 rows=64 loops=2) Join Filter: ((assigned_roles.id = member_roles.role_id) OR (projects.public AND (assigned_roles.builtin = 1) AND (member_roles.id IS NULL))) Rows Removed by Join Filter: 21166 -> Merge Join (cost=82.31..84.06 rows=79 width=12) (actual time=1.272..1.360 rows=110 loops=2) Merge Cond: (role_permissions.role_id = assigned_roles.id) -> Sort (cost=74.32..74.62 rows=120 width=4) (actual time=1.167..1.183 rows=120 loops=2) Sort Key: role_permissions.role_id Sort Method: quicksort Memory: 30kB Worker 0: Sort Method: quicksort Memory: 30kB -> Seq Scan on role_permissions (cost=0.00..70.18 rows=120 width=4) (actual time=0.015..1.121 rows=121 loops=2) Filter: ((permission)::text = 'view_work_packages'::text) Rows Removed by Filter: 3104 -> Sort (cost=7.98..8.27 rows=113 width=8) (actual time=0.102..0.116 rows=116 loops=2) Sort Key: assigned_roles.id Sort Method: quicksort Memory: 30kB Worker 0: Sort Method: quicksort Memory: 30kB -> Seq Scan on roles assigned_roles (cost=0.00..4.13 rows=113 width=8) (actual time=0.015..0.044 rows=116 loops=2) Filter: (id IS NOT NULL) -> Materialize (cost=76.81..299.96 rows=127 width=17) (actual time=0.005..0.039 rows=193 loops=220) -> Hash Right Join (cost=76.81..299.32 rows=127 width=17) (actual time=0.548..0.776 rows=193 loops=2) Hash Cond: (members.project_id = projects.id) Join Filter: projects.active -> Nested Loop Left Join (cost=4.73..227.08 rows=25 width=12) (actual time=0.046..0.218 rows=68 loops=2) -> Bitmap Heap Scan on members (cost=4.44..69.05 rows=19 width=8) (actual time=0.027..0.056 rows=67 loops=2) Recheck Cond: (user_id = 2148) Heap Blocks: exact=12 -> Bitmap Index Scan on index_members_on_user_id_and_project_id (cost=0.00..4.43 rows=19 width=0) (actual time=0.021..0.021 rows=67 loops=2) Index Cond: (user_id = 2148) -> Index Scan using index_member_roles_on_member_id on member_roles (cost=0.29..8.31 rows=1 width=12) (actual time=0.002..0.002 rows=1 loops=134) Index Cond: (member_id = members.id) -> Hash (cost=70.89..70.89 rows=96 width=10) (actual time=0.488..0.491 rows=192 loops=2) Buckets: 1024 Batches: 1 Memory Usage: 17kB -> Hash Join (cost=53.25..70.89 rows=96 width=10) (actual time=0.277..0.443 rows=192 loops=2) Hash Cond: (enabled_modules.project_id = projects.id) -> Bitmap Heap Scan on enabled_modules (cost=15.16..31.81 rows=372 width=4) (actual time=0.061..0.137 rows=382 loops=2) Recheck Cond: ((name)::text = 'work_package_tracking'::text) Heap Blocks: exact=12 -> Bitmap Index Scan on index_enabled_modules_on_name (cost=0.00..15.07 rows=372 width=0) (actual time=0.052..0.052 rows=383 loops=2) Index Cond: ((name)::text = 'work_package_tracking'::text) -> Hash (cost=36.85..36.85 rows=99 width=6) (actual time=0.200..0.201 rows=195 loops=2) Buckets: 1024 Batches: 1 Memory Usage: 16kB -> Seq Scan on projects (cost=0.00..36.85 rows=99 width=6) (actual time=0.009..0.155 rows=195 loops=2) Filter: (active AND active) Rows Removed by Filter: 190 -> Index Only Scan using roles_pkey on roles permission_roles (cost=0.14..9.84 rows=113 width=4) (actual time=0.023..0.030 rows=33 loops=2) Heap Fetches: 6 Planning Time: 2.247 ms Execution Time: 61.963 ms ``` The key difference is in the number of loops in the first statement.	3 years ago
Frank Bergmann	197f91738f	I18n: Added translation for attribute name = 'value' ... Amended to only set the translation for English because of potential Crowdin merge conflicts.	3 years ago
Christophe Bliard	8231f3fabd	make storages filters unavailable if storages module is unavailable	3 years ago
Christophe Bliard	84ee06e80d	make spec of Queries::Filters::AvailableFilters more readable and descriptive	3 years ago
Christophe Bliard	67247086f0	remove useless before block	3 years ago
Christophe Bliard	fbea927c96	make eager loading in test easier with EAGER_LOAD=1	3 years ago
Oliver Günther	d594a5ceb9	Use correct translation key for view_calendar	3 years ago
Eric Schubert	5f3da0896a	[chore] amended readme for docker dev env	3 years ago
Frank Bergmann	483fee76d5	[#38057] Missing translation in custom fields administration ... https://community.openproject.org/work_packages/38057	3 years ago
Christophe Bliard	4ace588f3a	improve error message for non-existing filter	3 years ago
Eric Schubert	979129f52c	[chore] fix two issues with docker dev ... - set default for OPENPROJECT_EDITION - fix default path for ckeditor volume - remove worker service from dependency	3 years ago
Christophe Bliard	8c3d077fcf	hide disabled modules in roles report page ... and sort modules in roles report page in the same order as in new role and update role pages wp 41690	3 years ago
Christophe Bliard	e761136efb	remove dead code ... introduced in a06120db10, and was already dead code at that time	3 years ago
Oliver Günther	02a80edccd	Allow setting the status on User create/update contracts	3 years ago
Oliver Günther	c7e6ff8cb2	Fix error message in query saving not found	3 years ago
OpenProject Actions CI	dd8f9edc57	update locales from crowdin [ci skip]	3 years ago
Niels Lindenthal	d8853b0ed5	Correct capitalization of User guid in docs	3 years ago
Niels Lindenthal	c1d1bea5a6	Merge pull request #10425 from opf/Harmonize-capitalization-in-docs ... Harmonize capitalization in docs	3 years ago
Niels Lindenthal	cf2bee32bc	Merge pull request #10429 from opf/design-system-links ... Adding links to to OpenProject application that show implementation examples of components	3 years ago
Christophe Bliard	05c804801b	hide storages from web pages if module is not active	3 years ago
Christophe Bliard	be2691e00e	fix test	3 years ago
Parimal Satyal	bf1a5155e6	Added some examples, but they're mostly Include projects	3 years ago
Niels Lindenthal	ee053ecc11	Adding link to Calendar module as example for an implemented component	3 years ago
Christophe Bliard	48f3c23bbd	make admin settings storage routes consistent with existing admin settings routes ... existing url/path helpers are all prefixed with admin_settings_, so move storages admin settings route under the same namespace.	3 years ago
Christophe Bliard	94e68bc951	Merge branch 'dev' into feature/feature-flag-module-storages-active	3 years ago
ulferts	28eea384ce	Merge pull request #10421 from opf/dependabot/bundler/dev/html-pipeline-2.14.1 ... Bump html-pipeline from 2.14.0 to 2.14.1	3 years ago
Parimal Satyal	98a0eb5331	Fixed markdown table, added implementation examples	3 years ago
Niels Lindenthal	371c89d9be	Example for implementation of Action bar	3 years ago
Christophe Bliard	416205f08e	return 404 for storages api routes if storages module is disabled	3 years ago
ulferts	f818d16ce1	adapt overwritten method name	3 years ago
Niels Lindenthal	cc169a82ce	Merge pull request #10427 from opf/psatyal-patch-1 ... Added missing elements, udpated status for each	3 years ago
Oliver Günther	4785387bf6	[41119] Correctly block parents in team planner ... https://community.openproject.org/wp/41119	3 years ago
Parimal Satyal	17d26022ff	Added missing elements, udpated status for each ... Added links to some components and patterns that were missing and updated the status to accurately reflect the documentation status for each. No doc status for foundation library yet (some elements like Illustrations and Spacing don't need documentation, the rest is in progress)	3 years ago
Niels Lindenthal	f02f475aa2	Make the capitalization consistent for API documentation	3 years ago
Niels Lindenthal	ca4217a3cc	Make capitalization consistent for System admin guide	3 years ago
Niels Lindenthal	94f17d0e06	Make the capitalization consistent for Enterprise guide	3 years ago
Niels Lindenthal	a7874846a3	Make the menu entry for installation & operations guide consistent with heading	3 years ago
Niels Lindenthal	a206cb1ab1	Make the capitalization consistent for Release notes	3 years ago
Oliver Günther	241a7ea981	Merge pull request #10368 from opf/feature/include-subprojects-attribute ... [41135] Add new query attribute include_subprojects	3 years ago
ulferts	e6157a766e	Merge pull request #10418 from opf/fix/bump_gems ... Fix/bump gems	3 years ago
Niels Lindenthal	fe3dde7a75	Merge pull request #10424 from opf/Design-System-Docs-Page ... Add information about the design system to our docs	3 years ago
Niels Lindenthal	edb76be7ec	Initial draft	3 years ago
Oliver Günther	58b64686d8	Add create contract spec for queries	3 years ago