201 Commits (df51b6ed99a46f34052321ab10b6234146ceefee)

Author	SHA1	Message	Date
Alex Coles	57618b25ec	Replace dynamic finder usages with #find_by, etc. ... This patch replaces all dynamic finders, for the sake of consistency, although only some methods are deprecated. See: https://github.com/rails/activerecord-deprecated_finders#active-record-deprecated-finders * Revert some `User#find_by_login` usages in cuke steps accidentally removed in 74228b59. User Story # 20325 Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Jens Ulferts	9b93316283	explicitly expecting a setting	9 years ago
Alexander Bach	9d641a30f6	Address styling issues	10 years ago
Alexander Bach	a670032b83	Covered #includes_for_columns in tests	10 years ago
Alex Coles	ebbc9e3d7d	Prefer #not_to over #to_not in specs ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	fed972eefa	Mark broken QueriesController policy spec pending ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	3785fdc9ed	Use #describe, #context with String arg not symbol ... The semantics of `describe` have changed in RSpec 3: passing a symbol rather than a string will change the value of the described object. See discussion here: https://github.com/rspec/rspec-core/issues/1114 Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	944b89d83e	Convert specs to RSpec 3.2.0 syntax with Transpec ... This conversion is done by Transpec 3.0.7 with the following command: transpec -f * 34 conversions from: it { should ... } to: it { is_expected.to ... } * 14 conversions from: obj.stub_chain(:message1, :message2) to: allow(obj).to receive_message_chain(:message1, :message2) * 7 conversions from: obj.stub(:message) to: allow(obj).to receive(:message) * 4 conversions from: be_true to: be_truthy * 3 conversions from: obj.should_receive(:message) to: expect(obj).to receive(:message) * 2 conversions from: failure_message_for_should { } to: failure_message { } * 2 conversions from: failure_message_for_should_not { } to: failure_message_when_negated { } * 1 conversion from: Klass.any_instance.stub(:message => value) to: allow_any_instance_of(Klass).to receive_messages(:message => value) * 1 conversion from: be_false to: be_falsey * 1 conversion from: obj.should_not_receive(:message) to: expect(obj).not_to receive(:message) * 1 conversion from: stub('something') to: double('something') * 1 addition of: RSpec.configure { |c| c.infer_spec_type_from_file_location! } For more details: https://github.com/yujinakayama/transpec#supported-conversions	10 years ago
Alex Coles	e0191e759c	Update year in copyright header to 2015 ... [ci skip]	10 years ago
Jens Ulferts	fa1d595d96	links user and version cf on wp table	10 years ago
Jens Ulferts	482c47f69b	improve handling of desired columns	10 years ago
Jens Ulferts	96ec53907c	only load required columns	10 years ago
Alex Coles	40001c90f3	Fix hash keys in WorkPackagesController spec ... Now uses a standard Hash rather than HashWithIndifferentAccess. Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	100955756a	Fix hash keys in QueriesController spec ... Now uses a standard Hash rather than HashWithIndifferentAccess. Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	1bb21b23c7	Remove option passed to render_template matcher ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	f95c9d15f3	Prefer #map over #collect in specs ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	25ede2df34	Re-run Rubocup auto-correct on pagination_spec_helper.rb ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	86f319a927	Fix bad rubocop auto-correct in pagination_spec_helper.rb ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	5afc11f19e	Fix syntax (w/Rubocop) in specs ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	03978767be	Use 1.9+ Hash syntax in specs ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Jens Ulferts	2a6f756570	read column_sums ... In 1513a19 I removed column_sums expecting it to be unnecessary. Turns out it is not.	10 years ago
Philipp Tessenow	8e3c56aef5	fix query_loading spec	10 years ago
Philipp Tessenow	4d6d4f4df6	add experimental-api query permission specs	10 years ago
Hagen Schink	a1cdb076e0	Improve spec readability	10 years ago
Hagen Schink	36a6230726	Improve context description	10 years ago
Hagen Schink	d514c66327	Ensure each action is called once	10 years ago
Hagen Schink	dc5cff4cbc	Recognize filter changes correctly	10 years ago
Hagen Schink	8225f0a25b	Test that 'update' policy is ignored	10 years ago
Hagen Schink	fe67f4ab56	Test that many policies are followed	10 years ago
Jens Ulferts	d7486ab811	allows api v2 types controller accessible for :view_work_packages permission	10 years ago
Hagen Schink	2165059b62	Test user with sufficient rights can depublicize query	10 years ago
Hagen Schink	2430995610	Test that user with sufficient rights can publicize query	10 years ago
Jens Ulferts	cd65f449dd	removes classes that should have been deleted in #4817547	10 years ago
Jens Ulferts	34712ffd8f	expect policy to be called in controller	10 years ago
Jens Ulferts	4817547d4a	introduces policies ... The pattern used here is taken from pundit although this here does by far not have the functionality pundit offers.	10 years ago
Jens Ulferts	61c05affd4	checks for permission before api/v2/types#index	10 years ago
Jens Ulferts	01d2569225	allows version selection for global filtering	10 years ago
Mihail Maxacov	a0631745de	fix saved queries don't update wp lists correctly when removing filters	10 years ago
Jens Ulferts	5c06dda316	users allowed new statuses no longer receive an edit menu entry ... They are not allowed to call the work_package#edit action anyway	10 years ago
Jens Ulferts	1513a19b84	readd experimental controllers and add authorization to them	10 years ago
Alex Coles	0b941955ce	Fully qualify ::Type class constant ... This fixes a naming collision with AR internals: undefined method `find' for ActiveRecord::AttributeMethods::Serialization::Type:Class Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Jens Ulferts	da721fd6d0	specs for json instead xml	10 years ago
Jens Ulferts	3c730ef131	enforces authorization for experimental api	10 years ago
Michael Frister	8d08e71ed5	API v2: Change boolean value to use true/false ... While this is not the OpenProject API, we use true/false for other APIs and for other parameters in the application, like `layout=false`. true/false also seems more intuitive.	10 years ago
Jens Ulferts	f91256fef9	remove no longer required experimental controller	10 years ago
Jens Ulferts	befb9f054e	removes unnecessary visibility filter on Version scope ... Authorization is handled an project level here and thus does not need to be done for the version itself. Authorising on the Version in addition has the drawback to only return versions in projects which the user can see work packages in. It does not take into account that the version can be shared.	10 years ago
Michael Frister	959c4ba405	API v2 PE index: Allow disabling parent rewiring ... Allow disabling rewiring - this exposes parent IDs of work packages invisible to the user. When requesting single work packages via IDs, the rewiring fails as it assumes that all visible work packages are loaded, which they might not be. For a work package with a parent visible to the user, but not included in the requested IDs, the parent_id would thus be nil. Disabling rewiring allows fetching work packages with their parent_ids even when the parents are not included in the list of requested work packages. There's also a case when rewiring is not used at all: When not providing a project id and requesting via /api/v2/planning_elements.json?ids=[...]. In this case parent_ids were and are always shown. This is pretty inconsistent, but that's the way API v2 is. Btw, planning_elements.json returns 404 when not giving an ids parameter. Apparently, the way custom fields are returned is also different between the general planning elements endpoint and the project-specific one. I didn't look into this, though.	10 years ago
Hagen Schink	32f0c4851e	Remove superfluous let statement	10 years ago
Hagen Schink	a4e07cfbce	Test version ids filter	10 years ago
Hagen Schink	eec14f6113	Remove show endpoint	10 years ago