openproject

Commit Graph

Author	SHA1	Message	Date
ulferts	1bdd2ab9ae	safe automatic fixes by rubocop (#8994 )	4 years ago
luz paz	3683042c9b	Fix typos in user facing and non-user facing code Found via `codespell v2.1.dev0`	4 years ago
ulferts	6140f4c7e9	update copyright to 2021 (#8925 ) Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded. Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013	4 years ago
ulferts	5968c0b18a	Fix/replace custom i18n function (#8681 ) * replace custom i18n function calls * remove custom i18n method	4 years ago
ulferts	9e2287bfcc	rename and inflect according to zeitwerk	5 years ago
Henriette Dinger	bd7f4e4814	Update copyright notice	5 years ago
Oliver Günther	d32e9f6788	Use page_param, not params[:page] [ci skip]	6 years ago
Markus Kahl	9db7749b4b	fixed CSP for dynamic graphs in repo stats page	6 years ago
Oliver Günther	8c477e5860	Fix more project settings related specs	7 years ago
Oliver Günther	ab4f9b7ed5	Replace settings and boards remotes with actual responses	7 years ago
Oliver Günther	8fb1c1573d	Fix repo tests due to changes repo_path	7 years ago
Oliver Günther	85a1079e25	Fix route generation for source urls and general escaping of quotes	7 years ago
Oliver Günther	6ef4211e77	Bump copyright to 2018 (#6171 ) [ci skip]	7 years ago
ulferts	5471c7686e	force html format for viewable repo entries (#5793 ) [ci skip]	7 years ago
ulferts	520815956d	preserve params when redirecting for login on repository (#5671 ) [ci skip]	7 years ago
Markus Kahl	470bf12826	show warning in subfolders too; fixed specs	8 years ago
Markus Kahl	c7cec30020	allow truncating repo browser list - Setting.repository_truncate_at	8 years ago
Oliver Günther	7cf11bb689	Update copyright notice	8 years ago
Oliver Günther	279ea14775	[24360] Force format when rendering html diff template	8 years ago
Oliver Günther	9c1508bad0	Fix legacy repository specs	8 years ago
Jens Ulferts	cf8b2c568e	ActionController::Parameter no longer is a hash	8 years ago
Oliver Günther	fe0e8dd919	Rename before_filter to before_action	8 years ago
Oliver Günther	1f66b19112	Fix double escaping of repository path params	9 years ago
Oliver Günther	1360639341	Fix URI escaping of svn checkout paths The paths weren't properly escaped for URLs. This fix allows any subdirectory of arbitrary chars to be displayed as a checkout URL. This also fixes an escaping issue in the adapter that prohibits checking folder with special characters which SVN doesn't care about.	9 years ago
Oliver Günther	396dcdd859	Add path-based checkout for SVN	9 years ago
Oliver Günther	d36c7d6591	Fix committers array access When adding a new committer to a repository, the user collection was `compact!`ed, which no longer exists on relations with Rails 4+. Thanks to @gehasia for spotting and proposing a fix for the bug.	9 years ago
Stefan Botzenhart	1f53f5472e	Code style enhancements to fight against bad scoring	9 years ago
Oliver Günther	dc90d71942	Replace severer warnings with danger zone This commit removes the `.-severe` warning notification type in favor of the danger zone.	9 years ago
Oliver Günther	bef80793a0	Small visual corrections for checkout This commit provides: * An integrated annotation warning display, when the entry could not be annotated (most often due to it being binary). * Hide current rev_id for subversion when no branch/revision is given.	9 years ago
Oliver Günther	1481afb666	Corrections from review	9 years ago
Oliver Günther	6661f2b6d5	Refuse to delete a repository in OpenProject on FS permission errors This commit changes the behavior of removing repositories. It is no longer possible to remove a managed repository (model) when the underlying repository directory could not be removed. This error originally occurred when Apache committed changes to the repository through mod_svn, which resulted in the OpenProject user being unable to delete a particular subdirectory.	9 years ago
Jan Sandbrink	f9cb083481	in production handle internal API errors gracefully - still allow for useful errors during development - let all own exceptions inherit from StandardError, the thing you should use for own errors...	9 years ago
Oliver Günther	dfb8ac4853	Add basic checkout instructions This commit adds very basic checkout instructions similar to `openproject-checkout` to repositories. Issues: * Uses table style for checkout component, as exact styling is unclear * Adds compressed table style with less padding * Checkout settings are best organized in a Hash with keys per SCM * vendor. Using default settings, a lot of new setting values would be introduced * Checks for Hash in SettingsController * Currently can't use SettingsHelper, as it requires single setting values	9 years ago
Oliver Günther	0b583c3ccf	Extend autofetching of commits into update repository information This commit extends the previous functionality of autofetch commits into internal updating of repository information, which encompasses: * Commit information (changesets) * Disk space information They are now both retrieved when browsing the repository and the latter is fetched asynchronously whenever the last update is older than the timeout setting. This timeout setting is now user-configurable.	9 years ago
Oliver Günther	3ccde73519	Allow automatic creation of manageable repositories through a setting This commit allows manageable repositories to be automatically created by default whenever a new project is created and the repository module is activated. Relevant work package: https://community.openproject.org/work_packages/21277	9 years ago
Oliver Günther	06d203141e	Remove outdated flash message Managed repositories are always deleted, even if the configuration states otherwise. The specific flash message concerning deletion of managed repositories is thus wrong and was removed.	9 years ago
Oliver Günther	c5b200d7a0	Review corrections - Remove repositories paths using project.id instead of `project_id` - Allow managed repositories to be unlinked in the instance (But doesn't remove repository directory). - Remove leftover settings partial	9 years ago
Oliver Günther	0284d11f21	Corrections from review - destroy_info: remove superfluous JS confirm dialog. - destroy_info: change notification type into severe warning - destroy_info: Remove delete button highlight and back button for consistency with styleguide. TODO: think of other ways to guide the user back (also applies to project destroy_info) - remove typo in 'repositories.errors.unauthorized' - empty repository: Render warning view (repositories/empty) instead of 500 exception notification. - revert reformat on code changed in rails4 branch. - create repository: Show managed flash part only when the repository is managed - delete repository: Show error when configuration no longer allows manageable (other ways tbd.) - repository controller: JS redirect wrapped inside format.js - repository settings: Select hidden when instance exists Specs: - Add routing spec for `get #destroy_info`	9 years ago
Oliver Günther	319bd21daf	Moved managed repository lifetime entirely to the model.	9 years ago
Oliver Günther	1e8c873544	Remove filesystem adapter This commit removes the entire FileSystem repository and adapter. It rids all specs (core and legacy) of remaining uses of this adpater and replaces it with a temporary subversion repository, where necessary. We also need to remove remaining filesystem instances from the database, otherwise users will receive errors when accessing said repositories on the Frontend. This does not destroy any data on filesystem, but database information on the repositories (remarks) are lost.	9 years ago
Oliver Günther	b0c0d0a53f	Avoid fishy factory delegation.	9 years ago
Oliver Günther	da27a552a1	Frontend extensions and build refactoring - switched to toggleable-attribute-groups to provide means for adding buttons in the attribute header (e.g., delete button). - added separate destroy_info page with different notifications for managed and linked repositories to ensure ramifications of removing physical repositories are communicated to the user. - Fixed several issues regarding scm_type selection and the building of repositories. Open questions still concern the question of acessing unsupported repositories (e.g., the soon-to-be-removed filesystem adapter). Acessing the class should will then throw an error, but we still have to allow users to remove the affected repository (somehow).	9 years ago
Oliver Günther	2b39d8fbdf	Cleaning up, Rubocop	9 years ago
Oliver Günther	abc597a6d2	First draft implementation of radio-based frontend.	9 years ago
Oliver Günther	05b27c1b98	Asynchronous creation, deletion of repositories from OP. This PR begins the push towards management of repository lifetime from within OpenProject. What this currently provides is the following: - A mixin `ManageableRepository`, included by `Repository::{Git, Subversion}` to provide an interface to repo management - Two services and delayed_job workers for creating (`CreateManagedRepositoryService`) and deleting (`DeleteRepositoryService`) - Customized rendering of subforms in the repository settings for arbitrary SCM vendors. TODOS: - [x] Provide sane ground to work on ( cf. PR #3149 ) - [x] Rework SCM settings form (`{scm}_tags` is currently HTML generated from within a Helper.) - [x] Ease integration of arbitrary SCM vendors - [x] Display meaningful error / warning when user looks at bare repository (currently outputs 500, as Git HEAD / svn revision is not available) - [x] I18n - [ ] Specs (in progress) - [x] Fix legacy specs - [ ] Decide what to do with `Filesystem` adapter. Open Questions: - Configuration: Currently replaces the existing options in `configuration.yml`. - Implementation specifics: - Sub-projects repositories reside in a hierarchy below their parents - How should the delayed_job react upon failure? (esp. creation of repositories) Relevant work package: https://community.openproject.org/work_packages/20416 Merge dependent on PR #3149	9 years ago
Oliver Günther	7ebac37c14	Repository Management - Refactoring and Preparation Related work package: [#20415](https://community.openproject.org/work_packages/20415). This is a combined refactoring and extraction effort of local SCM functionality for SVM, Git adapters in preparation for the explicit lifetime management of repositories in #20416 and implementation of (local) repository storage quota in #18393. This PR is still heavily WIP and for the time being, depends on the legacy specs for testing. To run the tests, execute the following steps: ~~~ rake test:scm:setup:all rake spec:legacy ~~~ I'm open for ideas on how we integrate scm adapters tests into current specs. --- - [x] Exchange `IO::Open` for `Open3` to avoid countless manual exitcode checks - [x] Extract local functionality in its own Module - [] Extend `LocalClient` module with links to create/delete services for #20415 - [x] Break down unbearable local parse routines (Hound will be over the place until fixed - but down from 260 to < 20) - [x] `entries` - [x] `revisions` - [] local repository factory - [] Specs - [] Fix / Modernize - [] More adapter-related specs	9 years ago
Alex Coles	8b4be7f749	Indent fix in RepositoriesController for Rubocop [ci skip] Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	0ad3cfb4b2	Prefer do…end for controller respond_to blocks `rubocop -a` does not currently normalise formatting consistently (see `ec1bb39f`). Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	0942d7335b	Add explicit join references in controllers Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	ec1bb39f9b	Fix syntax (w/Rubocop) in (Rails) controllers Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago

1 2 3 4

162 Commits (df5f899b2f712c4fbafd21f66e95f6b116eb25cd)