openproject

Commit Graph

Author	SHA1	Message	Date
Birthe	452df1fc8e	Updating texts for onboarding tour (#9393 ) * Updating texts for onboarding tour [#37656] Online Trial - Review onboarding guide -… …Demo project - English https://community.openproject.org/work_packages/37656 * Fix spec Co-authored-by: Oliver Günther <mail@oliverguenther.de>	3 years ago
Oliver Günther	c35c81d60b	[32867] Generalize me associated action for custom fields (#9443 ) https://community.openproject.org/work_packages/32867	3 years ago
Henriette Darge	daebe0e9e4	* Update modal class and remove old/obsolete styles (#9438 ) * Fix appearance of time entry configuration modal	3 years ago
Henriette Darge	d34b4517d9	[37939] Pagination style is lost (#9433 ) * Apply BEM styling rules for paginations && fix styling for ruby-created paginations * Add class for actual clickable element in the pagination * Introduce modifiers for positioning items at the start or end	3 years ago
ulferts	7779ac9e2b	correct expected links to docs	3 years ago
ulferts	f9b69abeeb	correct expected links to docs	3 years ago
Oliver Günther	15b0dc06a8	Fix read status and add spec (#9410 )	3 years ago
Oliver Günther	9636a08988	[26688] In-app notifications (#9399 ) * Add bell icon to icon font * Add in app notification in top menu * Add fullscreen modal * Add notification modal and items * Style items * Toggle details of item * Mark all read * Add no results box * wip specification for event api * Add events table, query and index * Send out events from WP notification mailer job There we have the recipients present * Add cleanup job for older events with a setting * Hide bell notification when not logged * Add specs for events API index/show * Fix setting yml key * remove pry in event creation * Fix before hook in events API to after_validation * Fix polymorphic association raising exception for aggregated journals * Fix typo in read_ian * Fix yml entry for mentioned * Add read/unread post actions to event API and add specs * Wire up API to frontend * Fix order on events * Switch to unread in notification * Add event query * rename WPEventService * route wp mail sending over events * rename spec methods * author becomes watcher * correct message call signature * rename events to notifications * renname parameter to reflect notification nature * create author watcher for existing work packages * Merge unreadCount from store * Take a stab at polymorphic representers * Fix link generation in polymorphic resources For journals, no title is being generated however * Fix frontend model for context * Use timer for polling * add notification_setting data layer * Fix show resource spec * Fix duplicate class in notification bell item * Add minimal feature spec for notification * API for notification settings * Persist notifications * adapt work package notification creation to notification settings * extract notified_on_all * consolidate wp#recipients * concentrate wp notification in journal service * simplify methods * Remove unused patch endpoint * Add specs for rendering and parsing notification settings * Contract spec * Update service spec * adapt specs * Angular notifications frontend commit `e29dced646` Author: Wieland Lindenthal <w.lindenthal@forkmerge.com> Date: Mon Jun 21 17:34:50 2021 +0200 Create Akita store and query for notification settings commit `1a45c26c1a` Author: Wieland Lindenthal <w.lindenthal@forkmerge.com> Date: Mon Jun 21 11:09:25 2021 +0200 Remove tabs from notificaition settings page commit `0ea21e90c1` Author: Oliver Günther <mail@oliverguenther.de> Date: Sun Jun 20 21:55:48 2021 +0200 WIP in app settings * migrate notification data * add project visible filter to project query * Add inline-create and table display grouped by project * Add notifications under admin/users * Remove notifications partial * Rename notififcations store to user preferences store * Add setting for self_notified and hook that up to the backend * Add aria-label to table checkboxes * Restyle table and toolbar * replace remains of mail_notifications attribute * initialize notification settings for new user * adapt my_preferences references * reenable no self notified for documents * adapt specs * Avoid has_many :notifcation_settings Rails magically autosaves the user's preferences when the user gets saved, which somehow also tries to save the notfifications even when unchanged. This breaks some specs such as the avatar upload spec. As we can't update the assocation through rails anyway, just delegate to the user for reading instead. * Restore update method of notification settings * Restore update spec * fix spec syntax * lint scss * linting * Fix content_tag for bell icon * Add feature specs for notification settings * Disable ContentTag cop * use visible filter to get projects for notification The visible filter will reduce the project list down to the set of projects visible to the user provided as a parameter. This includes public projects. * test for actual mail sending * adapt me resource path this.apiV3Service.users.me changed its type in `0d6c0b6bc7` * Implement changed migration * Linting * Add actor to notification representer * Fix factory creating a duplicate WP journal * Add work packages loading and journal details to notification entry component * IAN basic facets, keep and expanded states. * Fix notification bell spec * Render body separately and add auto updating relative time * Add fixedTime title * Add actor to notification entry * Fix clicking links on work package and project * Tiny styling changes on entry row * Disable count in notification if larger than 99 (wont fit) * Introduce virtual scrolling to entry table * allow delaying & prevent mail sending if ain read Introduces a setting to delay mail sending after a journal aggregation time has expired. That way, users can confirm a notification in app. If they do before the delay expires, no mail is sent out additionally for that user. * consolidate notifications (in&out) into shared admin menu Co-authored-by: ulferts <jens.ulferts@googlemail.com> Co-authored-by: Wieland Lindenthal <w.lindenthal@forkmerge.com>	3 years ago
ulferts	2a015eeac3	Feature/journal aggregation on write (#9396 ) * aggregate journals on write - simple implementation * remove references to aggregated journals on read * rewrite existing journals to be aggregated * remove aggregated journal reference * only delete predecessor if it can be aggregated * fix aggregation condition * adapt specs * remove aggregated journal functionality from production code The code is still necessary in a migration for the time being * adapt specs * use polymorphic belongs_to for journal data The association can then be employed for eager loading * eager load for activity rendering	3 years ago
Oliver Günther	46599dd90e	[37274] Remove accessibleClick (#9355 ) * Remove accessibleClick from wp-single-card * Remove accessibleClick directive itself * Fix context menu with button * Add common mixin for unset-button-styles * relations button * Editable query and toolbar * Resizer button * Replace wp-create button * Replace relation description value * Replace type form * Replace pagination links * Replace button styles for attachment dropzone * Replace accessibleClick in tile-view * Replace inline create * Replace display container with button * Replace text in notification on boards error * Replace global search component * Fix pagination spec * Fix specs * Fix triggering display field on enter * Make search toggle a button * Review feedback	3 years ago
Aleix Suau	7e2e05c88f	Feature/36390 code structure (#9319 ) * core/shared/features in progress * shared/components in progress * Fix rebase errors * core: added admin + apiv3 * shared: attachments + attirbute-help-text * core: OpenprojectAugmentingModule * shared: OpenprojectAutocompleterModule * shared: Autocompleter * feature: backlog * feature: bim * feature: boards * shared: calendar * core: userModule * feature: dashboards * shared: editor * shared: fields * shared: focus * core: globalsearch * shared: grid * shared: grid fix * core: hal * shared: icon * feature: invite user modal * feature: job status * shared: members autocomplete * shared: modal * feature: my page * feature: overview * shared: principal * feature: projects * feature: repoting * core: routing * shared: time entries * shared: OpenprojectWorkPackageGraphsModule * feature: workpackages * core: active window * shared: autofocus * features: wp: back-button * core: browser * shared: collapseible section * core: config * shared: copy-to-clipboard * shared: date-time * shared: helpers: drag-and-drop * shared: draggable autocompleter * shared: dynamic bootstrapper * shared: dynamic forms * features: wp: edit actions bar * shared: EditableToolbarTitleComponent * core: BannersService * shared: OpFormFieldComponent * shared: hide section * shared: highlight col * core: I18 + Sanitizer * shared: isClickedWithModifier * core: LoadingIndicator * core: Modal Heading * core: Model auth * shared: no results * shared: notifications * shared: datepicker * shared: option-list * core: path helper * shared: persistent toggle * shared: remote field * shared: set click position * shared: slide toggle * shared: tabs * shared: drag-scroll * shared: keyCodes * shared: OPSharedModule * global styles: common * core: * import fixes * shared: Enterprise banner * features: wps: filters * features: home screen * import fixes * core: html * import fixes * core: main-menu * features: home screen * shared: modals * shared: op-context-menu * core + shared: current project * core: schema-cache * shared: table-pagination * features: wps: time-entries * shared: user-link * features: wps * features: wps * features: wps: all wp-* components * core: states * Rename: angular4-modules to app.module * core: expression service * Modules just with plugins * Test fixes * added missing content-tabs.component.sass * Replaced with .op-ckeditor--wrapper * Replaced by .op-ckeditor-source-element * Replaced by the entire wysiwyg_editor.rb with dev version * Replacements by ckeditor-augmented-textarea * Fixes ./spec/support/components/work_packages/table_configuration_modal.rb:106 * Fixes ./modules/reporting/spec/features/update_entries_spec.rb:69 * work_packages renamed to work-packages * TimeEntryChangeset moved to helpers * 'filters' moved to wps/components * 'admin' moved to features * HAL moved to shared * plugins moved to features * plugins moved to features * Test fixes * Unit test fixes * plugin generator into /features/plugins * fix sass rule indentation * Revert "plugins moved to features" This reverts commit `f65ccbfd4b`. * Import fixes * Avoid commiting in linked plugins Co-authored-by: ulferts <jens.ulferts@googlemail.com> Co-authored-by: Oliver Günther <mail@oliverguenther.de>	3 years ago
Oliver Günther	e40b8367a5	[37555] Fix fullscreen link in notification https://community.openproject.org/wp/37555	4 years ago
ulferts	4cd75489ff	Fix/nil parent rendering (#9339 ) * next apiv_3 undisclosed i18n key * fix parent rendering condition Not having a parent should be visible	4 years ago
ulferts	2f00810e92	Bug/35510 editing project settings removes link to parent project for certain permission constellations (#9336 ) * breakup spec file into individual files * spec changing project without changing parent * have spec specific to project representer rendering * prevent parent from being embedded if user is not allowed to see it * extract urn into constant * handle parsing of a hidden uri * commit hidden uri * extract methods * improve understandability of undisclosed parent property * extract method to increase understandability * centralize information on default/none option * Remove unnecessary cast and cleaner structure * adapt expected fieldset in spec Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
Oliver Günther	fc090ac024	[37136] Disable delete button and check for deletion (#9338 ) https://community.openproject.org/wp/37136	4 years ago
Oliver Günther	e363d2f2fd	Remove accessible-by-keyboard a11y component (#9331 ) * Replace accessible-by-keyboard * Replace messed up inplace styles with work-package-comment bem block The styles are not used anymore except for work package comments anyway * Replace split view icons with buttons * Make back-button its own bem block * Replace button in hide-section component * Replace activity buttons * Replace notification icon * Replace collapsible-section * Replace config-menu * Make attribute help text trigger a button * Ensure all buttons are role=button * Replace inplace save controls * Replace relations buttons * Replace relation toggle button * Replace relation row buttons * Replace breadcrumb parent * Replace activities toggler * Remove accessible-by-keyboard component * Fix button role to button type * Fix indent * Bemmify media query * Fix specs	4 years ago
Benjamin Bädorf	a4e136ac92	Fix/37468 dynamic form a11y (#9328 ) * Improve form a11y * Show invalid status only for screenreaders * Improve HTML of dynamic form fieldsets * Remove unused import * Fix specs * Remove merge conflict marker * Fix more specs * Fix project page specific attribute help text spec	4 years ago
Aleix Suau	f1a3124098	fix: deletes date properly (#9333 ) * fix: deletes date properly * Close datepicker on escape on input * Add regression spec to date input Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
Oliver Günther	195b93ad30	[37463] Pass in work package project to IUM (#9324 ) * [37463] Pass in work package project to IUM https://community.openproject.org/work_packages/37463 * Add projectId from select input formly field	4 years ago
Oliver Günther	0f040daf39	[37453] Fix user custom fields on new projects not being selectable (#9318 ) * Filter for any members when the project is not persisted * Fix trying to load invite user permission for empty projects * Add spec for setting a user cf for projects	4 years ago
Aleix Suau	af30a8fe39	fix: deletes date properly (#9323 ) * fix: deletes date properly * Close datepicker on escape on input * Add regression spec to date input Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
Wieland Lindenthal	44d57d36c6	Fix #37136 : Restrict deletion of placeholder users (#9294 )	4 years ago
Behrokh Satarnejad	bd6ce44eff	[35354]Harmonize work package autocompleters (replacement of wp relations autocompleter) (#9225 ) * replace the autocompleter in wp relations with the new op-autocompleter component * resolve the test errors * make the code simpler * fix the test error	4 years ago
Markus Kahl	2bf74725b2	fixed password confirmation during token reset (#9314 )	4 years ago
ulferts	6cda6ad4fd	enforces dependent project modules being active (#9311 ) Project modules, e.g. calendar can define dependencies, e.g. work packages. An error message is now displayed if a user enables a project module without the dependency being active in the project as well. Also fixes a serious bug in the Shared::ServiceContext module. Whenever a failing service result is returned, every change to the database is to be rolled back. This was not true when a model was provided since the changes where carried out within an inner transaction	4 years ago
ulferts	98b04a4d4f	show "new project" option on add_subprojects permission (#9298 ) The "new project" option will only be displayed when the user is in a context, a project, where the add_subprojects permission is granted	4 years ago
Behrokh Satarnejad	06cd178f3d	[35354] Harmonize work package autocompleters (replacing global search box) (#9289 ) * replacement of ng-select with op-autocompleter * removing label and selecting the option with the searched id * resolving the error of not remarking by id * Remove expectation that search input remains the same They are interconnected, so this doesn't matter * Remove setTimeout/outzine zone in favor of ngAfterViewInit * remove commited code and improve outFocus Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
Oliver Günther	2a40ec0203	[37184] Hide archived projects from project search (#9283 ) https://community.openproject.org/wp/37184	4 years ago
Oliver Günther	5956ede030	[37107] render tabs in component (#9236 ) * Render work package tabs in one component * Move standard tabs into tab service * Move tab-count styles mostly into its own component style * Fix frontend specs * Remove unused texts * Fix routing to split view from button * Fix context menu not opening the tabbed view * Fix watcher tab counter not receiving an rxjs subscription * Fix selector * Fix clicking on relation link to fullscreen * Make WP tabs an instance of scrollable-tabs * Convert the tabs from .tabrow to its own BEM block * Refactor other usages of tabrow into op-tab-row * Fix frontend specs * Make wp modal tabs use scrollable-tabs * Fix disabled tab selectors * Restore scrollability of tabs * Fix import and change detection of graph modal * Fix selector in wp relations spec * Rename tab-count to match component style * Remove narrow style * Fix bem modifier style * Fix styles of scrollable tabs * Fix tab for time entry autocompleter	4 years ago
Aleix Suau	4700b77033	Feature/36382 improvements (#9266 ) * Show backend validation errors in toast instead of a generic message * Include disabled field values on submit * Documentation improvements * Dumber OpFormFieldComponent: control, error and help settings as @Input * Create fieldGroups programmatical from @Input * fix: new project from themplate. Prioritize backend model * Show backend validation errors in toast instead of a generic message * Include disabled field values on submit * Documentation improvements * Dumber OpFormFieldComponent: control, error and help settings as @Input * Create fieldGroups programmatical from @Input * fix: new project from themplate. Prioritize backend model * Setting template payload through DynamicForm @Input model * Tests fixes * Seet public-read ACL on capybara screenshots * New Project: reset form when template changed + keep name * fix: avoid OpCkeditorComponent >>> FormattableEditFieldComponent >>> OpCkeditorComponent rawValue loop * PR Review changes * Unit tests fixes Co-authored-by: Cyril Rohr <cyril.rohr@gmail.com>	4 years ago
ulferts	fe1e742a64	Fix/project in user invite validation (#9272 ) * validate project in invite modal The user might have the manage_member permission in a project but not necessarily in the one the modal is opened in. * resurface invite_user_modal spec deleted in `b50298eb30` * allows users without manage_placeholder to add placeholder to project	4 years ago
ulferts	51bcf7f6d6	Fix/add subproject only flow (#9268 ) * allow users only having add_subproject to create subprojects * remove reference to no longer existing projects controller action	4 years ago
Oliver Günther	780fbf452e	[37158] Hide meta settings when selecting a template (#9257 ) https://community.openproject.org/wp/37158	4 years ago
Oliver Günther	ad07264c4f	[36937] Fix navigation to active wiki item and add spec for it (#9264 ) https://community.openproject.org/wp/36937	4 years ago
Oliver Günther	6c75e16dc4	[37140] Use acts_as_url to generate unique slug for identifier (#9250 ) * Use acts_as_url to generate unique slug for identifier * Re-enable project identifier spec now handled in backend * Add integration spec for set attribute service * Adapt spec for new empty identifier * Avoid double error messages for empty identifier acts_as_url may return an empty string depending on the name, but the empty presence validation will suffice in this case, we don't need the invalid validation * Fix stubbed errors object accessed by acts_as_url * Avoid trying to get the upstream unique attribute in case of errors * Remove sequential_project_identifiers setting * Adapt spec to review feedback	4 years ago
Oliver Günther	76c828d8d5	[37157] Fix float value rendering with zero value (#9255 ) https://community.openproject.org/work_packages/37157	4 years ago
ulferts	d90d47e6b6	Feature/user invite from members for non admins (#9244 ) * users having manage_user can add users from member administration * linting and typo correction	4 years ago
Oliver Günther	b4a89e2454	Use BEM-compliant styling for user-activity (#9235 )	4 years ago
Benjamin Bädorf	d4a0b55c9d	Feature/dynamic float input (#9237 ) * Added basic float input * Added float type dynamic CF * Remove unused input type * Add spec Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
ulferts	f19df4ee95	Feature/colorful project settings on project form (#9208 ) * register colorful select for project settings * show default `not set` value if no project status is selected * Fix selectors Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
Benjamin Bädorf	831921a79a	Add attribute help texts to dynamic forms (#9215 ) * Projects form working with formly 50% * Removed console.log * Working with formattable * Working with formattable * Input with id and label * Input with id and label * Useless dependencies removed * Saving forms + required labels with * * First backend validation approach * Removed reload on type change + keep model on route changes * Handlig backend validations with setError * Formatting the form model to submit * Make up refactor * working with op-form-field * Form creation moved to the service * Working with op-form-field wrapper * Working with validation and op-form-field * Working with []CustomFields * Clean up * Clean up * Clean up * Clean up * Form routing working * Notification on form error and success * Refactor + removed useless dynamic form observable * DynamicFieldsService with tests * Refactor: inputs catalog + catch form load error * Filter out non writable fields * Refactor: naming consistency * Cleaning comments * dynamic-fields-service tests + wrapper component * DynamicForm Tests * @ngx-formly/core dependency added * Cleaning up * Provide DynamicFieldsService in root so it can be used independently * DynamicForm working as a FormControl * Getting route params sync * Global FormsService: submit + formatting + error handling * Fix: @Optional() FormGroupDirective in OpFormFieldComponent * Code climate fix * Removed CdkTextareaAutosize because of CDK issue 22469 * DynamicFormComponent tests * Dynamic input test helpers + boolean and text tests * Refactor edit fields to avoid circular dependencies in the dynamic forms * Naming fix * IntegerInputComponent tests * SelectInputComponent tests * Fix: duplicated identifier on inputs * Extract toolbar to be reused for now Still TBD whether we want to move them right now to the frontend? * Create new project route and redirect to rails view after saving * fieldsSettingsPipe + hide 'identifier' on projects * Handling multi-values (also as links) and passwords * Some TODOs removed * FormattableTextareaInputComponent tests * Projects form working with formly 50% * Removed console.log * Working with formattable * Working with formattable * Input with id and label * Input with id and label * Useless dependencies removed * Saving forms + required labels with * * First backend validation approach * Removed reload on type change + keep model on route changes * Handlig backend validations with setError * Formatting the form model to submit * Make up refactor * working with op-form-field * Form creation moved to the service * Working with op-form-field wrapper * Working with validation and op-form-field * Working with []CustomFields * Clean up * Clean up * Clean up * Clean up * Form routing working * Notification on form error and success * Refactor + removed useless dynamic form observable * DynamicFieldsService with tests * Refactor: inputs catalog + catch form load error * Filter out non writable fields * Refactor: naming consistency * Cleaning comments * dynamic-fields-service tests + wrapper component * DynamicForm Tests * @ngx-formly/core dependency added * Cleaning up * DynamicForm working as a FormControl * Getting route params sync * Global FormsService: submit + formatting + error handling * Fix: @Optional() FormGroupDirective in OpFormFieldComponent * Code climate fix * Removed CdkTextareaAutosize because of CDK issue 22469 * DynamicFormComponent tests * Dynamic input test helpers + boolean and text tests * Refactor edit fields to avoid circular dependencies in the dynamic forms * Naming fix * IntegerInputComponent tests * SelectInputComponent tests * Fix: duplicated identifier on inputs * Extract toolbar to be reused for now Still TBD whether we want to move them right now to the frontend? * Create new project route and redirect to rails view after saving * fieldsSettingsPipe + hide 'identifier' on projects * Handling multi-values (also as links) and passwords * Some TODOs removed * FormattableTextareaInputComponent tests * _isResourceSchema based on parent?.location * Scope DynamicFieldsService to DynamicFormComponent * Added backend validation method to FormsService * Remove form from DynamicForm when not isStandaloneForm * Allow multiple form keys to validate * Remove form from non standalone forms * Remove duplicated button * Fix: dynamic form with ng-template not showing validations * DynamicForm programatic validation * Hide the submit button input * Unify ckeditor spacings with other dynamic-form elements * Basic fixes to invalid dynamic form fields * Fix invalid styles for dynamic inputs * Updates to form styles, add op-form and op-fieldset * Soften inputs to 2px * Update input styles globally * Add basic dynamic forms attribute help texts * Add attribute help texts to dynamic forms This reshuffles a ton of files and modules to fix circular dependency issues around the OP common module. Mainly the following circular dependencies where resolved: common -> help texts -> modal -> common attachments -> common a11y -> common modal, attachments and a11y now directly depend on the modules/components they were using form common common -> help texts -> modal -> focus attachments -> icon, a11y a11y -> none * Fix spec build * attribute-help-text workin in dynamic forms * Add attribute help texts for fieldsets * Fix groups * Fix dynamic form groups even better * Fix selector on attribute Co-authored-by: Aleix Suau <info@macrofonoestudio.es> Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
Benjamin Bädorf	44294ede04	User custom fields in the invite user modal (#9220 ) * Projects form working with formly 50% * Removed console.log * Working with formattable * Working with formattable * Input with id and label * Input with id and label * Useless dependencies removed * Saving forms + required labels with * * First backend validation approach * Removed reload on type change + keep model on route changes * Handlig backend validations with setError * Formatting the form model to submit * Make up refactor * working with op-form-field * Form creation moved to the service * Working with op-form-field wrapper * Working with validation and op-form-field * Working with []CustomFields * Clean up * Clean up * Clean up * Clean up * Form routing working * Notification on form error and success * Refactor + removed useless dynamic form observable * DynamicFieldsService with tests * Refactor: inputs catalog + catch form load error * Filter out non writable fields * Refactor: naming consistency * Cleaning comments * dynamic-fields-service tests + wrapper component * DynamicForm Tests * @ngx-formly/core dependency added * Cleaning up * Provide DynamicFieldsService in root so it can be used independently * DynamicForm working as a FormControl * Getting route params sync * Global FormsService: submit + formatting + error handling * Fix: @Optional() FormGroupDirective in OpFormFieldComponent * Code climate fix * Removed CdkTextareaAutosize because of CDK issue 22469 * DynamicFormComponent tests * Dynamic input test helpers + boolean and text tests * Refactor edit fields to avoid circular dependencies in the dynamic forms * Naming fix * IntegerInputComponent tests * SelectInputComponent tests * Fix: duplicated identifier on inputs * Extract toolbar to be reused for now Still TBD whether we want to move them right now to the frontend? * Create new project route and redirect to rails view after saving * fieldsSettingsPipe + hide 'identifier' on projects * Handling multi-values (also as links) and passwords * Some TODOs removed * FormattableTextareaInputComponent tests * Projects form working with formly 50% * Removed console.log * Working with formattable * Working with formattable * Input with id and label * Input with id and label * Useless dependencies removed * Saving forms + required labels with * * First backend validation approach * Removed reload on type change + keep model on route changes * Handlig backend validations with setError * Formatting the form model to submit * Make up refactor * working with op-form-field * Form creation moved to the service * Working with op-form-field wrapper * Working with validation and op-form-field * Working with []CustomFields * Clean up * Clean up * Clean up * Clean up * Form routing working * Notification on form error and success * Refactor + removed useless dynamic form observable * DynamicFieldsService with tests * Refactor: inputs catalog + catch form load error * Filter out non writable fields * Refactor: naming consistency * Cleaning comments * dynamic-fields-service tests + wrapper component * DynamicForm Tests * @ngx-formly/core dependency added * Cleaning up * DynamicForm working as a FormControl * Getting route params sync * Global FormsService: submit + formatting + error handling * Fix: @Optional() FormGroupDirective in OpFormFieldComponent * Code climate fix * Removed CdkTextareaAutosize because of CDK issue 22469 * DynamicFormComponent tests * Dynamic input test helpers + boolean and text tests * Refactor edit fields to avoid circular dependencies in the dynamic forms * Naming fix * IntegerInputComponent tests * SelectInputComponent tests * Fix: duplicated identifier on inputs * Extract toolbar to be reused for now Still TBD whether we want to move them right now to the frontend? * Create new project route and redirect to rails view after saving * fieldsSettingsPipe + hide 'identifier' on projects * Handling multi-values (also as links) and passwords * Some TODOs removed * FormattableTextareaInputComponent tests * _isResourceSchema based on parent?.location * Scope DynamicFieldsService to DynamicFormComponent * Added backend validation method to FormsService * Removed projects routes and ruby template * Removed projects routes and dynamic forms from Projects * Revert "Provide DynamicFieldsService in root so it can be used independently" This reverts commit `ab56f3c56f`. * Provide DynamicFieldsService in root so it can be used independently * TODO: test ProjectsComponent * Code climate fixes (remove TODOs) * Default OpFormFieldComponent.inlineLabel to false * Dynamic components tests xkipped * Typing improvements * DynamicFormComponent working as a FormControl * Global FormsService: submit + formatting + error handling * Fix: @Optional() FormGroupDirective in OpFormFieldComponent * Code climate fixes * noWrapLabel default to false * Started adding user custom fields to the ium * Import the dynamic-forms module into the common module * Refactor edit fields to avoid circular dependencies in the dynamic forms * Using DynamicFormsModule in OpenprojectInviteUserModalModule * Add formly form * Update principal name filter * Dynamic form field is rendering * Handling multi-values (also as links) and passwords * Added backend validation method to FormsService * Remove form from DynamicForm when not isStandaloneForm * Allow multiple form keys to validate * Remove form from non standalone forms * Remove duplicated button * Moved to FormGroup input for dynamic form * Custom field happy path is done * Add explanatory comment to payload structure transformation * add op-form class to ium steps * Add shrinkwrap back in * Fix test, fix dynamic form resource path * gimme a shirnkwrap * Remove failing tests * Remove another failing test * Remove more failing specs * Fix double loading of principals * Add custom field spec * Fix spec * Reset shrinkwrap * Forbid Factory.build(:user, member_in_project) If you use the trait member_in_project(s), the user is implicitly saved to create the member. This is very confusing if trying to use required custom fields, as this will fail with the Member#user_id foreign key being nil, as the user cannot be saved. Instead, raise an error when trying to use this factory trait * Change additional spec factory Co-authored-by: Aleix Suau <info@macrofonoestudio.es> Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
Oliver Günther	2adce94853	Implement copy form in formly (#9218 ) * Implement copy form in formly * Add meta property handling to dynamic form * Remove copy projects controller, merge into projects * Fix copying of container attachments * Fix project copy path * Fix remainder of copy spec	4 years ago
ulferts	b50298eb30	Feature/send custom message from invite modal (#9222 ) * fix malformed i18n key * sent custom message from invite modal * cleanup imports	4 years ago
Oliver Günther	71b330ea80	[37026] Add new project form with template selection (#9193 ) * Projects form working with formly 50% * Removed console.log * Working with formattable * Working with formattable * Input with id and label * Input with id and label * Useless dependencies removed * Saving forms + required labels with * * First backend validation approach * Removed reload on type change + keep model on route changes * Handlig backend validations with setError * Formatting the form model to submit * Make up refactor * working with op-form-field * Form creation moved to the service * Working with op-form-field wrapper * Working with validation and op-form-field * Working with []CustomFields * Clean up * Clean up * Clean up * Clean up * Form routing working * Notification on form error and success * Refactor + removed useless dynamic form observable * DynamicFieldsService with tests * Refactor: inputs catalog + catch form load error * Filter out non writable fields * Refactor: naming consistency * Cleaning comments * dynamic-fields-service tests + wrapper component * DynamicForm Tests * @ngx-formly/core dependency added * Cleaning up * Provide DynamicFieldsService in root so it can be used independently * DynamicForm working as a FormControl * Getting route params sync * Global FormsService: submit + formatting + error handling * Fix: @Optional() FormGroupDirective in OpFormFieldComponent * Code climate fix * Removed CdkTextareaAutosize because of CDK issue 22469 * DynamicFormComponent tests * Dynamic input test helpers + boolean and text tests * Refactor edit fields to avoid circular dependencies in the dynamic forms * Naming fix * IntegerInputComponent tests * SelectInputComponent tests * Fix: duplicated identifier on inputs * Extract toolbar to be reused for now Still TBD whether we want to move them right now to the frontend? * Create new project route and redirect to rails view after saving * fieldsSettingsPipe + hide 'identifier' on projects * Handling multi-values (also as links) and passwords * Some TODOs removed * FormattableTextareaInputComponent tests * Projects form working with formly 50% * Removed console.log * Working with formattable * Working with formattable * Input with id and label * Input with id and label * Useless dependencies removed * Saving forms + required labels with * * First backend validation approach * Removed reload on type change + keep model on route changes * Handlig backend validations with setError * Formatting the form model to submit * Make up refactor * working with op-form-field * Form creation moved to the service * Working with op-form-field wrapper * Working with validation and op-form-field * Working with []CustomFields * Clean up * Clean up * Clean up * Clean up * Form routing working * Notification on form error and success * Refactor + removed useless dynamic form observable * DynamicFieldsService with tests * Refactor: inputs catalog + catch form load error * Filter out non writable fields * Refactor: naming consistency * Cleaning comments * dynamic-fields-service tests + wrapper component * DynamicForm Tests * @ngx-formly/core dependency added * Cleaning up * DynamicForm working as a FormControl * Getting route params sync * Global FormsService: submit + formatting + error handling * Fix: @Optional() FormGroupDirective in OpFormFieldComponent * Code climate fix * Removed CdkTextareaAutosize because of CDK issue 22469 * DynamicFormComponent tests * Dynamic input test helpers + boolean and text tests * Refactor edit fields to avoid circular dependencies in the dynamic forms * Naming fix * IntegerInputComponent tests * SelectInputComponent tests * Fix: duplicated identifier on inputs * Extract toolbar to be reused for now Still TBD whether we want to move them right now to the frontend? * Create new project route and redirect to rails view after saving * fieldsSettingsPipe + hide 'identifier' on projects * Handling multi-values (also as links) and passwords * Some TODOs removed * FormattableTextareaInputComponent tests * _isResourceSchema based on parent?.location * Scope DynamicFieldsService to DynamicFormComponent * Added backend validation method to FormsService * Remove form from DynamicForm when not isStandaloneForm * Allow multiple form keys to validate * Remove form from non standalone forms * Remove duplicated button * Fix: dynamic form with ng-template not showing validations * DynamicForm programatic validation * Add new project component that posts to the copy form * Hide the submit button input * Unify ckeditor spacings with other dynamic-form elements * Basic fixes to invalid dynamic form fields * Load the templated projects with newly added action * Fix invalid styles for dynamic inputs * Updates to form styles, add op-form and op-fieldset * Soften inputs to 2px * Update input styles globally * Redirect to job status modal when response is job status * fix: load projects routes * Collapsible groups working * Fix: setTimeout datepicker to wait DOM ready * resourceId added to project settings form * fieldsLayoutConfig * formUrl & formHttpMethod @Inputs * Avoid replacing non ending '/form' strings * formUrl @Input * @Input model * identifier hidden * Populate the model * Add new project component * Tests removed * Show create message when creating new resource * Change location to rails * Add field_name helper for testing * Add form field helper classes and fix tests * Remove templated from copy for now * Fix more tests * Reset toolbar from dev * Skip identifier test * Set overflow to visible when expanded * Fix more tests * Rename data-field-name to data-qa-field-name * Review feedback * Uncollapse group fields when they contains errors * Fix text spec * Remove instantiate template service * Remove unnecessary ProjectController#create Co-authored-by: Aleix Suau <info@macrofonoestudio.es> Co-authored-by: Benjamin Bädorf <b.baedorf@openproject.com>	4 years ago
ulferts	88799dbeb5	attempt to stabilize spec	4 years ago
ulferts	ce5e06dde2	Fix/non matching pagination (#9202 ) * fix duplicates returned for wp list on multiple matching attachments/comments LEFT JOIN leads to potentially having multiple records returned if a search string is present in more than one attachment/comment. This is not a problem if we fetch work packages directly out of the query results but becomes problematic if only the id is fetched and then used to get the work packages by a subquery. * attachment filters no longer differentiate on tsv_where concatenation As EXISTS and NOT EXISTS is now used, the full string is always to be searched for so `and` concatenation is now always employed. * adapt spec Work packages that have no attachment at all are now also considered to match the filter if a "doesn`t contain" operator is used * less strict rspec rubocops for feature specs * cleanup code	4 years ago
ulferts	2b7f71958c	hide active field in project form (#9204 ) The behaviour is available via the Archive/Unarchive button	4 years ago
ulferts	071180737b	hide quick add menu when login is required and user is anonymous (#9203 ) * hide quick add menu when login is required and user is anonymous The quick add menu ("+" icon in top bar) should not be displayed if login is required and the current user is anonymous if though anonymous might be allowed to create work packages * spec anonymous role with add_work_package permission	4 years ago
Aleix Suau	f5d2a7467b	Feature/36382 multi selection for project custom fields base (#9164 ) * Projects form working with formly 50% * Removed console.log * Working with formattable * Working with formattable * Input with id and label * Input with id and label * Useless dependencies removed * Saving forms + required labels with * * First backend validation approach * Removed reload on type change + keep model on route changes * Handlig backend validations with setError * Formatting the form model to submit * Make up refactor * working with op-form-field * Form creation moved to the service * Working with op-form-field wrapper * Working with validation and op-form-field * Working with []CustomFields * Clean up * Clean up * Clean up * Clean up * Form routing working * Notification on form error and success * Refactor + removed useless dynamic form observable * DynamicFieldsService with tests * Refactor: inputs catalog + catch form load error * Filter out non writable fields * Refactor: naming consistency * Cleaning comments * dynamic-fields-service tests + wrapper component * DynamicForm Tests * @ngx-formly/core dependency added * Cleaning up * Provide DynamicFieldsService in root so it can be used independently * DynamicForm working as a FormControl * Getting route params sync * Global FormsService: submit + formatting + error handling * Fix: @Optional() FormGroupDirective in OpFormFieldComponent * Code climate fix * Removed CdkTextareaAutosize because of CDK issue 22469 * DynamicFormComponent tests * Dynamic input test helpers + boolean and text tests * Refactor edit fields to avoid circular dependencies in the dynamic forms * Naming fix * IntegerInputComponent tests * SelectInputComponent tests * Fix: duplicated identifier on inputs * Extract toolbar to be reused for now Still TBD whether we want to move them right now to the frontend? * Create new project route and redirect to rails view after saving * fieldsSettingsPipe + hide 'identifier' on projects * Handling multi-values (also as links) and passwords * Some TODOs removed * FormattableTextareaInputComponent tests * Projects form working with formly 50% * Removed console.log * Working with formattable * Working with formattable * Input with id and label * Input with id and label * Useless dependencies removed * Saving forms + required labels with * * First backend validation approach * Removed reload on type change + keep model on route changes * Handlig backend validations with setError * Formatting the form model to submit * Make up refactor * working with op-form-field * Form creation moved to the service * Working with op-form-field wrapper * Working with validation and op-form-field * Working with []CustomFields * Clean up * Clean up * Clean up * Clean up * Form routing working * Notification on form error and success * Refactor + removed useless dynamic form observable * DynamicFieldsService with tests * Refactor: inputs catalog + catch form load error * Filter out non writable fields * Refactor: naming consistency * Cleaning comments * dynamic-fields-service tests + wrapper component * DynamicForm Tests * @ngx-formly/core dependency added * Cleaning up * DynamicForm working as a FormControl * Getting route params sync * Global FormsService: submit + formatting + error handling * Fix: @Optional() FormGroupDirective in OpFormFieldComponent * Code climate fix * Removed CdkTextareaAutosize because of CDK issue 22469 * DynamicFormComponent tests * Dynamic input test helpers + boolean and text tests * Refactor edit fields to avoid circular dependencies in the dynamic forms * Naming fix * IntegerInputComponent tests * SelectInputComponent tests * Fix: duplicated identifier on inputs * Extract toolbar to be reused for now Still TBD whether we want to move them right now to the frontend? * Create new project route and redirect to rails view after saving * fieldsSettingsPipe + hide 'identifier' on projects * Handling multi-values (also as links) and passwords * Some TODOs removed * FormattableTextareaInputComponent tests * _isResourceSchema based on parent?.location * Scope DynamicFieldsService to DynamicFormComponent * Added backend validation method to FormsService * Remove form from DynamicForm when not isStandaloneForm * Allow multiple form keys to validate * Remove form from non standalone forms * Remove duplicated button * Fix: dynamic form with ng-template not showing validations * DynamicForm programatic validation * Hide the submit button input * Unify ckeditor spacings with other dynamic-form elements * Basic fixes to invalid dynamic form fields * Fix invalid styles for dynamic inputs * Updates to form styles, add op-form and op-fieldset * Soften inputs to 2px * Update input styles globally * Fix selectors in copy spec * Undo new project route Will be handled in separate PR * Add separate module for field controls Otherwise it will not be found in the FormattableEditField component * Fix paths now having a trailing slash due to ui-router * Remove new project lazy route * Add data attribute to locate fields * Fix spec by locating field with data * Accept that ng-select can be cut off No idea why that changed in this PR though? * Fix success message to match tests * Redirect settings to generic to match angular path * Fix other project spec * Remove fdescribe * Fix missing cv with magic wait time for now * Remove broken angular tests * Fix routing spec * Import field controls module in wp module * Wait after inserting link into ckeditor It looks like the formly field doesn't get the current ckeditor value before saving * Decouple settings fetching from dynamicform mode (Standalone/FormControl) Co-authored-by: Oliver Günther <mail@oliverguenther.de> Co-authored-by: Benjamin Bädorf <b.baedorf@openproject.com>	4 years ago

1 2 3 4 5 ...

2066 Commits (df5f899b2f712c4fbafd21f66e95f6b116eb25cd)