12 Commits (e3f12bcd074a3ca25bf74d305f4fe53ff50cffa8)

Author	SHA1	Message	Date
ulferts	19d1175d03	include member mails when disabling notifications on project copy	3 years ago
Oliver Günther	ccfa29c728	Move license and copyright docs to root, fix names and references	3 years ago
ulferts	d1f419385f	Feature/member custom notifications (#9173) ... * include custom message in membership forms * keep pristine params to be able to pass it to the state * fix indentation on projects api docs * pass grape instance around in default endpoints The grape instance has readily available access to all the objects (params, current_user) so less individual parameters need to be passed. This also avoids having to store the grape endpoint in a potentials not thread safe variable * send custom message out on membership creation * send custom message on membership update * send custom message even if setting disabled * restore params interface * add custom message description to schema * describe notificationMessage in the api documentation * extract meta payload functionality into mixin * ensure password in spec meets requirements * Update docs/api/apiv3/endpoints/members.apib Co-authored-by: Oliver Günther <mail@oliverguenther.de> * Update docs/api/apiv3/endpoints/members.apib Co-authored-by: Oliver Günther <mail@oliverguenther.de> * Update docs/api/apiv3/endpoints/members.apib Co-authored-by: Oliver Günther <mail@oliverguenther.de> * Update docs/api/apiv3/endpoints/members.apib Co-authored-by: Oliver Günther <mail@oliverguenther.de> * Update docs/api/apiv3/endpoints/members.apib Co-authored-by: Oliver Günther <mail@oliverguenther.de> Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
ulferts	9fa5599392	Feature/member notifications (#8958) ... * spec with correctly scoped links * move db check into own file - fix deprecation * basic spec for member creation service * use constants for all notifications * send an OP notification after member has been created * send an OP notification after member has been updated * mails on group member added Depending on whether the membership existed before or not, an updated or a created notification is send. This is done asynchronously. * move all mail sender background jobs into namespace * wip * wip * correct handling group member notifications * add setting enable/disable mail sending on member alterations * use services in members controller * move Notifiable to OpenProject * remove member after save hooks * cleanup/testing/linting * render member mails in receiver locale * remove add_member! method * use mailer layout for all mailers * Update app/services/groups/cleanup_inherited_roles_service.rb Co-authored-by: Oliver Günther <mail@oliverguenther.de> * use around callback to avoid prepending * handle nil params Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
Oliver Günther	e9f1781d2b	Use contracted member services and show only manageable projects in user administration (#9076) ... * Reuse contracted services in memberships controller * Show only manageable projects * Show only manageable projects in select box * Reject empty values in role_ids * Add spec for when user has no manage_members permission * Also handle delete through service * Extend spec for when user has no manage_members permission * Extend Members SetAttributesSpec * Make manageable_Members an instance method and add spec * hide buttons if user is not allowed to use them * Rename manageable_projects to assignable_projects * Build a membership for the contract * Fix url for global_roles to work with update and create methods Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
ulferts	7ecf08e005	rework changed_by_system (#9043) ... Before, it was implemented by passing the changed attribut keys over to the contract to whitelist them. This lead to: * The contract interface becoming bloated * Having to rely on the knowledge of the developer not to falsely whitelist an attribute. The developer would also have to make sure to not perform a mass assignment after the attribute has been whitelisted The new approach it to integrate the behaviour into the model which is first altered in the service before it is scrutinized in the contract. The information about the changed attributes is now stored inside the model which removes the necessity to flag the whitelisted attribute separately. Additionally, the exact change is tracked. So if an attribute is set to one value inside a whitelisted block there is no risk in later on performing a mass assignment. This comes at the cost of extending the models which is weird also it is build into the default SetAttributesService so child classes do not have to worry. One might include the module into every AR model but currently we only need it for a very specific use case.	4 years ago
ulferts	6140f4c7e9	update copyright to 2021 (#8925) ... Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded. Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013	4 years ago
ulferts	7f34799a33	Chore/reimplement global roles (#8730) ... * remove outdated docs/code * global memberships are just memberships * rewire global membership creation/update/deletion * delete no longer required code and patches * move code to core * move specs to core * completely remove global roles in the form of a plugin * adapt specs * remove unused methods * migrate existing data * adapt membership representer to changed timestamps * global memberships available via API * implements created/update_at filters on memberships * update member on roles being added/removed * specify default value for created_at * fix project permission check and validation on members * adapt membership schema * adapt usage of sort by on members widget * support created/updated_on for api sort and filter	4 years ago
Henriette Dinger	bd7f4e4814	Update copyright notice	5 years ago
ulferts	cd3ffe0cc5	adapt specs to altered interface	5 years ago
ulferts	a93ecca5a8	Feature/members api show (#7308) ... * basic members collection response * complete member index end point * document versions#index * remove user association from members There is already a more generic principals association. Having both causes confusion and leads to duplicate loading of models * linting * remove disabled test * add members#show api end point * add project and principal to member representer * replace member.user reference with principal * use principal reference in project members association * modernize roles api * complete member representer rendering * replace remnants of user association * add member schema api endpoint * have dedicated available projects end point for versions * linting * limit roles to assignable ones in schema * rename member to membership in api * remove remnants of user in member * spec fixes * use available_projects endpoint in versions board * add eager loading to memberships#index * members create form api endpoint * ensure role exists for default assignment * extract switch for users/groups to work_packages representer * document membership create form * add l10n expected in specs * strengthen the usage of a delete base service * use base class for set attributes service * fix alias in service * add create endpoint to members api * document members create endpoint * linting * adapt to altered service signature * use default endpoint for wp#get * use CF infused representer [ci skip]	6 years ago