openproject

Commit Graph

Author	SHA1	Message	Date
Markus Kahl	6126b4311a	added error handling in create too	7 years ago
Markus Kahl	f2919d3cb6	show dependent errors if work package update (PATCH) fails	7 years ago
ulferts	e1027189bb	eager load associated work packages of relations (#6315 ) [ci skip]	7 years ago
Jens Ulferts	26320fe614	eager load for relations	7 years ago
Jens Ulferts	d04b86da9c	introduce custom eager loading for work package list Reduces the amount of AR models instantiated when handing wp#index requests by: * Calculating part of the checksum for caching in the db. This is done by using the id and the updated_at/on field of associated models whose representation is cached in the wp representer. * Reusing instantiated models for multiple associations. e.g instances of Project are used in various places (the work package itself, it's ancestors and children). Instead of using Rails' eager loading which would instantiate a project potentially once for every association path, the code now assigns the same instance to all those associations. Additionally, the commit streamlines the creation of custom field injected representers. Now only one class is created for all work packages when before it would be one class for every uniq set of custom fields. On top of that, the class can be reused if the set of custom fields does not change.	7 years ago
ulferts	eefbb413e7	performant visible condition on relations query (#6290 ) [ci skip]	7 years ago
Jens Ulferts	ac59ad6a89	introduce group resource stub	7 years ago
Jens Ulferts	ce21ee20f7	cached representers	7 years ago
Jens Ulferts	5a5e3494f9	turn attribute group into dedicated object	7 years ago
Jens Ulferts	77116b5cdb	ensure not to have user specific query cached in schema	7 years ago
Jens Ulferts	9e4f5053bc	hack having the children table provisioned from the backend	7 years ago
Jens Ulferts	3e86dafad2	extract children rendering into dedicated component	7 years ago
Jens Ulferts	a33b0bbbbd	WIP - return Query as an attribute group * only default query for now * only returned when no custom configuration is applied * start to turn attribute groups into ressources	7 years ago
Jens Ulferts	6d359cb02d	turn attribute groups into array of objects	7 years ago
Jens Ulferts	95a4c352d7	allow sorting custom actions	7 years ago
Jens Ulferts	9bf5d05fdb	add description on custom action * turn custom action into fully fledged resource * add description to custom action model * load custom action resource on mouse over and display in title	7 years ago
Oliver Günther	6ef4211e77	Bump copyright to 2018 (#6171 ) [ci skip]	7 years ago
Jens Ulferts	42e5933545	improve wp#index performance by eager loading custom actions	7 years ago
Jens Ulferts	d20960b998	add role condition	7 years ago
Jens Ulferts	77370d58ad	document custom actions	7 years ago
Jens Ulferts	414212c49f	handle multi select custom fields	7 years ago
Jens Ulferts	886273ee86	initial implementation of conditions - status	7 years ago
Jens Ulferts	92ce554e53	configurable actions on custom actions	7 years ago
Jens Ulferts	a0b822d50b	handle conflicts and other errors	7 years ago
Jens Ulferts	71d4e6a02a	generate workflow buttons dynamically from wp resource The information in the wp resource is still static, though.	7 years ago
Jens Ulferts	211f2066f3	dummy api to allow wp custom actions	7 years ago
ulferts	83e605e63c	allow setting parent that has relation via new siblings (#6114 ) [ci skip]	7 years ago
Jens Ulferts	2db1a27ab9	use first nonempty error on relations api	7 years ago
Jens Ulferts	8842558aac	refactor for code quality	7 years ago
Oliver Günther	376fa46d4b	[26691] Avoid find(ids) in eager loader The `WorkPackageCollectionEagerLoading` uses eager loading for eager loading CF values that MAY not exist anymore. This results in a faulty query when hitting one of these entries. ``` E, [2017-11-29T17:25:21.847832 #14241] ERROR -- : Grape rescuing from error: API::Errors::NotFound Original error: #<ActiveRecord::RecordNotFound: Couldn't find Version with 'id'=35> Stacktrace: /opt/openproject/vendor/bundle/ruby/2.4.0/gems/activerecord-5.0.4/lib/active_record/relation/finder_methods.rb:353:in `raise_record_not_found_exception!' /opt/openproject/vendor/bundle/ruby/2.4.0/gems/activerecord-5.0.4/lib/active_record/relation/finder_methods.rb:479:in `find_one' /opt/openproject/vendor/bundle/ruby/2.4.0/gems/activerecord-5.0.4/lib/active_record/relation/finder_methods.rb:458:in `find_with_ids' /opt/openproject/vendor/bundle/ruby/2.4.0/gems/activerecord-5.0.4/lib/active_record/relation/finder_methods.rb:66:in `find' /opt/openproject/vendor/bundle/ruby/2.4.0/gems/activerecord-5.0.4/lib/active_record/querying.rb:3:in `find' /opt/openproject/vendor/bundle/ruby/2.4.0/gems/activerecord-5.0.4/lib/active_record/core.rb:151:in `find' /opt/openproject/lib/api/v3/work_packages/work_package_collection_representer.rb:228:in `eager_load_custom_values' /opt/openproject/lib/api/v3/work_packages/work_package_collection_representer.rb:216:in `eager_load_version_custom_values' /opt/openproject/lib/api/v3/work_packages/work_package_collection_representer.rb:197:in `full_work_packages' /opt/openproject/lib/api/v3/work_packages/work_package_collection_representer.rb:72:in `initialize' /opt/openproject/app/services/api/v3/work_package_collection_from_query_service.rb:125:in `new' /opt/openproject/app/services/api/v3/work_package_collection_from_query_service.rb:125:in `collection_representer' /opt/openproject/app/services/api/v3/work_package_collection_from_query_service.rb:57:in `results_to_representer' /opt/openproject/app/services/api/v3/work_package_collection_from_query_service.rb:46:in `call' /opt/openproject/lib/api/v3/queries/helpers/query_representer_response.rb:37:in `query_representer_response' /opt/openproject/lib/api/v3/queries/queries_api.rb:91:in `block (3 levels) in <class:QueriesAPI>' ``` https://community.openproject.com/wp/26691	7 years ago
Jens Ulferts	690e0ffc60	wp create/update/destroy via services	7 years ago
Jens Ulferts	047e972653	speedup relation candidates api	7 years ago
Jens Ulferts	6fdd122534	merge wp tree and relations into typed_dag Instead of having the tree/hierarchy information for work packages and the relations between the work packages separated into two tables all the information is now stored in the relations table. To support this, the typed_dag plugin is used. Notable changes: * relations_to and relations_from are swapped. relations_to has all relations that point to another work package (from_id = work_package.id) and relations_from contains all relations that lead to the work package from another one (to_id = work_package.id). This change is merely in the code. The db information is left untouched. * For follows/precedes to_id and from_id are swapped in the db. Because of that, "follows" is now the canonical name instead of "precedes". This is done so that hierarchy relations and follows relations point into the same direction which allows to easily detect cyclic relationships that would lead to infinit scheduling. * the columns `root_id`, `lft`, `rgt` do no longer exist in the wp table. * the column `relation_type` does no longer exist in the relations table. * For every type of relation a column (integer) does now exist in the relations table (e.g. hierarchy, block, follow) * Separate associations exist for every type of relation into two directions. E.g. Work packages following the current one can be accessed via `work_package.precedes`	7 years ago
Wieland Lindenthal	4e22681e78	User mentions feature (#5897 ) * Extend syntax for linking users via their ID * Allow login names for linking user profiles. * User require_relative for legacy tests * Add specs for login name based user links; Fixes other specs, too. * Notify mentioned users * Notify linked users; - require quotes for login names in user links as login names can contain spaces, dots that are typical word boundaries - Adding specs * For the decision who gets notified due to mentions only the visibility permissions of the recipient are relevant. * Rubucop satisfaction * Add autocomplete for user names to work pack package descriptions and activity - Uses API V3 Principals endpoint. - Extends API endpoint with name filter and name order. - Make it activate when user types an "@" or a "user#" - Still for work packages only. * Directly show a list of users after typing '@' and allow navigating list with cursor keys * Add an '@' before the rendered user link * Adopting spec as WP autocompleter now expects whitespace before hash sign * Adding spec for using user autocompleter * Introduce magic pageSize of 0 for maximum length * Add id filter for principals * Allow pagination for principals and protect from falling back to a too low default value * Fixing specs * fixing typo in spec * Add magic number 0 for user custom fields * Add a toParams method for ApiV3FilterBuilder * User ApiV3FilterBuilder in path helper service * Add test for mentions principals to path helper * WIP * Convert auto complete helper to TS [ci skip]	7 years ago
Oliver Günther	47c5475e44	Require hashie [ci skip]	7 years ago
ulferts	9c8f7f3ca1	read operations for time_entries via api v3 (#5776 ) * read operations for time_entries via api v3 Introduces the endpoints: * GET /api/v3/time_entries * GET /api/v3/time_entries/:id * GET /api/v3/time_entries/activities/:id The index action for time entries can be queried by the following filters: * project_id * user_id * work_package_id The implementation is exposing the database structure mostly one to one with the exception of some renaming and the hiding of the activities' complexity, where only the activity used systemwide is referenced regardless of whether a project specific override exists or not. * allow custom values for time entries [ci skip]	7 years ago
ulferts	2f9d7f408a	Fix/wp table switch to milestone (#5825 ) * map date name in changeset * handle date switch in wp form * Don't stub_const for services that may exist before hand This will cause the const to be evaluated already, so that stub_const has no effect there. This is why this fails depending on the order on travis, but not locally/isolated. [ci skip]	7 years ago
ulferts	61281b7f6a	explicitly set author to be nonwritable in wp schema (#5805 ) While the author is writable, one can set it to the current user. It should not be marked as writable as the backend makes that assignment already. But because of this behaviour we cannot rely on the default behaviour for determining whether a property is writable [ci skip]	7 years ago
Oliver Günther	ab9a9baee7	[26002] Add date as writable when type is milestone (#5804 ) https://community.openproject.com/wp/26002 [ci skip]	7 years ago
ulferts	7154caec85	Fix/consolidate representers (#5732 ) * consolidate representers Minimizes the need for extensive payload representers by: * introducing the payload_representer module which removes all non writable propertyies from a representer * introducing the resource/resources/associated_resource/associated_ressources helper methods which provide a framework for having a representer suitable for parsing and rendering Additionally increases the importance of the contracts by using them to calculate the writeable attributes. * remove unused endpoint [ci skip]	7 years ago
Oliver Günther	8956700408	[25374] Remove attribute visibility	7 years ago
ulferts	fc139e55df	limit visibility of relations index (#5703 ) [ci skip]	7 years ago
ulferts	65c7db3120	avoid side effects on calls to attribute_groups (#5677 ) Without the deep_dup, the call to attribute_groups used to alter the type's attribute_groups deeply nested attribute_groups property. As a result, the second call to attribute_groups would be different from the first one. This became most apparent when rending the schema for a couple of work packages all sharing the same type. As the type was reused to render the schema, but the project might have changed, only the first schema for the type was accurate, while subsequent schemas for that type lacked attributes [ci skip]	7 years ago
ulferts	0c0b16508b	Fix/bump representable (#5465 ) * bump reform and roar -> bumps representer * adapt to changed validation interface * disable initializer patch for now * adapt to changed representable attr interface * can no longer have private methods inside a representer * private no longer possible for representer * bump reform * wip - restyle validation * remove commented out patch * apply injection as prescribed * reactivate reform error symbols patch * remove patch to Hash superfluous wit ruby 2.3 * remove outdated human_attribute_name patch * whitespace fixes * adapt filter name after removal of human_attribute_name patch * adapt filter specs to no longer rely on human_attribute_name patch * fix version filter name * remove reliance on no longer existing human_attribute_name patch * use correct key in journal formatter * remove private from representer * adapt to altered setter interface * reenable i18n for error messages in contracts * no private methods in representer * defined model for contracts * fix validaton * instantiate correct Object * define model for contract * circumvent now existing render method on reform * replace deprecated constant * patch correct reform class - not the module - via prepend * refactor too complex method * replace deprations * remove remnants of parentId * prevent error symbols from existing twice * adapt user representer to altered setter interface * adapt watcher representer to altered setter interface * remove now unnessary patch * adapt setter to altered interface * adapt spec * fix custom field setters * remove parentId from wp representer As the parent is a wp resource, clients should use the parent link instead * adapt spec to changed valid? interface * remove parentId from wp schema * replace references of parentId in frontend * remove TODO [ci skip]	8 years ago
Oliver Günther	5d50acc50e	[25288] Re-add translations to default attribute groups (#5515 ) * [25288] Re-add translations to default attribute groups Uses symbols to mark internal attribute groups and translates them in the schema representer to the user's locale. * Extend form configuration front end for translated default groups * fixing specs * fix feature spec for attribute groups * Add symbol test to attribute groups [ci skip]	8 years ago
Wieland Lindenthal	fd8ecbb2d9	Styling: Satisfying rubucop	8 years ago
Wieland Lindenthal	313271eef2	Adding links to create_form_representer for creating WPs globally	8 years ago
Wieland Lindenthal	cf41a81104	add drop down menu for wp create screen.	8 years ago
Wieland Lindenthal	ca1ee47645	Add configureForm Link to settings menu in WP list	8 years ago
Jens Ulferts	b67754d2b8	exclude already related work packages	8 years ago

1 2 3 4 5 ...

854 Commits (e4b134e1363cc20c21ea3e3452a962d3b42619aa)