1511 Commits (e4faa9ef8bb611e66cee4f776755098bd77c4868)

Author	SHA1	Message	Date
ulferts	3f8ca13830	rubocop autofix for cops added in 1.31.0	2 years ago
Dombi Attila	8124a3705a	Move duration for milestone validations to the base contract	2 years ago
Oliver Günther	99ce4f9ad2	Set up cache store early in application.rb	2 years ago
Dombi Attila	7ba6e63917	Clean up rubocop errors from work_package_representer_spec.rb	2 years ago
Dombi Attila	0bb487ab26	Add duration setter for WorkPackageRepresenter	2 years ago
ulferts	71e6f28df5	reduce count calls in collection representer ... will_paginated, when actually fetching the records will do an SQL count on top of the fetching. We don`t need that in our offset paginated represters since those implement their own counts. And if the per_page is 0, we don`t even have to try to fetch any objects so we can use `none` to avoid the database roundtrip.	2 years ago
Christophe Bliard	53dec1c74f	Remove useless import	2 years ago
Christophe Bliard	5596871a09	Add cop to enforce usage of ServiceResult factory methods ... The cop is named `OpenProject/UseServiceResultFactoryMethods`. It will check for ServiceResult.new call and check if it can be replaced by `ServiceResult.success` or `ServiceResult.failure`. These factory methods make the code easier to understand by being shorter and more explicit. This is the first cop I write, so there is probably room for improvement.	2 years ago
ulferts	9b727f2eec	add readonly property to wp schema	2 years ago
ulferts	b52a91aec4	rename hasReadonlyStatus to readonly	2 years ago
Oliver Günther	e4df121ca4	Implement hasReadonlyStatus	2 years ago
ulferts	44996d2ec3	allow having duration in payload representer ... It will only show up if the feature flag is enabled. As this will not yet be used in production it is ok to behave like that.	2 years ago
ulferts	ec01d40440	use feature flag spec helper for all duration specs	2 years ago
ulferts	369ea5578b	introduce with_flag spec helper	2 years ago
ulferts	b314f02c1b	add ignore flag to work package schema representer	2 years ago
ulferts	1aaf5ba57a	add ignore flag to work package representer	2 years ago
ulferts	5dbb3de9d8	rubocop autofix for cops added in 2.15	2 years ago
ulferts	bb60882b31	Revert "Remove duration from the work package form configuration" ... This reverts commit f73b1412f1.	2 years ago
Dombi Attila	f73b1412f1	Remove duration from the work package form configuration	2 years ago
Dombi Attila	cc7c2fd3a5	Add duration column to the work package table	2 years ago
Christophe Bliard	c6e44141db	Remove :stubbed_work_package factory ... Using build_stubbed(:work_package) works equally well. Relates to commit e1607a6116	2 years ago
Christophe Bliard	48a4f1b6ad	lint with rubocop --autocorrect (safe cops only)	2 years ago
Dombi Attila	91d36234f1	Implementation/42565 Extend signalling API of work packages (#10713) ... * Add due_date, start_date to WorkPackage signaling api * fixup! Add due_date, start_date to WorkPackage signaling api * fixup! Add due_date, start_date to WorkPackage signaling api * fixup! Add due_date, start_date to WorkPackage signaling api * fixup! Add due_date, start_date to WorkPackage signaling api * fixup! Add due_date, start_date to WorkPackage signaling api	2 years ago
Dombi Attila	8733386f87	fixup! Add non-working days to the api/v3/days	2 years ago
Dombi Attila	12e6b898db	Add weekday resource link to api/v3/days	2 years ago
Dombi Attila	54eca7fddb	Add non-working days to the api/v3/days	2 years ago
Christophe Bliard	084df42334	add first implementation of /api/v3/days ... no filters yet	2 years ago
Christophe Bliard	2471b06975	#41816: add stubs of days representer ... the links are still missing and will be added later	2 years ago
Dombi Attila	e92253aeb7	Add non-working day show api endpoint	2 years ago
Christophe Bliard	cc8fa1f7be	implement GET /api/v3/days/week ... wp#41816	2 years ago
Christophe Bliard	8da459140e	refactor: expand options argument of allowed_to calls ... Clean Authorization::UserAllowedService methods to remove global and options parameters when they are not used use allowed_to_globally? where possible	2 years ago
Oliver Günther	22b7849520	Remove legacy mailer configuration and move into settings ... Split from "Remove Setting.protocol in favor of static config" Restore cache store setup	2 years ago
Markus Kahl	5b3fef7909	fix starttls_auto and ssl_verify_mode settings	3 years ago
Eric Schubert	6140875b14	[#42362] added storages link to project representer ... - added unit tests	3 years ago
Eric Schubert	44392cfb96	[#42204] fixed tests and permission check	3 years ago
Christophe Bliard	f0f17d9293	Escape single quotes from i18n string in sql query ... Will fix PG::SyntaxError seen on Sentry SAAS-OPENPROJECT-PROD-111 https://sentry2.openproject.com/organizations/sentry/issues/1799/events/27338691eee84473b79410165e54bd6f/\?project\=6	3 years ago
Eric Schubert	fb93ff4c31	[#42204] add file links to work package resource ... - https://community.openproject.org/work_packages/42204 - added file links include module for other resources - fixed some rubocop issues in work package representer - added representer tests	3 years ago
Oliver Günther	c6e0cdaea0	add changed autocomplete=off due to rails bump	3 years ago
Oliver Günther	057ac5ff36	[42023] Ensure formattable properties output a string as raw ... The API specification states that the raw text is always a string. However when passing `nil` as the represented text, it is output directly. https://www.openproject.org/docs/api/basic-objects/#formattable-text https://community.openproject.org/wp/42023	3 years ago
Christophe Bliard	c6ff4be74f	deserialize empty string setting value to nil when not string format ... the seeder blindly saves all settings to database, setting the value to empty string when no value is defined. When the setting is read back, it can be misinterpreted. For instance a boolean setting with a nil value will have the value '' once seeded, and it is truthy which is wrong. add a helper to restore settings after resetting them in tests	3 years ago
Dombi Attila	76ea07ec6c	Regression tests for clearing filter representer cache on product version change	3 years ago
Eric Schubert	385ebe1902	[#40196] fixed representer spec	3 years ago
ulferts	f1111922ed	use API::ParserStruct for all API parsing	3 years ago
Christophe Bliard	083f0e6b27	clear Rails cache between tests to avoid Settings leaking state ... Settings are cached with a key having the timestamp of the latest updated setting. When no settings are saved, current time is used instead. For fast tests occurring in the same second, the settings state is kept as they share the same cache key. That leads to non-isolated tests and possibly failures. Clearing the Rails cache before each test avoids it.	3 years ago
Oliver Günther	f5ea098356	[41437] Use signalling on project edit field (#10432) ... * Add project-edit-field that uses op-autocompleter * Replace for_type param with regular filter * Fix unrelated spec now fixed in behavior due to the select helper change The spec did not apply the new type previously, so would not override the description. This caused the expects to remain valid, but was actually incorrect behavior. * Ensure we're not focussing the project field on inline create * fix flickering test because of ng-select/ng-select#1869 we can't use a string with spaces in ng-select input value while the list of items is empty. The spaces would be ignored and matching an entry would then fail. Instead wait for ng-dropdown-panel to appear which means items are present, the bug is inactive, and the spaces can be properly sent to the input. flickering test was spec/features/custom_fields/multi_user_custom_field_spec.rb:61 * fix tests broken in 65695f1 - Reintroduce sleep to make test pass. I'd like to get rid of it but can't understand why it's needed. - refine results_selector only if it is 'body'. * fix tests by not waiting for dropdown before typing for global search Co-authored-by: Benjamin Bädorf <b.baedorf@openproject.com> Co-authored-by: Christophe Bliard <c.bliard@openproject.com>	3 years ago
Oliver Günther	df220ed594	Extend project filter with replaced values and add spec	3 years ago
Christophe Bliard	76f9aa760d	reevaluate module availability on each call	3 years ago
ulferts	f4c4544f7a	bail when trying to write a configuration & deprecte non bool setting_name? access	3 years ago
Christophe Bliard	2356dfc133	test that :if in module declaration controls module availability ... and make rubocop happier	3 years ago
ulferts	491928a3fd	replace typed_dag with closure_tree and CTE	3 years ago