openproject

Commit Graph

Author	SHA1	Message	Date
Jens Ulferts	8842558aac	refactor for code quality	7 years ago
Wieland Lindenthal	4e22681e78	User mentions feature (#5897 ) * Extend syntax for linking users via their ID * Allow login names for linking user profiles. * User require_relative for legacy tests * Add specs for login name based user links; Fixes other specs, too. * Notify mentioned users * Notify linked users; - require quotes for login names in user links as login names can contain spaces, dots that are typical word boundaries - Adding specs * For the decision who gets notified due to mentions only the visibility permissions of the recipient are relevant. * Rubucop satisfaction * Add autocomplete for user names to work pack package descriptions and activity - Uses API V3 Principals endpoint. - Extends API endpoint with name filter and name order. - Make it activate when user types an "@" or a "user#" - Still for work packages only. * Directly show a list of users after typing '@' and allow navigating list with cursor keys * Add an '@' before the rendered user link * Adopting spec as WP autocompleter now expects whitespace before hash sign * Adding spec for using user autocompleter * Introduce magic pageSize of 0 for maximum length * Add id filter for principals * Allow pagination for principals and protect from falling back to a too low default value * Fixing specs * fixing typo in spec * Add magic number 0 for user custom fields * Add a toParams method for ApiV3FilterBuilder * User ApiV3FilterBuilder in path helper service * Add test for mentions principals to path helper * WIP * Convert auto complete helper to TS [ci skip]	7 years ago
Oliver Günther	fdfb41b327	[26069] Allow passing of me-value link for principal filters again The 'me' value is currently automatically normalized to the current user, making it impossible to store queries that reference the current user whenever accessing the query as before.	7 years ago
ulferts	9c8f7f3ca1	read operations for time_entries via api v3 (#5776 ) * read operations for time_entries via api v3 Introduces the endpoints: * GET /api/v3/time_entries * GET /api/v3/time_entries/:id * GET /api/v3/time_entries/activities/:id The index action for time entries can be queried by the following filters: * project_id * user_id * work_package_id The implementation is exposing the database structure mostly one to one with the exception of some renaming and the hiding of the activities' complexity, where only the activity used systemwide is referenced regardless of whether a project specific override exists or not. * allow custom values for time entries [ci skip]	7 years ago
ulferts	0c0b16508b	Fix/bump representable (#5465 ) * bump reform and roar -> bumps representer * adapt to changed validation interface * disable initializer patch for now * adapt to changed representable attr interface * can no longer have private methods inside a representer * private no longer possible for representer * bump reform * wip - restyle validation * remove commented out patch * apply injection as prescribed * reactivate reform error symbols patch * remove patch to Hash superfluous wit ruby 2.3 * remove outdated human_attribute_name patch * whitespace fixes * adapt filter name after removal of human_attribute_name patch * adapt filter specs to no longer rely on human_attribute_name patch * fix version filter name * remove reliance on no longer existing human_attribute_name patch * use correct key in journal formatter * remove private from representer * adapt to altered setter interface * reenable i18n for error messages in contracts * no private methods in representer * defined model for contracts * fix validaton * instantiate correct Object * define model for contract * circumvent now existing render method on reform * replace deprecated constant * patch correct reform class - not the module - via prepend * refactor too complex method * replace deprations * remove remnants of parentId * prevent error symbols from existing twice * adapt user representer to altered setter interface * adapt watcher representer to altered setter interface * remove now unnessary patch * adapt setter to altered interface * adapt spec * fix custom field setters * remove parentId from wp representer As the parent is a wp resource, clients should use the parent link instead * adapt spec to changed valid? interface * remove parentId from wp schema * replace references of parentId in frontend * remove TODO [ci skip]	8 years ago
Oliver Günther	7cf11bb689	Update copyright notice	8 years ago
Markus Kahl	64db3d3b8a	allow writing admin flag	8 years ago
Jens Ulferts	a52c8ee07d	allow for filtering the queries in the API v3 Only implements the `project` filter for now which can be used to differntiate between queries from specific projects and can also be used to specify that the client is only interested in global queries	8 years ago
Markus Kahl	9671e6368a	added missing auth fields to user endpoint	8 years ago
Oliver Günther	46db333060	Refactor as mixin	8 years ago
Oliver Günther	350de7c482	Allow users to be uniquely identified by login	8 years ago
Oliver Günther	7b21088959	Adapter UserRepresenter and spec according to visibility	8 years ago
Oliver Günther	087691b5d7	Fix permissions in specification	8 years ago
Jens Ulferts	d4e71fd67e	add user query and enabled it in the users api	8 years ago
Jens Ulferts	1a597e180b	first step towards generalizing the query and its filters	8 years ago
Jens Ulferts	e53916aec6	support perPage and offset on users index	8 years ago
Jens Ulferts	040bb5ab54	add basic GET api/v3/users	8 years ago
Oliver Günther	6cbfc7ffed	[24063] Add Users PATCH endpoint	8 years ago
Oliver Günther	467bf13e28	Return correct status from successful create	8 years ago
Oliver Günther	11794feed1	Handle invitation flow	8 years ago
Oliver Günther	9dc8d09516	Add CreateUser API endpoint and spec	8 years ago
ulferts	0a13362ab6	remove no longer required link (#4647 )	8 years ago
Oliver Günther	1ff1c170f9	Implement showUser path	9 years ago
Jan Sandbrink	88ed4d2df9	Promote ::create to a common interface method This one is already used by the representers that require a custom field injector. However, by having a separate method this also means collections (or the new DecoratorFactory) need to take care and call the ::create method instead of ::new. I therefore made create the default interface to create representers, which is now used by Factories and Collections. Note: I did not yet change all representer instantiations to ::create. I hope this will happen gradually.	9 years ago
Jan Sandbrink	6e9ed008fb	Enforce passing of current_user into representers Thereby permission checks will no longer silently fail if no user was passed. This uncovered a lot of places where we actually expected a user to be passed, when it wasn't. This was especially true for collections. The basic idea is, that virtually all representers could change their behaviour based on the current user. Representers where this is not the case (e.g. Digest), can still explicitly opt-out.	9 years ago
Jan Sandbrink	b332ef06aa	make collection representer explicitly unpaginated	9 years ago
Alex Coles	a6212fb304	Fix syntax (w/Rubocop) in lib code Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alexander Bach	870518f217	Unified permission checks	10 years ago
Alexander Bach	e73609c3ae	Unified permission checks	10 years ago
Jan Sandbrink	900b2a4c45	Backporting APIv3 categories to OP 4.0 Backport was neccessary to implement missing categories filter without adding more technical debt. These changes will be merged into 4.1 and following branches and vanish in that merge (merge-strategy "ours") YOU SHOULD NOT SEE ANY CONTENTS FROM THIS COMMIT ANYWHERE AFTER 4.0.x! This commit was built from the commits of the GitHub-PR mentioned below, as well as some code dependencies for that. The GitHub-PR was https://github.com/opf/openproject/pull/2505	10 years ago
Jan Sandbrink	a3ff9d57ed	fix user representer for representing groups [sic]	10 years ago
Jan Sandbrink	957b060851	hide a users mail address if he wishes to	10 years ago
Jan Sandbrink	9feb0700ac	rename mail to email, update docs, style code	10 years ago
Jan Sandbrink	b1ba33c75b	specify classes explicitly rather than implicitly This is a new try for the APIv3 classes, we either: - FULLY qualify a class and let the autoloader do the rest - don't qualify at all, but require the class explicitly Thus we do not (yet) completely give up on the rails autoloader, but we circumvent a fair amount of its magic (and problems). The hope is to eliminate the following problems in development mode: - NameErrors because the autoloader infers the wrong prefix - "object is not missing constant" errors occuring more rarely Let's see how that turns out to work...	10 years ago
Jan Sandbrink	f0863f9d53	allow to patch existing API endpoints	10 years ago
Jan Sandbrink	a72ea0d5af	more consequently use route_param this seems to be the GRAPE-iest way possible	10 years ago
Jan Sandbrink	2e1a999c6c	extract current_user into Single a current_user known by representers is an unfortunate concept, that we are using across multiple representers, so we should include it in the top level class for our representers.	10 years ago
Jan Sandbrink	2d821da157	prefix representers to help rails out some some reason it get random NameErrors in development mode otherwise... I don't know why nobody else is getting those, but I am getting them quite reliably when opening the work package view and then the work package details pane...	10 years ago
Jan Sandbrink	7c2a686657	make self_link even more awesome	10 years ago
Jan Sandbrink	327c53cb94	extract helper for self links	10 years ago
Jan Sandbrink	34f357f492	use formatter from member instead of immediately - allows to DI easier - more elegant solution around autoloading issues	10 years ago
Jan Sandbrink	83a42d82b9	fix auto loading of DateTimeFormatter during dev Apparantly the rails autoloader gets confused by trying to load a class from an included module. We can help it, by explicitly referencing (thus loading) the fully qualified class name first... I wish there was a better solution, but I couldn't find one...	10 years ago
Jan Sandbrink	c6323dbc10	refactor output of dates and times - all (?) APIv3 resources now use a common formatter - all APIv3 resources now use common names for "createdAt" and "updatedAt" - existing tests were adapted when they were wrong before (according to specs) - no unit tests for common formatter extracted yet	10 years ago
Jens Ulferts	ffc89d0f13	we no longer use instance variables here	10 years ago
Jens Ulferts	374c1f0af9	prefer current_user over User.current	10 years ago
Jan Sandbrink	0f3433d619	remove param from method	10 years ago
Jan Sandbrink	bb5cc904b1	actually call the method I intended apparently I am not able to distinguish a class method from an instance method ^^	10 years ago
Jens Ulferts	da588b812c	harmonize api decorators	10 years ago
Jan Sandbrink	e1c02db9ab	fix reference to current user	10 years ago
Jan Sandbrink	d1e3f23467	obey style rules	10 years ago

1 2

93 Commits (e5026a0a1a08fdb52badff3d7137b5b0d7a9b6e0)