850 Commits (e62e14feb53e0a1f517be304db9966697176a2fe)

Author	SHA1	Message	Date
Alexander Bach	39690ca19d	Improve block styling	9 years ago
Alexander Bach	e5b1d55974	Remove redundant argument	9 years ago
Alexander Bach	5fea667954	Return recipients as users instead of mail addresses	9 years ago
Jan Sandbrink	747e9ac3ca	add spec for single journable aggregation	9 years ago
Alexander Bach	39cbce0182	Cover new cases	9 years ago
Alexander Bach	22e6a37f9e	Migrate legacy spec	9 years ago
Jan Sandbrink	7240231769	make specs more readable	9 years ago
Jan Sandbrink	f65f9e3e2d	remove the AR portion of aggregated journals ... - this prohibits doing stupid things like saving aggregated journals - should make clear that aggregated journals are not real journals...	9 years ago
Jan Sandbrink	3a87b269fa	allow to fetch aggregated journals for a journable ... - this should be faster (or at least easier to optimize) than applying a WHERE to the whole scope - also starting to diverge from using classic ActiveRecord in aggregated journals	9 years ago
Oliver Günther	e1bdb41bcd	More complete specs wrt. coverage, cleanup	9 years ago
Oliver Günther	1e8c873544	Remove filesystem adapter ... This commit removes the entire FileSystem repository and adapter. It rids all specs (core and legacy) of remaining uses of this adpater and replaces it with a temporary subversion repository, where necessary. We also need to remove remaining filesystem instances from the database, otherwise users will receive errors when accessing said repositories on the Frontend. This does not destroy any data on filesystem, but database information on the repositories (remarks) are lost.	9 years ago
Oliver Günther	05b27c1b98	Asynchronous creation, deletion of repositories from OP. ... This PR begins the push towards management of repository lifetime from within OpenProject. What this currently provides is the following: - A mixin `ManageableRepository`, included by `Repository::{Git, Subversion}` to provide an interface to repo management - Two services and delayed_job workers for creating (`CreateManagedRepositoryService`) and deleting (`DeleteRepositoryService`) - Customized rendering of subforms in the repository settings for arbitrary SCM vendors. TODOS: - [x] Provide sane ground to work on ( cf. PR #3149 ) - [x] Rework SCM settings form (`{scm}_tags` is currently HTML generated from within a Helper.) - [x] Ease integration of arbitrary SCM vendors - [x] Display meaningful error / warning when user looks at bare repository (currently outputs 500, as Git HEAD / svn revision is not available) - [x] I18n - [ ] Specs (in progress) - [x] Fix legacy specs - [ ] Decide what to do with `Filesystem` adapter. Open Questions: - **Configuration**: Currently replaces the existing options in `configuration.yml`. - **Implementation specifics**: - Sub-projects repositories reside in a hierarchy below their parents - How should the delayed_job react upon failure? (esp. creation of repositories) Relevant work package: https://community.openproject.org/work_packages/20416 Merge dependent on PR #3149	9 years ago
Jan Sandbrink	5f06a8900d	better PSQL compatibility for aggregated journals	9 years ago
Jan Sandbrink	f02b32faad	override :initial? for AggregatedJournal ... the simple approach of looking at the version number does not work, because aggregated journals can have gaps in their versions (and there might be no version 1)	9 years ago
Jan Sandbrink	88169a46de	expose id of "master" as notes_id ... - make spec assertions more detailed by comparing all the attributes	9 years ago
Jan Sandbrink	e346909b36	add more specs for aggregated journals	9 years ago
Jan Sandbrink	8bab9a3d22	add specs for not aggregating comments	9 years ago
Jan Sandbrink	9e9ca84d9c	test non-aggregation after time gap	9 years ago
Jan Sandbrink	885d8d734f	add basic spec for aggregated journals	9 years ago
Alexander Bach	908c788e4f	Adjust work_package_action_mailer.spec	9 years ago
Alexander Bach	ee14628c09	Move send_notification to event origin	9 years ago
Alexander Bach	a5f4eb1e8b	First event-based draft ... Unifies Journal- and WorkPackageObserver Removes them as observers Makes new JournalListener more classy	9 years ago
Jens Ulferts	52f6b69221	hoping to fix spec flicker ... It seems to fail more often around date changes	9 years ago
Jan Sandbrink	7e53b9ac04	remove spec expecting german translations ... german translations are not part of OpenProject anymore (they are now provided via Crowdin)	9 years ago
Jan Sandbrink	138d3dba29	fix some specs ... - error messages now contain punctuation - when :save returns false, there should be errors present - errors in form representers are now API errors	9 years ago
Jan Sandbrink	218c75e765	fix update_by! user when not providing notes ... - previously the created Journal Entry would have been made by the specified user or the User.current, dependent whether :notes were provided or not - now the journal entry is always made by the specified user	9 years ago
Alex Coles	ae59a6985a	Teach User.authorize_within ActiveRecord::Relation ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	81de05e5fe	Remove deprecated Relation#all in specs ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	b2790b8db1	Migrate deprecated .update_all with conditions ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	0f9240037a	Fix TimeEntry cleanup on work package bulk delete ... Fix `WorkPackage.cleanup_associated_before_destructing_if_required` semantics so that the first argument can either be an individual `WorkPackage` (as the spec originally expected) or a collection (as in actual usages). Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	ce93701029	Fix syntax (w/Rubocop) in specs ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	57618b25ec	Replace dynamic finder usages with #find_by, etc. ... This patch replaces all dynamic finders, for the sake of consistency, although only some methods are deprecated. See: https://github.com/rails/activerecord-deprecated_finders#active-record-deprecated-finders * Revert some `User#find_by_login` usages in cuke steps accidentally removed in 74228b59. User Story # 20325 Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Jan Sandbrink	620c55bf3d	change the default preference for mail hiding	10 years ago
Oliver Günther	cb123c83be	Fix and specs for missing plus in login attribute ... Fixes the merge issue from 105934a5f9	10 years ago
Alex Coles	abf4a011f0	Fix copying of versions on Project copy ... Adds a more robust solution for copying closed versions and associating with copied work packages (see original patch 10ec20a8). Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	d060e654a5	Use vanilla Rails validations for CustomField#name ... Globalize should support regular Rails validations. Additionally `validate_name` was no longer working as expected, possibly due to changes in `CustomField::Translation` lifecycle. * Do not test translation implementation details in CustomFieldController spec. Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Jan Sandbrink	c075a7b401	only allow simple space in login ... also add specs to verify that	10 years ago
Alex Coles	3276c4ebb5	Add/update Copyright headers in specs ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Jan Sandbrink	8e1970b9bb	add roundtrip tests for more datatypes	10 years ago
Jan Sandbrink	27d6abfa35	add integrative tests for typed_value for booleans ... first charge of tests. I intend those to fail for postgres, but can't verify that locally, so travis will have to do it for me. If you see this build failing for the newly added specs: This is intentional!	10 years ago
Jan Sandbrink	f9b242884d	let custom values accept their native type ... - add specs for strategies to parse their typed representation as valid (instead of only their stringly typed counterpart) - add specs to int and float strategy regarding accepting eachother - fix int custom values accepting float inputs (which would work, but omit the fractional part) - fix date custom values not accepting on Date	10 years ago
Alex Coles	2efd6f4e45	Move legacy specs under spec/legacy ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	19ed4dc9ab	Replace more deprecated shoulda matchers in specs ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Jan Sandbrink	cdeb533904	allow to disable modules in project factory ... replaces specific "wiki-only" trait that existed before	10 years ago
Jan Sandbrink	88b99db223	only respond to valid custom_field_n accessors ... it is not enough that the CF exists, it actually has to be a CF that can be used on that work package	10 years ago
Jan Sandbrink	ad5b7b3c62	make spec localization independent	10 years ago
Jan Sandbrink	122384b8f2	use "be" instead of "eql"	10 years ago
Jan Sandbrink	05bdba6a29	fix preview of true custom field in form ... :typed_value would not return true if the internal value was set to true (it only ever expected it to be '1')	10 years ago
Jens Ulferts	13e0940171	only display scm options if they are configured	10 years ago
Jens Ulferts	fce72938e3	prevent path traversal via filesystem scm ... Setting up a filesystem scm now requires to specify a whitelist via the configuration	10 years ago