openproject

Commit Graph

Author	SHA1	Message	Date
Benjamin Bädorf	488cd3eff9	Fix/wysiwyg changes (#8884 ) * Only set styling on code-block when editing * CKEditor fixes Adds op-uc-figure--content fix for tables, Adds op-uc-container to preview, * Left align figure content by default, making the changes in appearance less severe * Revert wrapping table in op-uc-figure--content in edit mdoe * Update CSS Classes spec * Resize figcaption together with image * Add underlines to headings on wiki pages * Remove word breaking from tables * Left align images in editor * Avoid break inside all figures, including images * linting * restrict lines under headings to h1 only * remove ckeditor changes * adapt spec to altered l10n string * revert expected css classes since ckeditor remains unchanged Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
ulferts	7a738cebc6	Feature/group fold button (#8863 ) * add fold/unfold groups button * wip * introduce service to communicate fold state * fix colspan on folding/unfolding groups * move state handling into service * refreshAllGroupHeaderCells when allGroupsChanged too * have correct order for states to update * rely on refreshView to trigger collapsedRowRefreshing The refreshView method is called whenever a group is folded/expanded. Therefore, the listeners for the states are just extra and lead to the code being executed twice. * remove code made obsolete by commit before * show group toggle button only when grouping * use plus/minus icon for button * shorten code * remove duplicated code * linting * dropdown for expand/collapse * add icon to button * alter button position and switch icons * remove text from group toggle button * have unique html id on fold button * Rerendering only group rows when grouping changes * Disable unavailable menu collapse option + merge old collapse state * refreshAllGroupHeaderCells when allGroupsChanged too * Disable collapse options handling mixed scenarios * Working with different grouping & updating grouping options disable * Code climate fixes * Fix + Types with headers extracted to service * Test fixes * CodeClimate fixes Co-authored-by: Aleix Suau <info@macrofonoestudio.es>	4 years ago
Benjamin Bädorf	e848d44dea	Fix/update wysiwyg styles (#8844 ) This is a refactoring of the CSS classes in the WYSIWYG editor. The classes now use proper BEM and are almost completely independent of other CSS. It also includes small style refactorings, like a reduction of heading size in attribute fields, and an increase in heading size in all other instances. * Initial class definitions * Added more classes * Added Table of Contents basics * CkEditor applying custom CSS classes to p, h1, h2, h3, h4, h5, h6, li and blockquote * CKEditorInspector removed * op css class for headings * op css class for paragraphs * op css class for code/code block * adapt specs to altered markdown/html generation * adapt grid/budget representers to altered signature * op css class for lists * op css class for toc * op css class for links * Start working on typography css * op css class for tables * Fixing more typography, trying out larger headers * Applying custom classes to li, a, blockquote, figure, table, tr, td, th, image, codeblock, figcaption and macros * adapt specs to altered link classes * op css class for images * apply user content container class throughout application * CSS alignment custom classes applied to table * op css class for task list checkbox * Added task checkbox class * amend list checkbox class in backend * op css class for table thead element * adapt specs on image html generation * Updated table and typography styles * Update typography and figure styles * Figure overflow handling * Table alignment styles + ckEditor styles removed * rename wiki-anchor to op-uc-link_permalink * wrap table in div as well as figure * Updated code-block * Update permalinks * Fixed a lot about tables * Removed Description header from work-packages page * Fix frontend styles * Add placeholder styling, fix toc * Fixed figure print * working with table aligns * Custom class add to task lists * Custom classes applied to theads * op-uc-container custom class added to container * Codeblocks inside pre elements * Fix: single <code> and <a> tags * explicitly require overwritten gem class Apparently, the gem is not loaded yet when it is registered as a filter when in eager loading mode * adapt spec expectation to altered toc rendering * CkInspector removed * Latest ckeditor changes * remove highlight css class from wiki content * allow html pipleline to handle macros with additional classes * Fixed a lot of print css for tables * Add general print css back in * Update Table of Contents styling * Custom classes on ul, ol, li and task-lists * Revert "Custom classes on ul, ol, li and task-lists" This reverts commit `0d27d28137`. * Custom classes on ul, ol, li and task-lists * Custom classes on column's th * remove placeholder class when rendering * WOrking on task lists * Changing task-list classes, changed tests * Updated list styles * Remove unused todo list styles * remove checked in binstubs * Fix table of contents * adapt todo list handing in backend pipeline * adapt specs to altered css classes * Add numbers to table of contents * Better comments in table of contents * Fix: wrap single <table> with a <figure> * Fixes to todo list design * Updated todo list scss to fix nested lists * adapt selectors in table spec * Update table styles * Improve table borders more * Custom classes specs * Fix: no need to remove regular list classes when its type changes * Add modifier for inline headings * Update table editing styles * Remove break-word tests * wrap images just like tables * Update figure content styles * Fix: All tests passing (ul.op-uc-list_task-list) * div.op-uc-figure--content wrapping tables * Specs for figures wrappers div.op-uc-figure--content * Fix: add custom classes to links and codes again * Table wrapper div reverted + specs * Fix inline palceholders * Custom macro type classes * Add basic macro placeholder changes * Move heading permalink after text * Fix word-break spec * Sending figure styles to the backend (width) * extend test to take ckeditor placeholder into account * avoid adding bem classes multiple times * attempt to fix flickering spec * Removing image spinner when uploading finishes * adapt spec expectations Co-authored-by: Aleix Suau <info@macrofonoestudio.es> Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
Aleix Suau	459bbcb80a	Feature/32616 show children in row on collapsed parents (#8800 ) * Showing milestones on collapsed project rows * Showing milestone's labels on hover * Milestones adapting to zoom changes + refactor * Refactor to make it applicable to other wp types * Calculate timeline width including wps shown in collapsed rows * Tests * Custom labels for duplicated cells * Custom labels for duplicated cells * Hide empty labels on hover * All tests passing (switched to isMilestone function) * Make up * Showing milestones on collapsed project rows * Showing milestone's labels on hover * Milestones adapting to zoom changes + refactor * Refactor to make it applicable to other wp types * Calculate timeline width including wps shown in collapsed rows * Tests * Custom labels for duplicated cells * Custom labels for duplicated cells * Hide empty labels on hover * All tests passing (switched to isMilestone function) * Make up * Refactor fix * Empty line at the end of the file * Empty line at the end of the file * Hide non hover labels on group rows * Only include header cells for wp with date or startDate * Add group header cells into Autozoom width calculations * Showing labels on group headers * LabelRight's padding reduced * group-row class name changed to modifier -group-row * withCustomLabels moved to WorkPackageCellLabels class * withCustomLabels renamed to withAlternativeLabels * isDuplicatedCell and withAlternativeLabels moved into RenderInfo * Typings improvements * Duplicated code extracted to getWorkPackagesToCalculateTimelineWidthFrom * Conditional flag moved out of manageCollapsedGroupHeaderCells * manageCollapsedGroupHeaderCells setup extracted to a method * manageCollapsedGroupHeaderCells setup extracted to a method * manageCollapsedGroupHeaderCells setup extracted to a method * Group logic extrated to groupTypeFromIdentifier and groupIdFromIdentifier methods * Remove 'project' hardcoded reference from createCollapsedGroupHeaderCells * Common pipes grouped in a getter * Codeclimate fixes	4 years ago
Benjamin Bädorf	5f45ee07ab	Move development docker-compose file to the main directory (#8798 ) * Move development docker-compose file to the main directory This requires us to move some other files around, like the pullpreview and example docker-compose file for production setups. This commit also does some housekeeping, like removing some old files and deduping configuration. * Updated to selenium grid * Fix in-Docker Selenium tests The Selenium tests now run inside a Docker Chrome Container. Backwards compatability with non-docker setups is not guaranteed, though it should not be hard to implement with a couple of small fixes. * Updated docker development documentation * Improved test timings, changed the documentation * Updated docker testing again * Run npm in the frontend directory * Really run npm in the frontend directory * Also run npm in frontend when setting up travis cache * Change directory for one command only * Change default test driver name * CI test change fixes * Fixed syntax error * Added dev check * Trying to fix firefox resizing * Trying to get tests running * Stop resizing firefox * Fixed apple icon spec * fix host in url helpers for omniauth spec * Fix omniauth specs * Fix docs * Small fixes to docker tests * Added package.json back in * Change env variables Co-authored-by: Markus Kahl <machisuji@gmail.com>	4 years ago
ulferts	a842f44bda	[22048] Destroy journals after destroying journalized * clenaup journal data upon aaj model removal * remove unused methods * simplify aaj options handling * delete orphaned journaled data via migration Existing instances might already have journal data for which the journal itself is deleted. This migration removes them.	4 years ago
Oliver Günther	d29266f5bd	[34291] Use placeholder for new resource dates https://community.openproject.com/wp/34291	4 years ago
ulferts	8969afe617	close time entry modal on enter (#8653 ) * close time entry modal on enter As the time entry is saved anyway once the user saves the form, e.g. by pressing enter in the hours field, we can close the whole modal along with it. The "Save" and "Cancel" buttons do not make sense then anymore * attempt to stabilize flickering spec * fix ruby 2.7.1 hash parameter deprecations	4 years ago
ulferts	245a7ddfcf	Fix/duplicate work packages across pages (#8651 ) * deprecated method * remove apparently unused methods * append id desc sorting to work packages * enforce sorting is applied in query results * ensure deterministic order in base query	4 years ago
ulferts	a9dfb35150	avoid modifying frozen string from nil	4 years ago
ulferts	2562bd6475	Fix/bump gems (#8613 ) * bump em-http-request * bump warden * hopefully stabilize flickering spec	4 years ago
ulferts	05c9e3fca6	Feature/default dates for children (#8605 ) * fix start_date expectation based on setting * extract methods * set dates of parent work package * pass parent on form request * have initial dates displayed correctly in wp create form	4 years ago
ulferts	38d2707946	Fix/wp sums in db (#8580 ) * remove apparently unused methods * have specs for wp query sums * grouped sums in sql * sql for total sums * alter interface of all_grouped_sums Since we now fetch all sums in one sql statement it no longer makes sense to fetch the group sums individually * remove now unused method * extract method * Add material_costs to summing * add labor_costs to group sums * add overall costs to sum * fix sum grouping descision * fix summable? check * remove work_package_list_summable_columns setting Now all summable columns are always summed. The user no longer needs to select summing up in the settings. Selecting the column to be displayed and activiating sums will suffice * fix flickering spec	4 years ago
Aleix Suau	5ea357c750	Bump CKEditor5 to v21 (#8570 ) * Bump to v21 * Upgraded to v21, really * Todolist spec fixed * Update fixes for child pages macro * Fix code block conversion Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
Markus Kahl	c1b82bad00	direct uploads to S3 for attachments including IFC models Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
ulferts	3a3a48e267	journalize changes to the scheduling mode	4 years ago
Oliver Günther	dfa6bdb456	Extract all access of APIv3 calls into APIv3Service (#8521 ) * Move apiv3 path helper into apiv3 service * Refactor application to use apiv3 service * Allow caching responses within apiv3 endpoints through state cache * Fix reference to root service * Continue refactoring of DM services * Refactor version DM service * Refactor order service into v3 paths * Replace time entry dm and cache service * Replace QueryFormDmService with nested form resource * Replace QueryDmService with api paths * Replace ProjectDM and ProjectCacheService * Move PayloadDmService into static helper class * Replace NewsDmService with api paths * Replace MembershipDmService with api paths * Replace HelpTextDmService with api paths * Replace ConfigurationDmService with apiv3 path * Replace GridDmService with paths * Remove DmListParameters This is now Apiv3ListParameters type * Replace virtual BoardDmService with a virtual path Boards are not actually their own API resource, but a shallow wrapper over a grid resource. To reuse the same API service pattern, we can allow other resources other than HalResource and make the boards path just reference the grids paths. This allows to nicely use the `apiV3Service.boards.id(..).cache` patterns. * Refactor cacheState into single method * Make HalEditingService a v3 cache without loading ability * Replace usages of WorkPackageCacheService with api-integrated cache * Fix accessing grid subpath * Correctly use schema ensureLoaded before inserting into caches * Fix query not having an ID when updating * Fix npm tests after removal of wp cache * Readd missing path helper for APIv3 used from ckeditor * Correctly save query in widget * Fix watcher tab * Fix search path * Use a promise for the updateImmediately link of time entry * Make apiv3 independent cache services depend on the base cache service We had two cache services now, one base service for the apiv3, and the previous one. Both shared a lot of code, so we can unify them * Don't use multiState getter in schemaCache * Correct loading of schema * Correctly fill state with relations * Don't render comment until workPackage ready * Merge the initial loading observable to get error handling If we only return state.values$(), we never get the initial http observable and thus no error handling * Ensure we reload the default query from the current project if any * Use get() instead of stream * Load types correctly * Fix paths in enterprise token urls * Ensure take(1) in requireAndStream toPromise usage * Avoid duplicate StateCacheService definition * Only use project based query when there is no query.id yet There is no endpoint for /api/v3/projects/:projectIdentifier/queries/:id * Add isAvailable to filter out filters incorrectly added The search component always adds a subproject filter when in project scope. This filter however is only valid/existent in schemas if there is a subproject. This ensures we only try to access filters that are available * Refactor embedded table to reuse the loadQueryFromExisting method We had a few duplicate methods on how to look for a query with params basing on an existing (saved or unsaved) query. * Ensure filter schemas are inserted and checked before use * Better matcher for search spec * Ensure correct initialization of query states * Load attribute help text correctly	4 years ago
Oliver Günther	e80fcfbeac	[33901] Disable the button and disallow editing for scheduled parents https://community.openproject.com/wp/33901	4 years ago
Oliver Günther	3b78c25588	Fix spec expecting for start date to be moved back	4 years ago
ulferts	74fe191997	handle switching from manual to automatic	4 years ago
ulferts	4dc11b7240	handle switching from automatic to manual	4 years ago
ulferts	8805ea74c9	Use combined schema for combined date field Introduces a combined property schema for the combined date field of work packages. To that end, the way the schema is referenced is moved from calling the schema on the HalResource (i.e. work package) to fetching it from the SchemaCacheService. As the backend only provides generic Schema resources for all resources (e.g. TimeEntry, WorkPackage), the difference in behaviour (i.e. determining whether a property is editable is performed within a proxy handler. That handler is applied whenever a schema is fetched from the Service.	4 years ago
ulferts	fdcc89f810	allow freely setting the dates of manually scheduled child work packages	4 years ago
ulferts	c5ead62e0a	adjust contract to allow setting dates on manually scheduled parent wps	4 years ago
ulferts	7065c162fd	disregard manually scheduled nodes when scheduling work package graphs Instead of fetching all work packages from a subset of the whole graph constructed by hierarchy and follows relationships upon scheduling, only work packages eligible for automatic rescheduling are returned. In order to avoid quering the database multiple times, the whole subgraph is returned at once using a recursive CTE.	4 years ago
Oliver Günther	a92575e3ec	Use distinct(*) on aggregated journal to avoid duplicate raw journals https://community.openproject.com/wp/33744	4 years ago
Oliver Günther	c6b9c8ff02	Use distinct(*) on aggregated journal to avoid duplicate raw journals https://community.openproject.com/wp/33744	4 years ago
Oliver Günther	9d327900b9	Correctly collapse the sums together with the group header	4 years ago
Oliver Günther	558bfc5e74	[31617] Re-enable group sums rendering The grouped rows builder excluded rendering of per-groups sums, however the API returned these results anyway. It's easy to just render a sums row as we did before. To that end, I have removed that functionality from the sums row directive and into a generic renderer that can be used with and without angular. https://community.openproject.com/wp/31671	4 years ago
Oliver Günther	45fc54b7e0	Allow jobs to define a title for the job status modal	4 years ago
Behrokh Satarnejad	bf8c775f31	[33109]Arrow next to parent task still shown after removing subtask (#8472 ) * change removeChild function to reload the parent wp * add a ruby test to check the functionality	4 years ago
Behrokh Satarnejad	c42f35cfca	[33685]Number of watchers not shown when opening work package in full screen (through double-click) (#8466 ) * watchers number should be displayed in wp full view * adding a test for showing number of watchers in wp	4 years ago
Oliver Günther	88cb21a594	Fix export spec	4 years ago
Henriette Darge	65af828ff2	Add test case for selecting the same day as start and end date	4 years ago
Henriette Darge	d7b5289681	Add test case for "Today"-Link	4 years ago
Henriette Darge	67a56cca7b	Adapt test to WP date field showing two months in the datepicker modal	4 years ago
Behrokh Satarnejad	5256e8c525	[33457] Date fields of closed work packages are highlighted red (#8446 ) * Highlight only overdue dates of open Work Packages * Highlight only overdue dates of open Work Packages * Add test to highlight overdue finished date only for WP with open status Co-authored-by: Henriette Darge <h.darge@openproject.com>	4 years ago
Oliver Günther	373b673f1a	Replace export modal with job status modal	4 years ago
Henriette Darge	b3dd61946e	[32880] Display scheduling mode in work package view (full, split & table) (#8410 ) * Show icon next to start date depending on the scheduling mode * Show modal when opening date edit fields which shall be able to change the dates and the scheduling mode * Introduce flatpickr as a datepicker for the modal of the dateEditField * Use new datepicker within opDatePickerComponent * Reuse existing Datepicker class for better code abstraction * Set dates only when Instance is ready * Let augmentedDatePicker use generic DatePicker class, too. * Remove jQuery UI datepicker specific styles as they do not apply any more. * Use localized strings in new datepicker * Close datepicker only on click outside * Allow single and multi selection of dates and save changes * Update schedulingMode button correctly && remove unused method * Show combined field for start and end date within the WP single view * Show normal datepicker for most date fields and the modal with the extended datepicker only for startDate * Add datepicker edit field and component helper * Correctly save start and end date * Show correct default value for dateEditFields && Adapt some tests to new datepicker and combined date field * Fix date editor spec * Fix expecting datepicker for start/due date as milestone * Prevent overflow on body by using modal-portal class && make edit input for combinedDates visible again to show something in a create form * Only output one debounced change event for op datepicker * Show combined datepickerModal for dueDate in table, too && save correct scheduling value * Hide modal if the showing component gets destroyed * Correctly check for closed datepicker * Add spec for toggling scheduling mode * Fix setting dates to modal * Avoid too many (unnecessary) close events and use keydown instead * Fix date setting and add custom field date spec * Change layout of combined date picker modal * Switch from a range date picker to a multiple selection in order to be able to set only start or due date && Highlight date field that is changed next * Highlight range manually * Highlight dueDate initially when the user clicked on the due date field && handle special case that one of the values is not set yet. In this case we don't want to keep both values but only the newly clicked. * Move helper functions to own class && Improve the range selection to be able highlight ranges over multiple months && Prevent that a start date > due date can be chosen by setting minDate and maxDate * Adapt test to new way of changing the scheduling mode * Handle case that the user clicks on a already selected date and thus deselects it Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
Oliver Günther	d44389bbdc	Scroll to save button to avoid attachment spec error	5 years ago
Oliver Günther	5678e27e47	[33451] Use baseRoute to navigate to split view https://community.openproject.com/wp/33451	5 years ago
Oliver Günther	740d1e966f	Prevent double 409 conflict form errors after saving the work package Due to the way the changesets are used and cleared, we were causing double posting to the form with an old work package lockVersion: 1. Lock version in changeset correct, editing work package, saving it 2. The EditForm destroys the changeset on submit prior to the work package being updated in state 3. The WPStatusButtonComponent got a call after the changeset was destroyed, resulting in an immediate new changeset being created. 4. The new changeset resulted in the changeset set being fired, which triggered the select edit fields 5. They requested the form post with an older lock version	5 years ago
Henriette Darge	ebc3f6fe18	Prevent that the backend changes the order of filter attributes (sorted by id). Otherwise there is a visible change in the filter attributes in the frontend.	5 years ago
Henriette Darge	fd520f0150	Pass the correct WP to the spent time widget when starting it from the table	5 years ago
Oliver Günther	f0380bb570	[33329] Set parent in changeset to ensure it gets saved https://community.openproject.com/wp/33329	5 years ago
Oliver Günther	ed5e2c186d	Change spec expectation that now calls the service	5 years ago
Henriette Dinger	0286f0979f	Use ruby snake_case instead of camelCase [ci skip]	5 years ago
Henriette Darge	828688ab4b	Show timelogging modal when logging time via the context menu of a WP view (#8320 ) [ci skip]	5 years ago
ulferts	cf735714d3	order independent contains operator (#8315 ) * order independent contains operator This for example affects the search which relies on the subject filter with the contains operator being active. * remove legacy query spec The query is generally covered rather well in the new specs. [ci skip]	5 years ago
ulferts	e5749d9817	order independent contains operator (#8315 ) * order independent contains operator This for example affects the search which relies on the subject filter with the contains operator being active. * remove legacy query spec The query is generally covered rather well in the new specs. [ci skip]	5 years ago

1 2 3 4 5 ...

1010 Commits (e8810ba4339ee654f5fbf20ba6900c6710641bb3)