4245 Commits (e8e798785d61ceecd585edc70d4263518e9cc852)

Author	SHA1	Message	Date
Jens Ulferts	a0c7658c18	only return users eligible for watching but not already watching	8 years ago
Jens Ulferts	ff3ecc9e59	employ sql based user allowed scope for acts as watchable	8 years ago
Jens Ulferts	1ddc142fd3	add sql based query to fetch all users being allowed an action	8 years ago
Jens Ulferts	06c6defa51	replaces ruby based permission check for allowed_to? with sql based query	8 years ago
Oliver Günther	97678334ee	Extend My Account specs	8 years ago
Markus Kahl	1f4a1e1001	updated specs to new integrated add-member functionality	8 years ago
Oliver Günther	ab62a6717b	Fix empty ENV overrides to be parsed as false ... YAML parses '' as false, but empty ENV variables will be passed as that. To mitigate that, we first check for an explicit empty string. To specify specific values, one can use !!str (-> '') or !!null (-> nil) return value if value == ''.	8 years ago
Henriette Dinger	36a3b722ba	Fix broken tests && add more tests	8 years ago
Henriette Dinger	a5e3f3223d	Add possibility to add project specific WP	8 years ago
Henriette Dinger	f0f078b208	Styling of separator in WP menu	8 years ago
Henriette Dinger	3388a64c9d	Add tests for WP top menu && limit visiblity rights	8 years ago
Henriette Dinger	1641335acf	Move code to initializers && remove WP from modules menu	8 years ago
Oliver Günther	98bbee2031	Scroll to textarea controls before clicking them	8 years ago
Markus Kahl	58524d486d	updated membership spec to use group specific calls	8 years ago
Markus Kahl	c51be91aac	updated pagination spec reflecting new order by last name (desc)	8 years ago
Markus Kahl	fa5409ba13	fixed specs mostly	8 years ago
Oliver Günther	65c3ebaa2d	Fix specs	8 years ago
Henriette Dinger	b8b98c13c2	Fix broken spec	8 years ago
Oliver Günther	35fa92c2ff	Fix specs according to title <-> name swap	8 years ago
Oliver Günther	1ff88a823b	Swap and correct WikiMenuItems titles and names ... Previously, the `title` attribute of a WikiMenuItem was used to identify a page that was linked to. With slugs, that makes no sense. We swap the name and title usage so that: 1. Name is used for the wiki_page slug that is being linked to 2. Title is used for the displayed name	8 years ago
Oliver Günther	31f7f3770e	Fix specs	8 years ago
Oliver Günther	48d80c67be	Extend spec when warnOnLeavingUnsaved is false	8 years ago
Oliver Günther	b9b5f4888e	[23746] Fix leaving the page upon editing ... When in an active edit mode: 1. Moving from new/copy to other states wasn't caught by the edit mode alert handler 2. Moving to other (non-angular) pages weren't caught by the edit mode https://community.openproject.com/work_packages/23746	8 years ago
Oliver Günther	9efc17b64c	Fix expected flash notice	8 years ago
Oliver Günther	d891a3606e	Fix selectors on query spec	8 years ago
Oliver Günther	716c7cc32d	Add empty filters spec	8 years ago
Oliver Günther	781c7a257c	Move ContextMenu component	8 years ago
Oliver Günther	091f305f12	[23645] Fix watcher selection (#4726) ... ui-select opens upwards when there's no space left below it. Since the up styling is broken, Instead, we can append it to the body so that the user can scroll towards it and open it correctly.	8 years ago
Henriette Dinger	9427e13576	Fix specs	8 years ago
Markus Kahl	5ab2ea3bf7	Fix incoming field names for use in query (#4725) ... WP [#23713](https://community.openproject.com/work_packages/23713/activity) Fixes the bug and adds a much needed feature spec for the export code to make sure the frontend actually works with the backend here.	8 years ago
Oliver Günther	75344fd9c9	[23696] Fix updating wp resource values from allowedValues (#4717) ... When a form is activated, fields on the work package resource were updated from the form's embedded schema, more precisely, from the allowedValues when these existed. However, they were checked by name instead of the href, which does not exist on most properties. https://community.openproject.com/work_packages/23696	8 years ago
Oliver Günther	7d570595fa	[23697] Remove project-specific version from representer (#4720) ... Grouping versions are performed on their names, not on the project-specific name (e.g., `parent - version` in a subproject where this version is shared with). This causes the group name and row value to differ and cause an error. This commit changes the behavior as before. Grouping instead should be made on a unique identifier (valueLink for non-scalar values) and the grouping should generate a project-specific output so that versions can add the above project-specific name.	8 years ago
Oliver Günther	43fab7884a	Titles no longer need to be unique ... Since the slug is now the unique identifier for the page, we can avoid title conflicts by letting the slug determine unique records.	8 years ago
Oliver Günther	e8904a4f76	Clarify slug duplicate in spec	8 years ago
Oliver Günther	556f5072f0	Fix specs	8 years ago
Oliver Günther	f13226eb7a	Scope unique slugs per wiki_id	8 years ago
Oliver Günther	c5acedb1eb	Let text_formatter write the slug as a link	8 years ago
Oliver Günther	9a34fe27c7	Migrate wiki titles to URL slugs ... Wiki titles in 6.0 can contain ANY character, which is causing issues for specific characters processed by textile and CGI-escaped before we can actually parse wiki links. To mitigate the issue of linking space/underscored wiki pages, introduce a permalink URL based on the title and create a migration to move old underscored titles (e.g., `base_de_donées` to spaced titles `base de donées`).	8 years ago
Oliver Günther	37c3bfab21	Unload work package activity after save	8 years ago
Oliver Günther	95c1167071	Fix announcement flash type	8 years ago
Oliver Günther	616ec628b5	Rewrite with_setting specs ... And fix tests that do not expect settings to be cached during the request with RequestStore.	8 years ago
Oliver Günther	4353953605	Improve stored settings as a whole ... Currently, settings are cached on a per-name basis, but that cache is expired everytime *any* attribute is written. Even when a week-old attribute is still valid, its cache is expired as soon another setting is updated due to the max settings cache key. Instead of caching a single attribute, I suggest to cache the entire settings (the total number with plugins is less than 120 and 4KiB in size) and retrieve and deserialize a single value from that hash. That saves us the time to: 1. Locating a single element from database 2. Instantiate a setting object just for deserializing 3. Requesting settings several times by using RequestStore	8 years ago
Henriette Dinger	99e5853a15	Fix broken specs	8 years ago
Jens Ulferts	b3a21283c7	replace the rendering of a hash by a specific WorkPackageSumRepresenter ... That way, the sums follow the general implementation schema and plugins are able to customize displaying the sums.	8 years ago
Markus Kahl	494e97b4bd	made spec more robust dropping redundant steps	8 years ago
Oliver Günther	2f4919cbe5	[23615] Show error response when user is not allowed to create WPs (#4687)	8 years ago
Markus Kahl	a66c86ca60	regression tests for form configuration bugs	8 years ago
ulferts	f043409330	adhere to notification settings when notifying about added watcher (#4683) ... The PR will let the users added as watchers be notified according to their settings. Especially https://community.openproject.com/work_packages/22636/activity should be fixed by it. Unfortunately, the #notify_about method on User is not reusable here for all cases as it would have to be adjusted to fit the requirements. But that method is used for a couple of use cases and I did not want to alter it shortly before a release. The method looks weird, though as e.g. the watchers are not taken into account for 'only_my_events' which reads 'Only for things I watch or I am involved in'. Additionally, it does not care for the self_notified? setting.	8 years ago
Oliver Günther	550763ae46	Do not 'inherit' priority from children ... This removes updating of priority values from children to parent work packages.	8 years ago
ulferts	6a3496d26e	prevent editing a work package while saving takes place (#4658) ... Otherwise, especially in IE with their custom change handler for select boxes, it was possible to make a change, trigger saving and while saving takes place, change another attribute and change that. Only the first change would work while the second would fail because of optimistic locking.	8 years ago