1086 Commits (ed23d6eb7f09647b65e9d4a3765e0e0d9af3e5f1)

Author	SHA1	Message	Date
Tim Habermaas	ed23d6eb7f	Fix links from work packages table to fullscreen view.	9 years ago
Stefan Botzenhart	cdcc630d1e	Tmp fix css for subject inplace edit to display type and subject inline	9 years ago
Tim Habermaas	d8fd523ec6	Fix broken /projects/:id/work_packages/:id URL. ... This also fixes some inconsistencies with sidebar rendering when reloading the page.	9 years ago
Tim Habermaas	e06c4736ed	Attempt to make inline editing of work package subject work	9 years ago
Tim Habermaas	cafccc7761	Make @houndci happy.	9 years ago
Tim Habermaas	2c59f10735	Make actions menu work on show page.	9 years ago
Tim Habermaas	a742b1d298	Use new icons for split view toolbar.	9 years ago
Tim Habermaas	b7da944446	Add missing semicolons.	9 years ago
Tim Habermaas	390de18d1a	Order toolbar buttons according to screen design.	9 years ago
Tim Habermaas	d6b4d1618a	Add watch icon to angular work package show view.	9 years ago
Tim Habermaas	fb66c6c807	Make create_new work package view work when no type is set.	9 years ago
Tim Habermaas	728d410ff7	Use correct icon for fullscreen button.	9 years ago
Tim Habermaas	056ce056dd	Add edit button to Angular show view.	9 years ago
Tim Habermaas	b1c754b1e6	Make creating work packages from show view work.	9 years ago
Tim Habermaas	4b810e40e7	Preserve query parameters when switching to fullscreen view.	9 years ago
Tim Habermaas	f89bd45095	Change layout of workpackage title on show view.	9 years ago
Tim Habermaas	0e3bf33603	Fix markup.	9 years ago
Tim Habermaas	92c7968ff3	Add colon after work package subject in header.	9 years ago
Tim Habermaas	98a9633b76	Redirect user to default tab when landing on work package show page.	9 years ago
Simon Wiesmayr	de1a5b0263	Fix split-view styling issues	9 years ago
Tim Habermaas	19155c8ed8	Fix undefined errors on show page.	9 years ago
Tim Habermaas	44624eb3cd	Fix switching back to list view from fullscreen view.	9 years ago
Tim Habermaas	93475fba1b	Move Angular's WorkPackage show view to /work_packages/:id.	9 years ago
Tim Habermaas	e5fceb38be	Fix non-camelcased name. ... Thanks, @houndci.	9 years ago
Tim Habermaas	b3e431ce85	Fix buttons for switching between views on WorkPackage show page.	9 years ago
Tim Habermaas	4d19852d1c	Fix listing of attributes on fullscreen WorkPackage page.	9 years ago
Tim Habermaas	bc5df6e051	Point work package link from table to new angular show view.	9 years ago
Tim Habermaas	3d9b7266b3	Add fullscreen view for WorkPackage.	9 years ago
Oliver Günther	e88deb8556	Fix errors when editing comments ... This addressed an invalid event handler that causes a TypeError within jQuery and corrects a scoping error that leads to comments being updated with their original/unchanged texts. Relevant work package: https://community.openproject.org/work_packages/21578	9 years ago
Jens Ulferts	4bfc4cc8b2	sort versions case insensitive	9 years ago
Jens Ulferts	38cc9ff716	remove outdated comment	9 years ago
Oliver Günther	73769e5684	Restyling inplace-controls ... This commit restyles the inplace control buttons (save, send, cancel) according to the visual.	9 years ago
Oliver Günther	d5a3b21049	Scroll to element only when visible ... Introduces a simple helper plugin to determine whether an element is `visible()`.	9 years ago
Oliver Günther	de96916dac	Minor corrections ... This commit addresses the following minor corrections from review: 1. Remove constant URI: It breaks karma, and I can't really tell why 2. Avoid using Object.values Appeared to be supported by chrome, but causes the protractor failure. This also switches the ordering to binary (unshift, push) as that's all we need for now. 3. Remove location.hash when jumping to element `$location.hash` may take precedence over `scrollIntoView` ocassionaly, thus we forcefully remove the location hash when updating the work package on a particular field 4. Avoid showing comment success when empty When opening the comment field, and then submitting on another field with comment being empty and open, the comment was not submitted, but a successful comment notification was still sent. 5. Fix issues for IE 10+ * Force min-height to be set on the element, as IE tends to return 0 as height when empty 6. Misc. * Avoid undefined in comment text * Avoid resizing [msd-elastic] textareas * Rename `add_journal` to `create_journal` Correct wrong bracket for reject function	9 years ago
Oliver Günther	7f602664fc	Allow focussing an element after work package has been updated ... This commit allows comments or fields to specify a callback after the work package has been updated. This is currently used to scroll to the element (such as the inserted comment), whenever the work package has loaded.	9 years ago
Oliver Günther	9bd4e06d29	Use promises in submitFields methods to defer updating ... As submitting comments and fields in one go requires work packages to be submitted first, we can use promises to ease the processing of each and abort early, e.g., when the WP couldn't be updated, we don't want to submit the comment.	9 years ago
Oliver Günther	d1a1020097	Workaround for focus event on user activity ... It seems that the user activity doesn't correctly handle blur events. I do not know why, but to provide a workaround, I've forced setting the focus for the quote and edit buttons.	9 years ago
Oliver Günther	8da4ac0d63	Restore empty description submit	9 years ago
Oliver Günther	c3589353cb	Scroll to textarea controls when editing and space available	9 years ago
Oliver Günther	7cd7697fab	Replace autogrow with angular-elastic ... angular-elastic provides us with an option to always insert an additional newline to provide smoother animations. This also changes animations to CSS rather than `jQuery.animate`.	9 years ago
Henriette Dinger	27c60cf667	Incorporate review feedback ... * Notification when comment is created * Better binding to editing comments * Quote with inserted text fixed	9 years ago
Oliver Günther	3ca36e1e1d	Parallel sending of comment and fields in WP split view ... Parallel submitting of comments alongside WP edits wasn't possible natively due to the increased lock_version in work packages, caused by `touch`ing and explicitly saving the work package in the process of adding a journal. This commit works around this issue by updating the timestamp columns directly, bypassing optimistic locking in the work package table. This allows comments to be submitted transparently with other fields to the user, while actually, we send it in two subsequent steps.	9 years ago
Oliver Günther	5732eee3d3	Propagate and distribute field and comment submits in WP Field Service ... This commit allows parallel saving of comments and fields, however this currently results in a conflicting modification due to two saves with thes same lock version.	9 years ago
Oliver Günther	51509e6b34	Editing of comments with in-place button styles and preview ... This commit changes the comment edit and cancel buttons to reflect the in-place editing style. Also allows previewing of edited comments and also shows a notification-box when comments are edited.	9 years ago
Oliver Günther	0883cf9834	Replace exclusive-edit with transcluded comment directive ... This commit removes the somewhat superfluous exlusiveEditController in favor of event-based passing of quoted text to the correct comment field. The comment directive now decides for itself whether it wants to be placed above or below the activities and uses transclusion for that purpose. Editing comments is now no longer exlusive, but that shouldn't be necessary anyway.	9 years ago
Oliver Günther	3b5518e8db	Fix invalid ng-show on comments ... With multiple `ng-show`, the latter element will be selected, even when its hidden. This causes the quote button to (appear to) malfunction when sorting descending. HUGE props to @ulferts for finding that one.	9 years ago
Oliver Günther	0aed8bb310	Test for comment input	9 years ago
Oliver Günther	3bfad28db0	Correct comment behavior with optional notifications ... This allows submitting comments with and without notification for the created journal. Using hyperagent resource on activities, the resource `addComment` is replaced when executing `fetch` on the link. This breaks subsequent comment requests. This is fixed by requesting manually on the resource link using `$http`. This commit also provides the functionality required to comment with or without notification propagation, and changes the backend to comply to the APIv3 specification, which defines comments to be sent as a JSON `{ comment: { raw: 'my comment' } }`. This commit also provides: * Displaying the comment input on overview depending on sort setting * Disable inplace controls when comment is empty * correctly hiding the comment based on link availability	9 years ago
Oliver Günther	f589f565a6	Correct height when expanding inplace textareas with autogrow ... When using `.-autogrow` on textareas in inplace edit (e.g., description), the height is not correctly set as the selector is not visible. Only when starting to EDIT the textarea, the changes are being picked up and height is set correctly. This commit thus provides a second event listener to `focusin` events that cause the textareas to resize properly.	9 years ago
Oliver Günther	e168258e42	Remove replaced activity_comment	9 years ago