81 Commits (ef8a0a5c5f1db27c510e3ac7108055416097a388)

Author	SHA1	Message	Date
Jens Ulferts	cbbd7ea6e5	apply eager loading to work_packages#activities	9 years ago
Jens Ulferts	f59bbe4008	only need the user_id not the user.id	9 years ago
Oliver Günther	de96916dac	Minor corrections ... This commit addresses the following minor corrections from review: 1. Remove constant URI: It breaks karma, and I can't really tell why 2. Avoid using Object.values Appeared to be supported by chrome, but causes the protractor failure. This also switches the ordering to binary (unshift, push) as that's all we need for now. 3. Remove location.hash when jumping to element `$location.hash` may take precedence over `scrollIntoView` ocassionaly, thus we forcefully remove the location hash when updating the work package on a particular field 4. Avoid showing comment success when empty When opening the comment field, and then submitting on another field with comment being empty and open, the comment was not submitted, but a successful comment notification was still sent. 5. Fix issues for IE 10+ * Force min-height to be set on the element, as IE tends to return 0 as height when empty 6. Misc. * Avoid undefined in comment text * Avoid resizing [msd-elastic] textareas * Rename `add_journal` to `create_journal` Correct wrong bracket for reject function	9 years ago
Oliver Günther	3ca36e1e1d	Parallel sending of comment and fields in WP split view ... Parallel submitting of comments alongside WP edits wasn't possible natively due to the increased lock_version in work packages, caused by `touch`ing and explicitly saving the work package in the process of adding a journal. This commit works around this issue by updating the timestamp columns directly, bypassing optimistic locking in the work package table. This allows comments to be submitted transparently with other fields to the user, while actually, we send it in two subsequent steps.	9 years ago
Oliver Günther	3bfad28db0	Correct comment behavior with optional notifications ... This allows submitting comments with and without notification for the created journal. Using hyperagent resource on activities, the resource `addComment` is replaced when executing `fetch` on the link. This breaks subsequent comment requests. This is fixed by requesting manually on the resource link using `$http`. This commit also provides the functionality required to comment with or without notification propagation, and changes the backend to comply to the APIv3 specification, which defines comments to be sent as a JSON `{ comment: { raw: 'my comment' } }`. This commit also provides: * Displaying the comment input on overview depending on sort setting * Disable inplace controls when comment is empty * correctly hiding the comment based on link availability	9 years ago
Jan Sandbrink	6e9ed008fb	Enforce passing of current_user into representers ... Thereby permission checks will no longer silently fail if no user was passed. This uncovered a lot of places where we actually expected a user to be passed, when it wasn't. This was especially true for collections. The basic idea is, that virtually all representers could change their behaviour based on the current user. Representers where this is not the case (e.g. Digest), can still explicitly opt-out.	9 years ago
Jan Sandbrink	5de0f15898	Correctly link activities ... - they might not be embedded - create an endpoint for activities - document it properly - adapt angular client	9 years ago
Jan Sandbrink	3d49831bfd	extract activities by WP into own endpoint	9 years ago
Jan Sandbrink	f8f2d644ee	fix update link	9 years ago
Jan Sandbrink	563cb3c5c7	migrate APIv3 to aggregated journals ... - turns out agrgegated journals needed more features - turns out specs were incomplete and bogus	9 years ago
Jan Sandbrink	dcd2a3b03c	rework error instantiation ... - multiple errors are no longer a special case of specific errors - there is a separate error class to represent multiple API errors - convert ActiveRecord errors to API errors in a single place, ideally work with API errors from there on	9 years ago
Jan Sandbrink	025f3f589e	remove side effect from Validation.create ... I just don't know what the original author thought...	9 years ago
Alex Coles	a6212fb304	Fix syntax (w/Rubocop) in lib code ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alexander Bach	517540e730	Remove activity self link title	10 years ago
Alexander Bach	866ab1a5e5	Use implicit getter	10 years ago
Alexander Bach	bbd46ef8bd	Unify activity path declaration	10 years ago
Alexander Bach	3bd5f81921	Fix broken activity self_link	10 years ago
Alexander Bach	e75f0a49a3	Fix activity user	10 years ago
Alexander Bach	bd9520d964	Bring activity_representer in line with the others	10 years ago
Alexander Bach	866be8d800	Remove activity self link title	10 years ago
Alexander Bach	310c344bec	Use implicit getter	10 years ago
Alexander Bach	b2c194838c	Unify activity path declaration	10 years ago
Alexander Bach	5480a835d7	Fix broken activity self_link	10 years ago
Alexander Bach	ed137f9af7	Fix activity user	10 years ago
Alexander Bach	226401c2e8	Bring activity_representer in line with the others	10 years ago
Jan Sandbrink	900b2a4c45	Backporting APIv3 categories to OP 4.0 ... Backport was neccessary to implement missing categories filter without adding more technical debt. These changes will be merged into 4.1 and following branches and vanish in that merge (merge-strategy "ours") YOU SHOULD NOT SEE ANY CONTENTS FROM THIS COMMIT ANYWHERE AFTER 4.0.x! This commit was built from the commits of the GitHub-PR mentioned below, as well as some code dependencies for that. The GitHub-PR was https://github.com/opf/openproject/pull/2505	10 years ago
Jan Sandbrink	b1ba33c75b	specify classes explicitly rather than implicitly ... This is a new try for the APIv3 classes, we either: - FULLY qualify a class and let the autoloader do the rest - don't qualify at all, but require the class explicitly Thus we do not (yet) completely give up on the rails autoloader, but we circumvent a fair amount of its magic (and problems). The hope is to eliminate the following problems in development mode: - NameErrors because the autoloader infers the wrong prefix - "object is not missing constant" errors occuring more rarely Let's see how that turns out to work...	10 years ago
Jan Sandbrink	f0863f9d53	allow to patch existing API endpoints	10 years ago
Jan Sandbrink	a72ea0d5af	more consequently use route_param ... this seems to be the GRAPE-iest way possible	10 years ago
Jan Sandbrink	788a4a2d83	formaTTable	10 years ago
Jan Sandbrink	857acb2380	use common representer for formatables ... - can be set to a specific formatting (e.g. when the backend does not yet use renderers, but the API is specified as formatable) - will use the currently selected formatting of the Instance by default	10 years ago
Jan Sandbrink	83a42d82b9	fix auto loading of DateTimeFormatter during dev ... Apparantly the rails autoloader gets confused by trying to load a class from an included module. We can help it, by explicitly referencing (thus loading) the fully qualified class name first... I wish there was a better solution, but I couldn't find one...	10 years ago
Jan Sandbrink	c6323dbc10	refactor output of dates and times ... - all (?) APIv3 resources now use a common formatter - all APIv3 resources now use common names for "createdAt" and "updatedAt" - existing tests were adapted when they were wrong before (according to specs) - no unit tests for common formatter extracted yet	10 years ago
Jens Ulferts	45403ea044	quick fix for macro rendering in api	10 years ago
Alex Coles	e0191e759c	Update year in copyright header to 2015 ... [ci skip]	10 years ago
Hagen Schink	7605b37575	Make activity details a list of formattables	10 years ago
Hagen Schink	e86c6b7da7	Make activity comment a formattable	10 years ago
Hagen Schink	4337ea1a70	Fix activities error handling	10 years ago
Hagen Schink	746f7cce74	Use API V3's path helper	10 years ago
Hagen Schink	6ec63bc9af	Update reform and its dependencies	10 years ago
Hagen Schink	af6c037d6f	Fix missing link_to helper in API	10 years ago
Hagen Schink	0d215fb543	Apply code conventions	10 years ago
Hagen Schink	db8bfba3af	Remove usage of reform from API V3	10 years ago
Alex Coles	45297523c2	Fix syntax (w/Rubocop) in lib code ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	e7400af52a	Use 1.9+ Hash syntax in lib code ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Hagen Schink	7d2728bbd5	Use representer to render errors	10 years ago
Hagen Schink	578eea817b	Implement API V3 error handling according to the specs	10 years ago
Alex Coles	47b57c576c	Use paths instead of URLs in Resource links ... See specification commit: 7f40188581 Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Jens Ulferts	f758aabfb1	uses gravatar_image_tag gem as standard avatar lib	10 years ago
Alex Coles	92e8384266	Add missing Copyright headers in lib (API) code ... [ci skip] Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago