openproject

Commit Graph

Author	SHA1	Message	Date
Oliver Günther	1c20fbc99d	[24539] Respect project_id identifier in search links	8 years ago
Jens Ulferts	54e0aab55f	linting	8 years ago
Jan Sandbrink	f36a4d3576	Move visibility check into a scope of query	8 years ago
Markus Kahl	69bf799b72	use OpenProject text formatting	8 years ago
Jens Ulferts	1bb3631bd6	fix estimated time filters Because estimatedTime is turned to estimatated_hours by the PropertyNameConverter, checking whether work package responds to estimated_hours.pluralize only to return estimated_hours_id does not make sense. That behaviour was introduced to cope with the watcher attribute which should have been turned into watcher_ids as watchers is a has_many relations. But when that behaviour was fixed to work correctly with estimated_hours again, so that the name converter returns estimated_hours (no foreign key) and watcher_ids (foreign key) the watcher bug had to be fixed all over again. For turning work package filter parameters from the external to the internal representation, the v3 now makes use of the same method, as employed by the experimental api	8 years ago
Markus Kahl	d8b44d0ebd	new settings: email_login, registration_footer localised text setting cell used in settings for registration footer; also used cell for email header and footer with a slight change in that there are now 2 language select boxes there	8 years ago
Oliver Günther	4defd2c933	Add autohide feature to Rails notifications	8 years ago
Oliver Günther	bb2d9247e7	Fix reference to start/due date in calendar widget This should resolve the following error. ``` F, [2016-11-10T10:20:20.121294 #15771] FATAL -- : ActionView::Template::Error (Mysql2::Error: Column 'start_date' in where clause is ambiguous: SELECT DISTINCT `work_packages`.`id` AS t0_r0, `work_packages`.`type_id` AS t0_r1, `work_packages`.`project_id` AS t0_r2, `work_packages`.`subject` AS t0_r3, `work_packages`.`description` AS t0_r4, `work_packages`.`due_date` AS t0_r5, `work_packages`.`category_id` AS t0_r6, `work_packages`.`status_id` AS t0_r7, `work_packages`.`assigned_to_id` AS t0_r8, `work_packages`.`priority_id` AS t0_r9, `work_packages`.`fixed_version_id` AS t0_r10, `work_packages`.`author_id` AS t0_r11, `work_packages`.`lock_version` AS t0_r12, `work_packages`.`done_ratio` AS t0_r13, `work_packages`.`estimated_hours` AS t0_r14, `work_packages`.`created_at` AS t0_r15, `work_packages`.`updated_at` AS t0_r16, `work_packages`.`start_date` AS t0_r17, `work_packages`.`parent_id` AS t0_r18, `work_packages`.`responsible_id` AS t0_r19, `work_packages`.`root_id` AS t0_r20, `work_packages`.`lft` AS t0_r21, `work_packages`.`rgt` AS t0_r22, `work_packages`.`position` AS t0_r23, `work_packages`.`story_points` AS t0_r24, `work_packages`.`remaining_hours` AS t0_r25, `work_packages`.`cost_object_id` AS t0_r26, `projects`.`id` AS t1_r0, `projects`.`name` AS t1_r1, `projects`.`description` AS t1_r2, `projects`.`is_public` AS t1_r3, `projects`.`parent_id` AS t1_r4, `projects`.`created_on` AS t1_r5, `projects`.`updated_on` AS t1_r6, `projects`.`identifier` AS t1_r7, `projects`.`status` AS t1_r8, `projects`.`lft` AS t1_r9, `projects`.`rgt` AS t1_r10, `projects`.`project_type_id` AS t1_r11, `projects`.`responsible_id` AS t1_r12, `projects`.`work_packages_responsible_id` AS t1_r13, `types`.`id` AS t2_r0, `types`.`name` AS t2_r1, `types`.`position` AS t2_r2, `types`.`is_in_roadmap` AS t2_r3, `types`.`in_aggregation` AS t2_r4, `types`.`is_milestone` AS t2_r5, `types`.`is_default` AS t2_r6, `types`.`color_id` AS t2_r7, `types`.`created_at` AS t2_r8, `types`.`updated_at` AS t2_r9, `types`.`is_standard` AS t2_r10, `types`.`attribute_visibility` AS t2_r11, `enumerations`.`id` AS t3_r0, `enumerations`.`name` AS t3_r1, `enumerations`.`position` AS t3_r2, `enumerations`.`is_default` AS t3_r3, `enumerations`.`type` AS t3_r4, `enumerations`.`active` AS t3_r5, `enumerations`.`project_id` AS t3_r6, `enumerations`.`parent_id` AS t3_r7, `users`.`id` AS t4_r0, `users`.`login` AS t4_r1, `users`.`firstname` AS t4_r2, `users`.`lastname` AS t4_r3, `users`.`mail` AS t4_r4, `users`.`admin` AS t4_r5, `users`.`status` AS t4_r6, `users`.`last_login_on` AS t4_r7, `users`.`language` AS t4_r8, `users`.`auth_source_id` AS t4_r9, `users`.`created_on` AS t4_r10, `users`.`updated_on` AS t4_r11, `users`.`type` AS t4_r12, `users`.`identity_url` AS t4_r13, `users`.`terms_accepted` AS t4_r14, `users`.`force_password_reset` AS t4_r15, `users`.`failed_login_count` AS t4_r16, `users`.`last_failed_login_on` AS t4_r17, `users`.`guarantor_id` AS t4_r18, `users`.`mail_notification` AS t4_r19, `users`.`verified_phone` AS t4_r20, `users`.`unverified_phone` AS t4_r21, `users`.`first_login` AS t4_r22, `users`.`default_otp_channel` AS t4_r23, `users`.`force_password_change` AS t4_r24 FROM `work_packages` INNER JOIN `projects` ON `projects`.`id` = `work_packages`.`project_id` LEFT OUTER JOIN `types` ON `types`.`id` = `work_packages`.`type_id` LEFT OUTER JOIN `enumerations` ON `enumerations`.`id` = `work_packages`.`priority_id` AND `enumerations`.`type` IN ('IssuePriority') LEFT OUTER JOIN `users` ON `users`.`id` = `work_packages`.`assigned_to_id` LEFT OUTER JOIN `members` ON `projects`.`id` = `members`.`project_id` AND `members`.`user_id` = 1238 AND `projects`.`status` = 1 INNER JOIN `enabled_modules` ON `projects`.`id` = `enabled_modules`.`project_id` AND `enabled_modules`.`name` IN ('work_package_tracking') AND `projects`.`status` = 1 LEFT OUTER JOIN `role_assignment_intervals` ON `role_assignment_intervals`.`assignment_id` = `members`.`id` AND `role_assignment_intervals`.`assignment_type` = 'Member' INNER JOIN `role_permissions` ON `role_permissions`.`permission` IN ('view_work_packages') INNER JOIN `roles` `permission_roles` ON `permission_roles`.`id` = `role_permissions`.`role_id` LEFT OUTER JOIN `member_roles` ON `members`.`id` = `member_roles`.`member_id` LEFT OUTER JOIN `roles` `assigned_roles` ON `assigned_roles`.`id` = `permission_roles`.`id` AND `projects`.`status` = 1 AND ((`assigned_roles`.`id` = `member_roles`.`role_id` AND (`role_assignment_intervals`.`start_date` <= '2016-11-10' AND `role_assignment_intervals`.`end_date` >= '2016-11-10' OR `role_assignment_intervals`.`id` IS NULL)) OR `projects`.`is_public` = 1 AND `assigned_roles`.`builtin` = 1 AND (`member_roles`.`id` IS NULL OR (`role_assignment_intervals`.`start_date` > '2016-11-10' OR `role_assignment_intervals`.`end_date` < '2016-11-10'))) WHERE (`assigned_roles`.`id` IS NOT NULL) AND `work_packages`.`project_id` IN (2364, 2733, 582, 107, 1089, 470, 1120, 2358, 2618, 2517, 2519, 3054, 3572, 1324, 755, 838, 1238, 2544, 2506, 1943, 3698, 1267, 658, 813, 583, 601, 662, 702, 2725, 3737, 3024, 4747, 3877, 4148, 2588, 3533, 547, 2158, 4361, 6, 2063, 4208, 1560, 1156, 4516, 429, 18, 671) AND ((start_date>='2016-11-06' and start_date<='2016-11-12') or (due_date>='2016-11-06' and due_date<='2016-11-12'))): F, [2016-11-10T10:20:20.122062 #15771] FATAL -- : 37: </h3> F, [2016-11-10T10:20:20.122165 #15771] FATAL -- : 38: F, [2016-11-10T10:20:20.122344 #15771] FATAL -- : 39: <% calendar = Redmine::Helpers::Calendar.new(Date.today, current_language, :week) F, [2016-11-10T10:20:20.122475 #15771] FATAL -- : 40: calendar.events = calendar_items(calendar.startdt, calendar.enddt) %> F, [2016-11-10T10:20:20.122614 #15771] FATAL -- : 41: F, [2016-11-10T10:20:20.122728 #15771] FATAL -- : 42: <%= render partial: 'common/calendar', locals: {calendar: calendar } %> F, [2016-11-10T10:20:20.122837 #15771] FATAL -- : F, [2016-11-10T10:20:20.122952 #15771] FATAL -- : lib/redmine/helpers/calendar.rb:62:in `group_by' F, [2016-11-10T10:20:20.123029 #15771] FATAL -- : lib/redmine/helpers/calendar.rb:62:in `events=' F, [2016-11-10T10:20:20.123109 #15771] FATAL -- : app/views/my/blocks/_calendar.html.erb:40:in `_app_views_my_blocks__calendar_html_erb___758049655330408328_70034164793520' F, [2016-11-10T10:20:20.123185 #15771] FATAL -- : app/views/my/_block_container.html.erb:8:in `block in _app_views_my__block_container_html_erb___3995601020402966656_70034165158760' F, [2016-11-10T10:20:20.123272 #15771] FATAL -- : app/views/my/_block_container.html.erb:2:in `each' F, [2016-11-10T10:20:20.123346 #15771] FATAL -- : app/views/my/_block_container.html.erb:2:in `_app_views_my__block_container_html_erb___3995601020402966656_70034165158760' F, [2016-11-10T10:20:20.123380 #15771] FATAL -- : app/views/my/page.html.erb:41:in `_app_views_my_page_html_erb___1448889474268617509_70034165467820' F, [2016-11-10T10:20:20.123410 #15771] FATAL -- : app/controllers/my_controller.rb:71:in `index' F, [2016-11-10T10:20:20.123439 #15771] FATAL -- : app/middleware/reset_current_user.rb:47:in `call' ```	8 years ago
Oliver Günther	1939b69c20	Explicitly serialize query filters This avoids exposing data in the session table when `active_record_store` is used.	8 years ago
Markus Kahl	86ab55b323	update type attribute visibility on cf changes cf = custom field	8 years ago
Oliver Günther	9a0f9555c0	[24173] Add simple override to decide when to show the onboarding modal	8 years ago
Jens Ulferts	1a597e180b	first step towards generalizing the query and its filters	8 years ago
Jens Ulferts	533cbdd033	formatting	8 years ago
Henriette Dinger	d2d9a3ec12	Remove obselete info from add button part two	8 years ago
Oliver Günther	8391a9c0d2	Use PermittedParams to allow search parameters	8 years ago
Oliver Günther	16afe96224	Remove unwhitelisted references to params in url_for	8 years ago
Oliver Günther	117dfa4e2d	Legacy: Fix functional projects controller spec	8 years ago
Jens Ulferts	339d1025ee	rely on url_for to fill in request's parameters on sort urls	8 years ago
Jens Ulferts	84e86b22b5	rely on url_for to fill in request's parameters on calendar url	8 years ago
Jens Ulferts	24e285f05e	do not provide params explicilty - use those sanitized by rails We used to pass in the params but rails will already provide the missing parameters in url_for. And those that are provided are sanitized.	8 years ago
Oliver Günther	e6c4b12c58	Permit params in back_url Rails 5 requires whitelisted params when using them in `url_for`. We might want to consider rewriting this part instead.	8 years ago
Oliver Günther	0f6c644b9e	WIP	8 years ago
Markus Kahl	0e54c5fcf6	fix lost grouping in exports; added regression test	8 years ago
Oliver Günther	7ecad5e0ca	Make global setting for password confirmation Implements a check to request password confirmation only when: 1. `Setting.internal_password_confirmation` is set 2. The user is internally authenticated (`user.uses_external_authentication?` is false) [ci skip]	8 years ago
Markus Kahl	90868bd579	moved status options module to more appropriate place	8 years ago
Markus Kahl	cd53ae9090	refactoring to tidy up user status helper	8 years ago
Markus Kahl	492bbcd068	refactor user filter to allow impermanent memberships integration	8 years ago
Markus Kahl	6bb59c69d7	pass plain columns to sort_collection to be able to join conditionally	8 years ago
Markus Kahl	d9101386f6	final rubocop remarks	8 years ago
Markus Kahl	35c5a69e6c	rubocop remarks	8 years ago
Markus Kahl	b55b682805	enhanced member screen; members and user table refactoring using cells	8 years ago
Oliver Günther	c4b682ed0d	[23739] Avoid empty filters to raise error When not passing `params[:f]`, the current query implementation fails with an error due to the V3 conversion.	8 years ago
Markus Kahl	5ab2ea3bf7	Fix incoming field names for use in query (#4725 ) WP [#23713](https://community.openproject.com/work_packages/23713/activity) Fixes the bug and adds a much needed feature spec for the export code to make sure the frontend actually works with the backend here.	8 years ago
Oliver Günther	7312ed1d6f	Remove `pretty_title` since that won't matter now.	8 years ago
Henriette Dinger	b9ca06e1d7	Change icons and title arguments (#4637 ) This changes the icons of the repo legend. Now every action has its own icon and a title which describes the action. Thus the screenreader reads the file and the action that was done. https://community.openproject.com/work_packages/23399/	8 years ago
Jens Ulferts	54587235d5	add href attribute to turn an anchor into a valid hyperlink	8 years ago
Markus Kahl	1044723c43	Fix: date visibility settings (#4602 ) * fixed type date update/view * view spec for form configuration form * view spec => feature spec * types helper refactoring	8 years ago
ulferts	3b1976a5aa	Fix/accessible pre and suffix (#4601 ) * accessible form pre- and suffix Both pre- and suffix are attributes with aria-hidden="true". This should lead to them no longer being read out of context. In order to have them read when appropriate, the prefix is turned into a part of the label which is hidden for sighted users. The suffix is referenced in the form element via aria-describedby. * extract method refactoring	8 years ago
Oliver Günther	9f3c36eb1a	Fix project spec	8 years ago
Oliver Günther	983dba10bb	Add simple link_to_function replacement	8 years ago
Oliver Günther	911ec386a7	Start removing prototype implementations	8 years ago
Henriette Dinger	8dbe8d553d	[23522] Design errors in wiki "Change parent" page (#4584 ) * Fix styling issues with 'change parent' select box * Refactor method to enable array instead of string	9 years ago
Oliver Günther	8fb84e38f3	Load accessibility styles within default Otherwise, variables within won't be overriden. For this end, dynamically add a body class rather than loading the stylesheet separately.	9 years ago
Markus Kahl	a260f6dc0d	return nil if no column name parameter present	9 years ago
Markus Kahl	8bc34b31dd	fixed query column name mapping	9 years ago
ulferts	1d99206232	Fix/accessible error messages (#4529 ) * add error messages to each field * move role=alert up so that success messages are also covered * remove focus code from notification-box directive The box does not need to be focused as it has the role=alert which will lead to it being read out. * remove specific focusing behaviour for accessibility mode The mode was introduced to present error messages to user requiring assistive technology e.g. screen readers. By setting role=alert on the error fields and additionally labeling the fields with the errors, this should no longer be necessary	9 years ago
Jens Ulferts	6af269aa55	extract into service and fix date bug Creates the type_service hierarchy which contains updating/creating types and handles special the visible_attributes. Also fixes visible_attributes for the "date"/"start_date"/"due_date" fields which may or may not be valid based on whether the type is a milestone	9 years ago
Jens Ulferts	7fa26e79c3	avoid n+1 queries	9 years ago
Oliver Günther	32b289cfee	Let Homescreen use the same static links	9 years ago
Markus Kahl	f64d06638c	hide hidden fields even if they have a value (#4408 ) * Make test/dev assets settings explit * description must not be customizable * updated feature help text * fields with default values can be hidden * fixed hide condition * fixed edit wp spec (required cf) for some reason factories initialize custom fields with '' (empty string) as default values. The API interprets this as a default value being present. In normal operation a custom field without a default value will return nil, not the empty string	9 years ago

... 3 4 5 6 7 ...

1789 Commits (efe3f33132225f5d1f3eda9ab2730a59a313fd07)