openproject

Commit Graph

Author	SHA1	Message	Date
ulferts	1bdd2ab9ae	safe automatic fixes by rubocop (#8994 )	4 years ago
ulferts	6140f4c7e9	update copyright to 2021 (#8925 ) Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded. Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013	4 years ago
ulferts	9e2287bfcc	rename and inflect according to zeitwerk	5 years ago
Henriette Dinger	bd7f4e4814	Update copyright notice	5 years ago
Henriette Dinger	cbc530ca9d	Move project_settings_path to ApplicationHelper to be globally available and start adapting tests to new structure	5 years ago
Oliver Günther	183ad1480e	Replace deprecated controller success? with succesful?	6 years ago
Oliver Günther	059770f533	FactoryGirl => FactoryBot Removes the deprecation	7 years ago
Oliver Günther	8c477e5860	Fix more project settings related specs	7 years ago
Oliver Günther	8fb1c1573d	Fix repo tests due to changes repo_path	7 years ago
Oliver Günther	6ef4211e77	Bump copyright to 2018 (#6171 ) [ci skip]	7 years ago
Oliver Günther	26dff6132e	Remove default route (#6137 ) * Remove default route * Fix and clean legacy specs * Fix specs * Fix missing ID in request parameters in view specs https://stackoverflow.com/a/21789313 * Fix more invalid routes in specs * Pass parameter to omniauth spec * Add required ID parameter to types controller * Fix invalid omniauth URL * Fix project_id params in repository controller spec * Fix missing project id in projects controller spec * Fix missing params and failure url for omniauth * Fix invalid route name * Temporarily skip broken specs on dev [ci skip]	7 years ago
ulferts	c0b709530c	Fix/replace deprecations (#5533 ) * replace alias_method_chain * remove deprecation silencing * bump controller-testing * introduce permitted params for settings * replace various deprecations in controllers * remove deprecation silencing for legacy_specs * remove `puts` from spec * replace deprecated access to errors * remove unnecessary AR::Parameters usage in spec * specify error to expect * replace deprecations * replace deprecated action calls in legacy function specs * replace deprecations in functional controller tests * replace deprecations in controllers/controller_specs * remove params parser which does not seem to be in effect It is registered for the content type :exclude which makes no sense as it should deal with :json. The desired behaviour of the api dealing with parsing errors is working with or without the code. * replace deprecations in unit specs * replace alias_method_chain [ci skip]	7 years ago
ulferts	520815956d	preserve params when redirecting for login on repository (#5671 ) [ci skip]	7 years ago
Oliver Günther	7cf11bb689	Update copyright notice	8 years ago
Oliver Günther	92aebdcec4	Fix params deprecation Fixes in spec/controllers: ``` DEPRECATION WARNING: ActionController::TestCase HTTP request methods will accept only keyword arguments in future Rails versions. ```	8 years ago
Jens Ulferts	cf8b2c568e	ActionController::Parameter no longer is a hash	8 years ago
Oliver Günther	8fd75e0456	Extend Subversion repository with UTF-8 paths (#4326 ) Provide some test data for UTF-8 encoded paths with Subversion. This confirms the tests of PR #4324. Side note: OS X will decompose some unicode characters into two characters. For example, the LATIN SMALL LETTER O WITH DIAERESIS (U+00F6 `ö`) will be decomposed into o and COMBINING DIAERESIS (U+0308). This obviously breaks SVN path mapping and while you will be able to commit files with decomposed paths, it will wreak havoc when using these characters on repositories manipulated by OSX and other systems. It apepars that Windows, Linux silently ignore these changes. We can't really account for this server side, but unicode-path patches exists for Subversion on OSX. For git, a config setting exists that does just that (`core.precomposeunicode`).	9 years ago
Oliver Günther	1f66b19112	Fix double escaping of repository path params	9 years ago
Oliver Günther	396dcdd859	Add path-based checkout for SVN	9 years ago
Oliver Günther	d36c7d6591	Fix committers array access When adding a new committer to a repository, the user collection was `compact!`ed, which no longer exists on relations with Rails 4+. Thanks to @gehasia for spotting and proposing a fix for the bug.	9 years ago
Stefan Botzenhart	1c01b5801e	Use login_as helper method throughout all specs	9 years ago
Oliver Günther	ef322e89dd	Cleanup	9 years ago
Oliver Günther	3fce1d6f2e	Added service and controller specs	9 years ago
Oliver Günther	b15002beca	More explicit validation error message for repositories Adds a specific message for repository validation from enabled SCM Fixes missed venodor keys in specs	9 years ago
Oliver Günther	a71ce6f1a5	Refactor SCM config to lowercase / symbols ENV-based configuration for various configs can only provide case-insensitive values for SCM configuration and thus is unable to properly configure, e.g., managed repositories. This refactoring relies on lowercase configuration and symbols to define SCM vendors, and camelizes them to the old notation (e.g., :git => 'Git') when using `Setting.enabled_scms` to remain compatible with previous installations.	9 years ago
Oliver Günther	9336cff8bb	Extended specs This commit adds / extends the following specs: RepositoriesController: Ensure empty repository page is shown for empty repositories adapters/subversion: Test correct use of --login, --password arguments	9 years ago
Oliver Günther	caf5e4a706	Formatting and clean up	9 years ago
Oliver Günther	c5b200d7a0	Review corrections - Remove repositories paths using project.id instead of `project_id` - Allow managed repositories to be unlinked in the instance (But doesn't remove repository directory). - Remove leftover settings partial	9 years ago
Oliver Günther	e1bdb41bcd	More complete specs wrt. coverage, cleanup	9 years ago
Oliver Günther	1e8c873544	Remove filesystem adapter This commit removes the entire FileSystem repository and adapter. It rids all specs (core and legacy) of remaining uses of this adpater and replaces it with a temporary subversion repository, where necessary. We also need to remove remaining filesystem instances from the database, otherwise users will receive errors when accessing said repositories on the Frontend. This does not destroy any data on filesystem, but database information on the repositories (remarks) are lost.	9 years ago
Oliver Günther	05b27c1b98	Asynchronous creation, deletion of repositories from OP. This PR begins the push towards management of repository lifetime from within OpenProject. What this currently provides is the following: - A mixin `ManageableRepository`, included by `Repository::{Git, Subversion}` to provide an interface to repo management - Two services and delayed_job workers for creating (`CreateManagedRepositoryService`) and deleting (`DeleteRepositoryService`) - Customized rendering of subforms in the repository settings for arbitrary SCM vendors. TODOS: - [x] Provide sane ground to work on ( cf. PR #3149 ) - [x] Rework SCM settings form (`{scm}_tags` is currently HTML generated from within a Helper.) - [x] Ease integration of arbitrary SCM vendors - [x] Display meaningful error / warning when user looks at bare repository (currently outputs 500, as Git HEAD / svn revision is not available) - [x] I18n - [ ] Specs (in progress) - [x] Fix legacy specs - [ ] Decide what to do with `Filesystem` adapter. Open Questions: - Configuration: Currently replaces the existing options in `configuration.yml`. - Implementation specifics: - Sub-projects repositories reside in a hierarchy below their parents - How should the delayed_job react upon failure? (esp. creation of repositories) Relevant work package: https://community.openproject.org/work_packages/20416 Merge dependent on PR #3149	9 years ago
Jens Ulferts	b37ea687e2	showing error messages on scm updates	10 years ago
Jens Ulferts	fce72938e3	prevent path traversal via filesystem scm Setting up a filesystem scm now requires to specify a whitelist via the configuration	10 years ago
Alex Coles	e0191e759c	Update year in copyright header to 2015 [ci skip]	10 years ago
Alex Coles	5afc11f19e	Fix syntax (w/Rubocop) in specs Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	03978767be	Use 1.9+ Hash syntax in specs Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	e137ed8135	Convert specs to RSpec 2.99.0 syntax with Transpec This conversion is done by Transpec 2.3.1 with the following command: transpec * 72 conversions from: describe 'some controller' { } to: describe 'some controller', :type => :controller { } * 57 conversions from: describe 'some model' { } to: describe 'some model', :type => :model { } * 49 conversions from: describe 'some view' { } to: describe 'some view', :type => :view { } * 34 conversions from: obj.should to: expect(obj).to * 27 conversions from: describe 'some routing' { } to: describe 'some routing', :type => :routing { } * 8 conversions from: describe 'some feature' { } to: describe 'some feature', :type => :feature { } * 7 conversions from: describe 'some helper' { } to: describe 'some helper', :type => :helper { } * 5 conversions from: be_true to: be_truthy * 5 conversions from: describe 'some request' { } to: describe 'some request', :type => :request { } * 2 conversions from: obj.should_receive(:message) to: expect(obj).to receive(:message) * 2 conversions from: obj.stub(:message) to: allow(obj).to receive(:message) * 1 conversion from: before { example } to: before { \|example\| example } * 1 conversion from: describe 'some mailer' { } to: describe 'some mailer', :type => :mailer { } For more details: https://github.com/yujinakayama/transpec#supported-conversions	11 years ago
Alex Coles	0bdbdcac35	Convert specs to RSpec 2.14.8 syntax with Transpec This conversion is done by Transpec 1.10.4 with the following command: transpec * 1414 conversions from: obj.should to: expect(obj).to * 646 conversions from: == expected to: eq(expected) * 376 conversions from: obj.stub(:message) to: allow(obj).to receive(:message) * 107 conversions from: obj.should_not to: expect(obj).not_to * 70 conversions from: obj.should_receive(:message) to: expect(obj).to receive(:message) * 45 conversions from: =~ [1, 2] to: match_array([1, 2]) * 27 conversions from: lambda { }.should to: expect { }.to * 13 conversions from: Klass.any_instance.stub(:message) to: allow_any_instance_of(Klass).to receive(:message) * 8 conversions from: === expected to: be === expected * 7 conversions from: expect { }.not_to raise_error(SpecificErrorClass) to: expect { }.not_to raise_error * 6 conversions from: =~ /pattern/ to: match(/pattern/) * 2 conversions from: obj.should_not_receive(:message) to: expect(obj).not_to receive(:message) * 1 conversion from: < expected to: be < expected * 1 conversion from: obj.stub!(:message) to: allow(obj).to receive(:message) * 1 conversion from: stub('something') to: double('something')	11 years ago
Johannes Wollert	8b096975fe	updates copyright headers updates more copyright more copyright headers	11 years ago
Jens Ulferts	dc98efb5ac	fixes route globbing for repositories	11 years ago
Philipp Tessenow	a1e67dd460	new copyright header #1903	11 years ago
Michael Frister	774be9fc43	Don't embed commits per author graph for unauthorized users	11 years ago
Michael Frister	a9d2520b00	Deny access to repository commit author stats for unauthorized users	11 years ago

45 Commits (f1b30c547f2bac8e347a340c5ee4af344a077fad)