openproject

Commit Graph

Author	SHA1	Message	Date
ulferts	d90d47e6b6	Feature/user invite from members for non admins (#9244 ) * users having manage_user can add users from member administration * linting and typo correction	4 years ago
Oliver Günther	6dc662b1e4	[36243][30226] Different avatars for placeholders and groups (#9169 ) * Fix members autocompleter to allow hrefs * Add rendering of different avatar types * Remove unused code in backend avatar rendering * Add very basic test that the avatar gets customized per type * Allow avatar rendering in the CreateAutocompleter * Restructure avatars into BEM css * Remove avatar-classes in favor of passing size from backend * Remove to avoid confusion We use tracking with both href and , and was introduced to avoid a property called href to be overridden, but that was never a problem before. So from now we can safely use .href * Fix broken principal avatar in user activity * Ensure filters get updated even if the form is not reloaded There was a bug in conditionallyLoadForm that checked the property of link (always undefined) and would thus always reload a form. What we actually need is a form that gets reloaded only when the query link changes, but still update services from the updated query, such as filters * Adapt specs to changes classes * Rename op-principal-avatar to op-avatar	4 years ago
ulferts	9fa5599392	Feature/member notifications (#8958 ) * spec with correctly scoped links * move db check into own file - fix deprecation * basic spec for member creation service * use constants for all notifications * send an OP notification after member has been created * send an OP notification after member has been updated * mails on group member added Depending on whether the membership existed before or not, an updated or a created notification is send. This is done asynchronously. * move all mail sender background jobs into namespace * wip * wip * correct handling group member notifications * add setting enable/disable mail sending on member alterations * use services in members controller * move Notifiable to OpenProject * remove member after save hooks * cleanup/testing/linting * render member mails in receiver locale * remove add_member! method * use mailer layout for all mailers * Update app/services/groups/cleanup_inherited_roles_service.rb Co-authored-by: Oliver Günther <mail@oliverguenther.de> * use around callback to avoid prepending * handle nil params Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
schuemann	b577ed62ec	[#36518 ] respect hide mail preference in member list (#9072 ) * [#36518] respect hide mail preference in member list The member table should hide the email address if the user has the "Hide my email address" box checked in their profile. * [#36518] respect hide mail preference in member list Updating feature spec * Updating feature spec * Add transient preference object * Include preference to avoid n+1 query * Correctly pass user_id= to super * Fix now invalid usages of user_preference factory * Rewrite attribute check to include user attribute_present? does not return true for relations such as user_id * Only save a preference if the transient factory got used Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
ulferts	1bdd2ab9ae	safe automatic fixes by rubocop (#8994 )	4 years ago
Oliver Günther	cdf3cf4c34	[36136] Rework members page to show name and avatars for principals (#8973 ) * Rewrite members page to output name column * Remove white-space nowrap for long login names in administration * Extend member specs * Allow query instance to be used in table cell * Fix memberships specs with changed columns * Add order for email * Review feedback * Allow x to close add member form * WIP sort firstname/lastname * Make status sortable * Extract order_by_name into the order class * Re-add but deprecate order_by_name It's still in use in combination with some special scopes (custom actions for example) that I don't want to remove right now * Rewrite order_by_name into scope	4 years ago
Oliver Günther	2cde433326	Remove usages of AnyFixture (#8987 ) AnyFixture will create once instance of a factory for reuse in a number of specs. This will work fine until we require a clean slate for a specific example. As we have numerous tests that test like the database is empty, we get a number of disadvantages: - After an example with `with_clean_fixture` metadata, the fixture will only be regenerated after the next example that uses it. This means the order of execution will change the number of objects in the DB. - The more `with_clean_fixture` we have, the smaller the performance advantage of AnyFixture will result in. - You cannot use an AnyFixture in a spec that needs a clean slate. This should be obvious but was overlooked by myself.	4 years ago
ulferts	5ea185ef66	Placeholder user project members (#8961 ) * remove intermediate placeholder scope Doing so, placeholder users will begin to show up in the system * remove scope without value * extract scope * use enum for status * allow placeholder users to become project members * display placeholder user member on members widget * remove now superfluous method The status name can simply be queried via #status now * replace possible_assignees/responsibles on project This also leads to placeholder users becoming eligible as assignees and responsibles. * fix aggregated scope on bulk edit * linting * remove IssueHelper	4 years ago
Cyril Rohr	b4086b2968	Standalone CI docker container (#8943 )	4 years ago
ulferts	6140f4c7e9	update copyright to 2021 (#8925 ) Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded. Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013	4 years ago
Oliver Günther	e4dcc6c5ea	Avoid usage of `users <<` pattern in group This will no longer trigger the addition	5 years ago
Oliver Günther	53f2d694ff	Use AnyFixtures to generate fixtures from factories (#7230 ) Uses FactoryBot to keep and maintain specific records in a special transaction that does not get removed after each spec. They automatically are created whenever first hitting them. This makes an excellent time saver for items that are commonly used, such as an admin user account	5 years ago
Oliver Günther	3c9d32018d	Avoid RoutingError to break spec because missing avatar	5 years ago
Henriette Dinger	ebc8719fc6	Add members autocompleter to replace selcect2 with ngSelect	5 years ago
Henriette Dinger	bd7f4e4814	Update copyright notice	5 years ago
ulferts	a93ecca5a8	Feature/members api show (#7308 ) * basic members collection response * complete member index end point * document versions#index * remove user association from members There is already a more generic principals association. Having both causes confusion and leads to duplicate loading of models * linting * remove disabled test * add members#show api end point * add project and principal to member representer * replace member.user reference with principal * use principal reference in project members association * modernize roles api * complete member representer rendering * replace remnants of user association * add member schema api endpoint * have dedicated available projects end point for versions * linting * limit roles to assignable ones in schema * rename member to membership in api * remove remnants of user in member * spec fixes * use available_projects endpoint in versions board * add eager loading to memberships#index * members create form api endpoint * ensure role exists for default assignment * extract switch for users/groups to work_packages representer * document membership create form * add l10n expected in specs * strengthen the usage of a delete base service * use base class for set attributes service * fix alias in service * add create endpoint to members api * document members create endpoint * linting * adapt to altered service signature * use default endpoint for wp#get * use CF infused representer [ci skip]	6 years ago
Oliver Günther	70e2393f6a	[29611] Remove members group sort by https://community.openproject.com/wp/29611	6 years ago
Henriette Dinger	ec7627e0e7	Add migration to remove impaired column from database	6 years ago
Henriette Dinger	be30a7c302	Remove accessibility switch from columns modal and project menu	6 years ago
Oliver Günther	059770f533	FactoryGirl => FactoryBot Removes the deprecation	7 years ago
Oliver Günther	72cf7e2fb4	Update secure_headers	7 years ago
Oliver Günther	1b29f38c06	Fix most of the specs does not yet address the CSP problem of user memberships	7 years ago
Oliver Günther	6ef4211e77	Bump copyright to 2018 (#6171 ) [ci skip]	7 years ago
Oliver Günther	97f7c3a592	[26298] re-add filtering by mail through special filters (#5915 ) https://community.openproject.com/wp/26298 [ci skip]	7 years ago
Oliver Günther	aa802968cb	[26099] Default to 'all' status filter (#5852 ) https://community.openproject.com/wp/26099 [ci skip]	7 years ago
ulferts	daa1a4d4b7	fixes filtering members by group (#5800 ) additionally fixes: * with "all" selected, all members are shown, not only those being active, invited or registered * with "locked" selected, locked users are now displayed. * the Project#members_principals associations lacked the `references` method which lead to the users table being undefined in the resulting query. In order to achive the bug fixes, the member filtering is now based on the query engine also used for users, queries, work_packages, ... As a lot of the members filters are very similar to user filters (in fact, a lot of the members filter work on the users model), those filters are shared via modules. [ci skip]	7 years ago
Oliver Günther	7cf11bb689	Update copyright notice	8 years ago
Markus Kahl	d1e55e1622	fixed specs (filter changes do not apply automatically anymore)	8 years ago
Henriette Dinger	c30da3e640	Fix broken specs	8 years ago
Markus Kahl	1f4a1e1001	updated specs to new integrated add-member functionality	8 years ago
Markus Kahl	c51be91aac	updated pagination spec reflecting new order by last name (desc)	8 years ago
Markus Kahl	fa5409ba13	fixed specs mostly	8 years ago
Markus Kahl	0abc54d5ab	don't fail invitation on long email addresses	9 years ago
Markus Kahl	4bc8365075	don't fail invitation on long email addresses	9 years ago
Stefan Botzenhart	b7572f1416	Remove spec for missing role as we always have one Changing the behaviour to a single select without blank option removes the option of not submitting a role.	9 years ago
Peter Lehwess	5c316baf29	Fix a grammar error for my/page dashboard	9 years ago
Markus Kahl	71b327f5db	invite user feature including regression test for #21789	9 years ago
Markus Kahl	8d2d8e3c5f	adapted specs to reflect latest i18n change	9 years ago
Markus Kahl	24941f3b74	simplified page module structure	9 years ago
Markus Kahl	1319e1fe34	extracted member's roles feature spec from cuke fixed bug while at it (no error message when choosing no role)	9 years ago
Markus Kahl	1883f8a60c	fixed members/pagination feature (as spec)	9 years ago
Markus Kahl	56e94fb01f	fixed members/members feature (as spec) - dropped cuke - replaced with feature spec - DRY'd the heck out of the cuke (shared_examples ftw?)	9 years ago
Markus Kahl	5c3241ee50	fixed error messages feature (as feature spec) - dropped cuke - fixed a bug inviting Anonymous when no user selected - dropped obsolete test	9 years ago

41 Commits (f1b30c547f2bac8e347a340c5ee4af344a077fad)