openproject

Commit Graph

Author	SHA1	Message	Date
Oliver Günther	5956ede030	[37107] render tabs in component (#9236 ) * Render work package tabs in one component * Move standard tabs into tab service * Move tab-count styles mostly into its own component style * Fix frontend specs * Remove unused texts * Fix routing to split view from button * Fix context menu not opening the tabbed view * Fix watcher tab counter not receiving an rxjs subscription * Fix selector * Fix clicking on relation link to fullscreen * Make WP tabs an instance of scrollable-tabs * Convert the tabs from .tabrow to its own BEM block * Refactor other usages of tabrow into op-tab-row * Fix frontend specs * Make wp modal tabs use scrollable-tabs * Fix disabled tab selectors * Restore scrollability of tabs * Fix import and change detection of graph modal * Fix selector in wp relations spec * Rename tab-count to match component style * Remove narrow style * Fix bem modifier style * Fix styles of scrollable tabs * Fix tab for time entry autocompleter	4 years ago
Oliver Günther	2cde433326	Remove usages of AnyFixture (#8987 ) AnyFixture will create once instance of a factory for reuse in a number of specs. This will work fine until we require a clean slate for a specific example. As we have numerous tests that test like the database is empty, we get a number of disadvantages: - After an example with `with_clean_fixture` metadata, the fixture will only be regenerated after the next example that uses it. This means the order of execution will change the number of objects in the DB. - The more `with_clean_fixture` we have, the smaller the performance advantage of AnyFixture will result in. - You cannot use an AnyFixture in a spec that needs a clean slate. This should be obvious but was overlooked by myself.	4 years ago
Cyril Rohr	b4086b2968	Standalone CI docker container (#8943 )	4 years ago
ulferts	6140f4c7e9	update copyright to 2021 (#8925 ) Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded. Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013	4 years ago
ulferts	5a7176e6e1	Fix/search for projects (#8815 ) * fix searching for projects * only provide search options active in the project	4 years ago
Behrokh Satarnejad	c92c750625	[30242] Extend work package autocompleter with more useful information (#8554 ) * WP auto completer changes in global search box * resolve the travis check errors	4 years ago
Oliver Günther	dfa6bdb456	Extract all access of APIv3 calls into APIv3Service (#8521 ) * Move apiv3 path helper into apiv3 service * Refactor application to use apiv3 service * Allow caching responses within apiv3 endpoints through state cache * Fix reference to root service * Continue refactoring of DM services * Refactor version DM service * Refactor order service into v3 paths * Replace time entry dm and cache service * Replace QueryFormDmService with nested form resource * Replace QueryDmService with api paths * Replace ProjectDM and ProjectCacheService * Move PayloadDmService into static helper class * Replace NewsDmService with api paths * Replace MembershipDmService with api paths * Replace HelpTextDmService with api paths * Replace ConfigurationDmService with apiv3 path * Replace GridDmService with paths * Remove DmListParameters This is now Apiv3ListParameters type * Replace virtual BoardDmService with a virtual path Boards are not actually their own API resource, but a shallow wrapper over a grid resource. To reuse the same API service pattern, we can allow other resources other than HalResource and make the boards path just reference the grids paths. This allows to nicely use the `apiV3Service.boards.id(..).cache` patterns. * Refactor cacheState into single method * Make HalEditingService a v3 cache without loading ability * Replace usages of WorkPackageCacheService with api-integrated cache * Fix accessing grid subpath * Correctly use schema ensureLoaded before inserting into caches * Fix query not having an ID when updating * Fix npm tests after removal of wp cache * Readd missing path helper for APIv3 used from ckeditor * Correctly save query in widget * Fix watcher tab * Fix search path * Use a promise for the updateImmediately link of time entry * Make apiv3 independent cache services depend on the base cache service We had two cache services now, one base service for the apiv3, and the previous one. Both shared a lot of code, so we can unify them * Don't use multiState getter in schemaCache * Correct loading of schema * Correctly fill state with relations * Don't render comment until workPackage ready * Merge the initial loading observable to get error handling If we only return state.values$(), we never get the initial http observable and thus no error handling * Ensure we reload the default query from the current project if any * Use get() instead of stream * Load types correctly * Fix paths in enterprise token urls * Ensure take(1) in requireAndStream toPromise usage * Avoid duplicate StateCacheService definition * Only use project based query when there is no query.id yet There is no endpoint for /api/v3/projects/:projectIdentifier/queries/:id * Add isAvailable to filter out filters incorrectly added The search component always adds a subproject filter when in project scope. This filter however is only valid/existent in schemas if there is a subproject. This ensures we only try to access filters that are available * Refactor embedded table to reuse the loadQueryFromExisting method We had a few duplicate methods on how to look for a query with params basing on an existing (saved or unsaved) query. * Ensure filter schemas are inserted and checked before use * Better matcher for search spec * Ensure correct initialization of query states * Load attribute help text correctly	4 years ago
Oliver Günther	53f2d694ff	Use AnyFixtures to generate fixtures from factories (#7230 ) Uses FactoryBot to keep and maintain specific records in a special transaction that does not get removed after each spec. They automatically are created whenever first hitting them. This makes an excellent time saver for items that are commonly used, such as an admin user account	5 years ago
ulferts	006d2cae9a	mark correct item	5 years ago
ulferts	26c1ca5d15	remove search filter properly if no text is provided Otherwise, the filter will silently be active still and will be transmitted together with the visible filters	5 years ago
ulferts	571e01bfa2	speedup search spec	5 years ago
Oliver Günther	7b56b1c886	[32354] Correctly escape filters in frontend to avoid unescape The filters were not correctly escaped in the frontend, causing special query characters such as & to break to search. https://community.openproject.com/wp/32354	5 years ago
Henriette Dinger	bd7f4e4814	Update copyright notice	5 years ago
ulferts	8d35a9b5f0	rely on api for configuration instead of gon Replaces all configuration fields currently supported by the api to be fetched from the api instead of from gon. Reduces the information passed to gon. Only the date/time format fields are left for gon to pass as those are not yet available via the api. Adding the fields should be easy.	5 years ago
Oliver Günther	22a4533cf6	Ignore modifier-clicked links	5 years ago
Wieland Lindenthal	1e3fe98640	Respect custom field attributes "is_filter" and "searchable" within the SearchFilter	5 years ago
Wieland Lindenthal	83c72b549b	Let Global search also search within custom fields of type string or text.	5 years ago
Oliver Günther	3c3f44e75f	Better waiting for search spec (#7133 ) [ci skip]	6 years ago
Oliver Günther	0e7d2db15f	Add spec for status action board	6 years ago
Inga Mai	1e99cfcd5e	Search bug fixed: Enter before results loaded	6 years ago
Wieland Lindenthal	964d764bd3	Ensure that filters that according to the loaded form are not available will never be rendered.	6 years ago
Wieland Lindenthal	d9b28b7b86	Hopefully fix flaky spec on Travis.	6 years ago
Wieland Lindenthal	f8356677c5	Adopt integration test search_spec.rb for ngSelect	6 years ago
Wieland Lindenthal	27183c5909	I don't know how to make that part more robust. I remove that spec for now.	6 years ago
Wieland Lindenthal	7ac00698d7	Add more solidity to feature spec	6 years ago
Wieland Lindenthal	f24180dad5	Make search_spec more robust.	6 years ago
Wieland Lindenthal	3922c854a8	Fix spec for travis: some extra wait time for updating the work packages search result table	6 years ago
Wieland Lindenthal	c0a3912f2a	Test advanced filters of global search	6 years ago
Wieland Lindenthal	7485d28de1	Fix feature spec to reflect new global search autocompleter options for selecting project scope.	6 years ago
Wieland Lindenthal	a26af74f9f	Make global search autocmpleter spec more robust as you cannot trust that WP IDs start at 1	6 years ago
Wieland Lindenthal	ec5aa78b6e	resolve conflict	6 years ago
Wieland Lindenthal	262d47ec25	fix spec	6 years ago
Wieland Lindenthal	00f365eaeb	Make global search autocmpleter spec more robust as you cannot trust that WP IDs start at 1	6 years ago
Oliver Günther	0b0afb2bae	Wait longer for search result [ci skip]	6 years ago
Wieland Lindenthal	b060d83412	Feature/29218/search autocompleter (#6942 ) * Search autocompletion on work package subjects * cleaning up * Add status dot to autocompleter results * Add feature test for global search autocomplete * fix: remove update at from suggestions * Style search autocompleter results * fix: loading animation position * Extend search autocompletion to also search on work package IDs, too, allowing even the hash sign (#) to prefix an ID. * Move stop spinning into a separate method. * increase delay for search autocomplete * Travis debugging: reverse order of expectations * Travis: fix specs for search autocomplete * Fix spec for search auto completer * Ensure WP highlighting is always loaded, when needed. * fix spacing between animated bars of loading indicator [ci skip]	6 years ago
Oliver Günther	059770f533	FactoryGirl => FactoryBot Removes the deprecation	7 years ago
Oliver Günther	6ef4211e77	Bump copyright to 2018 (#6171 ) [ci skip]	7 years ago
Oliver Günther	c8ef6e1a4d	Strengthen specs (Try #2 ) (#5686 ) * Don't use expect in retry_block It doesn't raise an exception, but only marks the example erroneous * Replace textile_link cuke * Replace wp search cuke with existing spec We only need to test for the href, no need to check that the page exists. * Also remove pagination cuke, its part of the search-spec [ci skip]	8 years ago
Oliver Günther	7cf11bb689	Update copyright notice	8 years ago
Oliver Günther	1c20fbc99d	[24539] Respect project_id identifier in search links	8 years ago
Markus Kahl	d45b359d55	use query	8 years ago
Markus Kahl	91b2645460	fixed pagination	8 years ago
Jan Sandbrink	c03e1cfee9	replace deprecated :response calls by :rendered	9 years ago
Alex Coles	e0191e759c	Update year in copyright header to 2015 [ci skip]	10 years ago
Alex Coles	5afc11f19e	Fix syntax (w/Rubocop) in specs Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	03978767be	Use 1.9+ Hash syntax in specs Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	e137ed8135	Convert specs to RSpec 2.99.0 syntax with Transpec This conversion is done by Transpec 2.3.1 with the following command: transpec * 72 conversions from: describe 'some controller' { } to: describe 'some controller', :type => :controller { } * 57 conversions from: describe 'some model' { } to: describe 'some model', :type => :model { } * 49 conversions from: describe 'some view' { } to: describe 'some view', :type => :view { } * 34 conversions from: obj.should to: expect(obj).to * 27 conversions from: describe 'some routing' { } to: describe 'some routing', :type => :routing { } * 8 conversions from: describe 'some feature' { } to: describe 'some feature', :type => :feature { } * 7 conversions from: describe 'some helper' { } to: describe 'some helper', :type => :helper { } * 5 conversions from: be_true to: be_truthy * 5 conversions from: describe 'some request' { } to: describe 'some request', :type => :request { } * 2 conversions from: obj.should_receive(:message) to: expect(obj).to receive(:message) * 2 conversions from: obj.stub(:message) to: allow(obj).to receive(:message) * 1 conversion from: before { example } to: before { \|example\| example } * 1 conversion from: describe 'some mailer' { } to: describe 'some mailer', :type => :mailer { } For more details: https://github.com/yujinakayama/transpec#supported-conversions	11 years ago
Alex Coles	0bdbdcac35	Convert specs to RSpec 2.14.8 syntax with Transpec This conversion is done by Transpec 1.10.4 with the following command: transpec * 1414 conversions from: obj.should to: expect(obj).to * 646 conversions from: == expected to: eq(expected) * 376 conversions from: obj.stub(:message) to: allow(obj).to receive(:message) * 107 conversions from: obj.should_not to: expect(obj).not_to * 70 conversions from: obj.should_receive(:message) to: expect(obj).to receive(:message) * 45 conversions from: =~ [1, 2] to: match_array([1, 2]) * 27 conversions from: lambda { }.should to: expect { }.to * 13 conversions from: Klass.any_instance.stub(:message) to: allow_any_instance_of(Klass).to receive(:message) * 8 conversions from: === expected to: be === expected * 7 conversions from: expect { }.not_to raise_error(SpecificErrorClass) to: expect { }.not_to raise_error * 6 conversions from: =~ /pattern/ to: match(/pattern/) * 2 conversions from: obj.should_not_receive(:message) to: expect(obj).not_to receive(:message) * 1 conversion from: < expected to: be < expected * 1 conversion from: obj.stub!(:message) to: allow(obj).to receive(:message) * 1 conversion from: stub('something') to: double('something')	11 years ago
Johannes Wollert	8b096975fe	updates copyright headers updates more copyright more copyright headers	11 years ago
Philipp Tessenow	a1e67dd460	new copyright header #1903	11 years ago

46 Commits (f1e2035895772401f4e470746fa26e0179c51b81)