openproject

Commit Graph

Author	SHA1	Message	Date
Oliver Günther	aca68c92b6	Basic accessibility for inline-create row This commit: 1. Allows entering the inline-create mode by keyboard 2. Allows cancelling by x button with keyboard 3. Re-focuses the inline-create button when cancelling creation	9 years ago
Oliver Günther	78dc9548f3	[Bugfix] Work package grouping header (#4360 ) * Refactor how table grouping is applied and refreshed Currently, changes to groupBy causes the work package to be immediately refreshed before the actual groups are collected from the backend. This watch has been removed, since its unneeded. The work package table is now tracked by the row id and the current group, which causes the ng-repeat to re-evaluate when the group changes, thus fixing the group header bug. Additionally, we now carry the groupByColumn in the wpTableService, where the other grouping values are derived as well. * Allow nil aggregation group This should fix https://community.openproject.com/work_packages/22816/activity * Hide empty group header when groupName not defined This avoids showing an empty header for inline create row. Also forces the create button to disappear when the table is explictly refreshed (e.g., when grouping on another attribute).	9 years ago
Oliver Günther	5d51594b81	Show table even when empty (#4362 )	9 years ago
Alex Dik	116c4ec5c1	Refactor WP filter related components (#4348 ) * Implement WP filter button directive * Tidy up the WP inline create button controller * Reformat WP list route code * Move Filter model to components * Move filter constants to filters component directory * Move query filters directive * Move query filter directive * Add filter container directive Vote furinvader for less copy pasta! * Refactor filter visibility code * Move filters helper * Move query model service * Make the query service a part of the filters module * Remove getFilterCount test from WP list controller * Fix query model module import * Fix karma tests Importing Angular modules within the test files is not possible yet. * Move filter visibility to a dedicated service * Get rid of the FiltersHelper service	9 years ago
Oliver Günther	d34c89ee94	Preselect values of new work package from filter values (#4355 ) This allows to assign default values for new work packages from the current query filter. Due to the incompatibility in APIexperimental query filters APIv3 values, this link is made solely for the types assignees and types.	9 years ago
Oliver Günther	42cb4a7a78	Show inline-create in global work package list (#4340 ) When no project context is available, this fetches the `available_projects` endpoint and suggests using the first project for creating a new row.	9 years ago
Oliver Günther	02cf2b0efe	[22851] Table Inline Create (#4290 ) * Move the WP create button to the WP buttons directory * Move the keepTab service to the wp-panels directory * Move angular module definitions into separate file * Move the WP create button into a separate file * Use TS in WP create button directive * Refactor the WP create button controller * Move the has-context-menu directive to the components directory * Refactor has-context-menu item focus * Create new button directive and place in table * Export and use wpButton module * Add title to form properties * Add -new modifier to new work package rows * Add WP inline create directive * Reduce error widths to cell span * Save or update work package conditionally * Mark work package as new * Implement the WP inline create button * Style button correctly * Decide when to activate the field for new WPs * Remove padding on -new row * Avoid animation on added -new rows * Avoid writing title when passed from new workPackage * Remove jqMigrate warning * Avoid animations for newly added rows * Add cancel button to inline create row * Track new work packages by custom id If we don't track new work packages, ng-animate will freak out due to the track by expression. We thus track work packages by setting a custom id set from the current date. * Disable focus on errors outside accessibility mode * Add inline create cancel context menu * Conditionally set focus on fields Set focus on the first active field	9 years ago
HDinger	d6413d18c6	[21808] [Accessibility] Make wp view mode buttons accessible * Make list view button focusable by tab * Don't use 'disabled' as attribute	9 years ago
Henriette Dinger	d984153f35	Set `disabled` value for better accessability with screen reader	9 years ago
Alex Dik	da969b615c	Refactor loadingIndicator service	9 years ago
Alex Dik	3328e495ae	Implement list view button	9 years ago
Alex Dik	bc9f610bd6	Implement WP show view button directive	9 years ago
Alex Dik	b0bc521474	Implement WP details view button directive	9 years ago
Alex Dik	daf88a52f4	Implement keepTab service Intendet to replace the latestTab controller dependency.	9 years ago
Alex Dik	6e3b67f04d	Add WP button template file So the module may test a generic button directive.	9 years ago
Alex Dik	79f5511c9a	Implement wp-buttons base module Delivering two base controller classes and a directive helper.	9 years ago
Alex Dik	20dd67422e	Move away button components that don't fit	9 years ago
Alex Dik	40ce3c48a6	Implement tests for WP list view button directive	9 years ago
Alex Dik	ccabd2d482	Move access key getter to WP list view button controller	9 years ago
Alex Dik	5b25d0e331	Use bindToController in WP list view button	9 years ago
Alex Dik	924eda1912	Isolate the directive scope	9 years ago
Alex Dik	62cd9c40fd	Implement WP list view button directive	9 years ago
Alex Dik	ebd43c4cfe	Fix markup error in WP create button	9 years ago
Oliver Günther	8dc9b592c4	Fix merge hickup	9 years ago
Oliver Günther	46148e6e04	Remove empty href in new work package menu This removes the href attribute from the menu items, since it causes weird behavior depending on the subproject the user is in. It uses ui-sref for WP-create links instead. For the user, this should not have a drawback (rather, it improves readability for screenreaders since they do not pronounce 'Link, visited' all the time). The downside is that capybara's `click_link` does not match without a link. We could do `href='#'` or `href='javascript:;'`, but I dislike both. Alternatively, we should refactor these non-link items as a button instead, because essentially, that's what they are.	9 years ago
Alex Dik	9350ad4d13	Move context menus in separate components sub directory	9 years ago
Oliver Günther	383d0d631e	Restore accessible-by-keyboard template This fixes the broken specs due to: 1. Switch to button in accessible-by-keyboard 2. Changed label for '+ Work Packages'	9 years ago
Magdalena Kafka	52b0a373f1	Add aria-haspopup on wp create button	9 years ago
Magdalena Kafka	129ed091a7	Add label on create new wp button for screenreaders	9 years ago
Magdalena Kafka	70e07e3710	Fix wp view mode buttons labels for screenreaders	9 years ago
Henriette Dinger	c3035f1022	Change inccorect icon class	9 years ago
Alex Dik	37b91098dc	Rename WP-view button directive	9 years ago
Alex Dik	254a7f8746	Rename WP-watcher button directive	9 years ago
Alex Dik	a59d65b8aa	Rename WP-create button directive	9 years ago
Henriette Dinger	b0560a2188	Include review feedback	9 years ago
Alex Dik	c97226d9fc	Add loading animation when switching to fullscreen view	9 years ago
Alex Dik	64e9c20b47	Add href attribute to drop down menu link	9 years ago
Alex Dik	603d0031aa	Use ng-click directive to process state change	9 years ago
Alex Dik	77f5ce915d	Move types drop down menu to create button directory	9 years ago
Alex Dik	26dacf4739	Disable WP-create button for create states universally	9 years ago
Alex Dik	4fb6d3a158	Remove empty space of activation label	9 years ago
Alex Dik	de9c4c1e03	Move logic away from directive html	9 years ago
Alex Dik	a61db10c59	Remove EditableFieldsState dependency from view button directive	9 years ago
Alex Dik	ed2b0a4006	Move view button controller code to the directive	9 years ago
Alex Dik	3a8fea571d	Implement WP view button directive	9 years ago
Alex Dik	c34170719f	Refactor WP button component directory structure	9 years ago

47 Commits (f2246e32c718012e534ed10f775cc68ff37b9ec9)