openproject

Commit Graph

Author	SHA1	Message	Date
ulferts	c0b709530c	Fix/replace deprecations (#5533 ) * replace alias_method_chain * remove deprecation silencing * bump controller-testing * introduce permitted params for settings * replace various deprecations in controllers * remove deprecation silencing for legacy_specs * remove `puts` from spec * replace deprecated access to errors * remove unnecessary AR::Parameters usage in spec * specify error to expect * replace deprecations * replace deprecated action calls in legacy function specs * replace deprecations in functional controller tests * replace deprecations in controllers/controller_specs * remove params parser which does not seem to be in effect It is registered for the content type :exclude which makes no sense as it should deal with :json. The desired behaviour of the api dealing with parsing errors is working with or without the code. * replace deprecations in unit specs * replace alias_method_chain [ci skip]	7 years ago
ulferts	0c0b16508b	Fix/bump representable (#5465 ) * bump reform and roar -> bumps representer * adapt to changed validation interface * disable initializer patch for now * adapt to changed representable attr interface * can no longer have private methods inside a representer * private no longer possible for representer * bump reform * wip - restyle validation * remove commented out patch * apply injection as prescribed * reactivate reform error symbols patch * remove patch to Hash superfluous wit ruby 2.3 * remove outdated human_attribute_name patch * whitespace fixes * adapt filter name after removal of human_attribute_name patch * adapt filter specs to no longer rely on human_attribute_name patch * fix version filter name * remove reliance on no longer existing human_attribute_name patch * use correct key in journal formatter * remove private from representer * adapt to altered setter interface * reenable i18n for error messages in contracts * no private methods in representer * defined model for contracts * fix validaton * instantiate correct Object * define model for contract * circumvent now existing render method on reform * replace deprecated constant * patch correct reform class - not the module - via prepend * refactor too complex method * replace deprations * remove remnants of parentId * prevent error symbols from existing twice * adapt user representer to altered setter interface * adapt watcher representer to altered setter interface * remove now unnessary patch * adapt setter to altered interface * adapt spec * fix custom field setters * remove parentId from wp representer As the parent is a wp resource, clients should use the parent link instead * adapt spec to changed valid? interface * remove parentId from wp schema * replace references of parentId in frontend * remove TODO [ci skip]	8 years ago
Jens Ulferts	4df369884a	employ the subproject filter to handle subproject setting	8 years ago
Oliver Günther	7cf11bb689	Update copyright notice	8 years ago
Markus Kahl	7f6d74a88e	basic crud	8 years ago
Oliver Günther	2454624fde	Retain partial message for custom field to customizable	9 years ago
Oliver Günther	01e1141139	Use pre-generated error message from custom field Instead of generating a new error message when applying custom field errors on the customizable model, simply copy the already existing error message from the custom field, and save the symbol for later API processing. This saves both time and avoids errors when CFs require additional attributes for humanizing the error messages.	9 years ago
Oliver Günther	f03728c156	Retain partial message for custom field to customizable	9 years ago
Oliver Günther	9a1ccce4e3	Use pre-generated error message from custom field Instead of generating a new error message when applying custom field errors on the customizable model, simply copy the already existing error message from the custom field, and save the symbol for later API processing. This saves both time and avoids errors when CFs require additional attributes for humanizing the error messages.	9 years ago
Jens Ulferts	0980f01a95	copy over symbol in custom value to customizable We need to have access to the original symbol so that the API v3 can post process the errors on the custom fields just like it does every other field. When only a string is provided, the symbol :unknown is stored which will lead to the API rendering error messages like "can't be blank" (without the erroneous field name).	9 years ago
Jan Sandbrink	fb2efa5909	be more concise!	9 years ago
Jan Sandbrink	88e052a53e	style [ci skip]	9 years ago
Jan Sandbrink	b374ebdd7f	store messages alongside error symbols - allows to skip translation part in ErrorBase - allows to have correct translations containing placeholder values	9 years ago
Jan Sandbrink	a9d28d3fb6	fix some errors uncovered by specs - bad default values - missing attribute sanitation - style	9 years ago
Jan Sandbrink	6c9bd3c63f	apply a hack to fix an error	9 years ago
Jan Sandbrink	dcd2a3b03c	rework error instantiation - multiple errors are no longer a special case of specific errors - there is a separate error class to represent multiple API errors - convert ActiveRecord errors to API errors in a single place, ideally work with API errors from there on	9 years ago
Jan Sandbrink	c7207f0330	resort errors in WP contracts - use attributes as keys and error messages as value - AM errors immediately turn message symbols into translated strings, this makes them hardly processable -> patch some helper methods onto AM::Errors and everything is fine forever	9 years ago
Alex Coles	1bf90d2ff1	Revert "Add patch to fix Rails' hash types with Ruby 2.1.1" Rails 4.0.x `Hash` subclasses have been patched to deal with this behaviour change: https://github.com/rails/rails/pull/14198/ This reverts commit `8d6ae91d8b`. Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	c030b08cb2	Fix syntax (w/Rubocop) in Rails routes, config Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	57618b25ec	Replace dynamic finder usages with #find_by, etc. This patch replaces all dynamic finders, for the sake of consistency, although only some methods are deprecated. See: https://github.com/rails/activerecord-deprecated_finders#active-record-deprecated-finders * Revert some `User#find_by_login` usages in cuke steps accidentally removed in `74228b59`. User Story # 20325 Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Jan Sandbrink	afdd089080	add patch hint to full_message this hopefully makes clear which parts were changed by us and which belong to ActiveModel	10 years ago
Jan Sandbrink	36bb955f7c	add custom value errors to customizable - allows to relate error messages to their custom field - allows to use errors.full_message correctly for custom values - might break specs... we will see that soon	10 years ago
Alex Coles	e0191e759c	Update year in copyright header to 2015 [ci skip]	10 years ago
Alex Coles	d4d8826ac3	Fix field_error_proc for Rails 4 TagHelper changes `ActionView::Base::InstanceTag` is replaced by a new hierarchy of Tag classes under `ActionView::Helpers::Tags`. Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	8b7bcf4b61	Prefer #map over #collect in Rails config files Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	79f0cb88ea	Fix syntax (w/Rubocop) in Rails config files Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	f10023674e	Use 1.9+ Hash syntax in Rails config files Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Toshi MARUYAMA	17c0f1453e	[#14507 ] remove NestedSet patch from config/initializers/10-patches.rb https://www.openproject.org/work_packages/14507 For Rails4 porting. Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	a61332b503	Revert "Attempt workaround for failing theme asset specs" This reverts commit `b0f758fce2`. Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Toshi MARUYAMA	5a164fcc88	remove reduntant empty lines from config/initializers/10-patches.rb	11 years ago
Alex Coles	2660b8cd4b	Revert "Attempt workaround for LSG asset loading" Adding compass-rails (previous commit `9689b158`) solves the same issue. This reverts commit `67e5612215`.	11 years ago
Alex Coles	67e5612215	Attempt workaround for LSG asset loading Signed-off-by: Alex Coles <alex@alexbcoles.com>	11 years ago
Alex Coles	b0f758fce2	Attempt workaround for failing theme asset specs Signed-off-by: Alex Coles <alex@alexbcoles.com>	11 years ago
Michael Frister	8d6ae91d8b	Add patch to fix Rails' hash types with Ruby 2.1.1 Might also help us with Ruby 2.2 until we have Rails 4.	11 years ago
Johannes Wollert	8b096975fe	updates copyright headers updates more copyright more copyright headers	11 years ago
Hagen Schink	502c7b74d6	Removes superfluous patch	11 years ago
Jonas Heinrich	06f2b8b8bf	found another prettier way	11 years ago
Jonas Heinrich	ed54671e6f	fixed error message during creation of groups	11 years ago
Jonas Heinrich	cd35372b0c	Replaced Issue added/updated with Work package added/updated and added a migration for the settings	11 years ago
jwollert	2fdbf0316e	fixes small grammatical error in translation missing warning	11 years ago
Philipp Tessenow	444546e2e8	use \A and \z instead of ^ and $ in ruby regexes	11 years ago
Philipp Tessenow	a1e67dd460	new copyright header #1903	11 years ago
Christian Ratz	43bc798abb	changed feed setting to enabled instead of disabled	11 years ago
Christian Ratz	b86f8d65d7	[#1850 ] Disable atom feeds via setting	11 years ago
Jens Ulferts	bf1cb1e449	removes vendored acts_as_list The patch applied on it was moved to a separate module which is loaded during initialization. In order to have all the classes using acts_as_list receive the patch, it is necessary to load the patch as early as possible. Hence the patch is loaded in 10-patches.	12 years ago
Jens Ulferts	21459a384f	provide every possible file with a short copyright notice This was done using the rake task: rake copyright:update	12 years ago
Philipp Tessenow	48459250e4	when generating the I18n Deprecation message, consider all rails3 translation definitions (even superclasses)	12 years ago
Philipp Tessenow	068fbf6545	modified our human_attribute_name patch All /(.*)_id/ attributes names will be stripped of the '_id' part. Prepare for the new Rails3 way translation files.	12 years ago
Jens Ulferts	3ba030289d	improves deprecation warning message and allows passing default values * states the key and model for which the human_attribute_name is inquired * have the raise and default option only as a fallback when nothing else is supplied. Doing this allows for model classes to pass additional attributes.	12 years ago
Jens Ulferts	cdca76e9d2	prevents attribute name to be humanized Without the :default => false, the method's super implementation will use attribute_name.to_s.humanize as a last resort. This will prevent an error from beeing raised which will render the rescue statement added for backwards compatibility useless. Adding the fix will lead to a lot of warnings. But hey, that will lead to a faster adaptation of the new standard.	12 years ago

1 2 3

108 Commits (f3f498baa125480bf508b1d4e584366325b4942a)