27 Commits (f449509666cba70199e422a6db46733e38fabca4)

Author	SHA1	Message	Date
Cyril Rohr	648819ce1c	Bypass the default getters and setters for installation_uuid	6 years ago
Cyril Rohr	666d038f20	Add custom getter for Setting.installation_uuid	6 years ago
Wieland Lindenthal	b1e45bc200	Allow for filtering `Setting` values when they are read. This is needed for overwriting values when EE token is not available.	6 years ago
Oliver Günther	a6e9137163	Don't explicitly check empty rails cache ... [ci skip]	7 years ago
Oliver Günther	6ef4211e77	Bump copyright to 2018 (#6171) ... [ci skip]	7 years ago
Oliver Günther	7cf11bb689	Update copyright notice	8 years ago
Oliver Günther	367a18d452	Fix Setting.app_title order failure	8 years ago
Oliver Günther	616ec628b5	Rewrite with_setting specs ... And fix tests that do not expect settings to be cached during the request with RequestStore.	8 years ago
Oliver Günther	4353953605	Improve stored settings as a whole ... Currently, settings are cached on a per-name basis, but that cache is expired everytime *any* attribute is written. Even when a week-old attribute is still valid, its cache is expired as soon another setting is updated due to the max settings cache key. Instead of caching a single attribute, I suggest to cache the entire settings (the total number with plugins is less than 120 and 4KiB in size) and retrieve and deserialize a single value from that hash. That saves us the time to: 1. Locating a single element from database 2. Instantiate a setting object just for deserializing 3. Requesting settings several times by using RequestStore	8 years ago
Jens Ulferts	e03e1e99df	prevent spec flicker by cleaning up after Setting.notified_events	9 years ago
Alex Coles	ce93701029	Fix syntax (w/Rubocop) in specs ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	57618b25ec	Replace dynamic finder usages with #find_by, etc. ... This patch replaces all dynamic finders, for the sake of consistency, although only some methods are deprecated. See: https://github.com/rails/activerecord-deprecated_finders#active-record-deprecated-finders * Revert some `User#find_by_login` usages in cuke steps accidentally removed in 74228b59. User Story # 20325 Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	ebbc9e3d7d	Prefer #not_to over #to_not in specs ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	e0191e759c	Update year in copyright header to 2015 ... [ci skip]	10 years ago
Alex Coles	5afc11f19e	Fix syntax (w/Rubocop) in specs ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	03978767be	Use 1.9+ Hash syntax in specs ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Jens Ulferts	374a7a2798	cleans up Settings after spec	10 years ago
Alex Coles	e137ed8135	Convert specs to RSpec 2.99.0 syntax with Transpec ... This conversion is done by Transpec 2.3.1 with the following command: transpec * 72 conversions from: describe 'some controller' { } to: describe 'some controller', :type => :controller { } * 57 conversions from: describe 'some model' { } to: describe 'some model', :type => :model { } * 49 conversions from: describe 'some view' { } to: describe 'some view', :type => :view { } * 34 conversions from: obj.should to: expect(obj).to * 27 conversions from: describe 'some routing' { } to: describe 'some routing', :type => :routing { } * 8 conversions from: describe 'some feature' { } to: describe 'some feature', :type => :feature { } * 7 conversions from: describe 'some helper' { } to: describe 'some helper', :type => :helper { } * 5 conversions from: be_true to: be_truthy * 5 conversions from: describe 'some request' { } to: describe 'some request', :type => :request { } * 2 conversions from: obj.should_receive(:message) to: expect(obj).to receive(:message) * 2 conversions from: obj.stub(:message) to: allow(obj).to receive(:message) * 1 conversion from: before { example } to: before { |example| example } * 1 conversion from: describe 'some mailer' { } to: describe 'some mailer', :type => :mailer { } For more details: https://github.com/yujinakayama/transpec#supported-conversions	11 years ago
Alex Coles	5cdc438c52	Convert specs to RSpec 2.99.0.beta2 syntax with Transpec ... This conversion is done by Transpec 1.10.4 with the following command: transpec * 402 conversions from: it { should ... } to: it { is_expected.to ... } * 67 conversions from: be_true to: be_truthy * 55 conversions from: be_false to: be_falsey * 35 conversions from: it { should_not ... } to: it { is_expected.not_to ... } * 20 conversions from: == expected to: eq(expected) * 5 conversions from: obj.stub(:message) to: allow(obj).to receive(:message) * 4 conversions from: =~ /pattern/ to: match(/pattern/) * 1 conversion from: obj.should_receive(:message) to: expect(obj).to receive(:message) * 1 conversion from: Klass.any_instance.stub(:message) to: allow_any_instance_of(Klass).to receive(:message) * 1 conversion from: after { example } to: after { |example| example } * 1 conversion from: pending to: skip	11 years ago
Alex Coles	a2679b5d35	Convert specs to RSpec 2.14.8 syntax with Transpec ... This conversion is done by Transpec 1.10.4 with the following command: transpec . * 5 conversions from: obj.stub(:message) to: allow(obj).to receive(:message) * 3 conversions from: obj.should to: expect(obj).to * 1 conversion from: obj.should_receive(:message) to: expect(obj).to receive(:message) * 1 conversion from: obj.should_not to: expect(obj).not_to * 1 conversion from: Klass.any_instance.stub(:message) to: allow_any_instance_of(Klass).to receive(:message)	11 years ago
Martin Linkhorst	3f4732e3e3	fix a bogus test	11 years ago
Martin Linkhorst	10d694f6e9	push down callback block check into OpenProject::Notifications	11 years ago
Martin Linkhorst	feba6723cd	specs for the OP::Notifications based settings notifier: ... * arguments to the block is a hash * no clearing of callbacks * no callback objects	11 years ago
Martin Linkhorst	7a29578dfd	adds a spec to test invocation of multiple callbacks	11 years ago
Martin Linkhorst	dda5226dff	fire callbacks only when setting was stored sucessfully	11 years ago
Martin Linkhorst	48abe7d64c	dry up setting specs	11 years ago
Martin Linkhorst	b2df607540	adds setting callback specs, also converts old setting tests to specs	11 years ago