849 Commits (f4763d43111400f730471081c413fbfb7b5d939f)

Author	SHA1	Message	Date
ulferts	b8355caf51	treats non set cf values same as "No" for boolean cf filtering (#5803) ... Work packages who cannot have the value (not added to project or type) are exempt from this. [ci skip]	7 years ago
ulferts	daa1a4d4b7	fixes filtering members by group (#5800) ... additionally fixes: * with "all" selected, all members are shown, not only those being active, invited or registered * with "locked" selected, locked users are now displayed. * the Project#members_principals associations lacked the `references` method which lead to the users table being undefined in the resulting query. In order to achive the bug fixes, the member filtering is now based on the query engine also used for users, queries, work_packages, ... As a lot of the members filters are very similar to user filters (in fact, a lot of the members filter work on the users model), those filters are shared via modules. [ci skip]	7 years ago
Oliver Günther	2b85190d88	[25960] Hide non-writable fields in edit mode (#5791) ... The new edit mode activates all fields it finds - which makes sense. However, non-editable fields should never be created in the first place. https://community.openproject.com/wp/25960 [ci skip]	7 years ago
ulferts	b3efc877cd	adapt help text modal style (#5788) ... In order to allow using the keyboard to trigger the close button, the ngDialog close functionality is disabled and a custom close button (the X) is added which is tabbable. The rest is as specified in https://community.openproject.com/projects/openproject/work_packages/25912 Remove close button Change label to "Edit" (EN), "Bearbeiten" (DE) Decrease space between button and bottom. Remove blue border/highlight-effect around text Restore help/info icon left to header text [ci skip]	7 years ago
ulferts	4b76af2521	guard attribute help texts by ee token (#5786) ... The tokens are always queryable via the api but the administration requires an enterprise token to be set [ci skip]	7 years ago
ulferts	4d95cc815f	Feature/guarded relation columns (#5784) ... * refactor case statement * guard relation columns by enterprise token [ci skip]	7 years ago
ulferts	e60bd97f35	Fix/bump gems (#5770) ... * bump capybara * downgrade selenium-webdriver to get rid of a multitued of log messages Setting the logging preferences had no effect: https://github.com/SeleniumHQ/selenium/wiki/DesiredCapabilities#loggingpreferences-json-object * bump sass * bump openproject-token * bump autoprefixer-rails * bump database_cleaner * bump capybara-screenshot * bump aws-sdk * bump timecop * bump timecop * bump parallel_tests * bump faker * bump retriable * fix specs discovered to be broken by now working within Capybara introduced a proxy for `all` and `within` in v2.14 (6356719043 (diff-3944edd1c2651f608ed8a8bec061a734)). This revaled a couple of tests not working as desired. * skip `npm install` for unit specs [ci skip]	7 years ago
ulferts	75f501e897	Fix/custom field lacking options (#5768) ... * enforce having at least one custom option for a list cf Removes the hand written nested attributes handling by accept_nested_attributes_for. Removes the arbitrary boundary of having 500 custom options. * i18n for custom option mgmt [ci skip]	7 years ago
Oliver Günther	825a76f0e6	Add separate names to bulk actions	7 years ago
Oliver Günther	d01595d578	Test more explicitly in query_history spec	7 years ago
Oliver Günther	9b6e9a1371	Extract click position mapper for input fields for re-use	7 years ago
Oliver Günther	280c00d50f	Fix more tests	7 years ago
Oliver Günther	db4410dd1f	Remove single-wp edit in context menu	7 years ago
Oliver Günther	3cb9408faf	Fix tests	7 years ago
Oliver Günther	56b67e9f9e	Consolidate existing WorkPackageField and TableWorkPackageField	7 years ago
Oliver Günther	4a686f16d9	[25490] Add publicity settings for query saving modal (#5737) ... When copying queries, the publicity for other members is copied, but not the query `star` setting (whether it is shown in the project menu or not). This is confusing to the user in two ways: 1. The user does not know whether a query is public or not when copying it 2. It is weird to copy one setting, but not the other This PR suggests to extend the `save as` modal with the visibility settings. To this end, I extracted the visibility form into a separate directive to be re-used from the publish/sharing modal and the save as modal. As://community.openproject.com/projects/openproject/work_packages/25490 [ci skip]	7 years ago
Edward Betts	437bbd51bf	correct spelling mistakes (#5748) ... [ci skip]	7 years ago
Oliver Günther	9fabaaaf13	Show only attributes from the type attributes and status, project	7 years ago
Oliver Günther	ec6b856686	Add directive to show help text modal	7 years ago
Oliver Günther	39e11c72dc	Create backend for help text CRUD	7 years ago
Oliver Günther	9e576c9832	Alter specs after removed panel-toggler	7 years ago
Oliver Günther	8956700408	[25374] Remove attribute visibility	7 years ago
Oliver Günther	04d48ecec9	Wait longer for filter values to be loaded	7 years ago
Oliver Günther	aaf9781698	Try to strengthen filter spec	7 years ago
Oliver Günther	eabadccab1	[25704] Allow activities to be filtered for comments-only ... This adds a simply toggler to the activity tab that allows filtering all activities for only those with a comment set. This was on the wish list for a customer but is so trivial that I did this in a quiet minute since I very much appreciate the idea. https://community.openproject.com/work_packages/25704 [ci skip]	7 years ago
ulferts	d1ddd2d5d2	Feature/toggle between hierarchy and group by (#5720) ... * allow toggling between hierarchy and groupBy * fix icon alignment in query settings dropdown * buffer query updates to prevent duplicate backend requests * simplify focus-within delay [ci skip]	7 years ago
Oliver Günther	a684dbfa29	Extend spec	7 years ago
Oliver Günther	b2b499a7fd	[25686] Use collection_check_box in membership page ... This adds a hidden field for when no checkbox is selected, however it adds the caveat that non-selected values are transmitted as empty values, thus we have to filter them again in the backend.	7 years ago
Oliver Günther	5d84add246	Expire sessions in warden auth scope	7 years ago
Oliver Günther	8113ed9d19	Show relation rows as regular members of the table ... Still WIP: - Relation column is rendered as all other rows (indicator for dropdown), which is confusing	7 years ago
Oliver Günther	60de10881d	Strengthen relations spec	7 years ago
Oliver Günther	c8ef6e1a4d	Strengthen specs (Try #2) (#5686) ... * Don't use expect in retry_block It doesn't raise an exception, but only marks the example erroneous * Replace textile_link cuke * Replace wp search cuke with existing spec We only need to test for the href, no need to check that the page exists. * Also remove pagination cuke, its part of the search-spec [ci skip]	8 years ago
Oliver Günther	bbdb4bf54f	Print work package type for 'ofType' relation columns	8 years ago
Oliver Günther	cbf6671402	Housekeeping/strengthen specs (#5650) ... * Try to strengthen CF spec * Removing randomly failing old TL cuke [ci skip]	8 years ago
Oliver Günther	569369092d	Avoid setting the workPackageId to ignore clicks	8 years ago
ulferts	16f0cace89	Fix/wp copy with cf (#5638) ... * fix copying cf values on wp copy * use angular copy form if only one wp copied [ci skip]	8 years ago
Oliver Günther	7fa78d97ff	Add spec	8 years ago
ulferts	f4b36edccb	Feature/save zoom in query 7 1 (#5637) ... * Implement timeline zoom level as query enum * Implement query zoom handling in frontend Had to refactor: 1. The zoom level enum in the frontend cannot properly be matched to strings so I chose a separate type instead to map to the string retrieved from /sent to the query 2. The way query updates are done through the states. The previous implementation only worked for one single attribute state. For the timeline state, it does not make sense to split that into two, so I delegate to the state to handle checking and updating the query. * Extend feature spec for zoom saving * Refactor URLParamsHelper into TS service * Fix comparison in table query services * Remove reference to allowedValues [ci skip]	8 years ago
Oliver Günther	d179e754f2	Extend feature spec for zoom saving	8 years ago
ulferts	0c0b16508b	Fix/bump representable (#5465) ... * bump reform and roar -> bumps representer * adapt to changed validation interface * disable initializer patch for now * adapt to changed representable attr interface * can no longer have private methods inside a representer * private no longer possible for representer * bump reform * wip - restyle validation * remove commented out patch * apply injection as prescribed * reactivate reform error symbols patch * remove patch to Hash superfluous wit ruby 2.3 * remove outdated human_attribute_name patch * whitespace fixes * adapt filter name after removal of human_attribute_name patch * adapt filter specs to no longer rely on human_attribute_name patch * fix version filter name * remove reliance on no longer existing human_attribute_name patch * use correct key in journal formatter * remove private from representer * adapt to altered setter interface * reenable i18n for error messages in contracts * no private methods in representer * defined model for contracts * fix validaton * instantiate correct Object * define model for contract * circumvent now existing render method on reform * replace deprecated constant * patch correct reform class - not the module - via prepend * refactor too complex method * replace deprations * remove remnants of parentId * prevent error symbols from existing twice * adapt user representer to altered setter interface * adapt watcher representer to altered setter interface * remove now unnessary patch * adapt setter to altered interface * adapt spec * fix custom field setters * remove parentId from wp representer As the parent is a wp resource, clients should use the parent link instead * adapt spec to changed valid? interface * remove parentId from wp schema * replace references of parentId in frontend * remove TODO [ci skip]	8 years ago
Oliver Günther	94234bd5ee	[25432] Correctly transmit hasDefault to frontend (#5603) ... The default value for CFs is '', which is obviously not nil despite not being a default, however the frontend only _always_ shows the attribute when it is required and has no default. This PR also adds a 'always visible' flag to the form configuration when the CF is set required. [ci skip]	8 years ago
Oliver Günther	3c283ea512	Render table sums row in separate directive (#5595) ... * Render table sums row in separate directive * Fix JS error on setSelection It is not supported for [type=number] input fields. [ci skip]	8 years ago
Oliver Günther	e877713b0a	[25404] Show timeline context items only when visible (#5590) ... Fixes a check for the timelineVisible state. [ci skip]	8 years ago
Oliver Günther	bf9373120b	[25416] Refresh query on removed query_props with ID set ... When you're navigating to a query and override a filter, then move back to the query, the URL is changed, however the query is not being refreshed. This is due to the checksum being required to be non-null, even though it can possibly become null in the above case.	8 years ago
Oliver Günther	32381134f4	Fix relations removal in split screen and add test (#5578) ... [ci skip]	8 years ago
ulferts	86c2f3d59d	Fix/increase query api robustness (#5574) ... * removes unavailable filters on valid_subset! * remove invalid columns on valid_subset! * cleanup query form and collection * code prettification * add status to spec in order to have valid queries [ci skip]	8 years ago
Oliver Günther	892e39161f	[25370] Explicitly clear query_props for query menu items (#5563) ... [ci skip]	8 years ago
Wieland Lindenthal	a432d04440	Fix: after deleting an attribute updating the hidden fields was missing (#5552) ... * Fix: after deleting an attribute updating the hidden fields was missing * Fix within not being called * Fix tests after within [ci skip]	8 years ago
ulferts	2a71172837	prepare the query before reading results (#5547) ... * prepare the query before reading results * use string for list cf filter value because all other list filter also use a string * handle invalid group, columns, sort on query read [ci skip]	8 years ago
Henriette Dinger	dd15e61637	[25326] Modules menu is shown when there are no entries ... When the modules menu is empty it should not be rendered at all. Thus an empty drop down is avoided. https://community.openproject.com/projects/openproject/work_packages/25326/activity [ci skip]	8 years ago