76 Commits (f56833f6a81c946deadb3d9d3c2fd27b25139831)

Author	SHA1	Message	Date
Oliver Günther	4466832f38	[26044] Fix cancel editing for milestones (#5833) ... https://community.openproject.com/wp/26044 [ci skip]	7 years ago
Oliver Günther	ee93b01152	Don't build resource from empty changeset (#5832) ... [ci skip]	7 years ago
Oliver Günther	3a6f2e2278	[26044] Handle escape in field handler and reference form in table (#5828) ... * [26044] Handle escape in field handler and reference form in table Mousetrap was used to trigger escape on the field, but since we already have a keydown handler attached to it, we can re-use it for cancelling the field editing. While fixing this, I found out that the table edit context uses a new form for each field, which means the edit handler of the previous field is lost. A new reference context is held in the table to return existing forms, if any. In the single view, this is tied to the $scope of the edit field group, and thus ensure only one form exists. * Fix specs of long text fields now no longer escape-able. [ci skip]	7 years ago
ulferts	2f9d7f408a	Fix/wp table switch to milestone (#5825) ... * map date name in changeset * handle date switch in wp form * Don't stub_const for services that may exist before hand This will cause the const to be evaluated already, so that stub_const has no effect there. This is why this fails depending on the order on travis, but not locally/isolated. [ci skip]	7 years ago
Oliver Günther	466984f993	[26037] Don't initialize a changeset by copying (#5821) ... * [26037] Don't initialize a changeset by copying As it turns out, copying the resource and defaulting to the form is REALLY expensive. Since creating a new empty changeset should be cheap (its convenient to simply have on available in the timeline), we don't really need to copy the resource from the work package. https://community.openproject.com/wp/26037 * Insert the initial changeset to the state [ci skip]	7 years ago
ulferts	06a11ade58	fix milestone date edit in wp table (#5820) ... [ci skip]	7 years ago
Oliver Günther	2116aa0583	Rebuild the resource when changeset is cancelled (#5819) ... [26038] Rebuild the resource when changeset is cancelled [ci skip]	7 years ago
Oliver Günther	1bad575ace	Only update the form for type and project for NEW work packages	7 years ago
Oliver Günther	d49aec0dc7	Reset form when creating a new inline row	7 years ago
Oliver Günther	3c357aeca2	Remove unused startEditing ... We no longer need to set the current value, since we fall back to the resource value.	7 years ago
Oliver Günther	3968c26104	Fix clearing the edit form upon cancelling the edition	7 years ago
Oliver Günther	0bc6e4bc40	Reject the form update ONLY when trying to save	7 years ago
Oliver Günther	a46d9b1ca5	Fix usages of form and usage of raw values	7 years ago
Oliver Günther	9515b58f49	Reject submission earlier when validationErrors in form	7 years ago
Oliver Günther	591c665639	Store only the changeset in a state, not the form itself ... With the changeset being the authoritive source of the changes to a work package, we can pass it around. Also, a temporary resource for viewing the changes made to the work packages is available through the editing service. This is required since we need to show the WP resource as it were if the changes were applied.	7 years ago
Oliver Günther	589f228776	Create resource that contains the changeset and form	7 years ago
Oliver Günther	9687734a97	Only add to changes once changed	7 years ago
Oliver Günther	6663939ce9	Allow initialization with a new form resource ... Avoids loading the form again when the single view initializes the form editing.	7 years ago
Oliver Günther	7bafb6f5e2	Let timeline maintain a single changeset in renderInfo	7 years ago
Oliver Günther	b1945d97df	Correct focussing on new fields when switching	7 years ago
Oliver Günther	e9bd077d9b	Allow traversal from one single-view to the other (e.g. split -> full) ... This requires us to keep changes open if we're starting to edit other fields.	7 years ago
Oliver Günther	0bee148c27	Remove the overridden schema for new work packages once saved ... We still have components that use a new work package and its form schema set by the `overriddenSchema` property. We should get rid of this and instead let them use the edit resource in the long run.	7 years ago
Oliver Günther	4a8a16f82c	Don't gulp errors in PromiseLike	7 years ago
Oliver Günther	c0100a6367	Fix conflict notification	7 years ago
Oliver Günther	2987715c40	Update the form on special fields for global create	7 years ago
Oliver Günther	6b537b8132	Fix overridden setter/getter in multivalue select field	7 years ago
Oliver Günther	c811ef4ba5	Update fields when changeset resource is updated	7 years ago
Oliver Günther	e9cda39e3f	Keep erroneous fields open and instead only set their errors	7 years ago
Oliver Günther	8e07376912	Create separate changeset object to provide resource and schema	7 years ago
ulferts	7307f36e9a	remove content from wp display titles (#5809) ... [ci skip]	7 years ago
Oliver Günther	b1c8a7fc4e	Handle intermittently closed edit fields ... [ci skip]	7 years ago
ulferts	6e444f7359	fix redirecting when pressing enter on wp create (#5787) ... [ci skip]	7 years ago
Oliver Günther	ac61f3650e	Reject fields to be refreshed, but no longer in the schema	7 years ago
Oliver Günther	322200ee99	Improve accessibility of display fields	7 years ago
Oliver Günther	b54dde0735	Don't scope subscription in WP edit form to table	7 years ago
Oliver Günther	681ce4684d	Avoid normalization of date fields outside table	7 years ago
Oliver Günther	308eb555ea	Refresh open fields instead of redrawing all content	7 years ago
Oliver Günther	6094917224	Replace container instead of emptying first	7 years ago
Oliver Günther	9b6e9a1371	Extract click position mapper for input fields for re-use	7 years ago
Oliver Günther	280c00d50f	Fix more tests	7 years ago
Oliver Günther	3cb9408faf	Fix tests	7 years ago
Oliver Günther	56b67e9f9e	Consolidate existing WorkPackageField and TableWorkPackageField	7 years ago
Oliver Günther	f49e9c93ef	Replace wpEditModeState and wpEditForm with one directive	7 years ago
Oliver Günther	c00d53de90	Implement single view context for previous edit fields	7 years ago
ulferts	c1f43435e0	Fix/link on inline create success message (#5717) ... * provide saved work package to fix created message link The created message link needs to use the newly created work package (the one returned on the POST request) in order to have the correct id set. * fix styling [ci skip]	7 years ago
Oliver Günther	8113ed9d19	Show relation rows as regular members of the table ... Still WIP: - Relation column is rendered as all other rows (indicator for dropdown), which is confusing	7 years ago
Oliver Günther	160d8876c7	Add switch state in query state handling to clarify access to states (#5571) ... [ci skip]	8 years ago
Oliver Günther	6ebd1185ea	[25342] Display editing blocked notification in table (#5542) ... https://community.openproject.com/projects/openproject/work_packages/25342	8 years ago
Oliver Günther	5423b97b97	[25073][25092] More robust refreshing of table upon changes ... Currently, altering the hierarchy of a work package does not properly update the table. For example, removing a parent of w1 that isnt visible in the table causes w1 to refresh in the table (due to cache service), but the entire table isn't refreshed. We cannot refresh the entire table for cache service changes, since that happens quite often in the timeline mode and would cause a peformance impact. On the other hand, we don't have the information on _what_ changed in w1 when we subscribe to the cache service. This PR rather improves on the task of reloading the table after changes to work packages by making two things explicit: 1. A separate state controlling requests to table refreshing instead of a rootScope event 2. A service that orchestrates the state to allow moving to/from full screen to reload the table whenever moving back and requests were made in the full screen.	8 years ago
Oliver Günther	ff8da4435c	[25172] Force activation of field when user requested it ... The wp edit form currently checks for an active field before accepting a request to activate it. However, it appears to exist an external effect (refresh possibly) that closes the field without resetting the form. We should allow activating the field regardless of it being active currently to avoid this error.	8 years ago