3424 Commits (f60e1455cb1c3f57f28372e82b7dc755d8734523)

Author	SHA1	Message	Date
Jan Sandbrink	6a0ef38f5f	extract get_changes into own module	9 years ago
Alexander Bach	5fea667954	Return recipients as users instead of mail addresses	9 years ago
Florian Kraft	bfd4ed19d1	rebased against new notification styles ... This will introduce some changes throughout the notifications. Upload notifications can now group the uploads and the new notification system can now receive removal commands. In addition, I took the liberty of adding some minor animations Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Florian Kraft	8503bc77c5	probably fix create contract	9 years ago
Alexander Bach	8c51577e37	Clear up method name	9 years ago
Alexander Bach	196b5e049e	Move comment	9 years ago
Jonas Heinrich	d971acf200	Adapt version to corresponding OpenProject core version.	9 years ago
Oliver Günther	edf713fbd5	Rework managed repositories error handling ... This commit: - adds error messages for filesystem errors - Forces services and views to use repository.root_url instead of managed_path, which may not be available when config is missing	9 years ago
Jan Sandbrink	fd3312a0f2	extract attachment storing into service ... - service cares about adding a journal too - only store the attachment when the journal can be saved (i.e. the WP is valid)	9 years ago
Oliver Günther	bb2a09490b	Remove delayed running of management workers. ... This commit (temporarily) removes the delayed creation and deletion of managed repositories for the sake of improvded error handling. After consultation with @ulferts, we suggest to improve the `Delayed::Job` pipeline to create means for identifying jobs (referenced ID) and to create a unified service to manage database AND filesystem access in a transactional manner. Also provides the following corrections: - Improve migration speed - Delete parent projects only by their identifier, not the managed root	9 years ago
Jan Sandbrink	3a87b269fa	allow to fetch aggregated journals for a journable ... - this should be faster (or at least easier to optimize) than applying a WHERE to the whole scope - also starting to diverge from using classic ActiveRecord in aggregated journals	9 years ago
Oliver Günther	319bd21daf	Moved managed repository lifetime entirely to the model.	9 years ago
Oliver Günther	e1bdb41bcd	More complete specs wrt. coverage, cleanup	9 years ago
Oliver Günther	1e8c873544	Remove filesystem adapter ... This commit removes the entire FileSystem repository and adapter. It rids all specs (core and legacy) of remaining uses of this adpater and replaces it with a temporary subversion repository, where necessary. We also need to remove remaining filesystem instances from the database, otherwise users will receive errors when accessing said repositories on the Frontend. This does not destroy any data on filesystem, but database information on the repositories (remarks) are lost.	9 years ago
Oliver Günther	da27a552a1	Frontend extensions and build refactoring ... - switched to toggleable-attribute-groups to provide means for adding buttons in the attribute header (e.g., delete button). - added separate destroy_info page with different notifications for managed and linked repositories to ensure ramifications of removing physical repositories are communicated to the user. - Fixed several issues regarding scm_type selection and the building of repositories. Open questions still concern the question of acessing unsupported repositories (e.g., the soon-to-be-removed filesystem adapter). Acessing the class should will then throw an error, but we still have to allow users to remove the affected repository (somehow).	9 years ago
Oliver Günther	2b39d8fbdf	Cleaning up, Rubocop	9 years ago
Oliver Günther	abc597a6d2	First draft implementation of radio-based frontend.	9 years ago
Oliver Günther	05b27c1b98	Asynchronous creation, deletion of repositories from OP. ... This PR begins the push towards management of repository lifetime from within OpenProject. What this currently provides is the following: - A mixin `ManageableRepository`, included by `Repository::{Git, Subversion}` to provide an interface to repo management - Two services and delayed_job workers for creating (`CreateManagedRepositoryService`) and deleting (`DeleteRepositoryService`) - Customized rendering of subforms in the repository settings for arbitrary SCM vendors. TODOS: - [x] Provide sane ground to work on ( cf. PR #3149 ) - [x] Rework SCM settings form (`{scm}_tags` is currently HTML generated from within a Helper.) - [x] Ease integration of arbitrary SCM vendors - [x] Display meaningful error / warning when user looks at bare repository (currently outputs 500, as Git HEAD / svn revision is not available) - [x] I18n - [ ] Specs (in progress) - [x] Fix legacy specs - [ ] Decide what to do with `Filesystem` adapter. Open Questions: - **Configuration**: Currently replaces the existing options in `configuration.yml`. - **Implementation specifics**: - Sub-projects repositories reside in a hierarchy below their parents - How should the delayed_job react upon failure? (esp. creation of repositories) Relevant work package: https://community.openproject.org/work_packages/20416 Merge dependent on PR #3149	9 years ago
Oliver Günther	7ebac37c14	Repository Management - Refactoring and Preparation ... Related work package: [#20415](https://community.openproject.org/work_packages/20415). This is a combined refactoring and extraction effort of local SCM functionality for SVM, Git adapters in preparation for the explicit lifetime management of repositories in #20416 and implementation of (local) repository storage quota in #18393. This PR is still heavily WIP and for the time being, depends on the **legacy specs** for testing. To run the tests, execute the following steps: ~~~ rake test:scm:setup:all rake spec:legacy ~~~ I'm open for ideas on how we integrate scm adapters tests into current specs. --- - [x] Exchange `IO::Open` for `Open3` to avoid countless manual exitcode checks - [x] Extract local functionality in its own Module - [] Extend `LocalClient` module with links to create/delete services for #20415 - [x] Break down unbearable local parse routines (Hound will be over the place until fixed - but down from 260 to < 20) - [x] `entries` - [x] `revisions` - [] local repository factory - [] Specs - [] Fix / Modernize - [] More adapter-related specs	9 years ago
Jan Sandbrink	953ad6d15f	change aggregated_journals on AaJ to be a method ... - a "real" relation involves cascading updates that are not intended for _aggregated_ journals	9 years ago
Jan Sandbrink	d6533b100c	first spike for aggregatable journals	9 years ago
Jan Sandbrink	a59b361222	remove dead code	9 years ago
Alexander Bach	7e0c7c352e	Move event to fire after its sure that a journal will stay	9 years ago
Jonas Heinrich	38d6e644ad	Adapt version to corresponding OpenProject core version.	9 years ago
Oliver Günther	0d17061df3	Fix code syntax highlighting output. ... When annotating a file in the repository for whose language CodeRay supports, the output is not properly rendered as HTML, but escaped. As CodeRay escapes any items for HTML before output, we can safely assign syntax lines to HTML when highlighted. If text is output from CodeRay (no language set), we want to escape it instead.	9 years ago
jonasheinrich	88668116b0	Bump version to 4.4.0-alpha	9 years ago
Solotchi Veaceslav	7fd856808e	Create custom tooltip that support html	9 years ago
Jan Sandbrink	55a2cf9f51	replace references to Redmine::VERSION ... - we now live in OpenProject for quite some time - kept legacy specs because they are... legacy	9 years ago
Jan Sandbrink	8a0a60445b	update root representer ... - add it to the documentation - only provide links to resources that can be directly used (i.e. without templating) - provide useful general instance information	9 years ago
Jan Sandbrink	992888df2a	add configuration endpoint to APIv3	9 years ago
Jan Sandbrink	68d521ca85	add link for adding attachments to work package	9 years ago
Jan Sandbrink	2d3fd8eb73	only return nil for _unknown_ properties	9 years ago
Jan Sandbrink	1f7485d5bf	fix HTTP 500 in WP form ... - occured when an invalid type was provided by the client	9 years ago
Alex Coles	d906650a16	Remove AssociationsMapper remnants in WorkPackage ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Jan Sandbrink	88e052a53e	style ... [ci skip]	9 years ago
Jan Sandbrink	1ac80edc3c	use common name conversion in linked properties ... some day we could do that for ALL properties...	9 years ago
Jan Sandbrink	0dd77ecb5f	use merge! method of Reform::Contract::Errors ... - this is more concise, but more importantly: - it uses our patched in symbol merging, thereby correctly transferring symbol information	9 years ago
Jan Sandbrink	bc30b28558	extract attribute name conversion into extra class ... - consider special renaming rules for well known attribute names -> currently covering wp attributes and createdAt, updatedAt	9 years ago
Jan Sandbrink	b374ebdd7f	store messages alongside error symbols ... - allows to skip translation part in ErrorBase - allows to have correct translations containing placeholder values	9 years ago
Jan Sandbrink	a9d28d3fb6	fix some errors uncovered by specs ... - bad default values - missing attribute sanitation - style	9 years ago
Jan Sandbrink	662f99808a	apply basic attribute name transformations ... those are the ones that were present earlier already. They do not cover the hard cases, where the backend has completely different names form the API	9 years ago
Jan Sandbrink	dcd2a3b03c	rework error instantiation ... - multiple errors are no longer a special case of specific errors - there is a separate error class to represent multiple API errors - convert ActiveRecord errors to API errors in a single place, ideally work with API errors from there on	9 years ago
Jan Sandbrink	3e87d10980	fix bogus errors in contracts ... - AR tried to read properties that are undefined on the contract (:error_read_only) - now that we actually use Contract properties the copy-validations stuff started to do things, however: - we already went another path to simultaneously validate contract + model - validation was apparently broken, e.g. though the subject was not empty, there were subject :blank errors	9 years ago
Jan Sandbrink	13b9042293	treat all 422 errors the same for forms ... That means: Do render the form for all HTTP 422 errors, problems are highlighted within the form	9 years ago
Jan Sandbrink	a0e2c26deb	define properties on contract ... Actually it is documented that a :property needs to be defined on the contract (see https://github.com/apotonick/reform#contracts). We just did not do that until now, because it was not neccessary when abusing AR::Errors as hard as we did.	9 years ago
Jan Sandbrink	ac9cffe741	remove tautology and add apropriate specs	9 years ago
Jan Sandbrink	c7207f0330	resort errors in WP contracts ... - use attributes as keys and error messages as value - AM errors immediately turn message symbols into translated strings, this makes them hardly processable -> patch some helper methods onto AM::Errors and everything is fine forever	9 years ago
Jan Sandbrink	eec35308ce	use contract directly in WP create too	9 years ago
Jan Sandbrink	ce0b906d91	dirty trick to allow using a Hash as mock ... also removes default value from initializer, which was never sane	9 years ago
Jan Sandbrink	e5dd8732fc	fix stupid mistakes ... - reference to method by old name - not knowing how to call a super-method	9 years ago