4293 Commits (f7f17c8d4e39c9fb2812afa2113d44be76fea2c7)

Author	SHA1	Message	Date
Oliver Günther	cdd0f90315	Fix escaping empty html	7 years ago
Oliver Günther	48a4497839	[26168] Fix removal of mousemove handler by timeline cell (#5870) ... https://community.openproject.com/wp/26168 [ci skip]	7 years ago
Oliver Günther	6af0ee6efa	[26163] Skip activation of edit field on link click (#5869) ... Avoids a race condition that causes an internal error message on FF. https://community.openproject.com/wp/26163 [ci skip]	7 years ago
Oliver Günther	ea19a9697d	Fix aria-label when textnode before html node (#5868) ... [ci skip]	7 years ago
Oliver Günther	354bb70b20	[26117] Allow deletion of attachments in create mode ... https://community.openproject.com/wp/26117 [ci skip]	7 years ago
Oliver Günther	d3591a2793	[26100] Forcibly set the width of edit fields to that of the column ... By forcing the width of a new edit field in the table to whatever width the column has available, we can ensure that it won't trigger the browser to expand the column https://community.openproject.com/wp/26100 [ci skip]	7 years ago
Oliver Günther	98d0e65346	Fix inline create mirroring and height (#5858) ... [ci skip]	7 years ago
Roman Roelofsen	6b751b3ed4	Fixes bug in FF, exception on right click in timeline ... (cherry picked from commit 860f424)	7 years ago
Oliver Günther	645f0ceba9	Minor inline-create timeline styling fixes (#5849) ... * Fix row mirror in timeline * Add bottom to timeline body * Re-enter new timeline row upon rendered [ci skip]	7 years ago
Henriette Dinger	2171165ecc	Fix alignment issues on WP full view (#5845)	7 years ago
Oliver Günther	09637bd629	[26086] Fix switching from timeline (#5848) ... * [26086] Fix switching from timeline https://community.openproject.com/wp/26086 * Add regression test [ci skip]	7 years ago
Henriette Dinger	6347675f87	Increase video height to avoid black border	7 years ago
Oliver Günther	4466832f38	[26044] Fix cancel editing for milestones (#5833) ... https://community.openproject.com/wp/26044 [ci skip]	7 years ago
Roman Roelofsen	e83d636662	26011 timeline invalid cursor interaction on labels and subject (#5830) ... * Timeline view: Start/due dates can not be changed anymore while the mouse cursor hovers labels * timeline bar: highlight left and right handle on hover * timeline bar: highlight left and right handle on hover [ci skip]	7 years ago
Oliver Günther	ee93b01152	Don't build resource from empty changeset (#5832) ... [ci skip]	7 years ago
Oliver Günther	3a6f2e2278	[26044] Handle escape in field handler and reference form in table (#5828) ... * [26044] Handle escape in field handler and reference form in table Mousetrap was used to trigger escape on the field, but since we already have a keydown handler attached to it, we can re-use it for cancelling the field editing. While fixing this, I found out that the table edit context uses a new form for each field, which means the edit handler of the previous field is lost. A new reference context is held in the table to return existing forms, if any. In the single view, this is tied to the $scope of the edit field group, and thus ensure only one form exists. * Fix specs of long text fields now no longer escape-able. [ci skip]	7 years ago
ulferts	2f9d7f408a	Fix/wp table switch to milestone (#5825) ... * map date name in changeset * handle date switch in wp form * Don't stub_const for services that may exist before hand This will cause the const to be evaluated already, so that stub_const has no effect there. This is why this fails depending on the order on travis, but not locally/isolated. [ci skip]	7 years ago
Oliver Günther	e08ecfb1b6	[26041] Update selection and focus on state links as well (#5827) ... This ensure that we now which row has been clicked on, so that the details controller does not need to update the selection, but rather the table can do that beforehand. It only needs to set the selection when entering the page on an open details pane. https://community.openproject.com/wp/26041 [ci skip]	7 years ago
Wieland Lindenthal	33d71f25f9	Fixing that only first fold of screen was printed (#5808) ... * Fixing that only first fold of screen was printed Affected both Chrome and FF. https://community.openproject.com/projects/openproject/work_packages/259 44/activity * Enable printing of timelines again and dropping that for FF * [printing] Remove notification boxes * [printing] Extract FF specifics to extra block This avoids changes from flexbox to block where unnecessary, i.e. in Chrome. * [printing] Hack to improve positioning of relations lines in A4 landscape from page 1 to page 2 * [printing] Fix the hack for lay outing the WP list header * [printing] avoid page breaks inside table rows just as timeline rows [ci skip]	7 years ago
Oliver Günther	06e50797d9	Remove applying values from filter in inline create ... Will be solved in 7.3. with #26042 [ci skip]	7 years ago
Oliver Günther	02b21741ff	[26033] Remove base path when checking for angular URLs (#5824) ... The ui-router does not handle URLs with a base path, but instead the URLs are rewritten internally using the <base /> tag. This causes some links of the more menu to be incorrectly judged as non-angular links, causing a full reload without the query params. https://community.openproject.com/wp/26033 [ci skip]	7 years ago
Oliver Günther	b208726bef	[26035] Don't clear stale cache states (#5823) ... When a state is stale, its value was cleared. This causes e.g., a visual delay in the split screen beacuse a work package is no longer present in the system. If we instead only load the value, the stale value will be available for the period of the request of the next one. Regular value-subscriber of the state will thus receive the stale value first, followed by the refreshed value. https://community.openproject.com/wp/26035 [ci skip]	7 years ago
Oliver Günther	3222bc89d9	[26039] Fix null checking the date for milestones ... moment(null) returns a non-null value, but moment(null).valueOf() will correctly return NaN, which is used in the bar renderer, but not the milestone renderer. [ci skip]	7 years ago
Oliver Günther	466984f993	[26037] Don't initialize a changeset by copying (#5821) ... * [26037] Don't initialize a changeset by copying As it turns out, copying the resource and defaulting to the form is REALLY expensive. Since creating a new empty changeset should be cheap (its convenient to simply have on available in the timeline), we don't really need to copy the resource from the work package. https://community.openproject.com/wp/26037 * Insert the initial changeset to the state [ci skip]	7 years ago
ulferts	06a11ade58	fix milestone date edit in wp table (#5820) ... [ci skip]	7 years ago
Oliver Günther	4bc6b58b16	[26029] Provide custom unique name for pasted images (#5818) ... Chrome and Firefox paste images using the `image.<extension>` name. Since we upload them with these name, the formattable directive inserts an inline image link to `!image.<extension>`. If there are multiple of this kind, only the first one is referenced. https://community.openproject.com/wp/26029 [ci skip]	7 years ago
Oliver Günther	2116aa0583	Rebuild the resource when changeset is cancelled (#5819) ... [26038] Rebuild the resource when changeset is cancelled [ci skip]	7 years ago
Oliver Günther	2d5e4d45f2	Extract idFromLink into HalResource	7 years ago
Oliver Günther	1bad575ace	Only update the form for type and project for NEW work packages	7 years ago
Oliver Günther	d49aec0dc7	Reset form when creating a new inline row	7 years ago
Oliver Günther	f93ed2b992	Update labels AFTER changeset reset	7 years ago
Oliver Günther	6e7336710b	Avoid saving the WP if changeset is empty	7 years ago
Oliver Günther	3c357aeca2	Remove unused startEditing ... We no longer need to set the current value, since we fall back to the resource value.	7 years ago
Oliver Günther	06af69a182	[24916] Handle images from dataTransfer.images without file name ... Older versions of chrome did not pass pasted image data through `dataTransfer.files`, but in `dataTransfer.items`. These items are not files, but blobs without a file name. We can still allow uploading them by detecting the mime type in a basic manner. This has been fixed in Chrome January 2017. https://bugs.chromium.org/p/chromium/issues/detail?id=361145 https://community.openproject.com/wp/24916 [ci skip]	7 years ago
Roman Roelofsen	3e73601ba2	Sync hover between table and timeline rows (#5814) ... * Initial work on row hover sync * Sync hover between table and timeline rows * - Sync hover between table and timeline rows - simplified zIndex values * removed commented code [ci skip]	7 years ago
Oliver Günther	f8ffe527d3	Don't call disable just for resetting the placeholder TL element	7 years ago
Oliver Günther	69f4bf2d24	Fix moving in timeline ... Fixes #26019	7 years ago
Oliver Günther	ba60f27bbd	Fix broken copy spec due to double initialization	7 years ago
Oliver Günther	3968c26104	Fix clearing the edit form upon cancelling the edition	7 years ago
Oliver Günther	b8ab32d789	Don't access the changeset in the wiki subclass comment field	7 years ago
Oliver Günther	0bc6e4bc40	Reject the form update ONLY when trying to save	7 years ago
Oliver Günther	a46d9b1ca5	Fix usages of form and usage of raw values	7 years ago
Oliver Günther	9515b58f49	Reject submission earlier when validationErrors in form	7 years ago
Oliver Günther	591c665639	Store only the changeset in a state, not the form itself ... With the changeset being the authoritive source of the changes to a work package, we can pass it around. Also, a temporary resource for viewing the changes made to the work packages is available through the editing service. This is required since we need to show the WP resource as it were if the changes were applied.	7 years ago
Oliver Günther	589f228776	Create resource that contains the changeset and form	7 years ago
Oliver Günther	9687734a97	Only add to changes once changed	7 years ago
Oliver Günther	6663939ce9	Allow initialization with a new form resource ... Avoids loading the form again when the single view initializes the form editing.	7 years ago
Oliver Günther	7bafb6f5e2	Let timeline maintain a single changeset in renderInfo	7 years ago
Oliver Günther	b1945d97df	Correct focussing on new fields when switching	7 years ago
Oliver Günther	e9bd077d9b	Allow traversal from one single-view to the other (e.g. split -> full) ... This requires us to keep changes open if we're starting to edit other fields.	7 years ago