3876 Commits (f89f19dffcfd991dd8a868a56889425cd5cfffe8)

Author	SHA1	Message	Date
Markus Kahl	7f88ba5b22	removed attachments#show; only #download remains	9 years ago
Jens Ulferts	8c506b6f6e	remove redundant security check ... One might be able to constantize arbitrary objects (those that exist) but the checks after the constantize are very strict. They will only allow the find method to be called on objects inheriting from Acts::As::Watchable. The only parameter that is allowed for the method is an integer.	9 years ago
Stefan Botzenhart	e7490c1988	Fix copy project ... After switching to strong parameters mass assignment for project params is not supposed to work without permitting params. We now pass a normal hash instead of a ActionController::Params hash. Otherwise we get an ActiveModel::ForbiddenAttributesError All errors on the job are being rescued and logged to a separate file. Normally rescueing all errors on Exception is not something you want to do but as the job has an ensure block you won't know about any failures.	9 years ago
Stefan Botzenhart	1f53f5472e	Code style enhancements to fight against bad scoring	9 years ago
Markus Kahl	c256cfbb46	fixed documents/new by not requiring optional params	9 years ago
Jens Ulferts	6750ecfdc3	remove no longer required concern	9 years ago
Jens Ulferts	b0e80e3448	streamline work_packages_controller ... because of the reduced actions, the complexity of the controller as well as in the tests can now be reduced	9 years ago
Jens Ulferts	eec7a844bc	remove remains of no longer existing actions	9 years ago
Jens Ulferts	4f43470f7b	403/redirect on work package not existing/not visible	9 years ago
Jens Ulferts	acf2cfcf11	use correct AR method to reverse ... This is the same as in 03a3460	9 years ago
Markus Kahl	0abc54d5ab	don't fail invitation on long email addresses	9 years ago
Markus Kahl	4bc8365075	don't fail invitation on long email addresses	9 years ago
Markus Kahl	5324b2cc07	drop my first_login; redirect to work packages if possible	9 years ago
Oliver Günther	f508d81655	Restore journals for atom access	9 years ago
Oliver Günther	b64ef39986	Remove relations	9 years ago
Oliver Günther	69fae7bc54	Remove other remnants	9 years ago
Oliver Günther	eb888b7d2e	Remove views and actions	9 years ago
Jens Ulferts	d364d7d418	indentation	9 years ago
Jens Ulferts	8868b3d741	reremove line accidentally readded by merge dc3337a	9 years ago
Jens Ulferts	03a3460ba2	use AR method to reverse ... reverse! is not defined on an ActiveRecord AssociationProxy. This used to work when an array was still returned	9 years ago
Oliver Günther	32da16e979	Avoid internal error when project not found	9 years ago
Oliver Günther	135e7b4dfc	Use Core PermittedParams to add new strong_param key	9 years ago
Jonas Heinrich	54bccf70f8	Rename Settings to System Settings	9 years ago
Mohamed Wael Khobalatte	80192f6986	Do away with eval ... Eval is unnecessary here. Sure the code has slighly more duplication, but no where near enough to warrant an eval.	9 years ago
Mohamed Wael Khobalatte	c9b46dfd15	Ensure save and delete routes are working properly	9 years ago
Mohamed Wael Khobalatte	e2d0172353	Move add budget to toolbar	9 years ago
Mohamed Wael Khobalatte	391ad369a0	Add id to params to allow proper updates	9 years ago
Mohamed Wael Khobalatte	a11b57ea39	Resolve cucumber issues with whitelisted attributes	9 years ago
Mohamed Wael Khobalatte	9b4e0065a7	Fix issues with using attributes= in non-controller code ... This caused a ForbiddenAttribute all over the place, in addition to other related errors.	9 years ago
Mohamed Wael Khobalatte	3c7b8f5010	Ensure we actually mutate params when processing them ... Before, we were processing start_date in meetings params, but on a different hash, so we lose the work we did.	9 years ago
Mohamed Wael Khobalatte	2f10c30828	Add support for strong params	9 years ago
Stefan Botzenhart	a30a2c83f0	Fix rubocop issues	9 years ago
Stefan Botzenhart	463a115d6c	Fix rubocop issues	9 years ago
Stefan Botzenhart	3030d1336e	Fix rubocop issues	9 years ago
Mohamed Wael Khobalatte	a6422e1e73	Add support for strong params	9 years ago
Mohamed Wael Khobalatte	35693f2940	Re-implement my/page block drag and drop in dragula and jQuery ... We part ways with Protoype's Sortable module, link_to_remote, and some javascript in favor of a tigher implementation using dragula, jQuery, and some js.erb responses. Sorting logic was also simplified; we now merely send the state of the source and the target of the drag&drop to the server where it persists. We no longer make a special case for each of the containers.	9 years ago
Mohamed Wael Khobalatte	0e72ec4243	Move to ruby1-9 syntax once and for all	9 years ago
Markus Kahl	1fbdec561e	allow new users independently from password config ... The new user form has been simplified and decoupled from the password/authentication choice previously. Accordingly we may, nay, we must enable the user creation again even with the password login disabled. In such a case a user will have to use OmniAuth.	9 years ago
Oliver Günther	589ba8e7b1	Relocate repositories locally and remote ... This commit introduces relocating a repository as a followup after a project's identifier has been renamed.	9 years ago
Mohamed Wael Khobalatte	4f3930be79	Call the correct hook for costs plugin	9 years ago
Mohamed Wael Khobalatte	602dd749e3	Ensure versions params play well with plugins	9 years ago
Mohamed Wael Khobalatte	a1bf92212d	Fix legacy and cucumber specs failing because of strong params	9 years ago
Mohamed Wael Khobalatte	8ec4b40b11	Restore own User#find_by_mail impl, as it was doing more than just find	9 years ago
Mohamed Wael Khobalatte	d2349cf819	Delete Redmine's safe_attributes implementation ... It was an early implementation of strong_parameters, more or less. Going forward, we should strive to make the whitelisting of attributes a controller responsibility only.	9 years ago
Mohamed Wael Khobalatte	972b04d86e	Refactor to allow for strong params ... We no longer need attr_accessible.	9 years ago
Peter Lehwess	58e4966a64	Enable editing project identifier via an extra form	9 years ago
Oliver Günther	02807e02a8	Refactor CopyProjectJob to class	9 years ago
Jens Ulferts	b0a86a69c2	refactor types action on projects controller ... * Introduced a service to reduce complexity in the controller * Used permitted params to ensure params syntax * Introduced a scope for querying for types used by a work package of the project	9 years ago
Jens Ulferts	8cfe5ecef8	quickfix for showing a meaningfull error message ... And no empty notice.	9 years ago
Jens Ulferts	7eb8bdad53	invert setting for self notification ... Using the positive version to make it easier to understand. In order to avoid having to write a migration, the model layer encapsulates the transformation. Direct assignments to :no_self_notified is still possible.	9 years ago