2423 Commits (f9051bba3eb039820ad6b7977db96344c251d873)

Author	SHA1	Message	Date
Oliver Günther	05b27c1b98	Asynchronous creation, deletion of repositories from OP. ... This PR begins the push towards management of repository lifetime from within OpenProject. What this currently provides is the following: - A mixin `ManageableRepository`, included by `Repository::{Git, Subversion}` to provide an interface to repo management - Two services and delayed_job workers for creating (`CreateManagedRepositoryService`) and deleting (`DeleteRepositoryService`) - Customized rendering of subforms in the repository settings for arbitrary SCM vendors. TODOS: - [x] Provide sane ground to work on ( cf. PR #3149 ) - [x] Rework SCM settings form (`{scm}_tags` is currently HTML generated from within a Helper.) - [x] Ease integration of arbitrary SCM vendors - [x] Display meaningful error / warning when user looks at bare repository (currently outputs 500, as Git HEAD / svn revision is not available) - [x] I18n - [ ] Specs (in progress) - [x] Fix legacy specs - [ ] Decide what to do with `Filesystem` adapter. Open Questions: - **Configuration**: Currently replaces the existing options in `configuration.yml`. - **Implementation specifics**: - Sub-projects repositories reside in a hierarchy below their parents - How should the delayed_job react upon failure? (esp. creation of repositories) Relevant work package: https://community.openproject.org/work_packages/20416 Merge dependent on PR #3149	9 years ago
Oliver Günther	7ebac37c14	Repository Management - Refactoring and Preparation ... Related work package: [#20415](https://community.openproject.org/work_packages/20415). This is a combined refactoring and extraction effort of local SCM functionality for SVM, Git adapters in preparation for the explicit lifetime management of repositories in #20416 and implementation of (local) repository storage quota in #18393. This PR is still heavily WIP and for the time being, depends on the **legacy specs** for testing. To run the tests, execute the following steps: ~~~ rake test:scm:setup:all rake spec:legacy ~~~ I'm open for ideas on how we integrate scm adapters tests into current specs. --- - [x] Exchange `IO::Open` for `Open3` to avoid countless manual exitcode checks - [x] Extract local functionality in its own Module - [] Extend `LocalClient` module with links to create/delete services for #20415 - [x] Break down unbearable local parse routines (Hound will be over the place until fixed - but down from 260 to < 20) - [x] `entries` - [x] `revisions` - [] local repository factory - [] Specs - [] Fix / Modernize - [] More adapter-related specs	9 years ago
Jan Sandbrink	a8ab1024b5	clarify explanations ... typos, wording and stuff	9 years ago
Jan Sandbrink	5f06a8900d	better PSQL compatibility for aggregated journals	9 years ago
Jan Sandbrink	f02b32faad	override :initial? for AggregatedJournal ... the simple approach of looking at the version number does not work, because aggregated journals can have gaps in their versions (and there might be no version 1)	9 years ago
Jan Sandbrink	a5152e9875	use the actual setting for the aggregation time	9 years ago
Jan Sandbrink	88169a46de	expose id of "master" as notes_id ... - make spec assertions more detailed by comparing all the attributes	9 years ago
Jan Sandbrink	3c3b03bbcc	make SQL compliant for both MySQL and PSQL	9 years ago
Jan Sandbrink	405aa2d524	add PostgreSQL-compatible group numbering	9 years ago
Jan Sandbrink	3b7b0ec289	Enhance AggregatedJournals to correctly merge journals with notes ... Aggregation should now follow the rules previously defined for merging journals (see code comments). Jens (@ulferts) and I developed the SQL for this. I hope the explanatory comments make it a quite readable SQL experience.	9 years ago
Jan Sandbrink	ddbc8a4ba7	remove obsoleted helper	9 years ago
Jan Sandbrink	5ed1ff28c1	styling	9 years ago
Jan Sandbrink	885d8d734f	add basic spec for aggregated journals	9 years ago
Jan Sandbrink	ec720a0533	make aggregation capable for MySQL and PSQL ... - also give the time threshold a useful meaning (number of seconds)	9 years ago
Jan Sandbrink	d6533b100c	first spike for aggregatable journals	9 years ago
Alexander Bach	7e0c7c352e	Move event to fire after its sure that a journal will stay	9 years ago
Alexander Bach	0cf0468ebf	Add default value for send_notification	9 years ago
Alexander Bach	ee14628c09	Move send_notification to event origin	9 years ago
Alexander Bach	a5f4eb1e8b	First event-based draft ... Unifies Journal- and WorkPackageObserver Removes them as observers Makes new JournalListener more classy	9 years ago
Alexander Bach	c22ce53a7a	Add journal_created event	9 years ago
Jan Sandbrink	17940bf02c	change validation of WP children ... - do not add error on a symbol called :#123 (123 is the childrens ID) - this is against the semantics of ActiveRecord::Errors - creating symbols in a loop used to be a bad idea (might be better today) - it breaks error messages in the APIv3 (which is due to APIv3 working beyond the borders of AR errors, not the best of ideas...) - use :base instead, the place for unlocatable errors - include the fact that #123 refers to a child element in the error message Basically I feel that this makes the children validation cleaner and better. But somehow I fear, that there is some code out there that depends on the fact that error keys like :#123 existed...	9 years ago
Jan Sandbrink	218c75e765	fix update_by! user when not providing notes ... - previously the created Journal Entry would have been made by the specified user or the User.current, dependent whether :notes were provided or not - now the journal entry is always made by the specified user	9 years ago
Alexander Bach	c42dad3270	Correct comment	9 years ago
Alexander Bach	2f9c9178df	Fix regex properly	9 years ago
Alexander Bach	248f11fba8	Correct style	9 years ago
Alexander Bach	1a52cc1292	Suppress the hound	9 years ago
Alexander Bach	851f8bf3d1	Make validation regex comply with hint	9 years ago
Jan Sandbrink	9f4ebc04a5	fix moving of WPs without specifying a status ... attributes without a value are actually represented by empty strings. Thus only take the status_id if it is :present? (the inverse of :blank?)	9 years ago
Jan Sandbrink	96d0cf9462	fix moving of WPs without specifying a status ... attributes without a value are actually represented by empty strings. Thus only take the status_id if it is :present? (the inverse of :blank?)	9 years ago
Oliver Günther	cb123c83be	Fix and specs for missing plus in login attribute ... Fixes the merge issue from 105934a5f9	10 years ago
Jan Sandbrink	9a9d6aca2c	ensure correct file size errors are displayed	10 years ago
Jan Sandbrink	4a69d2505a	replace ternaries returning booleans ... - foo ? true : false was replaced where foo already was bool - foo ? true : false was kept, when the ternary did a bool conversion - foo ? false : true was replaced by either negation or replacing == with != Note: I intentionally left one occurence that is fixed in another running PR and would cause a conflict	10 years ago
Markus Kahl	8f7d8ef573	avoid unnecessary work	10 years ago
Markus Kahl	2b8848dc8b	don't use deprecated finder	10 years ago
Markus Kahl	6cb6953a07	basic auth for api v3 (WIP)	10 years ago
Jan Sandbrink	f1a93e1cf3	this is why I hate comments	10 years ago
Jan Sandbrink	c075a7b401	only allow simple space in login ... also add specs to verify that	10 years ago
TribesTom	2910137c03	Added user changement	10 years ago
Alexander Bach	55f5f33456	Changed code readability	10 years ago
Alexander Bach	942f39876f	Removed hard coded id column for pdf export	10 years ago
Alexander Bach	404a5b42e6	Remove hard coded id column for csv export	10 years ago
Jan Sandbrink	88107362b1	enhance PSQL compatibility of cast_value ... In PSQL a valid boolean can also be represented using other value than '0' and '1' This led to cast_value sometimes returning false, even though it was supposed to return true...	10 years ago
Jan Sandbrink	eb9ef1f2b1	replace occurences of cast_value with typed_value	10 years ago
Alex Coles	54ff7af6e7	Add/update Copyright headers in app code ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Jan Sandbrink	60ca779111	make transform to boolean more database resistant ... PostgreSQL has many representations for bool: http://www.postgresql.org/docs/9.1/static/datatype-boolean.html	10 years ago
Alex Coles	ef4285bc0c	Kill deprecated Setting.*_cache methods ... Deprecated in version 2.4.0 (2011). See: d76fd8e4. Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alexander Bach	9f692f6bf1	Use the empty string for absent descriptions	10 years ago
Jan Sandbrink	f9b242884d	let custom values accept their native type ... - add specs for strategies to parse their typed representation as valid (instead of only their stringly typed counterpart) - add specs to int and float strategy regarding accepting eachother - fix int custom values accepting float inputs (which would work, but omit the fractional part) - fix date custom values not accepting on Date	10 years ago
Alexander Bach	2d2f18b2c5	Remove unused code	10 years ago
Alexander Bach	ee31bc9762	Increased code readability	10 years ago