openproject

Commit Graph

Author	SHA1	Message	Date
Oliver Günther	8f0dfb21d7	[36688] Set default locale before checking authorization (#9114 ) We do set the user's desired (from HTTP headers) or saved language preference, but that is called after `check_if_login_required` so in some cases we return before setting localization https://community.openproject.org/work_packages/36688	4 years ago
ulferts	1bdd2ab9ae	safe automatic fixes by rubocop (#8994 )	4 years ago
ulferts	6140f4c7e9	update copyright to 2021 (#8925 ) Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded. Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013	4 years ago
ulferts	47e5ee26f2	load doorkeepr helper explicitly	4 years ago
ulferts	d695d03411	Fix/plugin settings breadcrumb label (#8618 ) * simplify code now that i18n can handle defaults * standardize settings plural i18n key * remove unused variable	4 years ago
Oliver Günther	bb8b6efef6	Add logout URL for header based SSO	5 years ago
ulferts	4cb0d0ff91	Feature/delayed bcf export (#8275 ) * delayed bcf export * remove unnecessary eager loading * Update rxjs polling statement with loading indicator * Avoid error handling due to JSON parsing * delay all wp list exports Co-authored-by: Oliver Günther <mail@oliverguenther.de> [ci skip]	5 years ago
ulferts	4dad6a4485	remove attachment unsuccessfully saved warning method Attachments are now always uploaded up front, uncontainered, and after a successful upload and save of the intended container, assigned to the container.	5 years ago
ulferts	9e2287bfcc	rename and inflect according to zeitwerk	5 years ago
Henriette Dinger	3ebe7f4d52	Add missing breadcrumbs and remove unnecessary ones	5 years ago
Henriette Dinger	efc9fc1062	Show first level menu entries per default in the administration	5 years ago
Henriette Dinger	bd7f4e4814	Update copyright notice	5 years ago
Henriette Dinger	67dd3bcb46	Replace all occurrences of settings_project_path && make toolbar and menu title consistent	5 years ago
Henriette Dinger	cbc530ca9d	Move project_settings_path to ApplicationHelper to be globally available and start adapting tests to new structure	5 years ago
ulferts	7d4a4a19e7	use join table for storing activites active in project	5 years ago
Oliver Günther	91ecb3ba1e	Fix resetting the session for non-html requests this caused a CSRF issue on saas. Requests were being redirected to /admin/subscriptions/expired and wrongfully so for API and CSS requests. Now imagine a request to `/` with `login_required` for a non-logged in user 1. The GET `/` request is redirected to `/login?back_url=...` by ApplicationController. Session is reset here to X 2. The user receives the login form with CSRF value from session X 3. A request is made to `/api/v3/configuration` from the frontend. It too is redirected to a Rails controller and ends up in the same `check_if_login_required` flow, resetting the session again 4. The user now has a session cookie Y, but the CSRF form is still from X 5. submitting it results in 422 CSRF validation error	5 years ago
ulferts	4e5b9afef5	rename project attributes	5 years ago
Oliver Günther	e0f5dee13d	Show an error when WP cannot be loaded	5 years ago
Oliver Günther	8a8193fa15	Add info on thread and connection pool for timeouts errors - Added to Rails controller request handling - Added to API root to catch all api requests as well Tested on sentry with both as https://sentry.openproject.com/sentry/localhost/issues/909/?query=is:unresolved	5 years ago
ulferts	d74dd04241	remove outdated api/atom references	5 years ago
ulferts	08391c7807	replace my_project_page by grid implementation	5 years ago
Oliver Günther	b9baa6cd08	Don't rescue_from when local_requests is set [ci skip]	6 years ago
Oliver Günther	0d5f50395e	[29253] Render error message in production on pending migrations Creates a new warning bar (previously top-shelf item) that renders a warning when migrations are pending. These did raise exceptions before in production and would result in users running in internal errors due to pending migration on some actions on the instance. https://community.openproject.com/wp/29253	6 years ago
Jens Ulferts	6e315c45fe	have dedicated controller in my_page engine	6 years ago
Oliver Günther	c5994d3b9b	Rename Boards to Forums	6 years ago
Oliver Günther	3bfde3bf0f	Log only internal errors to sentry [ci skip]	6 years ago
Oliver Günther	451331a910	Invalidate session,s extract passwords flow into services	6 years ago
Oliver Günther	81c7b40b7e	[29595] Remove cost_entries page when cost reporting is disabled This page was broken for some time and is never hit unless cost reporting is disabled, but costs is enabled. https://community.openproject.com/wp/29595	6 years ago
Oliver Günther	8ab4f2a663	Boards module (#7008 ) * Hack spike to show D&D use case [ci skip] * Add ordered work packages * Save order on existing work packages * Boards WIP * CDK drag * Add dragula handler [ci skip] * Add filter to return all manual sorted work packages * Print icon on hover * Boards routing and list components * Better loading indicator on list with streaming result [ci skip] * Add new board and list buttons [ci skip] * Post new query [ci skip] * Added creation of new board lists with persisted queries [ci skip] * Render placeholder row in empty queries [ci skip] * Push boards on grid * Use base class in scope [ci skip] * Extend api for options * Hack spike to show D&D use case [ci skip] * Add ordered work packages * Save order on existing work packages * Boards WIP * CDK drag * Add dragula handler [ci skip] * Add filter to return all manual sorted work packages * Print icon on hover * Boards routing and list components * Better loading indicator on list with streaming result [ci skip] * Add new board and list buttons [ci skip] * Post new query [ci skip] * Added creation of new board lists with persisted queries [ci skip] * Render placeholder row in empty queries [ci skip] * Save queries in grids [ci skip] * Renaming queries [ci skip] * Add existing work packages to board [ci skip] * Introduce card view component for work packages * Extend grids to allow project scope for boards (#7025) Extends the grid backend to also be able to handle boards. In particular, it adds the ability of boards to be attached to projects and changes the page property of grids to a scope property that better describes that more than one board can belong to the same scope (e.g. /projects/:project_id/boards). For a fully featured board, though, widgets need to be able to store options, so that they can store queries. Those widgets might also need to have custom processing and validation. That part has not been implemented. * introduce project association for boards * have dedicated grid registration classes * update and create form for board grids * extract defaults into grid registration [ci skip] * Add drag and drop to card view [ci skip] * Add options to grid * Fix option migration name * Renaming boards [ci skip] * Frontend deletion of boards * Avoid map on NodeList which doesnt exist [ci skip] * Add inline create to boards [ci skip] * Smaller create button [ci skip] * Add navigation for boards * Make inner grid same height * Replace index page with table * Workaround for widget registration [ci skip] * Fixed height for cards and tables [ci skip] * Implement escape as cancel d&d action [ci skip] * Fix and extend grid specs for name and options * Extend board specs for required name * Fix migration for MySQL references https://stackoverflow.com/a/45825566/420614 * Make board list extend from widget Since we cannot configure widgets yet, it's not yet possible to use a board-list widget anywhere. * Fix specs * Fix escape listener removal [ci skip] * Fix renamed to_path in relation spec [ci skip] * Allow deletion of grids for boards * Avoid reloading resource multiple times with replays * Frontend synchronization on deletion [ci skip] * Delete through table * Use work packages board path * Use work packages board path * Fix augmented columns breaking re-rendering * Fix duplicated permission with forums * Strengthen tab switch in specs * Add hidden flag for project-context queries Allows the API to create a hidden query that will not be rendered to the user even if it is within a project context. * private queries * Add hidden flag for project-context queries Allows the API to create a hidden query that will not be rendered to the user even if it is within a project context. * Move boards below work packages * Add Board configuration modal * Fix reloading with onPush * Saving / Switching of display mode [ci skip] * Extract wp-query-selectable-title into common component * Fix renaming of board-list * Fix auto-hide notifications in boards * Add permissions to seeders * Reorder lists in board * Linting * Remove default gravatar from settings * Show assignees avatar in the card view of WPs * Fix specs * Add missing method * Fix timeline icon * Use URL as input to be able to show avatars for groups, too * Fix test * Add further specs * Use correct data attribute to avoid unnecessary data base calls * Add further specs * Deletion of board lists * Pass permission via gon to decide whether we can create boards * Fix rename spec * Cherry-pick of `7873d59` and `30abc7f`	6 years ago
Oliver Günther	fb8a600579	Add reporting for CSRF validation error	6 years ago
Oliver Günther	1ba8422a36	Add lograge and log delegator	6 years ago
Oliver Günther	14c6e82882	Create error handler and helper for streaming to multiple receivers	6 years ago
Oliver Günther	52e88daadb	Redirect to correct controller https://sentry.openproject.com/share/issue/ea1e3470aef946db8c4b518dc9ec21e3/	6 years ago
Oliver Günther	fbc0b2dd44	Add fallback to unknown format https://sentry.openproject.com/sentry/saas-openproject-prod/issues/129	6 years ago
Oliver Günther	3a59dcb94a	Send HEAD 404 on any mime type	6 years ago
Oliver Günther	c3226bf2c0	Reload shared_lets by default	6 years ago
Oliver Günther	f86abae9eb	Enforce Arel.sql for string order, pluck	6 years ago
ulferts	4209539da9	Feature/angular calendar (#6766 ) * replace rails based calendar with angular * render empty calendar * update query on month switch * introduce specific interval filter * show colors * remove now unused filter partial * start on retaining the view in the url * hide datesInterval filter * I18n for calendars title * stengthen explicity of expected filters * spec moving to the next month * fix FilterSerializer reference * remove outdated feature spec * rework calendar controller specs * avoid undefined columns * bump ng-calendar to 1.7.0 * Revert "fix FilterSerializer reference" This reverts commit 2bb2e574cdd664a02a4eb9c3e94b5a170aec0a67. * Revert "avoid undefined columns" This reverts commit bcbb381b34b095526d3ee1aa15d6263a658c03c0. * load initial query only after calendar has been loaded * implement month remembering * implement history back and forth * cleanup code * remove unused methods * remove order value from filters * replace rails calendar widget completely * fix shrinkwrap * move module into correct namespace * linting * remove unused js * calculate full calendar height dynamically * setting calendar locale from service * retain week on reload * show notification in case of too many results * show tooltip on hover * go to work package on click * deactivate tooltip before wp show * narrow down style to tooltip * [28885] Improve html title consistency when navigating to queries Currently, query names are not reflected in the HTML title. This results in 'wrong' titles being shown when entering a split or full view and then returning back to the list. https://community.openproject.com/wp/28885 [ci skip]	6 years ago
Oliver Günther	b9c065505a	[28579] Ensure resetting the session before forwarding to login This might just fix the following issue since the cookie will be deleted and reset. https://community.openproject.com/wp/28579	6 years ago
Inga Mai	2d0d2feccf	[27828] Feature: Query menu in sidenav (#6429 ) * in main menu add gantt as extra work package child item * Satisfy spec and code climate * Add gantt chart icon behin default gantt query name. * WIP Query menu in left sidebar * Shift query dropdown in left sidenav * Reload menu or load query on click from every project location * WIP set correct label for default queries * Query menu listens on all changes of queries (delete, create, rename, toggle starred) and updates immediatly * WIP: Inline edit, field validation * Inline Edit validation and comfirm * Inline edit: validation of duplicate name * Set default columns and sorting for static queries * Codeclimate issues fixed * WIP Inline edit validation not working perfectly in all error states * Inline edit working * Autocompleter hover disabled and hovering over categories fixed * Category hover and toggle fixed; tested in Chrome, Firefox and Opera * Placeholder cut off fixed and text wrap added * English and german wording adjusted * Styles of inline edit and menu adjusted; matching wiki page styles * prevent menus to be displayed to often * application menu only displayed on work package * specify using no_menu layout more often * adapt tests to altered production implementation * Hamburger icon only in project; on global wp page: default queries shown correctly and summary removed * searching for undefined leads to error * Accessible click fixed (listen on escape) * Gantt in top menu deleted (gantt chart is part of default queries on wp page) * load menu on wp summary page * reduce times queries are loaded * lowercase on second word * remove menu from search and home * Styles fixed (category toggle and correct highlighting) * reflect static query in url * fix autocomplete handling in specs * Open all global menus on default and hide hamburger icon on global pages; Rebuild changes that have been ovrwritten after merge" * Correct highlighting of default queries after reload * Replace summary cuke with spec * WIP * Clear up selectors * Avoid actively setting promises and instead use $state.go to load links [ci skip] * Make editable title component a little simpler We can reuse the component I built for the wiki, that wasn't present in the frontend beforehand. * Fix moving through the menu and selecting items [ci skip] * Add save button to query title when query changed * Improve static names lookup by comparing query_props * Adapt and fix specs * Allow inner scrolling of wp query results Also, style the webkit scrollbar to make it pretty where supported * Allow renaming the query through setting menu, but simply focus on field [ci skip]	6 years ago
Oliver Günther	d980ec8d30	Avoid running into 422 loop due to null session The default Rails 5 behavior is throwing an exception when a CSRF violation occurs. Since we override +handle_unverified_request+ for detecting API requests, the super behavior would be to override the current session with a null session object This results in no session cookie being created for the anonymous user and subsequent POST requests being impossible. For example, this will happen when you invalidated your cookies while on the login page and try to log in. You will remain in a 422 loop because there is no valid CSRF token. If we instead use `reset_session` only, a new session is generated, the user is logged out and reset, but the following request may issue new data into the session. https://community.openproject.com/wp/28072	6 years ago
Jens Ulferts	e58a96515c	allow setting attachments through wp post/patch	7 years ago
Oliver Günther	ead0034795	Allow application controller before hook [ci skip]	7 years ago
ulferts	f1b1aa7839	Fix/back url when already logged in (#6166 ) * use the provided back url when already logged in But check the validity of the back_url to not be used maliciously to redirect users to pages outside our host * minor coding style improvements [ci skip]	7 years ago
Oliver Günther	6ef4211e77	Bump copyright to 2018 (#6171 ) [ci skip]	7 years ago
Oliver Günther	177f4e8963	Remove APIV2 and project associations / reportings [ci skip]	7 years ago
Markus Kahl	4e4ed9bbe8	verify authenticity of stage complete calls (#6014 ) * verify authenticity of stage complete calls * fixed path helper name [ci skip]	7 years ago
Markus Kahl	4b316ec470	LDAP Single Sign-on (#5888 ) * ldap sso * localise sso failure error * code climate * code climate 2 * code climate 3 * added missing login param * make spec work with SSO module prepended to ApplicationController * polish [ci skip]	7 years ago
ulferts	c0b709530c	Fix/replace deprecations (#5533 ) * replace alias_method_chain * remove deprecation silencing * bump controller-testing * introduce permitted params for settings * replace various deprecations in controllers * remove deprecation silencing for legacy_specs * remove `puts` from spec * replace deprecated access to errors * remove unnecessary AR::Parameters usage in spec * specify error to expect * replace deprecations * replace deprecated action calls in legacy function specs * replace deprecations in functional controller tests * replace deprecations in controllers/controller_specs * remove params parser which does not seem to be in effect It is registered for the content type :exclude which makes no sense as it should deal with :json. The desired behaviour of the api dealing with parsing errors is working with or without the code. * replace deprecations in unit specs * replace alias_method_chain [ci skip]	7 years ago
Oliver Günther	5d84add246	Expire sessions in warden auth scope	7 years ago

1 2 3 4 5 ...

274 Commits (f96894ed51ce9f3e52516e27296b958276373325)