openproject

Commit Graph

Author	SHA1	Message	Date
Oliver Günther	4bb8b9c325	Avoid returning all users for watcher_recipients (#9513 ) * Avoid returning all users for watcher_recipients * test #watcher_recipients of acts_as_watchable Co-authored-by: ulferts <jens.ulferts@googlemail.com>	3 years ago
luzpaz	2ae53bd252	Fix typos in user facing and non-user facing code (#9497 ) * Fix typos in user facing and non-user facing code Found via `codespell -q 3 -S ./config/locales -L ba,nd,parms,sur,varius` * Fix strings in specs	3 years ago
Oliver Günther	6a5bfc292a	Add API documentation for notifications	3 years ago
Oliver Günther	31726649d4	[38062] Avoid sending notifications with no ian reason	3 years ago
Oliver Günther	351cc7f969	[38062] Avoid sending notifications with no ian reason	3 years ago
Oliver Günther	394cc42dde	Bump version to 12.0.0	3 years ago
Oliver Günther	a1fcf2661f	Bumped version to 11.3.4 [ci skip]	3 years ago
Oliver Günther	a2244ca70a	Render backtrace for debug log level through LogDelegator (#9475 )	3 years ago
Oliver Günther	16d1f57857	Deprecation warning for < postgres13 in admin/info (#9473 ) https://community.openproject.org/work_packages/38047	3 years ago
ulferts	75bb809ad6	Feature/1899 send daily email summaries (#9430 ) * email digests * use time for notification digest setting * safeguard against empty digest	3 years ago
Oliver Günther	e9d7c374cc	[37868] Whitelist for attachment mime types and extensions on upload (#9431 ) * Add setting for whitelist * Make attachments API BaseServices compatible * Add prepare service and contract * Correctly pass the filename to the UploadedFile * Add presence check to filename * Fix expected validation message * We no longer raise a multipart error when metadata is empty * Fix filesize validation on prepared uploads * Add parser error if invalid metadata json * When attachment is not saved, use filename property * Return correct error message on JSON parser erroro * Fix specs * Use attachment upload representer * Fix direct uploads mocks with new service layer * Lint * Fix export job using attachment service * Fix IFC controller using attachment prepare service * Fix export job * RenameRename params_getter to params_source * Fix mail handler using attachment service * Fix usage of attachment create service in documents * Reuse shared examples for document attachment spec * Fix stubbed attachment service in export job spec * Use admin user in backup spec * Fix export job for bim * Fix attachment integration spec * Fix issues_controller spec * Make budget resource spec reuse common examples * Fix attachment parsing representer spec * Replace prepare part of attachment spec into separate service spec * Clear cache for login spec * Convert document create/update into services * Budget services * Allow options to be passed to property twin * Remove setting author on budget initialize * Replace meetings update with services * Replace ifc models attachment handling with services * Don't check uploader if changed by system * Fix uploader being changed by system * Replace wiki page attach_files with attachable services * Replace avatar saving * Replace snapshot attach_files * Skip double validation when container present * Set snapshot through attachment service * Remove attach_files * Validate content type in contract * Enforce writing the content type without accepting user input * Expect changed content_type * Fix content of viewpoint image to get correct content type * Fix tsv spec * Add create contract spec * Bypass whitelist in internal services when conflicting with user * Fix expects in specs after whitelist bypass * Render contract errors for wiki * Add before_hook to bodied to allow to pre-authorize permissions * Budget errors from contract * Document errors from contract	3 years ago
ulferts	0666c89828	Feature/35708 wp typeahead filter (#9426 ) * breakup wp resource specs into separate files * introduce and employ typeahead filter on work packages Co-authored-by: Oliver Günther <mail@oliverguenther.de>	3 years ago
Wieland Lindenthal	553cf861d1	Feature/37870 make in app notification center responsive to mobile sizes (#9413 ) * Shorten relative time strings in moment.js * Add user name as title and hide name from op principal * Lazy load momentJS config for short relative time strings * Hide modules menu on mobile in favor of in app notifcations bell * Many smaller layout improvements for the in app notification center * [IAN] Decrease size of clickareo of project name * [IAN] Smaller design fixes * Apply grid layout to better handle mobile sizes instead of using abbreviated texts for the relative time Co-authored-by: Henriette Darge <h.darge@openproject.com>	3 years ago
Benjamin Bädorf	0981c65582	Merge/release 11.3 (#9427 ) * Feature/37472 dynamic forms v2 flat resources links model (#9332) * Flat resources/_links model * Refactor: moving model formatting to FormsService * unit tests fixes * ValidateForm$ with schema * Adapt PrincipalComponent to flat form model * Default schema ti empty object * Avoid circular dependency * Update headlines for Board types [ci skip] * update locales from crowdin [ci skip] * update locales from crowdin [ci skip] * Fix how we gather and derive sampling traces for sentry (#9395) We previously defined a fixed tracing rate AND a sampling tracer in the backend, which result in everything to be traced regardless of the actual rate. We now define a base rate for certain requests, so that we can exclude health checks and other things. The configuration is now a factor (0 = off, default) (1 = use suggested rates), any other value x (x multiplied by suggested rates) * update locales from crowdin [ci skip] * update locales from crowdin [ci skip] * update locales from crowdin [ci skip] * update locales from crowdin [ci skip] * update locales from crowdin [ci skip] * correct expected links to docs Co-authored-by: Aleix Suau <info@macrofonoestudio.es> Co-authored-by: Birthe <b.lindenthal@openproject.com> Co-authored-by: OpenProject Actions CI <operations+ci@openproject.com> Co-authored-by: Oliver Günther <mail@oliverguenther.de> Co-authored-by: ulferts <jens.ulferts@googlemail.com>	3 years ago
Markus Kahl	fa08a3118f	code climate	3 years ago
Markus Kahl	20171e3839	put spec validation in script; polish	3 years ago
Markus Kahl	d39609a41d	put spec assembly into independent script as in it doesn't require bundling or a database conncetion as opposed to a rake task	3 years ago
Markus Kahl	31588fa25a	addressed review (including code climate) remarks	3 years ago
Markus Kahl	1a078ea667	/api/docs finished - made into separate, lazy loaded js/css bundle in angular - added setting allowing to disable API docs - added spec lint workflow - fixed styling (line-height) - renamed/restructured	3 years ago
Markus Kahl	968ffc2ca6	openapi spec, post apib conversion	3 years ago
Oliver Günther	d2ce834e23	[37866] Add attachment_created event and webhook (#9418 ) * [37866] Add attachment_created event and webhook * Remove other usages of direct attachment creation * Add attachment webhook spec * Fix other webhook specs * Fix attachment adding in mail_handler * Don't set content_type outside attachment#file= * Fix unrelated spec Co-authored-by: ulferts <jens.ulferts@googlemail.com>	3 years ago
Markus Kahl	dc8615de7e	openapi pre, pre apibp conversion	3 years ago
Markus Kahl	2ac1497c61	OpenAPI 3.0 spec, swagger UI right now the spec is generated from the existing api blueprint docs	3 years ago
ulferts	261b0fa5c3	add bulk read/unread enpoint for notifications	3 years ago
Oliver Günther	9636a08988	[26688] In-app notifications (#9399 ) * Add bell icon to icon font * Add in app notification in top menu * Add fullscreen modal * Add notification modal and items * Style items * Toggle details of item * Mark all read * Add no results box * wip specification for event api * Add events table, query and index * Send out events from WP notification mailer job There we have the recipients present * Add cleanup job for older events with a setting * Hide bell notification when not logged * Add specs for events API index/show * Fix setting yml key * remove pry in event creation * Fix before hook in events API to after_validation * Fix polymorphic association raising exception for aggregated journals * Fix typo in read_ian * Fix yml entry for mentioned * Add read/unread post actions to event API and add specs * Wire up API to frontend * Fix order on events * Switch to unread in notification * Add event query * rename WPEventService * route wp mail sending over events * rename spec methods * author becomes watcher * correct message call signature * rename events to notifications * renname parameter to reflect notification nature * create author watcher for existing work packages * Merge unreadCount from store * Take a stab at polymorphic representers * Fix link generation in polymorphic resources For journals, no title is being generated however * Fix frontend model for context * Use timer for polling * add notification_setting data layer * Fix show resource spec * Fix duplicate class in notification bell item * Add minimal feature spec for notification * API for notification settings * Persist notifications * adapt work package notification creation to notification settings * extract notified_on_all * consolidate wp#recipients * concentrate wp notification in journal service * simplify methods * Remove unused patch endpoint * Add specs for rendering and parsing notification settings * Contract spec * Update service spec * adapt specs * Angular notifications frontend commit `e29dced646` Author: Wieland Lindenthal <w.lindenthal@forkmerge.com> Date: Mon Jun 21 17:34:50 2021 +0200 Create Akita store and query for notification settings commit `1a45c26c1a` Author: Wieland Lindenthal <w.lindenthal@forkmerge.com> Date: Mon Jun 21 11:09:25 2021 +0200 Remove tabs from notificaition settings page commit `0ea21e90c1` Author: Oliver Günther <mail@oliverguenther.de> Date: Sun Jun 20 21:55:48 2021 +0200 WIP in app settings * migrate notification data * add project visible filter to project query * Add inline-create and table display grouped by project * Add notifications under admin/users * Remove notifications partial * Rename notififcations store to user preferences store * Add setting for self_notified and hook that up to the backend * Add aria-label to table checkboxes * Restyle table and toolbar * replace remains of mail_notifications attribute * initialize notification settings for new user * adapt my_preferences references * reenable no self notified for documents * adapt specs * Avoid has_many :notifcation_settings Rails magically autosaves the user's preferences when the user gets saved, which somehow also tries to save the notfifications even when unchanged. This breaks some specs such as the avatar upload spec. As we can't update the assocation through rails anyway, just delegate to the user for reading instead. * Restore update method of notification settings * Restore update spec * fix spec syntax * lint scss * linting * Fix content_tag for bell icon * Add feature specs for notification settings * Disable ContentTag cop * use visible filter to get projects for notification The visible filter will reduce the project list down to the set of projects visible to the user provided as a parameter. This includes public projects. * test for actual mail sending * adapt me resource path this.apiV3Service.users.me changed its type in `0d6c0b6bc7` * Implement changed migration * Linting * Add actor to notification representer * Fix factory creating a duplicate WP journal * Add work packages loading and journal details to notification entry component * IAN basic facets, keep and expanded states. * Fix notification bell spec * Render body separately and add auto updating relative time * Add fixedTime title * Add actor to notification entry * Fix clicking links on work package and project * Tiny styling changes on entry row * Disable count in notification if larger than 99 (wont fit) * Introduce virtual scrolling to entry table * allow delaying & prevent mail sending if ain read Introduces a setting to delay mail sending after a journal aggregation time has expired. That way, users can confirm a notification in app. If they do before the delay expires, no mail is sent out additionally for that user. * consolidate notifications (in&out) into shared admin menu Co-authored-by: ulferts <jens.ulferts@googlemail.com> Co-authored-by: Wieland Lindenthal <w.lindenthal@forkmerge.com>	3 years ago
ulferts	2a015eeac3	Feature/journal aggregation on write (#9396 ) * aggregate journals on write - simple implementation * remove references to aggregated journals on read * rewrite existing journals to be aggregated * remove aggregated journal reference * only delete predecessor if it can be aggregated * fix aggregation condition * adapt specs * remove aggregated journal functionality from production code The code is still necessary in a migration for the time being * adapt specs * use polymorphic belongs_to for journal data The association can then be employed for eager loading * eager load for activity rendering	3 years ago
Oliver Günther	99a8b3f140	Fix how we gather and derive sampling traces for sentry (#9395 ) We previously defined a fixed tracing rate AND a sampling tracer in the backend, which result in everything to be traced regardless of the actual rate. We now define a base rate for certain requests, so that we can exclude health checks and other things. The configuration is now a factor (0 = off, default) (1 = use suggested rates), any other value x (x multiplied by suggested rates)	3 years ago
Cyril Rohr	588a526531	Make postgres13 the default version when installing OpenProject (#9088 ) * Reexport PGVERSION and PGBIN according to existing install * Display message if PostgreSQL version deprecated * Do not launch postgres if using external URI * Add script to auto-upgrade postgres database for all-in-one dockerfile * Add documentation for packages and all-in-one docker image	3 years ago
Oliver Günther	7bbdcd8d1e	Bumped version to 11.3.3 [ci skip]	3 years ago
Oliver Günther	dcfa0533ef	Merge release/11.3 into dev	3 years ago
ulferts	9e66604dec	allow project identifier to begin with numbers (#9377 )	3 years ago
Aleix Suau	7e2e05c88f	Feature/36390 code structure (#9319 ) * core/shared/features in progress * shared/components in progress * Fix rebase errors * core: added admin + apiv3 * shared: attachments + attirbute-help-text * core: OpenprojectAugmentingModule * shared: OpenprojectAutocompleterModule * shared: Autocompleter * feature: backlog * feature: bim * feature: boards * shared: calendar * core: userModule * feature: dashboards * shared: editor * shared: fields * shared: focus * core: globalsearch * shared: grid * shared: grid fix * core: hal * shared: icon * feature: invite user modal * feature: job status * shared: members autocomplete * shared: modal * feature: my page * feature: overview * shared: principal * feature: projects * feature: repoting * core: routing * shared: time entries * shared: OpenprojectWorkPackageGraphsModule * feature: workpackages * core: active window * shared: autofocus * features: wp: back-button * core: browser * shared: collapseible section * core: config * shared: copy-to-clipboard * shared: date-time * shared: helpers: drag-and-drop * shared: draggable autocompleter * shared: dynamic bootstrapper * shared: dynamic forms * features: wp: edit actions bar * shared: EditableToolbarTitleComponent * core: BannersService * shared: OpFormFieldComponent * shared: hide section * shared: highlight col * core: I18 + Sanitizer * shared: isClickedWithModifier * core: LoadingIndicator * core: Modal Heading * core: Model auth * shared: no results * shared: notifications * shared: datepicker * shared: option-list * core: path helper * shared: persistent toggle * shared: remote field * shared: set click position * shared: slide toggle * shared: tabs * shared: drag-scroll * shared: keyCodes * shared: OPSharedModule * global styles: common * core: * import fixes * shared: Enterprise banner * features: wps: filters * features: home screen * import fixes * core: html * import fixes * core: main-menu * features: home screen * shared: modals * shared: op-context-menu * core + shared: current project * core: schema-cache * shared: table-pagination * features: wps: time-entries * shared: user-link * features: wps * features: wps * features: wps: all wp-* components * core: states * Rename: angular4-modules to app.module * core: expression service * Modules just with plugins * Test fixes * added missing content-tabs.component.sass * Replaced with .op-ckeditor--wrapper * Replaced by .op-ckeditor-source-element * Replaced by the entire wysiwyg_editor.rb with dev version * Replacements by ckeditor-augmented-textarea * Fixes ./spec/support/components/work_packages/table_configuration_modal.rb:106 * Fixes ./modules/reporting/spec/features/update_entries_spec.rb:69 * work_packages renamed to work-packages * TimeEntryChangeset moved to helpers * 'filters' moved to wps/components * 'admin' moved to features * HAL moved to shared * plugins moved to features * plugins moved to features * Test fixes * Unit test fixes * plugin generator into /features/plugins * fix sass rule indentation * Revert "plugins moved to features" This reverts commit `f65ccbfd4b`. * Import fixes * Avoid commiting in linked plugins Co-authored-by: ulferts <jens.ulferts@googlemail.com> Co-authored-by: Oliver Günther <mail@oliverguenther.de>	3 years ago
Markus Kahl	eaf839df8a	make sure log context is hash rather than, say ActionController::Parameters	3 years ago
ulferts	849b5aee22	Bumped version to 11.3.2 [ci skip]	3 years ago
ulferts	a8c075e258	[#37583 ] Error "Identifier is invalid" (#9373 ) * [#37583] Error "Identifier is invalid" Happens when creating a project that starts with a digit or a hypen. The functionality is added by extending acts_as_url to support a custom_rule lambda. https://community.openproject.org/work_packages/37583 * handle empty base_url in acts_as_url custom_rule	3 years ago
Oliver Günther	b21791b48b	Bump version to 11.4.0	3 years ago
Oliver Günther	46b85e5a47	Bumped version to 11.3.1 [ci skip]	3 years ago
Oliver Günther	a021379a98	Fix version to 11.3.0	3 years ago
Benjamin Bädorf	29a708f825	App header fixes (#9343 ) This fixes several issues the app header was experiencing on mobile and tablet screen sizes; * The project name was overlapping with the search icon, especially for long names. It will now get dotted out * The logo was being shown on screens that were really too small for it, causing the header to overflow and more important elements to lack space * The main menu toggle was being shown on pages that did do not have a main menu * Some refactoring around the global search input css by making it more bemmy, reducing class specificity * Improved the design of the search button on mobile, making it more in line with the other buttons	3 years ago
ulferts	4cd75489ff	Fix/nil parent rendering (#9339 ) * next apiv_3 undisclosed i18n key * fix parent rendering condition Not having a parent should be visible	3 years ago
ulferts	2f00810e92	Bug/35510 editing project settings removes link to parent project for certain permission constellations (#9336 ) * breakup spec file into individual files * spec changing project without changing parent * have spec specific to project representer rendering * prevent parent from being embedded if user is not allowed to see it * extract urn into constant * handle parsing of a hidden uri * commit hidden uri * extract methods * improve understandability of undisclosed parent property * extract method to increase understandability * centralize information on default/none option * Remove unnecessary cast and cleaner structure * adapt expected fieldset in spec Co-authored-by: Oliver Günther <mail@oliverguenther.de>	3 years ago
ulferts	2b74e8c92b	fix `required` value for properties on project resource (#9337 )	3 years ago
Oliver Günther	8ace160470	[37510] Fix accesing nil fragment in custom field injector (#9335 ) https://community.openproject.org/wp/37510 This got broken in `065dfbddc4` when changing the nil parsing of representable	3 years ago
Oliver Günther	0f040daf39	[37453] Fix user custom fields on new projects not being selectable (#9318 ) * Filter for any members when the project is not persisted * Fix trying to load invite user permission for empty projects * Add spec for setting a user cf for projects	3 years ago
Wieland Lindenthal	e642f7c745	Fix #37155 : Simplify quick add menu icon and circle positioning (#9304 ) * Fix #37155: Simplify quick add menu icon and circle positioning * Improve for BEM * Refactor: remove duplicate CSS class name	3 years ago
ulferts	6cda6ad4fd	enforces dependent project modules being active (#9311 ) Project modules, e.g. calendar can define dependencies, e.g. work packages. An error message is now displayed if a user enables a project module without the dependency being active in the project as well. Also fixes a serious bug in the Shared::ServiceContext module. Whenever a failing service result is returned, every change to the database is to be rolled back. This was not true when a model was provided since the changes where carried out within an inner transaction	3 years ago
Oliver Günther	de65503329	[37305] Fix accesskey to project search (#9308 ) https://community.openproject.org/wp/37305	3 years ago
ulferts	98b04a4d4f	show "new project" option on add_subprojects permission (#9298 ) The "new project" option will only be displayed when the user is in a context, a project, where the add_subprojects permission is granted	3 years ago
Oliver Günther	93faf5b5dd	[37278] Treat system_user as user type as well (#9287 ) https://community.openproject.org/wp/37278	4 years ago
Benjamin Bädorf	0b7a9954be	Fix form styles again (#9284 ) * Invite User button in dynamic SelectInputComponent (#9267) * change order in integrations Nextcloud is above FAQs [ci skip] * update locales from crowdin [ci skip] * Invite User button in dynamic SelectInputComponent * Update README.md Nextcloud priority higher [ci skip] * showAddNewUserButton in MultiSelectEditFieldComponent * showAddNewUserButton naming consistency * update locales from crowdin [ci skip] * prevent avatar getting squashed * Embed openproject-edition addon to use latest gltf2xkt version * Embed openproject-related packager addons * fix displaying `multi` toggle in cf form (#9269) * Install xeokit-gltf-to-xkt@1.1.1 for BIM * Fix/add subproject only flow (#9268) * allow users only having add_subproject to create subprojects * remove reference to no longer existing projects controller action * Fixed roles and permissions documentation link (#9271) * update locales from crowdin [ci skip] * Fix/project in user invite validation (#9272) * validate project in invite modal The user might have the manage_member permission in a project but not necessarily in the one the modal is opened in. * resurface invite_user_modal spec deleted in `b50298eb30` * allows users without manage_placeholder to add placeholder to project * replace legacy spec * Fix board creation modal layout (#9274) This got broken when refactoring all the modals to `op-modal` styling. All this commit does is increase the width * always create a wiki if clicking on "wiki" menu item (#9273) Previously, this only happend if a template is defined. Ideally, the page would not be created but only displayed for the user to save then. But this solution is easier to implement. * Update README.md * [30226] Derive user id from link in create autocompleter (#9275) The CreateAutocompleter doesn't get an ID for the user, so we have to derive it from its href. https://community.openproject.org/wp/30226 * [37257] Bust cache on settings name format change (#9276) * [37257] Bust cache on settings name format change https://community.openproject.org/wp/37257 * add specs for user representer cache busting & avoid patch Co-authored-by: ulferts <jens.ulferts@googlemail.com> * Always run the synchronization service as the system user (#9278) * Feature/36382 improvements (#9266) * Show backend validation errors in toast instead of a generic message * Include disabled field values on submit * Documentation improvements * Dumber OpFormFieldComponent: control, error and help settings as @Input * Create fieldGroups programmatical from @Input * fix: new project from themplate. Prioritize backend model * Show backend validation errors in toast instead of a generic message * Include disabled field values on submit * Documentation improvements * Dumber OpFormFieldComponent: control, error and help settings as @Input * Create fieldGroups programmatical from @Input * fix: new project from themplate. Prioritize backend model * Setting template payload through DynamicForm @Input model * Tests fixes * Seet public-read ACL on capybara screenshots * New Project: reset form when template changed + keep name * fix: avoid OpCkeditorComponent >>> FormattableEditFieldComponent >>> OpCkeditorComponent rawValue loop * PR Review changes * Unit tests fixes Co-authored-by: Cyril Rohr <cyril.rohr@gmail.com> * Invite User button in dynamic SelectInputComponent * showAddNewUserButton in MultiSelectEditFieldComponent * showAddNewUserButton naming consistency Co-authored-by: RBernsen <61973994+RBernsen@users.noreply.github.com> Co-authored-by: OpenProject Actions CI <operations+ci@openproject.com> Co-authored-by: ulferts <jens.ulferts@googlemail.com> Co-authored-by: Cyril Rohr <cyril.rohr@gmail.com> Co-authored-by: Benjamin Bädorf <hello@benjaminbaedorf.eu> Co-authored-by: Oliver Günther <mail@oliverguenther.de> * Bump version to 11.4.0 * Fix form styles again https://github.com/opf/openproject/pull/9266 probably broke these styles again. This PR reintroduces them. Co-authored-by: Aleix Suau <info@macrofonoestudio.es> Co-authored-by: RBernsen <61973994+RBernsen@users.noreply.github.com> Co-authored-by: OpenProject Actions CI <operations+ci@openproject.com> Co-authored-by: ulferts <jens.ulferts@googlemail.com> Co-authored-by: Cyril Rohr <cyril.rohr@gmail.com> Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago

1 2 3 4 5 ...

5785 Commits (f9f19cf29b687ae8dd314bcdf10222471e99554c)