openproject

Commit Graph

Author	SHA1	Message	Date
Markus Kahl	1061abf818	specs	8 years ago
Markus Kahl	470bf12826	show warning in subfolders too; fixed specs	8 years ago
Oliver Günther	7cf11bb689	Update copyright notice	8 years ago
Oliver Günther	8fd75e0456	Extend Subversion repository with UTF-8 paths (#4326 ) Provide some test data for UTF-8 encoded paths with Subversion. This confirms the tests of PR #4324. Side note: OS X will decompose some unicode characters into two characters. For example, the LATIN SMALL LETTER O WITH DIAERESIS (U+00F6 `ö`) will be decomposed into o and COMBINING DIAERESIS (U+0308). This obviously breaks SVN path mapping and while you will be able to commit files with decomposed paths, it will wreak havoc when using these characters on repositories manipulated by OSX and other systems. It apepars that Windows, Linux silently ignore these changes. We can't really account for this server side, but unicode-path patches exists for Subversion on OSX. For git, a config setting exists that does just that (`core.precomposeunicode`).	9 years ago
Oliver Günther	67e06ee2b2	Remove double escaping With OpenProject 5.0, we moved to Open3 pseudo-shell, which no longer requires escaping seperate arguments (unless the whole command is passed as a single string, which will result in an actual shell that would require escaping). The `shell_quote` functionality was still used though and causes issues with remote subversion passwords, which will be improperly escaped.	9 years ago
Oliver Günther	cd7ec57ee6	Empty check for newer Git versions Git recently introduced a new format for outputting warnings on empty repositories in `ce11360467` This commit extends the empty test for this output	9 years ago
Oliver Günther	612a1809f4	Confirmed that UTF-16 incorrectly returns nil This commit adds a spec for the UTF-16 invalid detection as binary, which is consistent with previous behavior, but the whole content encoding problem should be addressed.	9 years ago
Oliver Günther	bfa0c4d69d	Extend repository with UTF-16 encoded file, extend specs accordingly	9 years ago
Oliver Günther	86f847043b	Allow configuration to disable arbitrary SCM types This commit provides: - Configuration options for disabling any number of available types of that particular SCM vendor. - Changes to the underlying structure to allow determination of which types are available on a class level.	9 years ago
Oliver Günther	9336cff8bb	Extended specs This commit adds / extends the following specs: RepositoriesController: Ensure empty repository page is shown for empty repositories adapters/subversion: Test correct use of --login, --password arguments	9 years ago
Oliver Günther	e1bdb41bcd	More complete specs wrt. coverage, cleanup	9 years ago
Oliver Günther	2b39d8fbdf	Cleaning up, Rubocop	9 years ago
Oliver Günther	05b27c1b98	Asynchronous creation, deletion of repositories from OP. This PR begins the push towards management of repository lifetime from within OpenProject. What this currently provides is the following: - A mixin `ManageableRepository`, included by `Repository::{Git, Subversion}` to provide an interface to repo management - Two services and delayed_job workers for creating (`CreateManagedRepositoryService`) and deleting (`DeleteRepositoryService`) - Customized rendering of subforms in the repository settings for arbitrary SCM vendors. TODOS: - [x] Provide sane ground to work on ( cf. PR #3149 ) - [x] Rework SCM settings form (`{scm}_tags` is currently HTML generated from within a Helper.) - [x] Ease integration of arbitrary SCM vendors - [x] Display meaningful error / warning when user looks at bare repository (currently outputs 500, as Git HEAD / svn revision is not available) - [x] I18n - [ ] Specs (in progress) - [x] Fix legacy specs - [ ] Decide what to do with `Filesystem` adapter. Open Questions: - Configuration: Currently replaces the existing options in `configuration.yml`. - Implementation specifics: - Sub-projects repositories reside in a hierarchy below their parents - How should the delayed_job react upon failure? (esp. creation of repositories) Relevant work package: https://community.openproject.org/work_packages/20416 Merge dependent on PR #3149	9 years ago

13 Commits (fa1b4983d3de733c3283e1a4eca084b6bdf6a7fe)