128 Commits (ff84d03ab36343fe0e6fe5bbc842d8f077437995)

Author	SHA1	Message	Date
ulferts	a93ecca5a8	Feature/members api show (#7308) ... * basic members collection response * complete member index end point * document versions#index * remove user association from members There is already a more generic principals association. Having both causes confusion and leads to duplicate loading of models * linting * remove disabled test * add members#show api end point * add project and principal to member representer * replace member.user reference with principal * use principal reference in project members association * modernize roles api * complete member representer rendering * replace remnants of user association * add member schema api endpoint * have dedicated available projects end point for versions * linting * limit roles to assignable ones in schema * rename member to membership in api * remove remnants of user in member * spec fixes * use available_projects endpoint in versions board * add eager loading to memberships#index * members create form api endpoint * ensure role exists for default assignment * extract switch for users/groups to work_packages representer * document membership create form * add l10n expected in specs * strengthen the usage of a delete base service * use base class for set attributes service * fix alias in service * add create endpoint to members api * document members create endpoint * linting * adapt to altered service signature * use default endpoint for wp#get * use CF infused representer [ci skip]	6 years ago
ulferts	1850622f20	Feature/versions api update (#7299) ... Feature/versions api update [ci skip]	6 years ago
Oliver Günther	33bc6466d5	Fix some sentry issues	6 years ago
Oliver Günther	1bc3090952	Better errors when bulk editing	6 years ago
Oliver Günther	665f37816d	On bulk copying, collect errors from dependent results ... Otherwise, when errors exist in children, only the parent will be marked invalid, but not the actual child that caused the error. https://community.openproject.com/wp/29298	6 years ago
ulferts	4209539da9	Feature/angular calendar (#6766) ... * replace rails based calendar with angular * render empty calendar * update query on month switch * introduce specific interval filter * show colors * remove now unused filter partial * start on retaining the view in the url * hide datesInterval filter * I18n for calendars title * stengthen explicity of expected filters * spec moving to the next month * fix FilterSerializer reference * remove outdated feature spec * rework calendar controller specs * avoid undefined columns * bump ng-calendar to 1.7.0 * Revert "fix FilterSerializer reference" This reverts commit 2bb2e574cdd664a02a4eb9c3e94b5a170aec0a67. * Revert "avoid undefined columns" This reverts commit bcbb381b34b095526d3ee1aa15d6263a658c03c0. * load initial query only after calendar has been loaded * implement month remembering * implement history back and forth * cleanup code * remove unused methods * remove order value from filters * replace rails calendar widget completely * fix shrinkwrap * move module into correct namespace * linting * remove unused js * calculate full calendar height dynamically * setting calendar locale from service * retain week on reload * show notification in case of too many results * show tooltip on hover * go to work package on click * deactivate tooltip before wp show * narrow down style to tooltip * [28885] Improve html title consistency when navigating to queries Currently, query names are not reflected in the HTML title. This results in 'wrong' titles being shown when entering a split or full view and then returning back to the list. https://community.openproject.com/wp/28885 [ci skip]	6 years ago
Oliver Günther	661ea179a1	[28670] Use WP update service for bulk updating ... The update service handles scheduling and ancestry updates, so we can avoid doing that manually. Fixes https://community.openproject.com/wp/28670	6 years ago
Jens Ulferts	f1356816b8	fix wp open/closed calculation for reports on postgresql ... boolean values are returned as `true`/`false` in postgresql while they are `1`/`0` in mysql. Using `ActiveRecord::Type::Boolean.new.cast(v)` handles both cases	6 years ago
Inga Mai	2d0d2feccf	[27828] Feature: Query menu in sidenav (#6429) ... * in main menu add gantt as extra work package child item * Satisfy spec and code climate * Add gantt chart icon behin default gantt query name. * WIP Query menu in left sidebar * Shift query dropdown in left sidenav * Reload menu or load query on click from every project location * WIP set correct label for default queries * Query menu listens on all changes of queries (delete, create, rename, toggle starred) and updates immediatly * WIP: Inline edit, field validation * Inline Edit validation and comfirm * Inline edit: validation of duplicate name * Set default columns and sorting for static queries * Codeclimate issues fixed * WIP Inline edit validation not working perfectly in all error states * Inline edit working * Autocompleter hover disabled and hovering over categories fixed * Category hover and toggle fixed; tested in Chrome, Firefox and Opera * Placeholder cut off fixed and text wrap added * English and german wording adjusted * Styles of inline edit and menu adjusted; matching wiki page styles * prevent menus to be displayed to often * application menu only displayed on work package * specify using no_menu layout more often * adapt tests to altered production implementation * Hamburger icon only in project; on global wp page: default queries shown correctly and summary removed * searching for undefined leads to error * Accessible click fixed (listen on escape) * Gantt in top menu deleted (gantt chart is part of default queries on wp page) * load menu on wp summary page * reduce times queries are loaded * lowercase on second word * remove menu from search and home * Styles fixed (category toggle and correct highlighting) * reflect static query in url * fix autocomplete handling in specs * Open all global menus on default and hide hamburger icon on global pages; Rebuild changes that have been ovrwritten after merge" * Correct highlighting of default queries after reload * Replace summary cuke with spec * WIP * Clear up selectors * Avoid actively setting promises and instead use $state.go to load links [ci skip] * Make editable title component a little simpler We can reuse the component I built for the wiki, that wasn't present in the frontend beforehand. * Fix moving through the menu and selecting items [ci skip] * Add save button to query title when query changed * Improve static names lookup by comparing query_props * Adapt and fix specs * Allow inner scrolling of wp query results Also, style the webkit scrollbar to make it pretty where supported * Allow renaming the query through setting menu, but simply focus on field [ci skip]	6 years ago
Oliver Günther	ecd6b3b996	[27934] Avoid bulk copying children more than once ... All descendants of work packages are automatically copied by the `MoveService`. We can skip them by checking the ancestors of each work package beforehand. https://community.openproject.com/wp/27934	6 years ago
Jens Ulferts	e8976f6e2b	remove code now unnecessary from autocompletes controller	6 years ago
Oliver Günther	5528794571	[27975] Call update_ancestors in bulk controller ... https://community.openproject.com/wp/27975	6 years ago
ulferts	0cf4e121ff	use destroy service on bulk destroy action (#6260) ... That way, ancestors are destroyed as well.	7 years ago
Oliver Günther	6ef4211e77	Bump copyright to 2018 (#6171) ... [ci skip]	7 years ago
Jens Ulferts	690e0ffc60	wp create/update/destroy via services	7 years ago
Jens Ulferts	6fdd122534	merge wp tree and relations into typed_dag ... Instead of having the tree/hierarchy information for work packages and the relations between the work packages separated into two tables all the information is now stored in the relations table. To support this, the typed_dag plugin is used. Notable changes: * relations_to and relations_from are swapped. relations_to has all relations that point to another work package (from_id = work_package.id) and relations_from contains all relations that lead to the work package from another one (to_id = work_package.id). This change is merely in the code. The db information is left untouched. * For follows/precedes to_id and from_id are swapped in the db. Because of that, "follows" is now the canonical name instead of "precedes". This is done so that hierarchy relations and follows relations point into the same direction which allows to easily detect cyclic relationships that would lead to infinit scheduling. * the columns `root_id`, `lft`, `rgt` do no longer exist in the wp table. * the column `relation_type` does no longer exist in the relations table. * For every type of relation a column (integer) does now exist in the relations table (e.g. hierarchy, block, follow) * Separate associations exist for every type of relation into two directions. E.g. Work packages following the current one can be accessed via `work_package.precedes`	7 years ago
Jens Ulferts	4df369884a	employ the subproject filter to handle subproject setting	8 years ago
Oliver Günther	7cf11bb689	Update copyright notice	8 years ago
Oliver Günther	fe0e8dd919	Rename before_filter to before_action	8 years ago
Oliver Günther	29f749a489	Remove unused xhr check	8 years ago
Oliver Günther	ad9160c116	Remove JournalsHelper ... It's used only for meetings without editing functionality.	9 years ago
Oliver Günther	8b0cd01d9c	Use back_url for bulk move, copy, and edit ... This sets the back_url to wherever the bulk request originated from, allowing users to be redirected to their old work package, query, or table. Note that this does not simply work for bulk destroy, since users may use that functionality from split/full view and will in this case be redirected to a non-existing resource. We might pass a query_id in this case (to at least redirect back to queries), however it would be better if the frontend decided what path the user should be redirected to in this case.	9 years ago
Jens Ulferts	2dfcd12abf	improves performance of work package autocompleter ... * add db hint on mysql to use primary key for the ORDER BY * restrict the fiels to search on based on the character of the search query. e.g. if there are alphabet characters in the search query, we don't have to search on the id column	9 years ago
Jens Ulferts	be21a7a504	update error message for bulk operations across multiple projects	9 years ago
Mohamed Wael Khobalatte	4f3930be79	Call the correct hook for costs plugin	9 years ago
Oliver Günther	a6b4372b09	Always preprocess URLs with CGI.unescape ... This forces redirect URLs to always pass through the escaping process, in order to process escaped paths (`/mysubdir/%2E%2E/secret/`).	9 years ago
Jan Sandbrink	2b7261b2ee	move assembly of reports list into controller	9 years ago
Jan Sandbrink	8e4321959e	improve code style	9 years ago
Jan Sandbrink	dfb9a5cd20	remove remaining AR find_by_x finders ... - most of them were removed by @myabc in the rails4 branch - some where reintroduced due to parallel development to that branch - still some occurences left that will hit custom implementations	9 years ago
Jan Sandbrink	2a65240e52	always include relevant columns ... - caller does not need to do it anymore - caller is still allowed to do it, because it can also add own conditions...	9 years ago
Alex Coles	53a224bf76	Remove mutation method calls on AR::Relation ... See: * 6eeea9d1 * http://guides.rubyonrails.org/upgrading_ruby_on_rails.html#mutator-methods-called-on-relation Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Oliver Günther	988c9f38a7	Cucumber fixes ... * Use correct locale for testing * Global namespace refs	9 years ago
Oliver Günther	6eeea9d1da	Avoid mutator sort on relations ... https://github.com/rails/rails/pull/13314 removed mutator methods (e.g., `Array#sort!`) from relations. This commit enforces either an ordering on the query itself where applicable, or uses a non-mutator sort.	9 years ago
Tim Habermaas	5a57a5bf9d	[Refactor] Make wp_hashes_with_string depend solely on its parameters.	9 years ago
Tim Habermaas	d0426dcf17	[Refactor] Use ActiveRecord#find_by_id instead of #find and rescue.	9 years ago
Jens Ulferts	bdf20ef94d	extract work package move/copy to own service	9 years ago
Jens Ulferts	309254bf20	explicitly hand over the current user	9 years ago
Alexander Bach	ee14628c09	Move send_notification to event origin	9 years ago
Alexander Bach	a5f4eb1e8b	First event-based draft ... Unifies Journal- and WorkPackageObserver Removes them as observers Makes new JournalListener more classy	9 years ago
Alex Coles	0ad3cfb4b2	Prefer do…end for controller respond_to blocks ... `rubocop -a` does not currently normalise formatting consistently (see ec1bb39f). Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Florian Kraft	f8d69c5212	address hound complaints ... Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Jan Sandbrink	f86e0ef591	uglify order statement ... at least this one DOES work...	9 years ago
Jan Sandbrink	253785622c	specify order in the Rails 3 way ... ascending is the default anyway	9 years ago
Jan Sandbrink	9cb9957bbb	also accept auto complete requests without query	9 years ago
Jan Sandbrink	d2eeb27c84	eliminate instance variable	9 years ago
Jan Sandbrink	c9f0fba192	increase readability of wp->hash conversion ... it might use more lines, but I hope there is a gain in readability	9 years ago
Jan Sandbrink	8897235fa4	rewrite find into where, order and limit	9 years ago
Jan Sandbrink	194f1814e1	always return a valid scope ... though WorkPackage works like a scope *most* of the time, it is not a scope e.g. you can't directly call :order on WorkPackage Note: I would have loved to already do it the Rails 4 way and call :all However in Rails 3 :all returns an Array and not a Relation, so we will have to wait for the Rails 4(.1) Upgrade to replace :scoped with :all :( Sorry @myabc	9 years ago
Jan Sandbrink	e51a4005ff	try to increase readability ... - extract scopedeterminition into an extra method - always use "outer" if statements in index method	9 years ago
Jan Sandbrink	280e333f18	explain why some code exists	9 years ago