8910 Commits (ffe8f22c9d329387b67789562b54acd582fbf431)

Author	SHA1	Message	Date
sabine holler	ffe8f22c9d	Proper check for allowed work package context menu actions ... The permited actions step of the getIntersectOfPermittedActions method accidently allowed too many actions, when there are plugin registered actions. Eg. logCosts. We fixed it by introducing a new method isActionAllowed.	3 years ago
ulferts	b9ff3739e1	Fix/39959/duplicate query space initialization (#9888) ... * avoid updating/initializing the query space twice initially Both the `PartitionedQuerySpacePageComponent` as well as the `WorkPackagesListService` initialize the work package states via the `WorkPackageStatesInitializationService`. The `PartitionedQuerySpacePageComponent` initializes the `WorkPackagesListService` so the former is indirectly for calling both. Ideally, only the `WorkPackagesListService` would initialize the `WorkPackageStatesInitializationService` to avoid confusion but this could not be implemented at this time because of hard to control side effects. With this change, the `PartitionedQuerySpacePageComponent` on the first call to the `WorkPackagesListService` no longer initializes the wp states trusting in the list service to do it. This change results in reduced initialization time and avoids duplicated requests to the server e.g. for relations and the work packgages they point to. * remove unused method	3 years ago
Oliver Günther	da2a96af44	Handle API errors that respond without JSON	3 years ago
Benjamin Bädorf	da59a6f0c0	Proof of Concept for a DatasetInputs decorator (#9863) ... * Proof of Concept for a DatasetInputs decorator Currently, there are some usecases where we render a component tag in the backend, and then hydrate it in the browser. Accepting inputs in this scenario is less than preferable since the checking and parsing for dataset inputs has to be written in the component itself. This decorator does this automatically in the background. Just add it to a component, and it checks automatically whether there are data attributes to set initial input values from. In order not to overwrite any class properties that are not inputs, I've added a bit of a hacky check to get the Angulars internal `declaredInputs` object, which, as the name implies, lists the declared inputs. This is improvable. * Remove example usage, add better documentation, address PR comments * A bit more typing to reduce eslint errors * Add broken spec * fixed example syntax * Remove frontend spec, fix some linting issues Co-authored-by: Oliver Günther <mail@oliverguenther.de> Co-authored-by: Eric Schubert <e.schubert@openproject.com>	3 years ago
Henriette Darge	ec87ce56f1	Fix eslint issues for team planner module	3 years ago
Henriette Darge	9c4eed9c3f	Special fix for Safari to ensure that the content really spans the full availble height	3 years ago
Henriette Darge	6a2263f103	Add basic tests for team planner module	3 years ago
Oliver Günther	4f531086ca	Add team planner query page component	3 years ago
Eric Schubert	636e60d7d5	[#39772] fixed idents of xeokit tree carets	3 years ago
Henriette Darge	b0081a0639	Remove unused file. The rules are exactly like this written in _toast.sass	3 years ago
Henriette Darge	ee644249be	Avoid unnecessary scrolling on iOS	3 years ago
Oliver Günther	3d474071ee	Accept that _embedded in hal error can be empty ... https://sentry2.openproject.com/organizations/sentry/issues/1666/?project=4&query=is%3Aunresolved	3 years ago
Oliver Günther	fb3e1d853a	[39880] Fix broken detail messages in toast service ... https://community.openproject.org/wp/39880	3 years ago
Eric Schubert	bf67c648e2	[#39772] Replace query select component ... - https://community.openproject.org/work_packages/39772 - added op-sidemenu to wp-query-select - replaced jquery ui in wp-query-select - added css padding override for items with icon in op-sidemenu - changed databinding to observables - Rename "collapsible menu" to "searchable menu" and let it handle only the things needed for the searching. - Apply correct classes for query-select-menu so that it is scrollable again - All other (obsolete) parts have been removed. - Adapt test to new styling of reports sidebar	3 years ago
Eric Schubert	92f6878d9c	[39772] cp: Add extra link for href in op-sidemenu	3 years ago
Henriette Darge	ca339dd220	Apply two column class initially only when the view is wide enough	3 years ago
Henriette Darge	b3333c5668	Prevent that a long toolbar let the whole page overflow on mobile	3 years ago
Henriette Darge	689d6f5caa	Overflowing elements need to be visible so that the type dropdown can be seen	3 years ago
Henriette Darge	5cbd63b5c1	Unify widths for images in widget boxes	3 years ago
Henriette Darge	05b7c4d91a	[38129] Open the next notification only when the split screen is already open (#9848) ... * Open the next notification only when the split screen is already open * Use StateService to check whether details is open Co-authored-by: Oliver Günther <mail@oliverguenther.de>	3 years ago
Oliver Günther	f9d673c1ee	[39808] Don't try to mark read items as read again ... This will mess up the totalCount, resulting in an empty state https://community.openproject.org/wp/39808	3 years ago
Oliver Günther	27cc10fea1	[38700] add temporary op-form--section-header for margins ... The email reminders have a special kind of margin with a h5~like header and sometimes a description paragraph below it. The figma design specifies margins after the description, but in some cases there is none. So I added a header to wrap h5 + description https://community.openproject.org/wp/38700	3 years ago
Benjamin Bädorf	4a549e11df	Fix breadcrumb overflow	3 years ago
Benjamin Bädorf	f6c4330b97	Add missing margins in create WP form, add a bottom margin for wp details header	3 years ago
Benjamin Bädorf	cdf918d692	Fix scrollable tabs the easy way	3 years ago
Henriette Darge	92449ec86e	Move "mark as read" button in full view from toolbar to activity tab	3 years ago
Benjamin Bädorf	ce13e04e85	Remove unused css	3 years ago
Benjamin Bädorf	ab42c5c34f	Fix margins and arrangement of the activity tab header	3 years ago
Benjamin Bädorf	dcb77fc847	Add string to translateables, indicate project heierarchy, small typo changes	3 years ago
Benjamin Bädorf	90b90494c6	Fix checkbox-field input alignment	3 years ago
Oliver Günther	94bf6ddddf	[39562] Ensure selected item is set when following ... If the selected item is unset, the keydown event triggered _after_ the change will cause a search to be performed, even though we already followed the item in the change handler. This likely needs a better fix to avoid these double handlings, but I couldn't find another fast fix. https://community.openproject.org/wp/39562	3 years ago
Oliver Günther	1e002367b3	[35095] Use iso week formatting of moment to get week numbers ... https://community.openproject.org/wp/35095	3 years ago
Benjamin Bädorf	52994fd8e7	Remove unused css	3 years ago
Benjamin Bädorf	477fcb7cab	Fix margins and arrangement of the activity tab header	3 years ago
Oliver Günther	102163af53	[39775] Use same l/r padding values for op-ian-item ... https://community.openproject.org/wp/39775	3 years ago
Henriette Darge	224af330ed	Simplify code for two column layout for WP view by moving it all to one modifier class on the wp-single-view	3 years ago
Henriette Darge	bd7ebe0a90	Automatically opening the next notification in combination with the automatic redirect on mobile lead to the next WP being shown when marking a notification as read on mobile	3 years ago
Henriette Darge	f218cc6f09	Change notification images	3 years ago
Oliver Günther	b4cf90fb98	Add new features image	3 years ago
Benjamin Bädorf	a1b8cdd3be	Also reload activities in the work package split view on update, not just the notification count (#9810) ... * Also reload activities in the work package split view on update, not just the notification count When there are new notifications in the center, the user can force an update to the list. We also updated the number of notifications inside the work package, but did not load the new activity tab entries. This is fixed in this PR. Relevant comment: https://community.openproject.org/work_packages/39466/activity#activity-6 While we're here, also change the wp-split-view selector to align with the filename * Add op- prefix to wp-split-view	3 years ago
Benjamin Bädorf	56150d5582	Hide scrollable table if its empty (#9811) ... * Hide scrollable table if its empty The scrollable table used to show a scrollbar even if empty, because `overflow-x: scroll;` is set explicitly. Completely removing the element if it's empty fixes this	3 years ago
Henriette Darge	f971a52e28	Introduce grid for toolbars on partitioned query space pages for mobile	3 years ago
Benjamin Bädorf	a5f394b097	Remove old notification reload toasts ... If new notifications come in one after the other, the reload toaster would be shown multiple times. This Fixes this behaviour by removing old reload toasters before showing the new one.	3 years ago
Wieland Lindenthal	ebab8bb49c	Save for each IFC model what state its conversion to XKT is in. (#9751) ... * Save for each IFC model what state its conversion to XKT is in. Display the status and, if present, the error message to the users * Set conversion_state on migration * Add converion error messages to the ifc models list. * Extend ifc conversion spec to cover conversion status and message * Extend view spec to cover conversion status * Satisfy rubocop * Improve readability of migration code:	3 years ago
ulferts	6617f119b2	update teaser block to 12.0	3 years ago
Oliver Günther	6ec73cafc9	[39506] use shareReplay to ensure notification selected on load (#9801) ... https://community.openproject.org/wp/39506	3 years ago
Benjamin Bädorf	3aaac1c7ce	Rename most notification to toaster instances (#9765) ... * Rename most notification to toaster instances * Frontend builds * Fix spec build * Rename more notification elements to toaster * Rename toaster-box to op-toast * Fix op-toast-container * Rename toasters upload progress * Try fixing page.rb toaster check * Fix some specs, break some others * Correctly overwrite toast_type * Fix more specs * Fix one more notification to toaster rename * Fix linting errors, harmonize naming more * Remove byebug debugging statement * Remove byebug debugging statement * Rename notification in the backend, too * Rename more instances of notifications to toastService * Rename backend back to notification since bundle gems expect it there * expect_toaster -> expect_toast Co-authored-by: Henriette Darge <h.darge@openproject.com>	3 years ago
ulferts	4913d67031	show explanation when no time zone set	3 years ago
ulferts	0f5100e948	sort reminder times upon save	3 years ago
Oliver Günther	3c420d0e0d	[39562] Follow work package on key event in search ... https://community.openproject.org/wp/39562	3 years ago