OpenProject is the leading open source project management software.

kanbanworkflowstimelinescrumrubyroadmapproject-planningproject-managementopenprojectangularissue-trackerifcgantt-chartganttbug-trackerboardsbcf

You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

ulferts e58df37e29 Fix/copy budgets (#8856) ... * Fix broken call to #super in Budget#copy_from The #copy_from method in Budget appears to assume that superclasses will have the same method available to them as called on the new Budget object to which the copy is going. This is not the case. Resolve the issue by assigning duplicated attributes from the source object directly to self.attributes prior to copying the actual budget items. Tested in Chef/Vagrant test environment. Deployed to SemperVictus pre-production OP instance successfully. * Resolve budget child item copy confusion The #copy_from method does not account for child models duplicated from another Budget holding a unique constraint validation on the :budget_id attribute. The Budget itself also appears to inherit the source Budget's ID, creating additional problems. Address by unfolding the sub-object copy procedure and clean up the relevant attributes on #dup ensuring the appropriate relations are created when the object is assigned (after the #dup block). Tested in Chef/Vagrant workflow. * Rewrite for readability DRY the code, leaving it as an instance method for the time being. TODO for upstream: Convert to class method and update controller in the MVC (per GH comment). Write tests/spec and verify results of the original fix and final revision for release branches. * use whitelist approach for copying budgets * extract method Co-authored-by: RageLtMan <rageltman [at] sempervictus>		4 years ago
..
budgets_controller.rb	Fix/copy budgets (#8856)	4 years ago