openproject/spec/features/members/membership_spec.rb

#-- copyright
# OpenProject is an open source project management software.
# Copyright (C) 2012-2021 the OpenProject GmbH
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License version 3.
#
# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:
# Copyright (C) 2006-2013 Jean-Philippe Lang
# Copyright (C) 2010-2013 the ChiliProject Team
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License
# as published by the Free Software Foundation; either version 2
# of the License, or (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
#
# See COPYRIGHT and LICENSE files for more details.
#++

require 'spec_helper'

feature 'Administrating memberships via the project settings', type: :feature, js: true do
  shared_let(:admin) { FactoryBot.create :admin }
  let(:current_user) do
    FactoryBot.create(:user,
                      member_in_project: project,
                      member_through_role: manager)
  end
  let!(:project) { FactoryBot.create :project }

  let!(:peter) do
    FactoryBot.create :user,
                      status: User.statuses[:active],
                      firstname: 'Peter',
                      lastname: 'Pan',
                      mail: 'foo@example.org',
                      preferences: { hide_mail: false }
  end
  let!(:hannibal) do
    FactoryBot.create :user,
                      status: User.statuses[:invited],
                      firstname: 'Hannibal',
                      lastname: 'Smith',
                      mail: 'boo@bar.org',
                      preferences: { hide_mail: true }
  end
  let!(:developer_placeholder) { FactoryBot.create :placeholder_user, name: 'Developer 1' }
  let!(:crash) do
    FactoryBot.create :user,
                      firstname: "<script>alert('h4x');</script>",
                      lastname: "<script>alert('h4x');</script>"
  end
  let!(:group) do
    FactoryBot.create(:group, lastname: 'A-Team', members: [peter, hannibal])
  end

  let!(:manager)   { FactoryBot.create :role, name: 'Manager', permissions: [:manage_members] }
  let!(:developer) { FactoryBot.create :role, name: 'Developer' }
  let(:member1) { FactoryBot.create(:member, principal: peter, project: project, roles: [manager]) }
  let(:member2) { FactoryBot.create(:member, principal: hannibal, project: project, roles: [developer]) }
  let(:member3) { FactoryBot.create(:member, principal: group, project: project, roles: [manager]) }

  let!(:existing_members) { [] }

  let(:members_page) { Pages::Members.new project.identifier }

  before do
    login_as(admin)

    members_page.visit!

    SeleniumHubWaiter.wait
  end

  context 'with members in the project' do
    let!(:existing_members) { [member1, member2, member3] }

    scenario 'sorting the page' do
      members_page.expect_sorted_by 'name'
      expect(members_page.contents('name')).to eq [group.name, hannibal.name, peter.name]

      SeleniumHubWaiter.wait
      members_page.sort_by 'name'
      members_page.expect_sorted_by 'name', desc: true
      expect(members_page.contents('name')).to eq [peter.name, hannibal.name, group.name]

      SeleniumHubWaiter.wait
      members_page.sort_by 'email'
      members_page.expect_sorted_by 'email'
      expect(members_page.contents('email')).to eq [peter.mail]

      SeleniumHubWaiter.wait
      members_page.sort_by 'status'
      members_page.expect_sorted_by 'status'
      expect(members_page.contents('status', raw: true)).to eq %w(active active invited)

      SeleniumHubWaiter.wait
      members_page.sort_by 'status'
      members_page.expect_sorted_by 'status', desc: true
      expect(members_page.contents('status', raw: true)).to eq %w(invited active active)

      # Cannot sort by group, roles or status
      expect(page).to have_no_selector('.generic-table--sort-header a', text: 'ROLES')
      expect(page).to have_no_selector('.generic-table--sort-header a', text: 'GROUP')
    end
  end

  scenario 'Adding and Removing a Group as Member' do
    members_page.add_user! 'A-Team', as: 'Manager'

    expect(members_page).to have_added_group('A-Team')
    expect(page).to have_selector '.op-avatar_group'
    SeleniumHubWaiter.wait

    members_page.remove_group! 'A-Team'
    expect(page).to have_text 'Removed A-Team from project'
    expect(page).to have_text 'There are currently no members part of this project.'
  end

  scenario 'Adding and removing a User as Member' do
    members_page.add_user! 'Hannibal Smith', as: 'Manager'

    expect(members_page).to have_added_user 'Hannibal Smith'
    expect(page).to have_selector '.op-avatar_user'

    SeleniumHubWaiter.wait
    members_page.remove_user! 'Hannibal Smith'
    expect(page).to have_text 'Removed Hannibal Smith from project'
    expect(page).to have_text 'There are currently no members part of this project.'
  end

  scenario 'Adding and removing a Placeholder as Member' do
    members_page.add_user! developer_placeholder.name, as: developer.name

    expect(members_page).to have_added_user developer_placeholder.name
    expect(page).to have_selector '.op-avatar_placeholder-user'

    SeleniumHubWaiter.wait
    members_page.remove_user! developer_placeholder.name
    expect(page).to have_text "Removed #{developer_placeholder.name} from project"
    expect(page).to have_text 'There are currently no members part of this project.'
  end

  scenario 'Entering a Username as Member in firstname, lastname order' do
    members_page.open_new_member!
    SeleniumHubWaiter.wait

    members_page.search_principal! 'Hannibal S'
    expect(members_page).to have_search_result 'Hannibal Smith'
  end

  scenario 'Entering a Username as Member in lastname, firstname order' do
    members_page.open_new_member!
    SeleniumHubWaiter.wait

    members_page.search_principal! 'Smith, H'
    expect(members_page).to have_search_result 'Hannibal Smith'
  end

  scenario 'Escaping should work properly when entering a name' do
    members_page.open_new_member!
    SeleniumHubWaiter.wait

    members_page.search_principal! 'script'

    expect(members_page).not_to have_alert_dialog
    expect(members_page).to have_search_result "<script>alert('h4x');</script>"
  end
end