kanbanworkflowstimelinescrumrubyroadmapproject-planningproject-managementopenprojectangularissue-trackerifcgantt-chartganttbug-trackerboardsbcf
You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
134 lines
3.9 KiB
134 lines
3.9 KiB
#-- encoding: UTF-8
|
|
#-- copyright
|
|
# OpenProject is a project management system.
|
|
# Copyright (C) 2012-2018 the OpenProject Foundation (OPF)
|
|
#
|
|
# This program is free software; you can redistribute it and/or
|
|
# modify it under the terms of the GNU General Public License version 3.
|
|
#
|
|
# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:
|
|
# Copyright (C) 2006-2017 Jean-Philippe Lang
|
|
# Copyright (C) 2010-2013 the ChiliProject Team
|
|
#
|
|
# This program is free software; you can redistribute it and/or
|
|
# modify it under the terms of the GNU General Public License
|
|
# as published by the Free Software Foundation; either version 2
|
|
# of the License, or (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program; if not, write to the Free Software
|
|
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
|
|
#
|
|
# See docs/COPYRIGHT.rdoc for more details.
|
|
#++
|
|
|
|
require 'spec_helper'
|
|
|
|
describe AddWorkPackageNoteService, type: :model do
|
|
let(:user) { FactoryBot.build_stubbed(:user) }
|
|
let(:work_package) { FactoryBot.build_stubbed(:work_package) }
|
|
let(:instance) do
|
|
described_class.new(user: user,
|
|
work_package: work_package)
|
|
end
|
|
|
|
describe '.contract' do
|
|
it 'uses the CreateNoteContract contract' do
|
|
expect(instance.contract_class).to eql WorkPackages::CreateNoteContract
|
|
end
|
|
end
|
|
|
|
describe 'call' do
|
|
let(:mock_contract) do
|
|
double(WorkPackages::CreateNoteContract,
|
|
new: mock_contract_instance)
|
|
end
|
|
let(:mock_contract_instance) do
|
|
mock_model(WorkPackages::CreateNoteContract)
|
|
end
|
|
let(:valid_contract) { true }
|
|
|
|
let(:send_notifications) { false }
|
|
|
|
before do
|
|
expect(JournalManager)
|
|
.to receive(:with_send_notifications)
|
|
.with(send_notifications)
|
|
.and_yield
|
|
|
|
allow(instance).to receive(:contract_class).and_return(mock_contract)
|
|
allow(work_package).to receive(:save_journals).and_return true
|
|
allow(mock_contract_instance).to receive(:validate).and_return valid_contract
|
|
end
|
|
|
|
subject { instance.call('blubs', send_notifications: send_notifications) }
|
|
|
|
it 'is successful' do
|
|
expect(subject).to be_success
|
|
end
|
|
|
|
it 'persists the value' do
|
|
expect(work_package).to receive(:save_journals).and_return true
|
|
|
|
subject
|
|
end
|
|
|
|
it 'has no errors' do
|
|
expect(subject.errors).to be_empty
|
|
end
|
|
|
|
context 'when the contract does not validate' do
|
|
let(:valid_contract) { false }
|
|
|
|
it 'is unsuccessful' do
|
|
expect(subject.success?).to be_falsey
|
|
end
|
|
|
|
it 'does not persist the changes' do
|
|
expect(work_package).to_not receive(:save_journals)
|
|
|
|
subject
|
|
end
|
|
|
|
it "exposes the contract's errors" do
|
|
errors = double('errors')
|
|
allow(mock_contract_instance).to receive(:errors).and_return(errors)
|
|
|
|
subject
|
|
|
|
expect(subject.errors).to eql errors
|
|
end
|
|
end
|
|
|
|
context 'when the saving is unsuccessful' do
|
|
before do
|
|
expect(work_package).to receive(:save_journals).and_return false
|
|
end
|
|
|
|
it 'is unsuccessful' do
|
|
expect(subject).to_not be_success
|
|
end
|
|
|
|
it 'leaves the value unchanged' do
|
|
subject
|
|
|
|
expect(work_package.journal_notes).to eql 'blubs'
|
|
expect(work_package.journal_user).to eql user
|
|
end
|
|
|
|
it "exposes the work_packages's errors" do
|
|
errors = double('errors')
|
|
allow(work_package).to receive(:errors).and_return(errors)
|
|
|
|
subject
|
|
|
|
expect(subject.errors).to eql errors
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|