openproject

OpenProject is the leading open source project management software.

kanban workflows timeline scrum ruby roadmap project-planning project-management openproject angular issue-tracker ifc gantt-chart gantt bug-tracker boards bcf

History

Wieland Lindenthal a18954b2c9 Placeholder user services and administration (#8944 ) * Adding placeholder user contracts * Adding create, update, and delete services for placeholder users * WIP: Adding Placeholder User contract specs [ci skip] * Extract contract validation into common helper * Add common validation in BaseContract + common example for admin checks * Introduce common ModelContract shared context for validations * WIP: PlaceholderUser controller, i18n, and routes [ci skip] * Placeholder users index page and query - moved all group related scopes from User to Principal to make them also available in PlaceholderUser. * end * Create PlaceholderUser * Feature spec for editing a placeholder user * Manage PlaceholderUser memberships The managment of memberships is pretty similar for User and PlaceholderUser. This commit extacts the similarities and uses them for both. * General partial and show view for PlaceholderUser * Delete obosolete partial * Allow RequireAdminGuard to be used as a module function * Fix I18n for confirmation text * Smaller code improvements * Fix: Syntax for accessing status enums was wrong. * Use UpdateService for updating a placeholder user * Add spec for PlaceholderUsersController * First code improvements after code review. - more improvements to come. * Further code improvements after review ... still more to come * Correct namespace of delete service * Fix: Make placeholder user contract validate * Remove :type attribute from base contract of User and PlaceholerUser ...and add it to the CreateContracts. Also add type validations. Further extract shared examples for placeholder user attribute validation * Refactor: Extract membership hook calls to helper * Fix redirect paths for membership controllers * Specs already present in shared exampels. * Fix duplicates routes for users and placeholder users * Fix user path * Add attribute name and lastname We don't need a writeable check as both are equally writable * Replace more references to tab_edit_user_path * Skip specs for PlaceholderUsers::DeletionService We will tackle that service in a separate PR. * Fix module usage of RequireAdminGuard * Fix group filter for placeholder users * Fix invalid reference to expect_valid * Fix: Fix tabbed edit path for placeholder users * Fix status filtering on users * Linting * Improve generalisation of individual principal filter cell - Check for presence of groups and statuses in order to toggle visibility of their UI element. - Remove groups from placeholder user controller and cell initialization and options * Fix selector on groups assign * Remove using_shared_fixtures Co-authored-by: Oliver Günther <mail@oliverguenther.de>		4 years ago
..
activities	safe automatic fixes by rubocop (#8994 )	4 years ago
associations	Placeholder user backend (#8935 )	4 years ago
attribute_help_text	update copyright to 2021 (#8925 )	4 years ago
concerns	update copyright to 2021 (#8925 )	4 years ago
custom_actions	safe automatic fixes by rubocop (#8994 )	4 years ago
custom_field	safe automatic fixes by rubocop (#8994 )	4 years ago
custom_value	safe automatic fixes by rubocop (#8994 )	4 years ago
group	Fix test by calling service with system user	5 years ago
journal	safe automatic fixes by rubocop (#8994 )	4 years ago
members/scopes	use AR`s scope method instead of singleton class method (#8976 )	4 years ago
menu_items	safe automatic fixes by rubocop (#8994 )	4 years ago
mixins	merge changed_by_system into contract options	5 years ago
permitted_params	registration footer override	7 years ago
principals/scopes	safe automatic fixes by rubocop (#8994 )	4 years ago
priority	update copyright to 2021 (#8925 )	4 years ago
projects	safe automatic fixes by rubocop (#8994 )	4 years ago
queries	Placeholder user services and administration (#8944 )	4 years ago
query	safe automatic fixes by rubocop (#8994 )	4 years ago
relations/scopes	use AR`s scope method instead of singleton class method (#8976 )	4 years ago
repository	safe automatic fixes by rubocop (#8994 )	4 years ago
scopes	use AR`s scope method instead of singleton class method (#8976 )	4 years ago
setting	safe automatic fixes by rubocop (#8994 )	4 years ago
status	update copyright to 2021 (#8925 )	4 years ago
token	safe automatic fixes by rubocop (#8994 )	4 years ago
type	safe automatic fixes by rubocop (#8994 )	4 years ago
types/scopes	use AR`s scope method instead of singleton class method (#8976 )	4 years ago
user_password	safe automatic fixes by rubocop (#8994 )	4 years ago
users	use AR`s scope method instead of singleton class method (#8976 )	4 years ago
versions	use AR`s scope method instead of singleton class method (#8976 )	4 years ago
wikis	safe automatic fixes by rubocop (#8994 )	4 years ago
work_package	safe automatic fixes by rubocop (#8994 )	4 years ago
work_packages	safe automatic fixes by rubocop (#8994 )	4 years ago
announcement.rb	Use AnyFixtures to generate fixtures from factories (#7230 )	5 years ago
anonymous_user.rb	Placeholder user backend (#8935 )	4 years ago
application_record.rb	Remove usages of AnyFixture (#8987 )	4 years ago
attachment.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
attribute_help_text.rb	update copyright to 2021 (#8925 )	4 years ago
auth_source.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
category.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
change.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
changeset.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
color.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
comment.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
custom_action.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
custom_field.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
custom_option.rb	update copyright to 2021 (#8925 )	4 years ago
custom_style.rb	Use AnyFixtures to generate fixtures from factories (#7230 )	5 years ago
custom_value.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
deleted_user.rb	Placeholder user project members (#8961 )	4 years ago
design_color.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
dummy_auth_source.rb	LDAP Single Sign-on (#5888 )	7 years ago
enabled_module.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
enterprise_token.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
enumeration.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
forum.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
global_role.rb	update copyright to 2021 (#8925 )	4 years ago
group.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
group_custom_field.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
group_user.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
issue_priority.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
issue_priority_custom_field.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
journal.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
ldap_auth_source.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
mail_handler.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
member.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
member_role.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
menu_item.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
message.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
news.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
ordered_work_package.rb	update copyright to 2021 (#8925 )	4 years ago
permitted_params.rb	Placeholder user services and administration (#8944 )	4 years ago
placeholder_user.rb	Placeholder user services and administration (#8944 )	4 years ago
principal.rb	Placeholder user services and administration (#8944 )	4 years ago
project.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
project_custom_field.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
query.rb	update copyright to 2021 (#8925 )	4 years ago
relation.rb	use AR`s scope method instead of singleton class method (#8976 )	4 years ago
repository.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
role.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
role_permission.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
setting.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
status.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
system_user.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
type.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
user.rb	Placeholder user services and administration (#8944 )	4 years ago
user_custom_field.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
user_password.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
user_preference.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
user_session.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
version.rb	use AR`s scope method instead of singleton class method (#8976 )	4 years ago
version_custom_field.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
watcher.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
watcher_added_notification_mailer.rb	update copyright to 2021 (#8925 )	4 years ago
watcher_notification_mailer.rb	update copyright to 2021 (#8925 )	4 years ago
watcher_removed_notification_mailer.rb	update copyright to 2021 (#8925 )	4 years ago
wiki.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
wiki_content.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
wiki_page.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
wiki_redirect.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
work_package.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
work_package_custom_field.rb	update copyright to 2021 (#8925 )	4 years ago
workflow.rb	update copyright to 2021 (#8925 )	4 years ago