openproject

OpenProject is the leading open source project management software.

kanban workflows timeline scrum ruby roadmap project-planning project-management openproject angular issue-tracker ifc gantt-chart gantt bug-tracker boards bcf

History

Wieland Lindenthal a18954b2c9 Placeholder user services and administration (#8944 ) * Adding placeholder user contracts * Adding create, update, and delete services for placeholder users * WIP: Adding Placeholder User contract specs [ci skip] * Extract contract validation into common helper * Add common validation in BaseContract + common example for admin checks * Introduce common ModelContract shared context for validations * WIP: PlaceholderUser controller, i18n, and routes [ci skip] * Placeholder users index page and query - moved all group related scopes from User to Principal to make them also available in PlaceholderUser. * end * Create PlaceholderUser * Feature spec for editing a placeholder user * Manage PlaceholderUser memberships The managment of memberships is pretty similar for User and PlaceholderUser. This commit extacts the similarities and uses them for both. * General partial and show view for PlaceholderUser * Delete obosolete partial * Allow RequireAdminGuard to be used as a module function * Fix I18n for confirmation text * Smaller code improvements * Fix: Syntax for accessing status enums was wrong. * Use UpdateService for updating a placeholder user * Add spec for PlaceholderUsersController * First code improvements after code review. - more improvements to come. * Further code improvements after review ... still more to come * Correct namespace of delete service * Fix: Make placeholder user contract validate * Remove :type attribute from base contract of User and PlaceholerUser ...and add it to the CreateContracts. Also add type validations. Further extract shared examples for placeholder user attribute validation * Refactor: Extract membership hook calls to helper * Fix redirect paths for membership controllers * Specs already present in shared exampels. * Fix duplicates routes for users and placeholder users * Fix user path * Add attribute name and lastname We don't need a writeable check as both are equally writable * Replace more references to tab_edit_user_path * Skip specs for PlaceholderUsers::DeletionService We will tackle that service in a separate PR. * Fix module usage of RequireAdminGuard * Fix group filter for placeholder users * Fix invalid reference to expect_valid * Fix: Fix tabbed edit path for placeholder users * Fix status filtering on users * Linting * Improve generalisation of individual principal filter cell - Check for presence of groups and statuses in order to toggle visibility of their UI element. - Remove groups from placeholder user controller and cell initialization and options * Fix selector on groups assign * Remove using_shared_fixtures Co-authored-by: Oliver Günther <mail@oliverguenther.de>		4 years ago
..
api/v3	safe automatic fixes by rubocop (#8994 )	4 years ago
browsers	safe automatic fixes by rubocop (#8994 )	4 years ago
components	safe automatic fixes by rubocop (#8994 )	4 years ago
contracts	Boards module (#7008 )	6 years ago
custom_styles	Replace old logo favicons	6 years ago
edit_fields	safe automatic fixes by rubocop (#8994 )	4 years ago
matchers	safe automatic fixes by rubocop (#8994 )	4 years ago
pages	Placeholder user services and administration (#8944 )	4 years ago
queries	update copyright to 2021 (#8925 )	4 years ago
scm	safe automatic fixes by rubocop (#8994 )	4 years ago
shared	safe automatic fixes by rubocop (#8994 )	4 years ago
work_packages	update copyright to 2021 (#8925 )	4 years ago
active_record_timestamps.rb	update copyright to 2021 (#8925 )	4 years ago
angular.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
authentication_helpers.rb	add filtering for assignee with placeholder users	4 years ago
capybara.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
carrierwave.rb	update copyright to 2021 (#8925 )	4 years ago
clear_notification_subscriptions.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
database_cleaner.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
download_list.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
enterprise_token_helper.rb	update copyright to 2021 (#8925 )	4 years ago
file_helpers.rb	update copyright to 2021 (#8925 )	4 years ago
flash.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
identical_ext.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
local_storage_cleanup.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
noop_contract.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
omniauth.rb	Standalone CI docker container (#8943 )	4 years ago
onboarding_helper.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
parallel_helper.rb	Standalone CI docker container (#8943 )	4 years ago
permission_specs.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
puffing_billy_proxy.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
repository_helpers.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
request_with_header.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
roles.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
rspec_cleanup.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
rspec_disabled_specs.rb	Restructure spec_helper into rails_helper and support files	8 years ago
rspec_expect_it.rb	update copyright to 2021 (#8925 )	4 years ago
rspec_request_specs.rb	Use Rack::Test in all request specs	7 years ago
rspec_retry.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
selector_helpers.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
selenium_hub_waiter.rb	Standalone CI docker container (#8943 )	4 years ago
shared_let.rb	Fix typos in user facing and non-user facing code	4 years ago
system_test.rb	Re-add puma for single-process testing	6 years ago
tempdir.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
uploaded_file.rb	Standalone CI docker container (#8943 )	4 years ago
user_with_stubbed_permissions.rb	adapt factory usages	5 years ago
webmock.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
work_packages.rb	update copyright to 2021 (#8925 )	4 years ago