openproject

OpenProject is the leading open source project management software.

kanban workflows timeline scrum ruby roadmap project-planning project-management openproject angular issue-tracker ifc gantt-chart gantt bug-tracker boards bcf

History

Wieland Lindenthal a18954b2c9 Placeholder user services and administration (#8944 ) * Adding placeholder user contracts * Adding create, update, and delete services for placeholder users * WIP: Adding Placeholder User contract specs [ci skip] * Extract contract validation into common helper * Add common validation in BaseContract + common example for admin checks * Introduce common ModelContract shared context for validations * WIP: PlaceholderUser controller, i18n, and routes [ci skip] * Placeholder users index page and query - moved all group related scopes from User to Principal to make them also available in PlaceholderUser. * end * Create PlaceholderUser * Feature spec for editing a placeholder user * Manage PlaceholderUser memberships The managment of memberships is pretty similar for User and PlaceholderUser. This commit extacts the similarities and uses them for both. * General partial and show view for PlaceholderUser * Delete obosolete partial * Allow RequireAdminGuard to be used as a module function * Fix I18n for confirmation text * Smaller code improvements * Fix: Syntax for accessing status enums was wrong. * Use UpdateService for updating a placeholder user * Add spec for PlaceholderUsersController * First code improvements after code review. - more improvements to come. * Further code improvements after review ... still more to come * Correct namespace of delete service * Fix: Make placeholder user contract validate * Remove :type attribute from base contract of User and PlaceholerUser ...and add it to the CreateContracts. Also add type validations. Further extract shared examples for placeholder user attribute validation * Refactor: Extract membership hook calls to helper * Fix redirect paths for membership controllers * Specs already present in shared exampels. * Fix duplicates routes for users and placeholder users * Fix user path * Add attribute name and lastname We don't need a writeable check as both are equally writable * Replace more references to tab_edit_user_path * Skip specs for PlaceholderUsers::DeletionService We will tackle that service in a separate PR. * Fix module usage of RequireAdminGuard * Fix group filter for placeholder users * Fix invalid reference to expect_valid * Fix: Fix tabbed edit path for placeholder users * Fix status filtering on users * Linting * Improve generalisation of individual principal filter cell - Check for presence of groups and statuses in order to toggle visibility of their UI element. - Remove groups from placeholder user controller and cell initialization and options * Fix selector on groups assign * Remove using_shared_fixtures Co-authored-by: Oliver Günther <mail@oliverguenther.de>		4 years ago
..
contracts	Placeholder user services and administration (#8944 )	4 years ago
controllers	Placeholder user services and administration (#8944 )	4 years ago
decorators	safe automatic fixes by rubocop (#8994 )	4 years ago
factories	safe automatic fixes by rubocop (#8994 )	4 years ago
features	Placeholder user services and administration (#8944 )	4 years ago
fixtures	enforce token domain	5 years ago
helpers	Placeholder user services and administration (#8944 )	4 years ago
lib	safe automatic fixes by rubocop (#8994 )	4 years ago
mailers	safe automatic fixes by rubocop (#8994 )	4 years ago
models	Placeholder user services and administration (#8944 )	4 years ago
permissions	safe automatic fixes by rubocop (#8994 )	4 years ago
policies	safe automatic fixes by rubocop (#8994 )	4 years ago
requests	Use the configured variable for expiry (#8985 )	4 years ago
routing	safe automatic fixes by rubocop (#8994 )	4 years ago
security	safe automatic fixes by rubocop (#8994 )	4 years ago
seeders	safe automatic fixes by rubocop (#8994 )	4 years ago
services	Placeholder user services and administration (#8944 )	4 years ago
support	Placeholder user services and administration (#8944 )	4 years ago
tasks	update copyright to 2021 (#8925 )	4 years ago
views	safe automatic fixes by rubocop (#8994 )	4 years ago
workers	safe automatic fixes by rubocop (#8994 )	4 years ago
rails_helper.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
spec_helper.rb	Update copyright notice	5 years ago