kanbanworkflowstimelinescrumrubyroadmapproject-planningproject-managementopenprojectangularissue-trackerifcgantt-chartganttbug-trackerboardsbcf
You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
149 lines
4.6 KiB
149 lines
4.6 KiB
#-- encoding: UTF-8
|
|
|
|
#-- copyright
|
|
# OpenProject is an open source project management software.
|
|
# Copyright (C) 2012-2021 the OpenProject GmbH
|
|
#
|
|
# This program is free software; you can redistribute it and/or
|
|
# modify it under the terms of the GNU General Public License version 3.
|
|
#
|
|
# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:
|
|
# Copyright (C) 2006-2013 Jean-Philippe Lang
|
|
# Copyright (C) 2010-2013 the ChiliProject Team
|
|
#
|
|
# This program is free software; you can redistribute it and/or
|
|
# modify it under the terms of the GNU General Public License
|
|
# as published by the Free Software Foundation; either version 2
|
|
# of the License, or (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program; if not, write to the Free Software
|
|
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
|
|
#
|
|
# See docs/COPYRIGHT.rdoc for more details.
|
|
#++
|
|
|
|
require 'spec_helper'
|
|
require_relative './shared_contract_examples'
|
|
|
|
describe TimeEntries::UpdateContract do
|
|
it_behaves_like 'time entry contract' do
|
|
let(:time_entry) do
|
|
FactoryBot.build_stubbed(:time_entry,
|
|
project: time_entry_project,
|
|
work_package: time_entry_work_package,
|
|
user: time_entry_user,
|
|
activity: time_entry_activity,
|
|
spent_on: time_entry_spent_on,
|
|
hours: time_entry_hours,
|
|
comments: time_entry_comments)
|
|
end
|
|
subject(:contract) { described_class.new(time_entry, current_user) }
|
|
let(:permissions) { %i(edit_time_entries) }
|
|
|
|
context 'if user is not allowed to edit time entries' do
|
|
let(:permissions) { [] }
|
|
|
|
it 'is invalid' do
|
|
expect_valid(false, base: %i(error_unauthorized))
|
|
end
|
|
end
|
|
|
|
context 'if project changed' do
|
|
let(:new_project) do
|
|
FactoryBot.build_stubbed(:project).tap do |p|
|
|
allow(TimeEntryActivity::Scopes::ActiveInProject)
|
|
.to receive(:fetch)
|
|
.with(p)
|
|
.and_return(activities_scope)
|
|
|
|
allow(time_entry)
|
|
.to receive(:project) do
|
|
case time_entry.project_id
|
|
when p.id
|
|
p
|
|
when time_entry_project.id
|
|
time_entry_project
|
|
end
|
|
end
|
|
|
|
time_entry_work_package.project = p
|
|
|
|
allow(current_user)
|
|
.to receive(:allowed_to?) do |permission, permission_project|
|
|
new_project_permissions.include?(permission) && p == permission_project ||
|
|
permissions.include?(permission) && time_entry_project == permission_project
|
|
end
|
|
end
|
|
end
|
|
|
|
before do
|
|
time_entry.project = new_project
|
|
end
|
|
|
|
context 'if user is not allowed to edit time entries in old project but in new' do
|
|
let(:permissions) { [] }
|
|
let(:new_project_permissions) { %i(edit_time_entries) }
|
|
|
|
it 'is invalid' do
|
|
expect_valid(false, base: %i(error_unauthorized))
|
|
end
|
|
end
|
|
|
|
context 'if user is allowed to edit time entries in old project but not in new' do
|
|
let(:new_project_permissions) { [] }
|
|
|
|
it 'is invalid' do
|
|
expect_valid(false, base: %i(error_unauthorized))
|
|
end
|
|
end
|
|
|
|
context 'if user is allowed to edit time entries in both projects' do
|
|
let(:new_project_permissions) { %i(edit_time_entries) }
|
|
|
|
it 'is valid' do
|
|
expect_valid(true)
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'if the user is nil' do
|
|
let(:time_entry_user) { nil }
|
|
|
|
it 'is invalid' do
|
|
expect_valid(false, user_id: %i(blank))
|
|
end
|
|
end
|
|
|
|
context 'if the user is changed' do
|
|
it 'is invalid' do
|
|
time_entry.user = other_user
|
|
expect_valid(false, user_id: %i(error_readonly))
|
|
end
|
|
end
|
|
|
|
context 'if time_entry user is not contract user' do
|
|
let(:time_entry_user) { other_user }
|
|
|
|
context 'if has permission' do
|
|
let(:permissions) { %i[edit_time_entries] }
|
|
|
|
it 'is valid' do
|
|
expect_valid(true)
|
|
end
|
|
end
|
|
|
|
context 'if has no permission' do
|
|
let(:permissions) { %i[edit_own_time_entries] }
|
|
it 'is invalid' do
|
|
expect_valid(false, base: %i(error_unauthorized))
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|