kanbanworkflowstimelinescrumrubyroadmapproject-planningproject-managementopenprojectangularissue-trackerifcgantt-chartganttbug-trackerboardsbcf
You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
558 lines
17 KiB
558 lines
17 KiB
#-- encoding: UTF-8
|
|
#-- copyright
|
|
# OpenProject is an open source project management software.
|
|
# Copyright (C) 2012-2021 the OpenProject GmbH
|
|
#
|
|
# This program is free software; you can redistribute it and/or
|
|
# modify it under the terms of the GNU General Public License version 3.
|
|
#
|
|
# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:
|
|
# Copyright (C) 2006-2013 Jean-Philippe Lang
|
|
# Copyright (C) 2010-2013 the ChiliProject Team
|
|
#
|
|
# This program is free software; you can redistribute it and/or
|
|
# modify it under the terms of the GNU General Public License
|
|
# as published by the Free Software Foundation; either version 2
|
|
# of the License, or (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program; if not, write to the Free Software
|
|
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
|
|
#
|
|
# See docs/COPYRIGHT.rdoc for more details.
|
|
#++
|
|
|
|
require 'spec_helper'
|
|
|
|
describe UserMailer, type: :mailer do
|
|
let(:type_standard) { FactoryBot.build_stubbed(:type_standard) }
|
|
let(:user) { FactoryBot.build_stubbed(:user) }
|
|
let(:journal) do
|
|
FactoryBot.build_stubbed(:work_package_journal).tap do |j|
|
|
allow(j)
|
|
.to receive(:data)
|
|
.and_return(FactoryBot.build_stubbed(:journal_work_package_journal))
|
|
end
|
|
end
|
|
let(:work_package) do
|
|
FactoryBot.build_stubbed(:work_package,
|
|
type: type_standard)
|
|
end
|
|
|
|
let(:recipient) { FactoryBot.build_stubbed(:user) }
|
|
|
|
before do
|
|
allow(work_package).to receive(:reload).and_return(work_package)
|
|
|
|
allow(journal).to receive(:journable).and_return(work_package)
|
|
allow(journal).to receive(:user).and_return(user)
|
|
|
|
allow(Setting).to receive(:mail_from).and_return('john@doe.com')
|
|
allow(Setting).to receive(:host_name).and_return('mydomain.foo')
|
|
allow(Setting).to receive(:protocol).and_return('http')
|
|
allow(Setting).to receive(:default_language).and_return('en')
|
|
end
|
|
|
|
shared_examples_for 'mail is sent' do
|
|
let(:letters_sent_count) { 1 }
|
|
|
|
it 'actually sends a mail' do
|
|
expect(ActionMailer::Base.deliveries.size).to eql(letters_sent_count)
|
|
end
|
|
|
|
it 'is sent to the recipient' do
|
|
expect(ActionMailer::Base.deliveries.first.to).to include(recipient.mail)
|
|
end
|
|
|
|
it 'is sent from the configured address' do
|
|
expect(ActionMailer::Base.deliveries.first.from).to include('john@doe.com')
|
|
end
|
|
end
|
|
|
|
shared_examples_for 'multiple mails are sent' do |set_letters_sent_count|
|
|
it_behaves_like 'mail is sent' do
|
|
let(:letters_sent_count) { set_letters_sent_count }
|
|
end
|
|
end
|
|
|
|
shared_examples_for 'mail is not sent' do
|
|
it 'sends no mail' do
|
|
expect(ActionMailer::Base.deliveries.size).to eql(0)
|
|
end
|
|
end
|
|
|
|
shared_examples_for 'does only send mails to author if permitted' do
|
|
let(:user_preference) do
|
|
FactoryBot.build(:user_preference, others: { no_self_notified: true })
|
|
end
|
|
let(:user) { FactoryBot.build_stubbed(:user, preference: user_preference) }
|
|
|
|
context 'mail is for another user' do
|
|
it_behaves_like 'mail is sent'
|
|
end
|
|
|
|
context 'mail is for author' do
|
|
let(:recipient) { user }
|
|
|
|
it_behaves_like 'mail is not sent'
|
|
end
|
|
end
|
|
|
|
describe '#test_mail' do
|
|
let(:test_email) { 'bob.bobbi@example.com' }
|
|
let(:test_user) { User.new(firstname: 'Bob', lastname: 'Bobbi', mail: test_email) }
|
|
let(:mail) { UserMailer.test_mail(test_user) }
|
|
|
|
before do
|
|
# the name method uses a format setting to determine how to concatenate first name
|
|
# and last name whereby an unescaped comma will lead to have two email addresses
|
|
# defined instead of one (['Bobbi', 'bob.bobbi@example.com'] vs. ['bob.bobbi@example.com'])
|
|
allow(test_user).to receive(:name).and_return('Bobbi, Bob')
|
|
end
|
|
|
|
it 'escapes the name attribute properly' do
|
|
expect(mail.to).to eql [test_email]
|
|
end
|
|
end
|
|
|
|
describe '#work_package_added' do
|
|
before do
|
|
UserMailer.work_package_added(recipient, journal, user).deliver_now
|
|
end
|
|
|
|
it_behaves_like 'mail is sent'
|
|
|
|
it 'contains the WP subject in the mail subject' do
|
|
expect(ActionMailer::Base.deliveries.first.subject).to include(work_package.subject)
|
|
end
|
|
|
|
it_behaves_like 'does only send mails to author if permitted'
|
|
end
|
|
|
|
describe '#work_package_updated' do
|
|
before do
|
|
UserMailer.work_package_updated(recipient, journal, user).deliver_now
|
|
end
|
|
|
|
it_behaves_like 'mail is sent'
|
|
|
|
it_behaves_like 'does only send mails to author if permitted'
|
|
end
|
|
|
|
describe '#work_package_watcher_changed' do
|
|
let(:watcher_changer) { user }
|
|
before do
|
|
UserMailer.work_package_watcher_changed(work_package, recipient, watcher_changer, 'added').deliver_now
|
|
UserMailer.work_package_watcher_changed(work_package, recipient, watcher_changer, 'removed').deliver_now
|
|
end
|
|
|
|
include_examples 'multiple mails are sent', 2
|
|
|
|
it 'contains the WP subject in the mail subject' do
|
|
expect(ActionMailer::Base.deliveries.first.subject).to include(work_package.subject)
|
|
end
|
|
end
|
|
|
|
describe :wiki_content_added do
|
|
let(:wiki_content) { FactoryBot.create(:wiki_content) }
|
|
|
|
before do
|
|
UserMailer.wiki_content_added(recipient, wiki_content, user).deliver_now
|
|
end
|
|
|
|
it_behaves_like 'mail is sent'
|
|
|
|
it_behaves_like 'does only send mails to author if permitted'
|
|
end
|
|
|
|
describe '#wiki_content_updated' do
|
|
let(:wiki_content) { FactoryBot.create(:wiki_content) }
|
|
|
|
before do
|
|
UserMailer.wiki_content_updated(recipient, wiki_content, user).deliver_now
|
|
end
|
|
|
|
it_behaves_like 'mail is sent'
|
|
|
|
it 'should link to the latest version diff page' do
|
|
expect(ActionMailer::Base.deliveries.first.body.encoded).to include 'diff/1'
|
|
end
|
|
|
|
it_behaves_like 'does only send mails to author if permitted'
|
|
end
|
|
|
|
describe '#message_id' do
|
|
describe 'same user' do
|
|
let(:journal_2) { FactoryBot.build_stubbed(:work_package_journal) }
|
|
|
|
before do
|
|
allow(journal_2).to receive(:journable).and_return(work_package)
|
|
allow(journal_2).to receive(:user).and_return(user)
|
|
allow(journal_2).to receive(:created_at).and_return(journal.created_at + 5.seconds)
|
|
end
|
|
|
|
subject do
|
|
message_ids = [journal, journal_2].each_with_object([]) do |j, l|
|
|
l << UserMailer.work_package_updated(user, j).message_id
|
|
end
|
|
|
|
message_ids.uniq.count
|
|
end
|
|
|
|
it { expect(subject).to eq(2) }
|
|
end
|
|
|
|
describe 'same timestamp' do
|
|
let(:user_2) { FactoryBot.build_stubbed(:user) }
|
|
|
|
before do
|
|
allow(work_package).to receive(:recipients).and_return([user, user_2])
|
|
end
|
|
|
|
subject do
|
|
message_ids = [user, user_2].each_with_object([]) do |u, l|
|
|
l << UserMailer.work_package_updated(u, journal).message_id
|
|
end
|
|
|
|
message_ids.uniq.count
|
|
end
|
|
|
|
it { expect(subject).to eq(2) }
|
|
end
|
|
end
|
|
|
|
describe 'journal details' do
|
|
subject { UserMailer.work_package_updated(user, journal).body.encoded.gsub("\r\n", "\n") }
|
|
|
|
describe 'plain text mail' do
|
|
before do
|
|
allow(Setting).to receive(:plain_text_mail).and_return('1')
|
|
end
|
|
|
|
describe 'done ration modifications' do
|
|
context 'changed done ratio' do
|
|
before do
|
|
allow(journal).to receive(:details).and_return('done_ratio' => [40, 100])
|
|
end
|
|
|
|
it 'displays changed done ratio' do
|
|
is_expected.to include("Progress (%) changed from 40 \nto 100")
|
|
end
|
|
end
|
|
|
|
context 'new done ratio' do
|
|
before do
|
|
allow(journal).to receive(:details).and_return('done_ratio' => [nil, 100])
|
|
end
|
|
|
|
it 'displays new done ratio' do
|
|
is_expected.to include("Progress (%) changed from 0 \nto 100")
|
|
end
|
|
end
|
|
|
|
context 'deleted done ratio' do
|
|
before do
|
|
allow(journal).to receive(:details).and_return('done_ratio' => [50, nil])
|
|
end
|
|
|
|
it 'displays deleted done ratio' do
|
|
is_expected.to include("Progress (%) changed from 50 \nto 0")
|
|
end
|
|
end
|
|
end
|
|
|
|
describe 'start_date attribute' do
|
|
context 'format the start date' do
|
|
before do
|
|
allow(journal).to receive(:details).and_return('start_date' => ['2010-01-01', '2010-01-31'])
|
|
end
|
|
|
|
it 'old date should be formatted' do
|
|
is_expected.to match('01/01/2010')
|
|
end
|
|
|
|
it 'new date should be formatted' do
|
|
is_expected.to match('01/31/2010')
|
|
end
|
|
end
|
|
end
|
|
|
|
describe 'due_date attribute' do
|
|
context 'format the end date' do
|
|
before do
|
|
allow(journal).to receive(:details).and_return('due_date' => ['2010-01-01', '2010-01-31'])
|
|
end
|
|
|
|
it 'old date should be formatted' do
|
|
is_expected.to match('01/01/2010')
|
|
end
|
|
|
|
it 'new date should be formatted' do
|
|
is_expected.to match('01/31/2010')
|
|
end
|
|
end
|
|
end
|
|
|
|
describe 'project attribute' do
|
|
let(:project_1) { FactoryBot.create(:project) }
|
|
let(:project_2) { FactoryBot.create(:project) }
|
|
|
|
before do
|
|
allow(journal).to receive(:details).and_return('project_id' => [project_1.id, project_2.id])
|
|
end
|
|
|
|
it "shows the old project's name" do
|
|
is_expected.to match(project_1.name)
|
|
end
|
|
|
|
it "shows the new project's name" do
|
|
is_expected.to match(project_2.name)
|
|
end
|
|
end
|
|
|
|
describe 'attribute issue status' do
|
|
let(:status_1) { FactoryBot.create(:status) }
|
|
let(:status_2) { FactoryBot.create(:status) }
|
|
|
|
before do
|
|
allow(journal).to receive(:details).and_return('status_id' => [status_1.id, status_2.id])
|
|
end
|
|
|
|
it "shows the old status' name" do
|
|
is_expected.to match(status_1.name)
|
|
end
|
|
|
|
it "shows the new status' name" do
|
|
is_expected.to match(status_2.name)
|
|
end
|
|
end
|
|
|
|
describe 'attribute type' do
|
|
let(:type_1) { FactoryBot.create(:type_standard) }
|
|
let(:type_2) { FactoryBot.create(:type_bug) }
|
|
|
|
before do
|
|
allow(journal).to receive(:details).and_return('type_id' => [type_1.id, type_2.id])
|
|
end
|
|
|
|
it "shows the old type's name" do
|
|
is_expected.to match(type_1.name)
|
|
end
|
|
|
|
it "shows the new type's name" do
|
|
is_expected.to match(type_2.name)
|
|
end
|
|
end
|
|
|
|
describe 'attribute assigned to' do
|
|
let(:assignee_1) { FactoryBot.create(:user) }
|
|
let(:assignee_2) { FactoryBot.create(:user) }
|
|
|
|
before do
|
|
allow(journal).to receive(:details).and_return('assigned_to_id' => [assignee_1.id, assignee_2.id])
|
|
end
|
|
|
|
it "shows the old assignee's name" do
|
|
is_expected.to match(assignee_1.name)
|
|
end
|
|
|
|
it "shows the new assignee's name" do
|
|
is_expected.to match(assignee_2.name)
|
|
end
|
|
end
|
|
|
|
describe 'attribute priority' do
|
|
let(:priority_1) { FactoryBot.create(:priority) }
|
|
let(:priority_2) { FactoryBot.create(:priority) }
|
|
|
|
before do
|
|
allow(journal).to receive(:details).and_return('priority_id' => [priority_1.id, priority_2.id])
|
|
end
|
|
|
|
it "shows the old priority's name" do
|
|
is_expected.to match(priority_1.name)
|
|
end
|
|
|
|
it "shows the new priority's name" do
|
|
is_expected.to match(priority_2.name)
|
|
end
|
|
end
|
|
|
|
describe 'attribute category' do
|
|
let(:category_1) { FactoryBot.create(:category) }
|
|
let(:category_2) { FactoryBot.create(:category) }
|
|
|
|
before do
|
|
allow(journal).to receive(:details).and_return('category_id' => [category_1.id, category_2.id])
|
|
end
|
|
|
|
it "shows the old category's name" do
|
|
is_expected.to match(category_1.name)
|
|
end
|
|
|
|
it "shows the new category's name" do
|
|
is_expected.to match(category_2.name)
|
|
end
|
|
end
|
|
|
|
describe 'attribute version' do
|
|
let(:version_1) { FactoryBot.create(:version) }
|
|
let(:version_2) { FactoryBot.create(:version) }
|
|
|
|
before do
|
|
allow(journal).to receive(:details).and_return('version_id' => [version_1.id, version_2.id])
|
|
end
|
|
|
|
it "shows the old version's name" do
|
|
is_expected.to match(version_1.name)
|
|
end
|
|
|
|
it "shows the new version's name" do
|
|
is_expected.to match(version_2.name)
|
|
end
|
|
end
|
|
|
|
describe 'attribute estimated hours' do
|
|
let(:estimated_hours_1) { 30.5678 }
|
|
let(:estimated_hours_2) { 35.912834 }
|
|
|
|
before do
|
|
allow(journal).to receive(:details).and_return('estimated_hours' => [estimated_hours_1, estimated_hours_2])
|
|
end
|
|
|
|
it 'shows the old estimated hours' do
|
|
is_expected.to match('%.2f' % estimated_hours_1)
|
|
end
|
|
|
|
it 'shows the new estimated hours' do
|
|
is_expected.to match('%.2f' % estimated_hours_2)
|
|
end
|
|
end
|
|
|
|
describe 'custom field' do
|
|
let(:expected_text_1) { 'original, unchanged text' }
|
|
let(:expected_text_2) { 'modified, new text' }
|
|
let(:custom_field) do
|
|
FactoryBot.create :work_package_custom_field,
|
|
field_format: 'text'
|
|
end
|
|
|
|
before do
|
|
allow(journal).to receive(:details).and_return("custom_fields_#{custom_field.id}" => [expected_text_1, expected_text_2])
|
|
end
|
|
|
|
it 'shows the old custom field value' do
|
|
is_expected.to match(expected_text_1)
|
|
end
|
|
|
|
it 'shows the new custom field value' do
|
|
is_expected.to match(expected_text_2)
|
|
end
|
|
end
|
|
|
|
describe 'attachments' do
|
|
shared_let(:attachment) { FactoryBot.create(:attachment) }
|
|
|
|
context 'added' do
|
|
before do
|
|
allow(journal).to receive(:details).and_return("attachments_#{attachment.id}" => [nil, attachment.filename])
|
|
end
|
|
|
|
it "shows the attachment's filename" do
|
|
is_expected.to match(attachment.filename)
|
|
end
|
|
|
|
it "links correctly" do
|
|
is_expected.to match("<a href=\"http://mydomain.foo/api/v3/attachments/#{attachment.id}/content\">")
|
|
end
|
|
|
|
context 'with a suburl', with_config: { rails_relative_url_root: '/rdm' } do
|
|
it "links correctly" do
|
|
is_expected.to match("<a href=\"http://mydomain.foo/rdm/api/v3/attachments/#{attachment.id}/content\">")
|
|
end
|
|
end
|
|
|
|
it "shows status 'added'" do
|
|
is_expected.to match('added')
|
|
end
|
|
|
|
it "shows no status 'deleted'" do
|
|
is_expected.not_to match('deleted')
|
|
end
|
|
end
|
|
|
|
context 'removed' do
|
|
before do
|
|
allow(journal).to receive(:details).and_return("attachments_#{attachment.id}" => [attachment.filename, nil])
|
|
end
|
|
|
|
it "shows the attachment's filename" do
|
|
is_expected.to match(attachment.filename)
|
|
end
|
|
|
|
it "shows no status 'added'" do
|
|
is_expected.not_to match('added')
|
|
end
|
|
|
|
it "shows status 'deleted'" do
|
|
is_expected.to match('deleted')
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
describe 'html mail' do
|
|
let(:expected_translation) do
|
|
I18n.t(:done_ratio, scope: [:activerecord,
|
|
:attributes,
|
|
:work_package])
|
|
end
|
|
let(:expected_prefix) { "<li><strong>#{expected_translation}</strong>" }
|
|
|
|
before do
|
|
allow(Setting).to receive(:plain_text_mail).and_return('0')
|
|
end
|
|
|
|
context 'changed done ratio' do
|
|
let(:expected) { "#{expected_prefix} changed from <i title=\"40\">40</i> <br/><strong>to</strong> <i title=\"100\">100</i>" }
|
|
|
|
before do
|
|
allow(journal).to receive(:details).and_return('done_ratio' => [40, 100])
|
|
end
|
|
|
|
it 'displays changed done ratio' do
|
|
is_expected.to include(expected)
|
|
end
|
|
end
|
|
|
|
context 'new done ratio' do
|
|
let(:expected) { "#{expected_prefix} changed from <i title=\"0\">0</i> <br/><strong>to</strong> <i title=\"100\">100</i>" }
|
|
|
|
before do
|
|
allow(journal).to receive(:details).and_return('done_ratio' => [nil, 100])
|
|
end
|
|
|
|
it 'displays new done ratio' do
|
|
is_expected.to include(expected)
|
|
end
|
|
end
|
|
|
|
context 'deleted done ratio' do
|
|
let(:expected) { "#{expected_prefix} changed from <i title=\"50\">50</i> <br/><strong>to</strong> <i title=\"0\">0</i>" }
|
|
|
|
before do
|
|
allow(journal).to receive(:details).and_return('done_ratio' => [50, nil])
|
|
end
|
|
|
|
it 'displays deleted done ratio' do
|
|
is_expected.to include(expected)
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|