openproject

OpenProject is the leading open source project management software.

kanban workflows timeline scrum ruby roadmap project-planning project-management openproject angular issue-tracker ifc gantt-chart gantt bug-tracker boards bcf

History

Wieland Lindenthal a18954b2c9 Placeholder user services and administration (#8944 ) * Adding placeholder user contracts * Adding create, update, and delete services for placeholder users * WIP: Adding Placeholder User contract specs [ci skip] * Extract contract validation into common helper * Add common validation in BaseContract + common example for admin checks * Introduce common ModelContract shared context for validations * WIP: PlaceholderUser controller, i18n, and routes [ci skip] * Placeholder users index page and query - moved all group related scopes from User to Principal to make them also available in PlaceholderUser. * end * Create PlaceholderUser * Feature spec for editing a placeholder user * Manage PlaceholderUser memberships The managment of memberships is pretty similar for User and PlaceholderUser. This commit extacts the similarities and uses them for both. * General partial and show view for PlaceholderUser * Delete obosolete partial * Allow RequireAdminGuard to be used as a module function * Fix I18n for confirmation text * Smaller code improvements * Fix: Syntax for accessing status enums was wrong. * Use UpdateService for updating a placeholder user * Add spec for PlaceholderUsersController * First code improvements after code review. - more improvements to come. * Further code improvements after review ... still more to come * Correct namespace of delete service * Fix: Make placeholder user contract validate * Remove :type attribute from base contract of User and PlaceholerUser ...and add it to the CreateContracts. Also add type validations. Further extract shared examples for placeholder user attribute validation * Refactor: Extract membership hook calls to helper * Fix redirect paths for membership controllers * Specs already present in shared exampels. * Fix duplicates routes for users and placeholder users * Fix user path * Add attribute name and lastname We don't need a writeable check as both are equally writable * Replace more references to tab_edit_user_path * Skip specs for PlaceholderUsers::DeletionService We will tackle that service in a separate PR. * Fix module usage of RequireAdminGuard * Fix group filter for placeholder users * Fix invalid reference to expect_valid * Fix: Fix tabbed edit path for placeholder users * Fix status filtering on users * Linting * Improve generalisation of individual principal filter cell - Check for presence of groups and statuses in order to toggle visibility of their UI element. - Remove groups from placeholder user controller and cell initialization and options * Fix selector on groups assign * Remove using_shared_fixtures Co-authored-by: Oliver Günther <mail@oliverguenther.de>		4 years ago
..
access_control	update copyright to 2021 (#8925 )	4 years ago
acts_as_url/adapter	safe automatic fixes by rubocop (#8994 )	4 years ago
authentication	safe automatic fixes by rubocop (#8994 )	4 years ago
cache	update copyright to 2021 (#8925 )	4 years ago
configuration	safe automatic fixes by rubocop (#8994 )	4 years ago
custom_styles	safe automatic fixes by rubocop (#8994 )	4 years ago
hooks	update copyright to 2021 (#8925 )	4 years ago
journal	safe automatic fixes by rubocop (#8994 )	4 years ago
journal_formatter	safe automatic fixes by rubocop (#8994 )	4 years ago
logging	safe automatic fixes by rubocop (#8994 )	4 years ago
nested_set	safe automatic fixes by rubocop (#8994 )	4 years ago
omni_auth	safe automatic fixes by rubocop (#8994 )	4 years ago
patches	safe automatic fixes by rubocop (#8994 )	4 years ago
plugins	safe automatic fixes by rubocop (#8994 )	4 years ago
reminders	rename project attributes	5 years ago
scm	safe automatic fixes by rubocop (#8994 )	4 years ago
static	safe automatic fixes by rubocop (#8994 )	4 years ago
text_formatting	safe automatic fixes by rubocop (#8994 )	4 years ago
ui	Placeholder user services and administration (#8944 )	4 years ago
access_control.rb	update copyright to 2021 (#8925 )	4 years ago
access_keys.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
assets.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
authentication.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
cache.rb	update copyright to 2021 (#8925 )	4 years ago
configuration.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
content_type_detector.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
custom_field_format.rb	update copyright to 2021 (#8925 )	4 years ago
database.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
default_wp_queries.rb	update copyright to 2021 (#8925 )	4 years ago
deprecation.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
enterprise.rb	Placeholder user project members (#8961 )	4 years ago
events.rb	update copyright to 2021 (#8925 )	4 years ago
file_command_content_type_detector.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
files.rb	update copyright to 2021 (#8925 )	4 years ago
footer.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
form_tag_helper.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
full_text_search.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
global_search.rb	improve code climate	6 years ago
hooks.rb	update copyright to 2021 (#8925 )	4 years ago
info.rb	update copyright to 2021 (#8925 )	4 years ago
locale_helper.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
mutex.rb	update copyright to 2021 (#8925 )	4 years ago
notifications.rb	update copyright to 2021 (#8925 )	4 years ago
null_db_fallback.rb	update copyright to 2021 (#8925 )	4 years ago
object_linking.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
page_hierarchy_helper.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
passwords.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
plugins.rb	update copyright to 2021 (#8925 )	4 years ago
repository_authentication.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
safe_params.rb	update copyright to 2021 (#8925 )	4 years ago
sql_sanitization.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
static_routing.rb	update copyright to 2021 (#8925 )	4 years ago
storage.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
syntax_highlighting.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
text_formatting.rb	safe automatic fixes by rubocop (#8994 )	4 years ago
version.rb	safe automatic fixes by rubocop (#8994 )	4 years ago