OpenProject is the leading open source project management software.

kanbanworkflowstimelinescrumrubyroadmapproject-planningproject-managementopenprojectangularissue-trackerifcgantt-chartganttbug-trackerboardsbcf

You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

ulferts 8dfc5e8803 fix touching the customizable on removing custom_values ... Before the commit, the existing custom_values where attempted to be reused but there was no deterministic behaviour with which reusing them was attempted. Additionally, the existing values where always changed (or they would receive the current value again) whenever values where provided, regardless of whether those values actually changes. There was no explicit flag that a value was removed. This poses a couple of problems: * Even if no new values where provided the order of the custom values as stored in the db might change leading to journal entries that where not actually caused by the user. * If values where only removed, due to the missing explicit removal flag, it became luck whether an existing custom value was actually changed. Only then would the customized object be touched leading to an update of cached fragments, i.e. representers. * Because the values where updated all the time, the performance would suffer. * Removed custom values where removed right away and not only after save. This commit introduces an explicit flag for removal and does not alter existing custom values. This might have the drawback of creating a custom value even when a value, chosen to be removed by the user, could be reused but this should be negligible. It also has the drawback of introducing a flag to be maintained.		4 years ago
..
activate_in_project_spec.rb	Update copyright notice	5 years ago
create_bool_spec.rb	FactoryGirl => FactoryBot	7 years ago
create_date_spec.rb	FactoryGirl => FactoryBot	7 years ago
create_float_spec.rb	FactoryGirl => FactoryBot	7 years ago
create_int_spec.rb	FactoryGirl => FactoryBot	7 years ago
create_long_text_spec.rb	[32501] Make long test CF creation form show WYSIWYG editor	5 years ago
custom_fields_page.rb	Update copyright notice	5 years ago
custom_fields_spec.rb	Codeclimate and tests fixed	6 years ago
multi_user_custom_field_spec.rb	[31023] Preparation for project edit fields: Generalize edit and display fields currently work package specific (#7726)	5 years ago
multi_value_custom_field_spec.rb	fix touching the customizable on removing custom_values	4 years ago