OpenProject is the leading open source project management software.
You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
 
 
 
 
 
 
openproject/spec/features/work_packages/details/details_relations_spec.rb

334 lines
12 KiB

require 'spec_helper'
describe 'Work package relations tab', js: true, selenium: true do
include_context 'ui-autocomplete helpers'
let(:user) { FactoryGirl.create :admin }
let(:project) { FactoryGirl.create :project }
let(:work_package) { FactoryGirl.create(:work_package, project: project) }
let(:work_packages_page) { ::Pages::SplitWorkPackage.new(work_package) }
let(:relations) { ::Components::WorkPackages::Relations.new(work_package) }
let(:visit) { true }
before do
login_as user
if visit
visit_relations
end
end
def visit_relations
work_packages_page.visit_tab!('relations')
work_packages_page.expect_subject
loading_indicator_saveguard
end
def add_hierarchy(container, query, expected_text)
# Locate the create row container
container = find(container)
# Enter the query and select the child
autocomplete = container.find(".wp-relations--autocomplete")
select_autocomplete(autocomplete, query: query, select_text: expected_text)
container.find('.wp-create-relation--save').click
expect(page).to have_selector('.wp-relations-hierarchy-subject',
text: expected_text,
wait: 10)
end
def remove_hierarchy(selector, removed_text)
expect(page).to have_selector(selector, text: removed_text)
container = find(selector)
container.hover
container.find('.wp-relation--remove').click
expect(page).to have_no_selector(selector, text: removed_text, wait: 10)
end
describe 'as admin' do
let!(:parent) { FactoryGirl.create(:work_package, project: project) }
let!(:child) { FactoryGirl.create(:work_package, project: project) }
let!(:child2) { FactoryGirl.create(:work_package, project: project, subject: 'Something new') }
it 'allows to mange hierarchy' do
# Shows link parent link
expect(page).to have_selector('#hierarchy--add-parent')
find('.work-packages--details .wp-inline-create--add-link',
text: I18n.t('js.relation_buttons.add_parent')).click
# Add parent
add_hierarchy('.wp-relations--parent-form', parent.id, parent.subject)
##
# Add child #1
find('.work-packages--details .wp-inline-create--add-link',
text: I18n.t('js.relation_buttons.add_existing_child')).click
add_hierarchy('.wp-relations--child-form', child.id, child.subject)
##
# Add child #2
find('.work-packages--details .wp-inline-create--add-link',
text: I18n.t('js.relation_buttons.add_existing_child')).click
add_hierarchy('.wp-relations--child-form', child2.subject, child2.subject)
end
end
describe 'relation group-by toggler' do
let(:project) { FactoryGirl.create :project, types: [type_1, type_2] }
let(:type_1) { FactoryGirl.create :type }
let(:type_2) { FactoryGirl.create :type }
let(:to_1) { FactoryGirl.create(:work_package, type: type_1, project: project) }
let(:to_2) { FactoryGirl.create(:work_package, type: type_2, project: project) }
let!(:relation_1) do
FactoryGirl.create :relation,
from: work_package,
to: to_1,
relation_type: Relation::TYPE_FOLLOWS
end
let!(:relation_2) do
FactoryGirl.create :relation,
from: work_package,
to: to_2,
relation_type: Relation::TYPE_RELATES
end
let(:toggle_btn_selector) { '#wp-relation-group-by-toggle' }
let(:visit) { false }
before do
visit_relations
work_packages_page.visit_tab!('relations')
work_packages_page.expect_subject
loading_indicator_saveguard
end
it 'allows to toggle how relations are grouped' do
# Expect to be grouped by relation type by default
expect(page).to have_selector(toggle_btn_selector,
text: 'Group by work package type', wait: 10)
expect(page).to have_selector('.relation-group--header', text: 'FOLLOWS')
expect(page).to have_selector('.relation-group--header', text: 'RELATED TO')
expect(page).to have_selector('.relation-row--type', text: type_1.name)
expect(page).to have_selector('.relation-row--type', text: type_2.name)
find(toggle_btn_selector).click
expect(page).to have_selector(toggle_btn_selector, text: 'Group by relation type', wait: 10)
expect(page).to have_selector('.relation-group--header', text: type_1.name.upcase)
expect(page).to have_selector('.relation-group--header', text: type_2.name.upcase)
expect(page).to have_selector('.relation-row--type', text: 'Follows')
expect(page).to have_selector('.relation-row--type', text: 'Related To')
end
it 'allows to edit relation types when toggled' do
find(toggle_btn_selector).click
expect(page).to have_selector(toggle_btn_selector, text: 'Group by relation type', wait: 10)
# Expect current to be follows and other one related
expect(page).to have_selector('.relation-row--type', text: 'Follows')
expect(page).to have_selector('.relation-row--type', text: 'Related To')
# edit to blocks
relations.edit_relation_type(to_1, to_type: 'Blocks')
# the other one should not be altered
expect(page).to have_selector('.relation-row--type', text: 'Blocks')
expect(page).to have_selector('.relation-row--type', text: 'Related To')
updated_relation = Relation.find(relation_1.id)
expect(updated_relation.relation_type).to eq('blocks')
expect(updated_relation.from_id).to eq(work_package.id)
expect(updated_relation.to_id).to eq(to_1.id)
relations.edit_relation_type(to_1, to_type: 'Blocked by')
expect(page).to have_selector('.relation-row--type', text: 'Blocked by')
expect(page).to have_selector('.relation-row--type', text: 'Related To')
updated_relation = Relation.find(relation_1.id)
expect(updated_relation.relation_type).to eq('blocks')
expect(updated_relation.from_id).to eq(to_1.id)
expect(updated_relation.to_id).to eq(work_package.id)
end
end
describe 'with limited permissions' do
let(:permissions) { %i(view_work_packages) }
let(:user_role) do
FactoryGirl.create :role, permissions: permissions
end
let(:user) do
FactoryGirl.create :user,
member_in_project: project,
member_through_role: user_role
end
context 'as view-only user, with parent set' do
let(:parent) { FactoryGirl.create(:work_package, project: project) }
let(:work_package) { FactoryGirl.create(:work_package, parent: parent, project: project) }
it 'shows no links to create relations' do
# No create buttons should exist
expect(page).to have_no_selector('.wp-relations-create-button')
# Test for add relation
expect(page).to have_no_selector('#relation--add-relation')
# Test for add parent
expect(page).to have_no_selector('#hierarchy--add-parent')
# Test for add children
expect(page).to have_no_selector('#hierarchy--add-exisiting-child')
expect(page).to have_no_selector('#hierarchy--add-new-child')
# But it should show the linked parent
expect(page).to have_selector('.wp-relations-hierarchy-subject', text: parent.subject)
end
end
context 'with manage_subtasks permissions' do
let(:permissions) { %i(view_work_packages manage_subtasks) }
let!(:parent) { FactoryGirl.create(:work_package, project: project) }
let!(:child) { FactoryGirl.create(:work_package, project: project) }
it 'should be able to link parent and children' do
# Shows link parent link
expect(page).to have_selector('#hierarchy--add-parent')
find('.work-packages--details .wp-inline-create--add-link',
text: I18n.t('js.relation_buttons.add_parent')).click
# Add parent
add_hierarchy('.wp-relations--parent-form', parent.id, parent.subject)
##
# Add child
find('.work-packages--details .wp-inline-create--add-link',
text: I18n.t('js.relation_buttons.add_existing_child')).click
add_hierarchy('.wp-relations--child-form', child.id, child.subject)
# Remove parent
remove_hierarchy('.relation-row.parent', parent.subject)
# Remove child
remove_hierarchy('.relation-row.child', child.subject)
end
end
context 'with relations permissions' do
let(:permissions) do
%i(view_work_packages add_work_packages manage_subtasks manage_work_package_relations)
end
let!(:relatable) { FactoryGirl.create(:work_package, project: project) }
it 'should allow to manage relations' do
relations.add_relation(type: 'follows', to: relatable)
relations.remove_relation(relatable)
expect(page).to have_no_selector('.relation-group--header', text: 'FOLLOWS')
work_package.reload
expect(work_package.relations.direct).to be_empty
end
it 'should allow to move between split and full view (Regression #24194)' do
relations.add_relation(type: 'follows', to: relatable)
# Switch to full view
find('.work-packages--details-fullscreen-icon').click
# Expect to have row
relations.hover_action(relatable, :delete)
expect(page).to have_no_selector('.relation-group--header', text: 'FOLLOWS')
expect(page).to have_no_selector('.wp-relations--subject-field', text: relatable.subject)
# Back to split view
page.execute_script('window.history.back()')
work_packages_page.expect_subject
expect(page).to have_no_selector('.relation-group--header', text: 'FOLLOWS')
expect(page).to have_no_selector('.wp-relations--subject-field', text: relatable.subject)
end
it 'should follow the relation links (Regression #26794)' do
relations.add_relation(type: 'follows', to: relatable)
relations.click_relation(relatable)
subject = work_packages_page.edit_field(:subject)
subject.expect_state_text relatable.subject
relations.click_relation(work_package)
subject = work_packages_page.edit_field(:subject)
subject.expect_state_text work_package.subject
# Switch to full view
find('.work-packages--details-fullscreen-icon').click
full_page = ::Pages::FullWorkPackage.new(work_package)
relations.click_relation(relatable)
subject = full_page.edit_field(:subject)
subject.expect_state_text relatable.subject
relations.click_relation(work_package)
subject = full_page.edit_field(:subject)
subject.expect_state_text work_package.subject
end
it 'should allow to change relation descriptions' do
relations.add_relation(type: 'follows', to: relatable)
## Toggle description
relations.hover_action(relatable, :info)
# Open textarea
created_row = relations.find_row(relatable)
created_row.find('.wp-relation--description-read-value.-placeholder',
text: I18n.t('js.placeholders.relation_description')).click
expect(page).to have_focus_on('.wp-relation--description-textarea')
textarea = created_row.find('.wp-relation--description-textarea')
textarea.set 'my description!'
# Save description
created_row.find('.inplace-edit--control--save a').click
loading_indicator_saveguard
## Toggle description again
relations.hover_action(relatable, :info)
created_row = relations.find_row(relatable)
created_row.find('.wp-relation--description-read-value',
text: 'my description!').click
# Cancel edition
created_row.find('.inplace-edit--control--cancel a').click
created_row.find('.wp-relation--description-read-value',
text: 'my description!').click
relation = work_package.relations.direct.first
relation.reload
expect(relation.description).to eq('my description!')
# Toggle to close
relations.hover_action(relatable, :info)
expect(created_row).to have_no_selector('.wp-relation--description-read-value')
end
end
end
end